206180 2020-01-13 10:06:42 -0800 [EWS] Status bubble tooltip might display success message sometimes on a failed build 2020-01-14 17:09:35 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap jbedard webkit-bug-importer oldest_to_newest 1605919 0 aakash_jain 2020-01-13 10:06:42 -0800 [EWS] Status bubble tooltip might display success message sometimes on a failed build if the last step in the build succeeds. For the failed builds, status bubble tooltip displays the message from the last step. If the last step is successful (but some other step failed), it might be misleading. e.g.: https://ews-build.webkit.org/#/builders/20/builds/11444 1606641 1 387715 aakash_jain 2020-01-14 15:39:57 -0800 Created attachment 387715 Patch 1606643 2 aakash_jain 2020-01-14 15:44:18 -0800 Tested in https://ews.webkit-uat.org/status-bubble/387402/ 1606709 3 aakash_jain 2020-01-14 17:08:36 -0800 Committed r254545: <https://trac.webkit.org/changeset/254545> 1606710 4 webkit-bug-importer 2020-01-14 17:09:35 -0800 <rdar://problem/58588995> 387715 2020-01-14 15:39:57 -0800 2020-01-14 16:59:06 -0800 Patch bug-206180-20200114183955.patch text/plain 2295 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NDU0MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIwLTAxLTE0ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbRVdTXSBTdGF0dXMgYnViYmxlIHRvb2x0aXAgbWlnaHQgZGlzcGxheSBz dWNjZXNzIG1lc3NhZ2Ugc29tZXRpbWVzIG9uIGEgZmFpbGVkIGJ1aWxkCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDYxODAKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3 cy1hcHAvZXdzL3ZpZXdzL3N0YXR1c2J1YmJsZS5weToKKyAgICAgICAgKFN0YXR1c0J1YmJsZS5f YnVpbGRfYnViYmxlKToKKyAgICAgICAgKFN0YXR1c0J1YmJsZS5fbW9zdF9yZWNlbnRfZmFpbHVy ZV9tZXNzYWdlKTogUmV0dXJucyB0aGUgc3RhdHVzIGZyb20gZmFpbGVkIHN0ZXAgaW5zdGVhZCBv ZiBsYXN0IHN0ZXAuCisKIDIwMjAtMDEtMTQgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3 ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyNTQ1MzMgYW5k IHIyNTQ1MzUuCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy92aWV3 cy9zdGF0dXNidWJibGUucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv ZXdzLWFwcC9ld3Mvdmlld3Mvc3RhdHVzYnViYmxlLnB5CShyZXZpc2lvbiAyNTQ1MzkpCisrKyBU b29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy92aWV3cy9zdGF0dXNidWJibGUucHkJ KHdvcmtpbmcgY29weSkKQEAgLTExNiw3ICsxMTYsNyBAQCBjbGFzcyBTdGF0dXNCdWJibGUoVmll dyk6CiAgICAgICAgICAgICBidWJibGVbJ2RldGFpbHNfbWVzc2FnZSddID0gJ1dhcm5pbmcnICsg c2VsZi5fc3RlcHNfbWVzc2FnZXNfZnJvbV9tdWx0aXBsZV9idWlsZHMoYnVpbGRzKQogICAgICAg ICBlbGlmIGJ1aWxkLnJlc3VsdCA9PSBCdWlsZGJvdC5GQUlMVVJFOgogICAgICAgICAgICAgYnVi YmxlWydzdGF0ZSddID0gJ2ZhaWwnCi0gICAgICAgICAgICBidWJibGVbJ2RldGFpbHNfbWVzc2Fn ZSddID0gc2VsZi5fbW9zdF9yZWNlbnRfc3RlcF9tZXNzYWdlKGJ1aWxkKQorICAgICAgICAgICAg YnViYmxlWydkZXRhaWxzX21lc3NhZ2UnXSA9IHNlbGYuX21vc3RfcmVjZW50X2ZhaWx1cmVfbWVz c2FnZShidWlsZCkKICAgICAgICAgZWxpZiBidWlsZC5yZXN1bHQgPT0gQnVpbGRib3QuU0tJUFBF RDoKICAgICAgICAgICAgIGJ1YmJsZVsnc3RhdGUnXSA9ICdub25lJwogICAgICAgICAgICAgYnVi YmxlWydkZXRhaWxzX21lc3NhZ2UnXSA9ICdUaGUgcGF0Y2ggaXMgbm8gbG9uZ2VyIGVsaWdpYmxl IGZvciBwcm9jZXNzaW5nLicKQEAgLTIwMywxMSArMjAzLDExIEBAIGNsYXNzIFN0YXR1c0J1YmJs ZShWaWV3KToKICAgICAgICAgICAgICAgICByZXR1cm4gVHJ1ZQogICAgICAgICByZXR1cm4gRmFs c2UKIAotICAgIGRlZiBfbW9zdF9yZWNlbnRfc3RlcF9tZXNzYWdlKHNlbGYsIGJ1aWxkKToKLSAg ICAgICAgcmVjZW50X3N0ZXAgPSBidWlsZC5zdGVwX3NldC5sYXN0KCkKLSAgICAgICAgaWYgbm90 IHJlY2VudF9zdGVwOgotICAgICAgICAgICAgcmV0dXJuICcnCi0gICAgICAgIHJldHVybiByZWNl bnRfc3RlcC5zdGF0ZV9zdHJpbmcKKyAgICBkZWYgX21vc3RfcmVjZW50X2ZhaWx1cmVfbWVzc2Fn ZShzZWxmLCBidWlsZCk6CisgICAgICAgIGZvciBzdGVwIGluIGJ1aWxkLnN0ZXBfc2V0LmFsbCgp Lm9yZGVyX2J5KCctdWlkJyk6CisgICAgICAgICAgICBpZiBzdGVwLnJlc3VsdCA9PSBCdWlsZGJv dC5GQUlMVVJFOgorICAgICAgICAgICAgICAgIHJldHVybiBzdGVwLnN0YXRlX3N0cmluZworICAg ICAgICByZXR1cm4gJycKIAogICAgIGRlZiBnZXRfbGF0ZXN0X2J1aWxkX2Zvcl9xdWV1ZShzZWxm LCBwYXRjaCwgcXVldWUsIHBhcmVudF9xdWV1ZT1Ob25lKToKICAgICAgICAgYnVpbGRzLCBpc19w YXJlbnRfYnVpbGQgPSBzZWxmLmdldF9hbGxfYnVpbGRzX2Zvcl9xdWV1ZShwYXRjaCwgcXVldWUs IHBhcmVudF9xdWV1ZSkK