205940 2020-01-08 11:24:50 -0800 Fix testing Makefile to inherit preprocessor definitions 2020-01-08 13:19:13 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller commit-queue mark.lam webkit-bug-importer oldest_to_newest 1604173 0 keith_miller 2020-01-08 11:24:50 -0800 Fix testing Makefile to inherit preprocessor definitions 1604178 1 387117 keith_miller 2020-01-08 11:34:07 -0800 Created attachment 387117 Patch 1604192 2 387119 keith_miller 2020-01-08 11:46:30 -0800 Created attachment 387119 Patch 1604222 3 387119 mark.lam 2020-01-08 12:07:20 -0800 Comment on attachment 387119 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387119&action=review r=me with fix. > ChangeLog:17 > +2020-01-08 Keith Miller <keith_miller@apple.com> > + > + Fix testing Makefile to inherit preprocessor definitions > + https://bugs.webkit.org/show_bug.cgi?id=205940 > + > + Reviewed by NOBODY (OOPS!). > + > + * Makefile.shared: Remove dupe ChangeLog. 1604223 4 387126 keith_miller 2020-01-08 12:08:05 -0800 Created attachment 387126 Patch for landing 1604247 5 commit-queue 2020-01-08 13:17:59 -0800 The commit-queue encountered the following flaky tests while processing attachment 387126: fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com) The commit-queue is continuing to process your patch. 1604248 6 387126 commit-queue 2020-01-08 13:18:50 -0800 Comment on attachment 387126 Patch for landing Clearing flags on attachment: 387126 Committed r254219: <https://trac.webkit.org/changeset/254219> 1604249 7 commit-queue 2020-01-08 13:18:52 -0800 All reviewed patches have been landed. Closing bug. 1604250 8 webkit-bug-importer 2020-01-08 13:19:13 -0800 <rdar://problem/58419206> 387117 2020-01-08 11:34:07 -0800 2020-01-08 11:46:28 -0800 Patch bug-205940-20200108113405.patch text/plain 1917 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MTg0CmRpZmYgLS1naXQgYS9Ub29scy9NYWtlZmlsZSBi L1Rvb2xzL01ha2VmaWxlCmluZGV4IDY5NmNlMTZjNzliMDc0ZGNiMTgxZDU5YjIyZmE3MjkzM2M4 OGU0ZTkuLjg3NGNlMmFlMTJhODVjZGMyNWVjY2I0N2QyYWE3MWM5N2YxODFhYTMgMTAwNjQ0Ci0t LSBhL1Rvb2xzL01ha2VmaWxlCisrKyBiL1Rvb2xzL01ha2VmaWxlCkBAIC0zNCw3ICszNCw3IEBA IHJlbGVhc2UgciBkZXBsb3ltZW50IGRlcCBkZXBsb3k6CiAKIHRlc3RpbmcgdDoKIAlAZm9yIGRp ciBpbiAkKE1PRFVMRVMpOyBkbyAke01BS0V9ICRAIC1DICQkZGlyOyBleGl0X3N0YXR1cz0kJD87 IFwKLSAgICAgICAgaWYgWyAkJGV4aXRfc3RhdHVzIC1uZSAwIF07IHRoZW4gZXhpdCAkJGV4aXRf c3RhdHVzOyBmaTsgZG9uZQorCWlmIFsgJCRleGl0X3N0YXR1cyAtbmUgMCBdOyB0aGVuIGV4aXQg JCRleGl0X3N0YXR1czsgZmk7IGRvbmUKIAogYW5hbHl6ZToKIAlAZm9yIGRpciBpbiAkKE1PRFVM RVMpOyBkbyAke01BS0V9ICRAIC1DICQkZGlyOyBleGl0X3N0YXR1cz0kJD87IFwKZGlmZiAtLWdp dCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA5M2I3MThmZmQ1NTAxYWI5ZDZiMGU1Nzkz ZGQ5Y2I3MjNiMDZiNzI4Li45NzY0MDU3M2VkZTM2MTUzNTY4ZjcyODk3YzFiZDRmYTI4OTFiZjMy IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMjAtMDEtMDggIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CisKKyAg ICAgICAgRml4IHRlc3RpbmcgTWFrZWZpbGUgdG8gaW5oZXJpdCBwcmVwcm9jZXNzb3IgZGVmaW5p dGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw NTk0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog TWFrZWZpbGUuc2hhcmVkOgorCiAyMDIwLTAxLTA3ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxs ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBhIHRlc3RpbmcgdGFyZ2V0IHRvIG1ha2UgdGhh dCBpcyByZWxlYXNlICsgYXNzZXJ0aW9ucwpkaWZmIC0tZ2l0IGEvTWFrZWZpbGUuc2hhcmVkIGIv TWFrZWZpbGUuc2hhcmVkCmluZGV4IDdhM2U5YzYyMWIyMDkyMDM4ZDNmMzQ4ZDI2NTE0YjRmZmEz YTc1NTkuLjgwNTc1ZTVlYTcxMWFjNzNjODE1MjAxY2EzY2FiMGJhMDUwMmM4NzQgMTAwNjQ0Ci0t LSBhL01ha2VmaWxlLnNoYXJlZAorKysgYi9NYWtlZmlsZS5zaGFyZWQKQEAgLTEwMyw3ICsxMDMs NyBAQCByZWxlYXNlIHIgZGVwbG95bWVudCBkZXAgZGVwbG95OiBmb3JjZQogCiB0ZXN0aW5nIHQ6 IGZvcmNlCiAJJChTQ1JJUFRTX1BBVEgpL3NldC13ZWJraXQtY29uZmlndXJhdGlvbiAtLXJlbGVh c2UgJChBU0FOX09QVElPTikgJChXS19MVE9fT1BUSU9OKQotCSggJChTRVRfQ09MT1JfRElBR05P U1RJQ1NfQVJHKTsgeGNvZGVidWlsZCAkKE9USEVSX09QVElPTlMpICQoWENPREVfT1BUSU9OUykg R0NDX1BSRVBST0NFU1NPUl9ERUZJTklUSU9OUz0iQVNTRVJUX0VOQUJMRUQ9MSIgfCAkKE9VVFBV VF9GSUxURVIpICYmIGV4aXQgJCR7UElQRVNUQVRVU1swXX0gKQorCSggJChTRVRfQ09MT1JfRElB R05PU1RJQ1NfQVJHKTsgeGNvZGVidWlsZCAkKE9USEVSX09QVElPTlMpICQoWENPREVfT1BUSU9O UykgR0NDX1BSRVBST0NFU1NPUl9ERUZJTklUSU9OUz0nQVNTRVJUX0VOQUJMRUQ9MSAkJChpbmhl cml0ZWQpJyB8ICQoT1VUUFVUX0ZJTFRFUikgJiYgZXhpdCAkJHtQSVBFU1RBVFVTWzBdfSApCiAK IGFuYWx5emU6CiAJJChTQ1JJUFRTX1BBVEgpL3NldC13ZWJraXQtY29uZmlndXJhdGlvbiAtLWRl YnVnICQoQVNBTl9PUFRJT04pICQoV0tfTFRPX09QVElPTikK 387119 2020-01-08 11:46:30 -0800 2020-01-08 12:08:04 -0800 Patch bug-205940-20200108114629.patch text/plain 2710 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MTg0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzcwMmE3ZmQzYzg1YTg5NjVkOWZjYjY3NWM1MTU3Njk1 OThlYmE3MS4uZTExNjM5MWJiMWE4OGViMWM1ZWRjODlmMWNiMDEwNDllMzIwM2QxNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDIwLTAxLTA4ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgor CisgICAgICAgIEZpeCB0ZXN0aW5nIE1ha2VmaWxlIHRvIGluaGVyaXQgcHJlcHJvY2Vzc29yIGRl ZmluaXRpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMDU5NDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIE1ha2VmaWxlOgorCiAyMDIwLTAxLTA3ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVu c2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgSW50cm9kdWNlIF9XS1Jlc291cmNlTG9hZERlbGVn YXRlCmRpZmYgLS1naXQgYS9Ub29scy9NYWtlZmlsZSBiL1Rvb2xzL01ha2VmaWxlCmluZGV4IDY5 NmNlMTZjNzliMDc0ZGNiMTgxZDU5YjIyZmE3MjkzM2M4OGU0ZTkuLjg3NGNlMmFlMTJhODVjZGMy NWVjY2I0N2QyYWE3MWM5N2YxODFhYTMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01ha2VmaWxlCisrKyBi L1Rvb2xzL01ha2VmaWxlCkBAIC0zNCw3ICszNCw3IEBAIHJlbGVhc2UgciBkZXBsb3ltZW50IGRl cCBkZXBsb3k6CiAKIHRlc3RpbmcgdDoKIAlAZm9yIGRpciBpbiAkKE1PRFVMRVMpOyBkbyAke01B S0V9ICRAIC1DICQkZGlyOyBleGl0X3N0YXR1cz0kJD87IFwKLSAgICAgICAgaWYgWyAkJGV4aXRf c3RhdHVzIC1uZSAwIF07IHRoZW4gZXhpdCAkJGV4aXRfc3RhdHVzOyBmaTsgZG9uZQorCWlmIFsg JCRleGl0X3N0YXR1cyAtbmUgMCBdOyB0aGVuIGV4aXQgJCRleGl0X3N0YXR1czsgZmk7IGRvbmUK IAogYW5hbHl6ZToKIAlAZm9yIGRpciBpbiAkKE1PRFVMRVMpOyBkbyAke01BS0V9ICRAIC1DICQk ZGlyOyBleGl0X3N0YXR1cz0kJD87IFwKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxv ZwppbmRleCA5M2I3MThmZmQ1NTAxYWI5ZDZiMGU1NzkzZGQ5Y2I3MjNiMDZiNzI4Li4zZDM1NzJk MjU1YTlmY2U5Y2VlNWY4MzVkMDFmODlhYmE0OGI1YjY1IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cK KysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjAtMDEtMDggIEtlaXRoIE1pbGxl ciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IHRlc3RpbmcgTWFrZWZp bGUgdG8gaW5oZXJpdCBwcmVwcm9jZXNzb3IgZGVmaW5pdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTk0MAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTWFrZWZpbGUuc2hhcmVkOgorCisyMDIw LTAxLTA4ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgorCisgICAgICAg IEZpeCB0ZXN0aW5nIE1ha2VmaWxlIHRvIGluaGVyaXQgcHJlcHJvY2Vzc29yIGRlZmluaXRpb25z CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDU5NDAK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIE1ha2Vm aWxlLnNoYXJlZDoKKwogMjAyMC0wMS0wNyAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFw cGxlLmNvbT4KIAogICAgICAgICBBZGQgYSB0ZXN0aW5nIHRhcmdldCB0byBtYWtlIHRoYXQgaXMg cmVsZWFzZSArIGFzc2VydGlvbnMKZGlmZiAtLWdpdCBhL01ha2VmaWxlLnNoYXJlZCBiL01ha2Vm aWxlLnNoYXJlZAppbmRleCA3YTNlOWM2MjFiMjA5MjAzOGQzZjM0OGQyNjUxNGI0ZmZhM2E3NTU5 Li44MDU3NWU1ZWE3MTFhYzczYzgxNTIwMWNhM2NhYjBiYTA1MDJjODc0IDEwMDY0NAotLS0gYS9N YWtlZmlsZS5zaGFyZWQKKysrIGIvTWFrZWZpbGUuc2hhcmVkCkBAIC0xMDMsNyArMTAzLDcgQEAg cmVsZWFzZSByIGRlcGxveW1lbnQgZGVwIGRlcGxveTogZm9yY2UKIAogdGVzdGluZyB0OiBmb3Jj ZQogCSQoU0NSSVBUU19QQVRIKS9zZXQtd2Via2l0LWNvbmZpZ3VyYXRpb24gLS1yZWxlYXNlICQo QVNBTl9PUFRJT04pICQoV0tfTFRPX09QVElPTikKLQkoICQoU0VUX0NPTE9SX0RJQUdOT1NUSUNT X0FSRyk7IHhjb2RlYnVpbGQgJChPVEhFUl9PUFRJT05TKSAkKFhDT0RFX09QVElPTlMpIEdDQ19Q UkVQUk9DRVNTT1JfREVGSU5JVElPTlM9IkFTU0VSVF9FTkFCTEVEPTEiIHwgJChPVVRQVVRfRklM VEVSKSAmJiBleGl0ICQke1BJUEVTVEFUVVNbMF19ICkKKwkoICQoU0VUX0NPTE9SX0RJQUdOT1NU SUNTX0FSRyk7IHhjb2RlYnVpbGQgJChPVEhFUl9PUFRJT05TKSAkKFhDT0RFX09QVElPTlMpIEdD Q19QUkVQUk9DRVNTT1JfREVGSU5JVElPTlM9J0FTU0VSVF9FTkFCTEVEPTEgJCQoaW5oZXJpdGVk KScgfCAkKE9VVFBVVF9GSUxURVIpICYmIGV4aXQgJCR7UElQRVNUQVRVU1swXX0gKQogCiBhbmFs eXplOgogCSQoU0NSSVBUU19QQVRIKS9zZXQtd2Via2l0LWNvbmZpZ3VyYXRpb24gLS1kZWJ1ZyAk KEFTQU5fT1BUSU9OKSAkKFdLX0xUT19PUFRJT04pCg== 387126 2020-01-08 12:08:05 -0800 2020-01-08 13:18:50 -0800 Patch for landing bug-205940-20200108120804.patch text/plain 2451 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MTg0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzcwMmE3ZmQzYzg1YTg5NjVkOWZjYjY3NWM1MTU3Njk1 OThlYmE3MS4uMDlhZGVkY2JkODFmYWY4N2Q2NTUwZmMxMDBjODVhZWZiOWU2NDZjNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDIwLTAxLTA4ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgor CisgICAgICAgIEZpeCB0ZXN0aW5nIE1ha2VmaWxlIHRvIGluaGVyaXQgcHJlcHJvY2Vzc29yIGRl ZmluaXRpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMDU5NDAKKworICAgICAgICBSZXZpZXdlZCBieSBNYXJrIExhbS4KKworICAgICAgICAqIE1h a2VmaWxlOgorCiAyMDIwLTAxLTA3ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdl YmtpdC5vcmc+CiAKICAgICAgICAgSW50cm9kdWNlIF9XS1Jlc291cmNlTG9hZERlbGVnYXRlCmRp ZmYgLS1naXQgYS9Ub29scy9NYWtlZmlsZSBiL1Rvb2xzL01ha2VmaWxlCmluZGV4IDY5NmNlMTZj NzliMDc0ZGNiMTgxZDU5YjIyZmE3MjkzM2M4OGU0ZTkuLjg3NGNlMmFlMTJhODVjZGMyNWVjY2I0 N2QyYWE3MWM5N2YxODFhYTMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01ha2VmaWxlCisrKyBiL1Rvb2xz L01ha2VmaWxlCkBAIC0zNCw3ICszNCw3IEBAIHJlbGVhc2UgciBkZXBsb3ltZW50IGRlcCBkZXBs b3k6CiAKIHRlc3RpbmcgdDoKIAlAZm9yIGRpciBpbiAkKE1PRFVMRVMpOyBkbyAke01BS0V9ICRA IC1DICQkZGlyOyBleGl0X3N0YXR1cz0kJD87IFwKLSAgICAgICAgaWYgWyAkJGV4aXRfc3RhdHVz IC1uZSAwIF07IHRoZW4gZXhpdCAkJGV4aXRfc3RhdHVzOyBmaTsgZG9uZQorCWlmIFsgJCRleGl0 X3N0YXR1cyAtbmUgMCBdOyB0aGVuIGV4aXQgJCRleGl0X3N0YXR1czsgZmk7IGRvbmUKIAogYW5h bHl6ZToKIAlAZm9yIGRpciBpbiAkKE1PRFVMRVMpOyBkbyAke01BS0V9ICRAIC1DICQkZGlyOyBl eGl0X3N0YXR1cz0kJD87IFwKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRl eCA5M2I3MThmZmQ1NTAxYWI5ZDZiMGU1NzkzZGQ5Y2I3MjNiMDZiNzI4Li4zMjQ3YWIyNDhlMzU0 M2QwNzM1MGJhYjE0OGU4MTZkZjUwZGE2YTY4IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjAtMDEtMDggIEtlaXRoIE1pbGxlciAgPGtl aXRoX21pbGxlckBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IHRlc3RpbmcgTWFrZWZpbGUgdG8g aW5oZXJpdCBwcmVwcm9jZXNzb3IgZGVmaW5pdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTk0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE1h cmsgTGFtLgorCisgICAgICAgICogTWFrZWZpbGUuc2hhcmVkOgorCiAyMDIwLTAxLTA3ICBLZWl0 aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBhIHRlc3Rp bmcgdGFyZ2V0IHRvIG1ha2UgdGhhdCBpcyByZWxlYXNlICsgYXNzZXJ0aW9ucwpkaWZmIC0tZ2l0 IGEvTWFrZWZpbGUuc2hhcmVkIGIvTWFrZWZpbGUuc2hhcmVkCmluZGV4IDdhM2U5YzYyMWIyMDky MDM4ZDNmMzQ4ZDI2NTE0YjRmZmEzYTc1NTkuLjgwNTc1ZTVlYTcxMWFjNzNjODE1MjAxY2EzY2Fi MGJhMDUwMmM4NzQgMTAwNjQ0Ci0tLSBhL01ha2VmaWxlLnNoYXJlZAorKysgYi9NYWtlZmlsZS5z aGFyZWQKQEAgLTEwMyw3ICsxMDMsNyBAQCByZWxlYXNlIHIgZGVwbG95bWVudCBkZXAgZGVwbG95 OiBmb3JjZQogCiB0ZXN0aW5nIHQ6IGZvcmNlCiAJJChTQ1JJUFRTX1BBVEgpL3NldC13ZWJraXQt Y29uZmlndXJhdGlvbiAtLXJlbGVhc2UgJChBU0FOX09QVElPTikgJChXS19MVE9fT1BUSU9OKQot CSggJChTRVRfQ09MT1JfRElBR05PU1RJQ1NfQVJHKTsgeGNvZGVidWlsZCAkKE9USEVSX09QVElP TlMpICQoWENPREVfT1BUSU9OUykgR0NDX1BSRVBST0NFU1NPUl9ERUZJTklUSU9OUz0iQVNTRVJU X0VOQUJMRUQ9MSIgfCAkKE9VVFBVVF9GSUxURVIpICYmIGV4aXQgJCR7UElQRVNUQVRVU1swXX0g KQorCSggJChTRVRfQ09MT1JfRElBR05PU1RJQ1NfQVJHKTsgeGNvZGVidWlsZCAkKE9USEVSX09Q VElPTlMpICQoWENPREVfT1BUSU9OUykgR0NDX1BSRVBST0NFU1NPUl9ERUZJTklUSU9OUz0nQVNT RVJUX0VOQUJMRUQ9MSAkJChpbmhlcml0ZWQpJyB8ICQoT1VUUFVUX0ZJTFRFUikgJiYgZXhpdCAk JHtQSVBFU1RBVFVTWzBdfSApCiAKIGFuYWx5emU6CiAJJChTQ1JJUFRTX1BBVEgpL3NldC13ZWJr aXQtY29uZmlndXJhdGlvbiAtLWRlYnVnICQoQVNBTl9PUFRJT04pICQoV0tfTFRPX09QVElPTikK