205807 2020-01-06 09:50:38 -0800 REGRESSION: [ Mac Debug ] inspector/page/setBootstrapScript-main-frame.html is a flaky failure 2020-01-07 12:17:50 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tsavell hi commit-queue dino hi inspector-bugzilla-changes webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1603101 0 tsavell 2020-01-06 09:50:38 -0800 inspector/page/setBootstrapScript-main-frame.html Description: This test is a flaky failure on Mac Debug. This test has been flakey for at least several months. I do not have a starting point at this time. It was first added in https://trac.webkit.org/changeset/251531/webkit so this test may have been flaky from introduction. History: https://results.webkit.org/?suite=layout-tests&test=inspector%2Fpage%2FsetBootstrapScript-main-frame.html&limit=10000 Diff: --- /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/inspector/page/setBootstrapScript-main-frame-expected.txt +++ /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/inspector/page/setBootstrapScript-main-frame-actual.txt @@ -6,5 +6,7 @@ PASS: 'valueFromBootstrapScript' should be 'undefined'. Setting bootstrap script... Reloading page... -PASS: 'valueFromBootstrapScript' should be '42'. +FAIL: 'valueFromBootstrapScript' should be '42'. + Expected: 42 + Actual: undefined 1603102 1 webkit-bug-importer 2020-01-06 09:50:52 -0800 <rdar://problem/58344669> 1603104 2 tsavell 2020-01-06 09:56:39 -0800 marked test as failing while it is investigated: https://trac.webkit.org/changeset/254059/webkit 1603347 3 386906 hi 2020-01-06 15:56:11 -0800 Created attachment 386906 Patch It took a while (over 10000 iterations), but I was finally able to reproduce this locally. I'm not 100% sure whether all of them are actually necessary to fix this issue, but I do think all of them are necessary overall (e.g. some may effectively be a drive-by), and since it seems to reproduce so infrequently for me, I'd rather put the patch up and get it tested/landed than take the (likely long) time to try to bisect what actually fixed it among these changes. 1603481 4 386906 dino 2020-01-07 01:04:17 -0800 Comment on attachment 386906 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386906&action=review > Source/WebInspectorUI/UserInterface/Controllers/NetworkManager.js:1432 > + let source = this._bootstrapScript.content || ""; Use ?? ? (wouldn't matter here though). Also, this can be const. 1603669 5 386906 hi 2020-01-07 11:07:58 -0800 Comment on attachment 386906 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386906&action=review >> Source/WebInspectorUI/UserInterface/Controllers/NetworkManager.js:1432 >> + let source = this._bootstrapScript.content || ""; > > Use ?? ? (wouldn't matter here though). > > Also, this can be const. In this case, I'd prefer `||` as I would also want to switch to a string in the case that `this._bootstrapScript.content` was actually `false`. Frankly, this code is probably unnecessary, but it can't hurt ¯\_(ツ)_/¯ Web Inspector style is to only use `const` for values that don't change between sessions, like literal constant values. 1603672 6 386906 commit-queue 2020-01-07 11:10:50 -0800 Comment on attachment 386906 Patch Rejecting attachment 386906 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 386906, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=386906&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=205807&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 386906 from bug 205807. Fetching: https://bugs.webkit.org/attachment.cgi?id=386906 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Dean Jackson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 5 diffs from patch file(s). patching file Source/WebInspectorUI/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebInspectorUI/UserInterface/Controllers/NetworkManager.js patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/inspector/page/setBootstrapScript-main-frame.html patching file LayoutTests/platform/mac/TestExpectations Hunk #1 FAILED at 1967. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/TestExpectations.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Dean Jackson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/13300740 1603678 7 387000 hi 2020-01-07 11:15:56 -0800 Created attachment 387000 Patch 1603720 8 commit-queue 2020-01-07 12:16:54 -0800 The commit-queue encountered the following flaky tests while processing attachment 387000: imported/w3c/web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/content/002.xhtml bug 205881 (author: cdumez@apple.com) transitions/default-timing-function.html bug 138901 (authors: dino@apple.com and graouts@apple.com) The commit-queue is continuing to process your patch. 1603722 9 387000 commit-queue 2020-01-07 12:17:48 -0800 Comment on attachment 387000 Patch Clearing flags on attachment: 387000 Committed r254145: <https://trac.webkit.org/changeset/254145> 1603723 10 commit-queue 2020-01-07 12:17:50 -0800 All reviewed patches have been landed. Closing bug. 386906 2020-01-06 15:56:11 -0800 2020-01-07 11:15:54 -0800 Patch bug-205807-20200106165610.patch text/plain 6489 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDBiMmUyNDI1NTk1OTE0NGJkMmRiMTY4NzdiZDBi ZTEzYThkNjJmYzAuLjNjMTZkZjQwNzNmYThhMjk1OWUyMTAwYTg5YjdhODg4YzY1MjkxODIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTAxLTA2ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OOiBbIE1h YyBEZWJ1ZyBdIGluc3BlY3Rvci9wYWdlL3NldEJvb3RzdHJhcFNjcmlwdC1tYWluLWZyYW1lLmh0 bWwgaXMgYSBmbGFreSBmYWlsdXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDU4MDcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU4MzQ0NjY5Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlcklu dGVyZmFjZS9Db250cm9sbGVycy9OZXR3b3JrTWFuYWdlci5qczoKKyAgICAgICAgKFdJLk5ldHdv cmtNYW5hZ2VyLnByb3RvdHlwZS5hc3luYyBjcmVhdGVCb290c3RyYXBTY3JpcHQpOgorICAgICAg ICAoV0kuTmV0d29ya01hbmFnZXIucHJvdG90eXBlLl9oYW5kbGVCb290c3RyYXBTY3JpcHRDb250 ZW50RGlkQ2hhbmdlKToKKyAgICAgICAgRW5zdXJlIHRoYXQgYFBhZ2Uuc2V0Qm9vdHN0cmFwU2Ny aXB0YCBpcyBjYWxsZWQgd2hlbiByZXN0b3JpbmcgdGhlIGJvb3RzdHJhcCBzY3JpcHQgZnJvbSB0 aGUKKyAgICAgICAgSW5kZXhlZERCIHN0b3JhZ2UuIE90aGVyd2lzZSwgaW4gc2l0dWF0aW9ucyBs aWtlIHdoZW4gV2ViIEluc3BlY3RvciBpcyBmaXJzdCBvcGVuZWQsIHdlIHdpbGwKKyAgICAgICAg c2hvdyB0aGUgSW5zcGVjdG9yIEJvb3RzdHJhcCBTY3JpcHQgaW4gdGhlIFVJLCBidXQgbm90IGFj dHVhbGx5IHNldCBpdCBvbiB0aGUgaW5zcGVjdGVkIHBhZ2UuCisKIDIwMjAtMDEtMDYgIE5pa2l0 YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihy MjE4ODM5KTogV2ViIEluc3BlY3RvcjogQ29sb3IgcGlja2VyOiBwcmVzc2luZyBFc2Mgc2hvdWxk IGhpZGUgY29sb3IgcGlja2VyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9Db250cm9sbGVycy9OZXR3b3JrTWFuYWdlci5qcyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL05ldHdvcmtNYW5hZ2VyLmpzCmluZGV4 IGQxMDE4YWRlNGZmZDc2MmUwYjQzZGYwNmI2ZmJmMzAyOTAwMTI5ZjUuLjU3MDAwNTFmZDQwODI1 N2IwY2E2YmMxNjllMTM4MjAwMTljNGYzNDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL05ldHdvcmtNYW5hZ2VyLmpzCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL05ldHdvcmtNYW5h Z2VyLmpzCkBAIC0zMjQsOSArMzI0LDcgQEAgV0kuTmV0d29ya01hbmFnZXIgPSBjbGFzcyBOZXR3 b3JrTWFuYWdlciBleHRlbmRzIFdJLk9iamVjdAogICAgICAgICBjb25zdCBzb3VyY2VVUkwgPSBO ZXR3b3JrTWFuYWdlci5ib290c3RyYXBTY3JpcHRVUkw7CiAgICAgICAgIHRoaXMuX2Jvb3RzdHJh cFNjcmlwdCA9IG5ldyBXSS5Mb2NhbFNjcmlwdCh0YXJnZXQsIHVybCwgc291cmNlVVJMLCBXSS5T Y3JpcHQuU291cmNlVHlwZS5Qcm9ncmFtLCBzb3VyY2UsIHtpbmplY3RlZDogdHJ1ZSwgZWRpdGFi bGU6IHRydWV9KTsKICAgICAgICAgdGhpcy5fYm9vdHN0cmFwU2NyaXB0LmFkZEV2ZW50TGlzdGVu ZXIoV0kuU291cmNlQ29kZS5FdmVudC5Db250ZW50RGlkQ2hhbmdlLCB0aGlzLl9oYW5kbGVCb290 c3RyYXBTY3JpcHRDb250ZW50RGlkQ2hhbmdlLCB0aGlzKTsKLQotICAgICAgICBpZiAoIXRoaXMu X2Jvb3RzdHJhcFNjcmlwdC5jb250ZW50KQotICAgICAgICAgICAgV0kub2JqZWN0U3RvcmVzLmdl bmVyYWwucHV0KCIiLCBOZXR3b3JrTWFuYWdlci5ib290c3RyYXBTY3JpcHRTb3VyY2VPYmplY3RT dG9yZUtleSk7CisgICAgICAgIHRoaXMuX2hhbmRsZUJvb3RzdHJhcFNjcmlwdENvbnRlbnREaWRD aGFuZ2UoKTsKIAogICAgICAgICB0aGlzLmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycyhOZXR3b3Jr TWFuYWdlci5FdmVudC5Cb290c3RyYXBTY3JpcHRDcmVhdGVkLCB7Ym9vdHN0cmFwU2NyaXB0OiB0 aGlzLl9ib290c3RyYXBTY3JpcHR9KTsKICAgICB9CkBAIC0xNDMxLDcgKzE0MjksNyBAQCBXSS5O ZXR3b3JrTWFuYWdlciA9IGNsYXNzIE5ldHdvcmtNYW5hZ2VyIGV4dGVuZHMgV0kuT2JqZWN0CiAK ICAgICBfaGFuZGxlQm9vdHN0cmFwU2NyaXB0Q29udGVudERpZENoYW5nZShldmVudCkKICAgICB7 Ci0gICAgICAgIGxldCBzb3VyY2UgPSB0aGlzLl9ib290c3RyYXBTY3JpcHQuY29udGVudDsKKyAg ICAgICAgbGV0IHNvdXJjZSA9IHRoaXMuX2Jvb3RzdHJhcFNjcmlwdC5jb250ZW50IHx8ICIiOwog CiAgICAgICAgIFdJLm9iamVjdFN0b3Jlcy5nZW5lcmFsLnB1dChzb3VyY2UsIE5ldHdvcmtNYW5h Z2VyLmJvb3RzdHJhcFNjcmlwdFNvdXJjZU9iamVjdFN0b3JlS2V5KTsKIApkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDUyZWE5 YWM4OWI4ZDY2Nzg2NmYyYjg2Y2ZjNDExZDIyYjMwOTE5YzUuLjJhYjhmZDJiM2Q5OGJhZmJjMDJi MjY1ODM4Y2EwYTBjNWVlZTg1YjggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZwor KysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAyMC0wMS0wNiAg RGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTjog WyBNYWMgRGVidWcgXSBpbnNwZWN0b3IvcGFnZS9zZXRCb290c3RyYXBTY3JpcHQtbWFpbi1mcmFt ZS5odG1sIGlzIGEgZmxha3kgZmFpbHVyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjA1ODA3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81ODM0NDY2 OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGlu c3BlY3Rvci9wYWdlL3NldEJvb3RzdHJhcFNjcmlwdC1tYWluLWZyYW1lLmh0bWw6CisgICAgICAg IEluIGFkZGl0aW9uIHRvIHdhaXRpbmcgZm9yIGBQYWdlLnJlbG9hZGAsIHdlIHNob3VsZCBhbHNv IHdhaXQgZm9yIHRoZSBwYWdlIHRvIGFjdHVhbGx5IGxvYWQuCisgICAgICAgIFNldCB0aGUgY29u dGVudCBvZiB0aGUgYm9vdHN0cmFwIHNjcmlwdCBkdXJpbmcgaXRzIGNyZWF0aW9uIGluc3RlYWQg b2YgYXMgYSB0d28gc3RlcCBwcm9jZXNzLgorICAgICAgICBBdm9pZCBhbiBhc3NlcnRpb24gYnkg c2V0dGluZyB0aGUgZW5hYmxlZCBzdGF0ZSBhZnRlciB0aGUgYm9vdHN0cmFwIHNjcmlwdCBpcyBp bml0YWxpemVkLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnM6Cisg ICAgICAgIFJlbW92ZSBleHBlY3RhdGlvbiBhZGRlZCBpbiByMjU0MDU5LgorCiAyMDIwLTAxLTA2 ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgUmVncmVzc2lvbiBy MjU0MDI5OiBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9ldmVudHMvRXZlbnRU YXJnZXQtZGlzcGF0Y2hFdmVudC5odG1sIGlzIGZhaWxpbmcKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2luc3BlY3Rvci9wYWdlL3NldEJvb3RzdHJhcFNjcmlwdC1tYWluLWZyYW1lLmh0bWwgYi9M YXlvdXRUZXN0cy9pbnNwZWN0b3IvcGFnZS9zZXRCb290c3RyYXBTY3JpcHQtbWFpbi1mcmFtZS5o dG1sCmluZGV4IDJjNzI5YzBjZTQ2MDkwYTg1MzYzMTg1MDlhNzVlY2Y0MmU3NDI1YzIuLjNmMmE0 ZmU5MGY4NzI4MDAzMjQ4N2VmNjc5NjI2OTcxNDI2OWY1NTIgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL2luc3BlY3Rvci9wYWdlL3NldEJvb3RzdHJhcFNjcmlwdC1tYWluLWZyYW1lLmh0bWwKKysr IGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3BhZ2Uvc2V0Qm9vdHN0cmFwU2NyaXB0LW1haW4tZnJh bWUuaHRtbApAQCAtMTEsMTggKzExLDIwIEBAIGZ1bmN0aW9uIHRlc3QoKQogICAgICAgICBuYW1l OiAiUGFnZS5zZXRCb290c3RyYXBTY3JpcHQuTWFpbkZyYW1lIiwKICAgICAgICAgZGVzY3JpcHRp b246ICJUZXN0IHRoYXQgdGhlIGJvb3RzdHJhcCBzY3JpcHQgaXMgZXhlY3V0ZWQgaW4gdGhlIG1h aW4gZnJhbWUuIiwKICAgICAgICAgYXN5bmMgdGVzdCgpIHsKKyAgICAgICAgICAgIEluc3BlY3Rv clRlc3QuYXNzZXJ0KCFXSS5uZXR3b3JrTWFuYWdlci5ib290c3RyYXBTY3JpcHQsICJTaG91bGQg bm90IGFscmVhZHkgaGF2ZSBhIGJvb3RzdHJhcCBzY3JpcHQuIik7CisKICAgICAgICAgICAgIGxl dCB2YWx1ZUJlZm9yZUJvb3RzdHJhcFNjcmlwdCA9IGF3YWl0IEluc3BlY3RvclRlc3QuZXZhbHVh dGVJblBhZ2UoYHdpbmRvdy52YWx1ZUZyb21Cb290c3RyYXBTY3JpcHRgKTsKICAgICAgICAgICAg IEluc3BlY3RvclRlc3QuZXhwZWN0RXF1YWwodmFsdWVCZWZvcmVCb290c3RyYXBTY3JpcHQsIHVu ZGVmaW5lZCwgIid2YWx1ZUZyb21Cb290c3RyYXBTY3JpcHQnIHNob3VsZCBiZSAndW5kZWZpbmVk Jy4iKTsKIAogICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5sb2coIlNldHRpbmcgYm9vdHN0cmFw IHNjcmlwdC4uLiIpOwotICAgICAgICAgICAgYXdhaXQgV0kubmV0d29ya01hbmFnZXIuY3JlYXRl Qm9vdHN0cmFwU2NyaXB0KCk7CisgICAgICAgICAgICBhd2FpdCBXSS5uZXR3b3JrTWFuYWdlci5j cmVhdGVCb290c3RyYXBTY3JpcHQoYHdpbmRvdy52YWx1ZUZyb21Cb290c3RyYXBTY3JpcHQgPSA0 MjtgKTsKICAgICAgICAgICAgIFdJLm5ldHdvcmtNYW5hZ2VyLmJvb3RzdHJhcFNjcmlwdEVuYWJs ZWQgPSB0cnVlOwotICAgICAgICAgICAgV0kubmV0d29ya01hbmFnZXIuYm9vdHN0cmFwU2NyaXB0 LmN1cnJlbnRSZXZpc2lvbi51cGRhdGVSZXZpc2lvbkNvbnRlbnQoYHdpbmRvdy52YWx1ZUZyb21C b290c3RyYXBTY3JpcHQgPSA0MjtgKTsKIAogICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5sb2co IlJlbG9hZGluZyBwYWdlLi4uIik7Ci0gICAgICAgICAgICBhd2FpdCBJbnNwZWN0b3JUZXN0LnJl bG9hZFBhZ2UoKTsKLQotICAgICAgICAgICAgYXdhaXQgUHJvbWlzZS5kZWxheSgxMCk7CisgICAg ICAgICAgICBhd2FpdCBQcm9taXNlLmFsbChbCisgICAgICAgICAgICAgICAgSW5zcGVjdG9yVGVz dC5hd2FpdEV2ZW50KEZyb250ZW5kVGVzdEhhcm5lc3MuRXZlbnQuVGVzdFBhZ2VEaWRMb2FkKSwK KyAgICAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LnJlbG9hZFBhZ2UoKSwKKyAgICAgICAgICAg IF0pOwogCiAgICAgICAgICAgICBsZXQgdmFsdWVBZnRlckJvb3RzdHJhcFNjcmlwdCA9IGF3YWl0 IEluc3BlY3RvclRlc3QuZXZhbHVhdGVJblBhZ2UoYHdpbmRvdy52YWx1ZUZyb21Cb290c3RyYXBT Y3JpcHRgKTsKICAgICAgICAgICAgIEluc3BlY3RvclRlc3QuZXhwZWN0RXF1YWwodmFsdWVBZnRl ckJvb3RzdHJhcFNjcmlwdCwgNDIsICIndmFsdWVGcm9tQm9vdHN0cmFwU2NyaXB0JyBzaG91bGQg YmUgJzQyJy4iKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhw ZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMKaW5k ZXggNGNlNDNjNmFhMzEwZDE5Y2VlYWJiNjZmNDA4ZTExZWY4NWZjNDM3Mi4uYzBmOGNlNWNiZjg4 MjExY2ZiNzExYTU1YTM5MGE3MTcwM2E1ZTVjMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxh dGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFj L1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTE5NjcsNSArMTk2NywzIEBAIHdlYmtpdC5vcmcvYi8yMDIw NjQgd2ViYXVkaW8vc2lsZW50LWF1ZGlvLWludGVycnVwdGVkLWluLWJhY2tncm91bmQuaHRtbCBb IFBhc3MKIAogd2Via2l0Lm9yZy9iLzIwNTc1NyB3ZWJnbC8xLjAuMy9jb25mb3JtYW5jZS90ZXh0 dXJlcy90ZXh0dXJlLXVwbG9hZC1zaXplLmh0bWwgWyBQYXNzIFRpbWVvdXQgXQogd2Via2l0Lm9y Zy9iLzIwNTc1NiB3ZWJnbC8yLjAuMC9jb25mb3JtYW5jZTIvZ2xzbDMvbm8tYXR0cmlidXRlLXZl cnRleC1zaGFkZXIuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCi0KLXdlYmtpdC5vcmcvYi8yMDU4MDcg WyBEZWJ1ZyBdIGluc3BlY3Rvci9wYWdlL3NldEJvb3RzdHJhcFNjcmlwdC1tYWluLWZyYW1lLmh0 bWwgWyBQYXNzIEZhaWx1cmUgXQpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK 387000 2020-01-07 11:15:56 -0800 2020-01-07 12:17:48 -0800 Patch bug-205807-20200107121556.patch text/plain 6781 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGRjYzlkYzVhMjAyMjY4MjU2NDQ3ZDRhYWNlZWMx NzQwYWVkMjQ0NTEuLjE0ZDEwNWVmNzQ1Y2M1OGRjYjQxYTEzY2YxZjJmOTNlY2RkYjg0MjcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTAxLTA2ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OOiBbIE1h YyBEZWJ1ZyBdIGluc3BlY3Rvci9wYWdlL3NldEJvb3RzdHJhcFNjcmlwdC1tYWluLWZyYW1lLmh0 bWwgaXMgYSBmbGFreSBmYWlsdXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDU4MDcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU4MzQ0NjY5Pgor CisgICAgICAgIFJldmlld2VkIGJ5IERlYW4gSmFja3Nvbi4KKworICAgICAgICAqIFVzZXJJbnRl cmZhY2UvQ29udHJvbGxlcnMvTmV0d29ya01hbmFnZXIuanM6CisgICAgICAgIChXSS5OZXR3b3Jr TWFuYWdlci5wcm90b3R5cGUuYXN5bmMgY3JlYXRlQm9vdHN0cmFwU2NyaXB0KToKKyAgICAgICAg KFdJLk5ldHdvcmtNYW5hZ2VyLnByb3RvdHlwZS5faGFuZGxlQm9vdHN0cmFwU2NyaXB0Q29udGVu dERpZENoYW5nZSk6CisgICAgICAgIEVuc3VyZSB0aGF0IGBQYWdlLnNldEJvb3RzdHJhcFNjcmlw dGAgaXMgY2FsbGVkIHdoZW4gcmVzdG9yaW5nIHRoZSBib290c3RyYXAgc2NyaXB0IGZyb20gdGhl CisgICAgICAgIEluZGV4ZWREQiBzdG9yYWdlLiBPdGhlcndpc2UsIGluIHNpdHVhdGlvbnMgbGlr ZSB3aGVuIFdlYiBJbnNwZWN0b3IgaXMgZmlyc3Qgb3BlbmVkLCB3ZSB3aWxsCisgICAgICAgIHNo b3cgdGhlIEluc3BlY3RvciBCb290c3RyYXAgU2NyaXB0IGluIHRoZSBVSSwgYnV0IG5vdCBhY3R1 YWxseSBzZXQgaXQgb24gdGhlIGluc3BlY3RlZCBwYWdlLgorCiAyMDIwLTAxLTA2ICBZdXJ5IFNl bWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJFR1JFU1NJT046IFsg TWFjIHdrMiBdIGh0dHAvdGVzdHMvaW5zcGVjdG9yL3RhcmdldC9wcm92aXNpb25hbC1sb2FkLWNh bmNlbHMtcHJldmlvdXMtbG9hZC5odG1sIGlzIGEgZmxha3kgZmFpbHVyZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvTmV0d29ya01h bmFnZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVy cy9OZXR3b3JrTWFuYWdlci5qcwppbmRleCBkMTAxOGFkZTRmZmQ3NjJlMGI0M2RmMDZiNmZiZjMw MjkwMDEyOWY1Li41NzAwMDUxZmQ0MDgyNTdiMGNhNmJjMTY5ZTEzODIwMDE5YzRmMzQyIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9O ZXR3b3JrTWFuYWdlci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9Db250cm9sbGVycy9OZXR3b3JrTWFuYWdlci5qcwpAQCAtMzI0LDkgKzMyNCw3IEBAIFdJLk5l dHdvcmtNYW5hZ2VyID0gY2xhc3MgTmV0d29ya01hbmFnZXIgZXh0ZW5kcyBXSS5PYmplY3QKICAg ICAgICAgY29uc3Qgc291cmNlVVJMID0gTmV0d29ya01hbmFnZXIuYm9vdHN0cmFwU2NyaXB0VVJM OwogICAgICAgICB0aGlzLl9ib290c3RyYXBTY3JpcHQgPSBuZXcgV0kuTG9jYWxTY3JpcHQodGFy Z2V0LCB1cmwsIHNvdXJjZVVSTCwgV0kuU2NyaXB0LlNvdXJjZVR5cGUuUHJvZ3JhbSwgc291cmNl LCB7aW5qZWN0ZWQ6IHRydWUsIGVkaXRhYmxlOiB0cnVlfSk7CiAgICAgICAgIHRoaXMuX2Jvb3Rz dHJhcFNjcmlwdC5hZGRFdmVudExpc3RlbmVyKFdJLlNvdXJjZUNvZGUuRXZlbnQuQ29udGVudERp ZENoYW5nZSwgdGhpcy5faGFuZGxlQm9vdHN0cmFwU2NyaXB0Q29udGVudERpZENoYW5nZSwgdGhp cyk7Ci0KLSAgICAgICAgaWYgKCF0aGlzLl9ib290c3RyYXBTY3JpcHQuY29udGVudCkKLSAgICAg ICAgICAgIFdJLm9iamVjdFN0b3Jlcy5nZW5lcmFsLnB1dCgiIiwgTmV0d29ya01hbmFnZXIuYm9v dHN0cmFwU2NyaXB0U291cmNlT2JqZWN0U3RvcmVLZXkpOworICAgICAgICB0aGlzLl9oYW5kbGVC b290c3RyYXBTY3JpcHRDb250ZW50RGlkQ2hhbmdlKCk7CiAKICAgICAgICAgdGhpcy5kaXNwYXRj aEV2ZW50VG9MaXN0ZW5lcnMoTmV0d29ya01hbmFnZXIuRXZlbnQuQm9vdHN0cmFwU2NyaXB0Q3Jl YXRlZCwge2Jvb3RzdHJhcFNjcmlwdDogdGhpcy5fYm9vdHN0cmFwU2NyaXB0fSk7CiAgICAgfQpA QCAtMTQzMSw3ICsxNDI5LDcgQEAgV0kuTmV0d29ya01hbmFnZXIgPSBjbGFzcyBOZXR3b3JrTWFu YWdlciBleHRlbmRzIFdJLk9iamVjdAogCiAgICAgX2hhbmRsZUJvb3RzdHJhcFNjcmlwdENvbnRl bnREaWRDaGFuZ2UoZXZlbnQpCiAgICAgewotICAgICAgICBsZXQgc291cmNlID0gdGhpcy5fYm9v dHN0cmFwU2NyaXB0LmNvbnRlbnQ7CisgICAgICAgIGxldCBzb3VyY2UgPSB0aGlzLl9ib290c3Ry YXBTY3JpcHQuY29udGVudCB8fCAiIjsKIAogICAgICAgICBXSS5vYmplY3RTdG9yZXMuZ2VuZXJh bC5wdXQoc291cmNlLCBOZXR3b3JrTWFuYWdlci5ib290c3RyYXBTY3JpcHRTb3VyY2VPYmplY3RT dG9yZUtleSk7CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRl c3RzL0NoYW5nZUxvZwppbmRleCA3NDAxNThjZDA4OGVkZjkyZGZjOTBiNDg4ZjExYjBlNjE0MWQx ZmQyLi42MTRiM2U5NjA3NDJiOGM3Zjc0NGRiYjIxMjhlYzZmMzUxODE4NzJiIDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTkgQEAKKzIwMjAtMDEtMDYgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29t PgorCisgICAgICAgIFJFR1JFU1NJT046IFsgTWFjIERlYnVnIF0gaW5zcGVjdG9yL3BhZ2Uvc2V0 Qm9vdHN0cmFwU2NyaXB0LW1haW4tZnJhbWUuaHRtbCBpcyBhIGZsYWt5IGZhaWx1cmUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTgwNworICAgICAg ICA8cmRhcjovL3Byb2JsZW0vNTgzNDQ2Njk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGVhbiBK YWNrc29uLgorCisgICAgICAgICogaW5zcGVjdG9yL3BhZ2Uvc2V0Qm9vdHN0cmFwU2NyaXB0LW1h aW4tZnJhbWUuaHRtbDoKKyAgICAgICAgSW4gYWRkaXRpb24gdG8gd2FpdGluZyBmb3IgYFBhZ2Uu cmVsb2FkYCwgd2Ugc2hvdWxkIGFsc28gd2FpdCBmb3IgdGhlIHBhZ2UgdG8gYWN0dWFsbHkgbG9h ZC4KKyAgICAgICAgU2V0IHRoZSBjb250ZW50IG9mIHRoZSBib290c3RyYXAgc2NyaXB0IGR1cmlu ZyBpdHMgY3JlYXRpb24gaW5zdGVhZCBvZiBhcyBhIHR3byBzdGVwIHByb2Nlc3MuCisgICAgICAg IEF2b2lkIGFuIGFzc2VydGlvbiBieSBzZXR0aW5nIHRoZSBlbmFibGVkIHN0YXRlIGFmdGVyIHRo ZSBib290c3RyYXAgc2NyaXB0IGlzIGluaXRhbGl6ZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9t YWMvVGVzdEV4cGVjdGF0aW9uczoKKyAgICAgICAgUmVtb3ZlIGV4cGVjdGF0aW9uIGFkZGVkIGlu IHIyNTQwNTkuCisKIDIwMjAtMDEtMDcgIFRydWl0dCBTYXZlbGwgIDx0c2F2ZWxsQGFwcGxlLmNv bT4KIAogICAgICAgICBDb3JyZWN0IHNvbWUgY29uZmxpY3RpbmcgZXhwZWN0YXRpb25zIGZvciBm YXN0L3RleHQvZW1vamktZ2VuZGVyLSB0ZXN0cwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5z cGVjdG9yL3BhZ2Uvc2V0Qm9vdHN0cmFwU2NyaXB0LW1haW4tZnJhbWUuaHRtbCBiL0xheW91dFRl c3RzL2luc3BlY3Rvci9wYWdlL3NldEJvb3RzdHJhcFNjcmlwdC1tYWluLWZyYW1lLmh0bWwKaW5k ZXggMmM3MjljMGNlNDYwOTBhODUzNjMxODUwOWE3NWVjZjQyZTc0MjVjMi4uM2YyYTRmZTkwZjg3 MjgwMDMyNDg3ZWY2Nzk2MjY5NzE0MjY5ZjU1MiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5z cGVjdG9yL3BhZ2Uvc2V0Qm9vdHN0cmFwU2NyaXB0LW1haW4tZnJhbWUuaHRtbAorKysgYi9MYXlv dXRUZXN0cy9pbnNwZWN0b3IvcGFnZS9zZXRCb290c3RyYXBTY3JpcHQtbWFpbi1mcmFtZS5odG1s CkBAIC0xMSwxOCArMTEsMjAgQEAgZnVuY3Rpb24gdGVzdCgpCiAgICAgICAgIG5hbWU6ICJQYWdl LnNldEJvb3RzdHJhcFNjcmlwdC5NYWluRnJhbWUiLAogICAgICAgICBkZXNjcmlwdGlvbjogIlRl c3QgdGhhdCB0aGUgYm9vdHN0cmFwIHNjcmlwdCBpcyBleGVjdXRlZCBpbiB0aGUgbWFpbiBmcmFt ZS4iLAogICAgICAgICBhc3luYyB0ZXN0KCkgeworICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5h c3NlcnQoIVdJLm5ldHdvcmtNYW5hZ2VyLmJvb3RzdHJhcFNjcmlwdCwgIlNob3VsZCBub3QgYWxy ZWFkeSBoYXZlIGEgYm9vdHN0cmFwIHNjcmlwdC4iKTsKKwogICAgICAgICAgICAgbGV0IHZhbHVl QmVmb3JlQm9vdHN0cmFwU2NyaXB0ID0gYXdhaXQgSW5zcGVjdG9yVGVzdC5ldmFsdWF0ZUluUGFn ZShgd2luZG93LnZhbHVlRnJvbUJvb3RzdHJhcFNjcmlwdGApOwogICAgICAgICAgICAgSW5zcGVj dG9yVGVzdC5leHBlY3RFcXVhbCh2YWx1ZUJlZm9yZUJvb3RzdHJhcFNjcmlwdCwgdW5kZWZpbmVk LCAiJ3ZhbHVlRnJvbUJvb3RzdHJhcFNjcmlwdCcgc2hvdWxkIGJlICd1bmRlZmluZWQnLiIpOwog CiAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmxvZygiU2V0dGluZyBib290c3RyYXAgc2NyaXB0 Li4uIik7Ci0gICAgICAgICAgICBhd2FpdCBXSS5uZXR3b3JrTWFuYWdlci5jcmVhdGVCb290c3Ry YXBTY3JpcHQoKTsKKyAgICAgICAgICAgIGF3YWl0IFdJLm5ldHdvcmtNYW5hZ2VyLmNyZWF0ZUJv b3RzdHJhcFNjcmlwdChgd2luZG93LnZhbHVlRnJvbUJvb3RzdHJhcFNjcmlwdCA9IDQyO2ApOwog ICAgICAgICAgICAgV0kubmV0d29ya01hbmFnZXIuYm9vdHN0cmFwU2NyaXB0RW5hYmxlZCA9IHRy dWU7Ci0gICAgICAgICAgICBXSS5uZXR3b3JrTWFuYWdlci5ib290c3RyYXBTY3JpcHQuY3VycmVu dFJldmlzaW9uLnVwZGF0ZVJldmlzaW9uQ29udGVudChgd2luZG93LnZhbHVlRnJvbUJvb3RzdHJh cFNjcmlwdCA9IDQyO2ApOwogCiAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmxvZygiUmVsb2Fk aW5nIHBhZ2UuLi4iKTsKLSAgICAgICAgICAgIGF3YWl0IEluc3BlY3RvclRlc3QucmVsb2FkUGFn ZSgpOwotCi0gICAgICAgICAgICBhd2FpdCBQcm9taXNlLmRlbGF5KDEwKTsKKyAgICAgICAgICAg IGF3YWl0IFByb21pc2UuYWxsKFsKKyAgICAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmF3YWl0 RXZlbnQoRnJvbnRlbmRUZXN0SGFybmVzcy5FdmVudC5UZXN0UGFnZURpZExvYWQpLAorICAgICAg ICAgICAgICAgIEluc3BlY3RvclRlc3QucmVsb2FkUGFnZSgpLAorICAgICAgICAgICAgXSk7CiAK ICAgICAgICAgICAgIGxldCB2YWx1ZUFmdGVyQm9vdHN0cmFwU2NyaXB0ID0gYXdhaXQgSW5zcGVj dG9yVGVzdC5ldmFsdWF0ZUluUGFnZShgd2luZG93LnZhbHVlRnJvbUJvb3RzdHJhcFNjcmlwdGAp OwogICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5leHBlY3RFcXVhbCh2YWx1ZUFmdGVyQm9vdHN0 cmFwU2NyaXB0LCA0MiwgIid2YWx1ZUZyb21Cb290c3RyYXBTY3JpcHQnIHNob3VsZCBiZSAnNDIn LiIpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlv bnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA1OTE3 YzBiY2UxNDk4Y2U0OTNhYjc0Mzg5M2M3YjhhZTMxMDg2MTA0Li5lMjc3MmYxYjljZGE4ZWIzNWQ2 N2NiNGU3YTlkNGUxY2NkYmQzYjE2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9t YWMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4 cGVjdGF0aW9ucwpAQCAtMTk2Myw4ICsxOTYzLDYgQEAgd2Via2l0Lm9yZy9iLzIwMjA2NCB3ZWJh dWRpby9zaWxlbnQtYXVkaW8taW50ZXJydXB0ZWQtaW4tYmFja2dyb3VuZC5odG1sIFsgUGFzcwog d2Via2l0Lm9yZy9iLzIwNTc1NyB3ZWJnbC8xLjAuMy9jb25mb3JtYW5jZS90ZXh0dXJlcy90ZXh0 dXJlLXVwbG9hZC1zaXplLmh0bWwgWyBQYXNzIFRpbWVvdXQgXQogd2Via2l0Lm9yZy9iLzIwNTc1 NiB3ZWJnbC8yLjAuMC9jb25mb3JtYW5jZTIvZ2xzbDMvbm8tYXR0cmlidXRlLXZlcnRleC1zaGFk ZXIuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiAKLXdlYmtpdC5vcmcvYi8yMDU4MDcgWyBEZWJ1ZyBd IGluc3BlY3Rvci9wYWdlL3NldEJvb3RzdHJhcFNjcmlwdC1tYWluLWZyYW1lLmh0bWwgWyBQYXNz IEZhaWx1cmUgXQotCiB3ZWJraXQub3JnL2IvMjA1ODYyIFsgTW9qYXZlKyBdIHdlYmdwdS93aGxz bC93aGlsZS1sb29wLWJyZWFrLmh0bWwgWyBQYXNzIEltYWdlT25seUZhaWx1cmUgXQogd2Via2l0 Lm9yZy9iLzIwNTg2NSBbIE1vamF2ZSsgXSB3ZWJncHUvd2hsc2wvZW5zdXJlLXByb3Blci12YXJp YWJsZS1saWZldGltZS0yLmh0bWwgWyBQYXNzIEltYWdlT25seUZhaWx1cmUgXQogd2Via2l0Lm9y Zy9iLzIwNTg2NyBbIE1vamF2ZSsgXSB3ZWJncHUvZHJhdy1pbmRleGVkLXRyaWFuZ2xlcy5odG1s IFsgUGFzcyBJbWFnZU9ubHlGYWlsdXJlIF0KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCg==