205785 2020-01-05 21:52:51 -0800 String.prototype.replace() incorrectly handles named references on RegExp w/o named groups 2020-06-12 02:10:54 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=176814 https://bugs.webkit.org/show_bug.cgi?id=176434 https://bugs.webkit.org/show_bug.cgi?id=205783 InRadar P2 Minor --- 1 ashvayka ashvayka commit-queue ews-watchlist keith_miller mark.lam msaboff nisl_grammarly1 ross.kirsling saam tzagallo webkit-bug-importer oldest_to_newest 1602943 0 ashvayka 2020-01-05 21:52:51 -0800 Test case: "ab".replace(/a/, "$<c>$<d>") Expected: "$<c>$<d>b" Actual: "$<$<d>b" ECMA262: https://tc39.es/ecma262/#sec-getsubstitution (step 11) Test262: https://test262.report/browse/built-ins/RegExp/named-groups/string-replace-nocaptures.js 1602945 1 386812 ashvayka 2020-01-05 22:16:03 -0800 Created attachment 386812 Patch 1603157 2 386812 ross.kirsling 2020-01-06 11:20:02 -0800 Comment on attachment 386812 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386812&action=review Wow, what an interesting bug. r=me, but a couple of questions. > Source/JavaScriptCore/runtime/StringPrototype.cpp:-226 > - result.append(replacement.substring(i, 2)); > - offset = i + 2; > - advance = 1; So was this the correct behavior prior to named capture groups? Or is this too associated with https://github.com/tc39/proposal-regexp-named-groups/issues/29? > Source/JavaScriptCore/runtime/StringPrototype.cpp:-232 > - // FIXME: https://bugs.webkit.org/show_bug.cgi?id=176434 We should also close the referenced bug, right? 1603185 3 ashvayka 2020-01-06 11:45:21 -0800 (In reply to Ross Kirsling from comment #2) > So was this the correct behavior prior to named capture groups? Or is this > too associated with > https://github.com/tc39/proposal-regexp-named-groups/issues/29? No, I believe it wasn't. For backwards compatibility, named capture groups leave "$<..>" as-is for a RegExp w/o named groups. This patch isn't associated with https://github.com/tc39/proposal-regexp-named-groups/issues/29: I've only removed FIXMEs to avoid submitting another patch. > We should also close the referenced bug, right? I've just closed https://bugs.webkit.org/show_bug.cgi?id=176434, thank you. 1603288 4 commit-queue 2020-01-06 14:46:49 -0800 The commit-queue encountered the following flaky tests while processing attachment 386812: transitions/default-timing-function.html bug 138901 (authors: dino@apple.com and graouts@apple.com) The commit-queue is continuing to process your patch. 1603289 5 386812 commit-queue 2020-01-06 14:47:42 -0800 Comment on attachment 386812 Patch Clearing flags on attachment: 386812 Committed r254088: <https://trac.webkit.org/changeset/254088> 1603290 6 commit-queue 2020-01-06 14:47:44 -0800 All reviewed patches have been landed. Closing bug. 1603291 7 webkit-bug-importer 2020-01-06 14:48:20 -0800 <rdar://problem/58355159> 1661887 8 ashvayka 2020-06-12 02:10:54 -0700 *** Bug 213023 has been marked as a duplicate of this bug. *** 386812 2020-01-05 22:16:03 -0800 2020-01-06 14:47:42 -0800 Patch bug-205785-20200106081601.patch text/plain 4751 ashvayka SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTQwNDgpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEyIEBACisyMDIwLTAxLTA1ICBBbGV4ZXkgU2h2YXlrYSAgPHNodmFpa2FsZXNo QGdtYWlsLmNvbT4KKworICAgICAgICBTdHJpbmcucHJvdG90eXBlLnJlcGxhY2UoKSBpbmNvcnJl Y3RseSBoYW5kbGVzIG5hbWVkIHJlZmVyZW5jZXMgb24gUmVnRXhwIHcvbyBuYW1lZCBncm91cHMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTc4NQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogdGVzdDI2 Mi9leHBlY3RhdGlvbnMueWFtbDogTWFyayAyIHRlc3QgY2FzZXMgYXMgcGFzc2luZy4KKwogMjAy MC0wMS0wNCAgQWxleGV5IFNodmF5a2EgIDxzaHZhaWthbGVzaEBnbWFpbC5jb20+CiAKICAgICAg ICAgSlNPTi5wYXJzZSBzaG91bGQgaW5pdGlhbGl6ZSB3cmFwcGVyIG9iamVjdCB3aXRoIFtbRGVm aW5lT3duUHJvcGVydHldXQpJbmRleDogSlNUZXN0cy90ZXN0MjYyL2V4cGVjdGF0aW9ucy55YW1s Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIEpTVGVzdHMvdGVzdDI2Mi9leHBlY3RhdGlvbnMueWFtbAkocmV2aXNp b24gMjU0MDMyKQorKysgSlNUZXN0cy90ZXN0MjYyL2V4cGVjdGF0aW9ucy55YW1sCSh3b3JraW5n IGNvcHkpCkBAIC0xMjg1LDkgKzEyODUsNiBAQCB0ZXN0L2J1aWx0LWlucy9SZWdFeHAvbmFtZWQt Z3JvdXBzL2dyb3VwCiB0ZXN0L2J1aWx0LWlucy9SZWdFeHAvbmFtZWQtZ3JvdXBzL2dyb3Vwcy1v YmplY3Qtc3ViY2xhc3MuanM6CiAgIGRlZmF1bHQ6ICdUZXN0MjYyRXJyb3I6IEV4cGVjdGVkIFNh bWVWYWx1ZSjCq2LCuywgwqskPGE+wrspIHRvIGJlIHRydWUnCiAgIHN0cmljdCBtb2RlOiAnVGVz dDI2MkVycm9yOiBFeHBlY3RlZCBTYW1lVmFsdWUowqtiwrssIMKrJDxhPsK7KSB0byBiZSB0cnVl JwotdGVzdC9idWlsdC1pbnMvUmVnRXhwL25hbWVkLWdyb3Vwcy9zdHJpbmctcmVwbGFjZS1ub2Nh cHR1cmVzLmpzOgotICBkZWZhdWx0OiAnVGVzdDI2MkVycm9yOiBFeHBlY3RlZCBTYW1lVmFsdWUo wqskPHNuZD4kPGZzdD5jZMK7LCDCqyQ8JDxmc3Q+Y2TCuykgdG8gYmUgdHJ1ZScKLSAgc3RyaWN0 IG1vZGU6ICdUZXN0MjYyRXJyb3I6IEV4cGVjdGVkIFNhbWVWYWx1ZSjCqyQ8c25kPiQ8ZnN0PmNk wrssIMKrJDwkPGZzdD5jZMK7KSB0byBiZSB0cnVlJwogdGVzdC9idWlsdC1pbnMvUmVnRXhwL25h bWVkLWdyb3Vwcy91bmljb2RlLXByb3BlcnR5LW5hbWVzLmpzOgogICBkZWZhdWx0OiAnU3ludGF4 RXJyb3I6IEludmFsaWQgcmVndWxhciBleHByZXNzaW9uOiBpbnZhbGlkIGdyb3VwIHNwZWNpZmll ciBuYW1lJwogICBzdHJpY3QgbW9kZTogJ1N5bnRheEVycm9yOiBJbnZhbGlkIHJlZ3VsYXIgZXhw cmVzc2lvbjogaW52YWxpZCBncm91cCBzcGVjaWZpZXIgbmFtZScKSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L0NoYW5nZUxvZwkocmV2aXNpb24gMjU0MDMyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDIwLTAxLTA1ICBBbGV4 ZXkgU2h2YXlrYSAgPHNodmFpa2FsZXNoQGdtYWlsLmNvbT4KKworICAgICAgICBTdHJpbmcucHJv dG90eXBlLnJlcGxhY2UoKSBpbmNvcnJlY3RseSBoYW5kbGVzIG5hbWVkIHJlZmVyZW5jZXMgb24g UmVnRXhwIHcvbyBuYW1lZCBncm91cHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIwNTc4NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggZml4ZXMgc3Vic3RpdHV0aW9uIG9mIG5hbWVkIHJl ZmVyZW5jZXMgYnkgaWdub3JpbmcgIiQ8IiBzZXF1ZW5jZXMKKyAgICAgICAgZm9yIGEgUmVnRXhw IHdpdGhvdXQgbmFtZWQgY2FwdHVyZSBncm91cHMsIHJlbW92aW5nIHNvbWUgaW5kZXggdHdlYWtp bmcuCisgICAgICAgIChzdGVwIDExIG9mIGh0dHBzOi8vdGMzOS5lcy9lY21hMjYyLyNzZWMtZ2V0 c3Vic3RpdHV0aW9uKQorCisgICAgICAgIEFsc28gdGhpcyBjaGFuZ2UgcmVtb3ZlcyAyIG9ic29s ZXRlIEZJWE1FcyByZWdhcmRpbmcgcG9zc2libGUgc3BlYyBjaGFuZ2VzLgorCisgICAgICAgICog cnVudGltZS9TdHJpbmdQcm90b3R5cGUuY3BwOgorICAgICAgICAoSlNDOjpzdWJzdGl0dXRlQmFj a3JlZmVyZW5jZXNTbG93KToKKwogMjAyMC0wMS0wMiAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lA YXBwbGUuY29tPgogCiAgICAgICAgIFtKU0NdIE1hcmtlZEJsb2NrOjpIYW5kbGUgYW5kIEJsb2Nr RGlyZWN0b3J5IHNob3VsZCBiZSBzaHJ1bmsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNwcAkocmV2aXNpb24gMjU0MDMyKQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMjIwLDMxICsyMjAsMTcgQEAgc3RhdGljIE5FVkVSX0lOTElORSB2b2lkIHN1 YnN0aXR1dGVCYWNrcgogICAgICAgICAgICAgYmFja3JlZkxlbmd0aCA9IHNvdXJjZS5sZW5ndGgo KSAtIGJhY2tyZWZTdGFydDsKICAgICAgICAgfSBlbHNlIGlmIChyZWcgJiYgcmVmID09ICc8Jykg ewogICAgICAgICAgICAgLy8gTmFtZWQgYmFjayByZWZlcmVuY2UKLSAgICAgICAgICAgIGlmICgh aGFzTmFtZWRDYXB0dXJlcykgewotICAgICAgICAgICAgICAgIHJlc3VsdC5hcHBlbmQocmVwbGFj ZW1lbnQuc3Vic3RyaW5nKGksIDIpKTsKLSAgICAgICAgICAgICAgICBvZmZzZXQgPSBpICsgMjsK LSAgICAgICAgICAgICAgICBhZHZhbmNlID0gMTsKKyAgICAgICAgICAgIGlmICghaGFzTmFtZWRD YXB0dXJlcykKICAgICAgICAgICAgICAgICBjb250aW51ZTsKLSAgICAgICAgICAgIH0KIAogICAg ICAgICAgICAgc2l6ZV90IGNsb3NpbmdCcmFja2V0ID0gcmVwbGFjZW1lbnQuZmluZCgnPicsIGkg KyAyKTsKLSAgICAgICAgICAgIGlmIChjbG9zaW5nQnJhY2tldCA9PSBXVEY6Om5vdEZvdW5kKSB7 Ci0gICAgICAgICAgICAgICAgLy8gRklYTUU6IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNzY0MzQKLSAgICAgICAgICAgICAgICAvLyBDdXJyZW50IHByb3Bvc2VkIHNw ZWMgY2hhbmdlIHRocm93cyBhIHN5bnRheCBlcnJvciBpbiB0aGlzIGNhc2UuCi0gICAgICAgICAg ICAgICAgLy8gV2UgaGF2ZSBtYWRlIHRoZSBjYXNlIHRoYXQgaXQgbWFrZXMgbW9yZSBzZW5zZSB0 byB0cmVhdCB0aGlzIGEgbGl0ZXJhbAotICAgICAgICAgICAgICAgIC8vIElmIHRocm93U3ludGF4 RXJyb3IoZ2xvYmFsT2JqZWN0LCBzY29wZSwgIk1pc3NpbmcgY2xvc2luZyAnPicgaW4gcmVwbGFj ZW1lbnQgdGV4dCIpOworICAgICAgICAgICAgaWYgKGNsb3NpbmdCcmFja2V0ID09IFdURjo6bm90 Rm91bmQpCiAgICAgICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgICAgICB9CiAKICAgICAg ICAgICAgIHVuc2lnbmVkIG5hbWVMZW5ndGggPSBjbG9zaW5nQnJhY2tldCAtIGkgLSAyOwogICAg ICAgICAgICAgdW5zaWduZWQgYmFja3JlZkluZGV4ID0gcmVnLT5zdWJwYXR0ZXJuRm9yTmFtZShy ZXBsYWNlbWVudC5zdWJzdHJpbmcoaSArIDIsIG5hbWVMZW5ndGgpLnRvU3RyaW5nKCkpOwogCiAg ICAgICAgICAgICBpZiAoIWJhY2tyZWZJbmRleCB8fCBiYWNrcmVmSW5kZXggPiByZWctPm51bVN1 YnBhdHRlcm5zKCkpIHsKLSAgICAgICAgICAgICAgICAvLyBGSVhNRTogaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NjQzNAotICAgICAgICAgICAgICAgIC8vIFByb3Bv c2VkIHNwZWMgY2hhbmdlIHRocm93cyBhIHRocm93IHN5bnRheCBlcnJvciBpbiB0aGlzIGNhc2Uu Ci0gICAgICAgICAgICAgICAgLy8gV2UgaGF2ZSBtYWRlIHRoZSBjYXNlIHRoYXQgYSBub24tZXhp c3RlbnQgYmFjayByZWZlcmVuY2Ugc2hvdWxkIGJlIHJlcGxhY2VkIHdpdGgKLSAgICAgICAgICAg ICAgICAvLyBhbmQgZW1wdHkgc3RyaW5nLgotICAgICAgICAgICAgICAgIC8vIHRocm93U3ludGF4 RXJyb3IoZ2xvYmFsT2JqZWN0LCBzY29wZSwgbWFrZVN0cmluZygiUmVwbGFjZW1lbnQgdGV4dCBy ZWZlcmVuY2VzIG5vbi1leGlzdGVudCBiYWNrcmVmZXJlbmNlIFwiIiArIHJlcGxhY2VtZW50LnN1 YnN0cmluZyhpICsgMiwgbmFtZUxlbmd0aCkudG9TdHJpbmcoKSkpOwogICAgICAgICAgICAgICAg IGJhY2tyZWZTdGFydCA9IDA7CiAgICAgICAgICAgICAgICAgYmFja3JlZkxlbmd0aCA9IDA7CiAg ICAgICAgICAgICB9IGVsc2Ugewo=