205750 2020-01-03 14:05:17 -0800 IconLoadingClient::getLoadDecisionForIcon() leaks an Objective-C block 2020-01-03 18:44:16 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 garrett_davidson webkit-unassigned beidson commit-queue simon.fraser thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1602577 0 garrett_davidson 2020-01-03 14:05:17 -0800 <rdar://problem/57981723> 1602579 1 386715 garrett_davidson 2020-01-03 14:11:05 -0800 Created attachment 386715 Patch 1602661 2 commit-queue 2020-01-03 17:00:57 -0800 The commit-queue encountered the following flaky tests while processing attachment 386715: imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/error-type-1.html bug 205242 (author: cdumez@apple.com) The commit-queue is continuing to process your patch. 1602662 3 commit-queue 2020-01-03 17:00:58 -0800 The commit-queue encountered the following flaky tests while processing attachment 386715: The commit-queue is continuing to process your patch. 1602692 4 386715 commit-queue 2020-01-03 18:44:15 -0800 Comment on attachment 386715 Patch Clearing flags on attachment: 386715 Committed r254027: <https://trac.webkit.org/changeset/254027> 1602693 5 commit-queue 2020-01-03 18:44:16 -0800 All reviewed patches have been landed. Closing bug. 386715 2020-01-03 14:11:05 -0800 2020-01-03 18:44:15 -0800 Patch bug-205750-20200103141104.patch text/plain 2114 garrett_davidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzOTc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJlOGJhZDYyYTYzOWU4YTg1 ZGQ5OTA0ZjE5NTMwNzBlZmE3NTcyODQuLmE1N2I2MWRkOGEwZTE1MzM5YTQ5NDcyM2MzMmU0OGE3 Yzg2NjMzY2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDEtMDMgIEdhcnJldHQg RGF2aWRzb24gIDxnYXJyZXR0X2Rhdmlkc29uQGFwcGxlLmNvbT4KKworICAgICAgICBJY29uTG9h ZGluZ0NsaWVudDo6Z2V0TG9hZERlY2lzaW9uRm9ySWNvbigpIGxlYWtzIGFuIE9iamVjdGl2ZS1D IGJsb2NrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MDU3NTAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU3OTgxNzIzPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlcGxhY2UgYSBCbG9ja19jb3B5IHdp dGggbWFrZUJsb2NrUHRyIHRvIHByZXZlbnQgbGVha2luZyB0aGUgT2JqQyBibG9jay4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9Db2NvYS9JY29uTG9hZGluZ0RlbGVnYXRlLm1tOgorICAgICAgICAo V2ViS2l0OjpJY29uTG9hZGluZ0RlbGVnYXRlOjpJY29uTG9hZGluZ0NsaWVudDo6Z2V0TG9hZERl Y2lzaW9uRm9ySWNvbik6CisKIDIwMjAtMDEtMDIgIFNhbSBXZWluaWcgIDx3ZWluaWdAYXBwbGUu Y29tPgogCiAgICAgICAgIFNpbXBsaWZ5IFN0cmluZ0J1aWxkZXIgQVBJL2FsaWduIHdpdGggbWFr ZVN0cmluZyBieSByZW1vdmluZyBhcHBlbmRGaXhlZCogZnVuY3Rpb25zIGFuZCB1c2luZyBGb3Jt YXROdW1iZXIgc3RydWN0IGluc3RlYWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0NvY29hL0ljb25Mb2FkaW5nRGVsZWdhdGUubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9Db2NvYS9JY29uTG9hZGluZ0RlbGVnYXRlLm1tCmluZGV4IDE2M2ZiOTUyZWUwZWE5YjcxYTNk NDlkM2RkOTdjZTAwNDNjYzY4ZjcuLjlkODBlZmVhMjkzNjYzMGQ2YjMwNDJkNjk2NGQzZmJiMjM4 NWU5Y2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL0ljb25Mb2Fk aW5nRGVsZWdhdGUubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvSWNvbkxv YWRpbmdEZWxlZ2F0ZS5tbQpAQCAtODgsNyArODgsNyBAQCB2b2lkIEljb25Mb2FkaW5nRGVsZWdh dGU6Okljb25Mb2FkaW5nQ2xpZW50OjpnZXRMb2FkRGVjaXNpb25Gb3JJY29uKGNvbnN0IFdlYkNv cgogICAgIFtkZWxlZ2F0ZSB3ZWJWaWV3Om1faWNvbkxvYWRpbmdEZWxlZ2F0ZS5tX3dlYlZpZXcg c2hvdWxkTG9hZEljb25XaXRoUGFyYW1ldGVyczpwYXJhbWV0ZXJzLmdldCgpIGNvbXBsZXRpb25I YW5kbGVyOm1ha2VCbG9ja1B0cihbY29tcGxldGlvbkhhbmRsZXIgPSBXVEZNb3ZlKGNvbXBsZXRp b25IYW5kbGVyKV0gKEljb25Mb2FkQ29tcGxldGlvbkhhbmRsZXIgbG9hZENvbXBsZXRpb25IYW5k bGVyKSBtdXRhYmxlIHsKICAgICAgICAgQVNTRVJUKFJ1bkxvb3A6OmlzTWFpbigpKTsKICAgICAg ICAgaWYgKGxvYWRDb21wbGV0aW9uSGFuZGxlcikgewotICAgICAgICAgICAgY29tcGxldGlvbkhh bmRsZXIoW2xvYWRDb21wbGV0aW9uSGFuZGxlciA9IEJsb2NrX2NvcHkobG9hZENvbXBsZXRpb25I YW5kbGVyKV0oQVBJOjpEYXRhKiBkYXRhLCBXZWJLaXQ6OkNhbGxiYWNrQmFzZTo6RXJyb3IgZXJy b3IpIHsKKyAgICAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKFtsb2FkQ29tcGxldGlvbkhhbmRs ZXIgPSBtYWtlQmxvY2tQdHIobG9hZENvbXBsZXRpb25IYW5kbGVyKV0oQVBJOjpEYXRhKiBkYXRh LCBXZWJLaXQ6OkNhbGxiYWNrQmFzZTo6RXJyb3IgZXJyb3IpIHsKICAgICAgICAgICAgICAgICBp ZiAoZXJyb3IgIT0gQ2FsbGJhY2tCYXNlOjpFcnJvcjo6Tm9uZSB8fCAhZGF0YSkKICAgICAgICAg ICAgICAgICAgICAgbG9hZENvbXBsZXRpb25IYW5kbGVyKG5pbCk7CiAgICAgICAgICAgICAgICAg ZWxzZQo=