205705 2020-01-02 18:12:22 -0800 Reformat WebPage logging 2020-01-04 10:23:16 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=205679 InRadar P2 Normal --- 1 krollin krollin achristensen cdumez commit-queue webkit-bug-importer oldest_to_newest 1602303 0 krollin 2020-01-02 18:12:22 -0800 Update the format used by WebPage in its RELEASE_LOG logging. Use the format used by WebPageProxy and NetworkResourceLoader, which is generally of the form: <object-address> - [<values that help thread together operations>] <class>::<method>: <message and other useful values> So, for example: 0x7f83ba009208 - WebPage (webPageID=15) - Adding a reason 1 to freeze layer tree (now 1); old reasons were 0 becomes: 0x7f83ba009208 - [webPageID=15] WebPage::freezeLayerTree: Adding a reason to freeze layer tree (reason=1, new=1, old=0) 1602304 1 webkit-bug-importer 2020-01-02 18:12:32 -0800 <rdar://problem/58288704> 1602305 2 386652 krollin 2020-01-02 18:15:42 -0800 Created attachment 386652 Patch 1602770 3 386652 commit-queue 2020-01-04 10:23:15 -0800 Comment on attachment 386652 Patch Clearing flags on attachment: 386652 Committed r254033: <https://trac.webkit.org/changeset/254033> 1602771 4 commit-queue 2020-01-04 10:23:16 -0800 All reviewed patches have been landed. Closing bug. 386652 2020-01-02 18:15:42 -0800 2020-01-04 10:23:15 -0800 Patch bug-205705-20200102181541.patch text/plain 6890 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzOTg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDBkYTY3ZjgyY2JkM2U1YjUy M2FiNmJlZTVjNTFhNzIzNDk3OTI0NmMuLjhmZThkZGExOWQ3MGY4MjVjNGZjYTE5NmEwZGYwNmE3 NGI1OGI0YjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzYgQEAKKzIwMjAtMDEtMDIgIEtlaXRoIFJv bGxpbiAgPGtyb2xsaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJlZm9ybWF0IFdlYlBhZ2UgbG9n Z2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA1 NzA1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81ODI4ODcwND4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgdGhlIGZvcm1hdCB1c2VkIGJ5 IFdlYlBhZ2UgaW4gaXRzIFJFTEVBU0VfTE9HIGxvZ2dpbmcuIFVzZSB0aGUKKyAgICAgICAgZm9y bWF0IHVzZWQgYnkgV2ViUGFnZVByb3h5IGFuZCBOZXR3b3JrUmVzb3VyY2VMb2FkZXIsIHdoaWNo IGlzCisgICAgICAgIGdlbmVyYWxseSBvZiB0aGUgZm9ybToKKworICAgICAgICAgICAgPG9iamVj dC1hZGRyZXNzPiAtIFs8dmFsdWVzIHRoYXQgaGVscCB0aHJlYWQgdG9nZXRoZXIgb3BlcmF0aW9u cz5dIDxjbGFzcz46OjxtZXRob2Q+OiA8bWVzc2FnZSBhbmQgb3RoZXIgdXNlZnVsIHZhbHVlcz4K KworICAgICAgICBTbywgZm9yIGV4YW1wbGU6CisKKyAgICAgICAgICAgIDB4N2Y4M2JhMDA5MjA4 IC0gV2ViUGFnZSAod2ViUGFnZUlEPTE1KSAtIEFkZGluZyBhIHJlYXNvbiAxIHRvIGZyZWV6ZSBs YXllciB0cmVlIChub3cgMSk7IG9sZCByZWFzb25zIHdlcmUgMAorCisgICAgICAgIGJlY29tZXM6 CisKKyAgICAgICAgICAgIDB4N2Y4M2JhMDA5MjA4IC0gW3dlYlBhZ2VJRD0xNV0gV2ViUGFnZTo6 ZnJlZXplTGF5ZXJUcmVlOiBBZGRpbmcgYSByZWFzb24gdG8gZnJlZXplIGxheWVyIHRyZWUgKHJl YXNvbj0xLCBuZXc9MSwgb2xkPTApCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIC0gbm8gYWRkZWQg b3IgY2hhbmdlZCBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdl L1dlYlBhZ2UuY3BwOgorICAgICAgICAoV2ViS2l0OjptX292ZXJyaWRkZW5NZWRpYVR5cGUpOgor ICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpjcmVhdGVQbHVnaW4pOgorICAgICAgICAoV2ViS2l0 OjpXZWJQYWdlOjpmcmVlemVMYXllclRyZWUpOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjp1 bmZyZWV6ZUxheWVyVHJlZSk6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6Om1hcmtMYXllcnNW b2xhdGlsZSk6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OmNhbmNlbE1hcmtMYXllcnNWb2xh dGlsZSk6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OnRvdWNoRXZlbnRTeW5jKToKKwogMjAy MC0wMS0wMiAgS2VpdGggUm9sbGluICA8a3JvbGxpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVm b3JtYXQgV2ViUHJvY2VzcyBsb2dnaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQ YWdlL1dlYlBhZ2UuY3BwCmluZGV4IGQwNWEyYWFjNDRiZWI1MTJkNWRjYjZmYTBiMjNkZmMzOWZh MjNiNTguLmZhMzUwNjY3ODkwODJiYjRmNTRjZThhZDMyOGJlYTlmOTYzMTIzMDcgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCkBAIC0zMjUsOCArMzI1 LDggQEAgc3RhdGljIGNvbnN0IFNlY29uZHMgcGFnZVNjcm9sbEh5c3RlcmVzaXNEdXJhdGlvbiB7 IDMwMF9tcyB9Owogc3RhdGljIGNvbnN0IFNlY29uZHMgaW5pdGlhbExheWVyVm9sYXRpbGl0eVRp bWVySW50ZXJ2YWwgeyAyMF9tcyB9Owogc3RhdGljIGNvbnN0IFNlY29uZHMgbWF4aW11bUxheWVy Vm9sYXRpbGl0eVRpbWVySW50ZXJ2YWwgeyAyX3MgfTsKIAotI2RlZmluZSBSRUxFQVNFX0xPR19J Rl9BTExPV0VEKGNoYW5uZWwsIGZtdCwgLi4uKSBSRUxFQVNFX0xPR19JRihpc0Fsd2F5c09uTG9n Z2luZ0FsbG93ZWQoKSwgY2hhbm5lbCwgIiVwIC0gV2ViUGFnZTo6IiBmbXQsIHRoaXMsICMjX19W QV9BUkdTX18pCi0jZGVmaW5lIFJFTEVBU0VfTE9HX0VSUk9SX0lGX0FMTE9XRUQoY2hhbm5lbCwg Zm10LCAuLi4pIFJFTEVBU0VfTE9HX0VSUk9SX0lGKGlzQWx3YXlzT25Mb2dnaW5nQWxsb3dlZCgp LCBjaGFubmVsLCAiJXAgLSBXZWJQYWdlOjoiIGZtdCwgdGhpcywgIyNfX1ZBX0FSR1NfXykKKyNk ZWZpbmUgUkVMRUFTRV9MT0dfSUZfQUxMT1dFRChjaGFubmVsLCBmbXQsIC4uLikgUkVMRUFTRV9M T0dfSUYoaXNBbHdheXNPbkxvZ2dpbmdBbGxvd2VkKCksIGNoYW5uZWwsICIlcCAtIFt3ZWJQYWdl SUQ9JSIgUFJJdTY0ICJdIFdlYlBhZ2U6OiIgZm10LCB0aGlzLCBtX2lkZW50aWZpZXIudG9VSW50 NjQoKSwgIyNfX1ZBX0FSR1NfXykKKyNkZWZpbmUgUkVMRUFTRV9MT0dfRVJST1JfSUZfQUxMT1dF RChjaGFubmVsLCBmbXQsIC4uLikgUkVMRUFTRV9MT0dfRVJST1JfSUYoaXNBbHdheXNPbkxvZ2dp bmdBbGxvd2VkKCksIGNoYW5uZWwsICIlcCAtIFt3ZWJQYWdlSUQ9JSIgUFJJdTY0ICJdIFdlYlBh Z2U6OiIgZm10LCB0aGlzLCBtX2lkZW50aWZpZXIudG9VSW50NjQoKSwgIyNfX1ZBX0FSR1NfXykK IAogY2xhc3MgU2VuZFN0b3BSZXNwb25zaXZlbmVzc1RpbWVyIHsKIHB1YmxpYzoKQEAgLTcwMiw3 ICs3MDIsNyBAQCBXZWJQYWdlOjpXZWJQYWdlKFBhZ2VJZGVudGlmaWVyIHBhZ2VJRCwgV2ViUGFn ZUNyZWF0aW9uUGFyYW1ldGVycyYmIHBhcmFtZXRlcnMpCiAgICAgbV9jb250ZXh0Rm9yVmlzaWJp bGl0eVByb3BhZ2F0aW9uID0gTGF5ZXJIb3N0aW5nQ29udGV4dDo6Y3JlYXRlRm9yRXh0ZXJuYWxI b3N0aW5nUHJvY2Vzcyh7CiAgICAgICAgIG1fY2FuU2hvd1doaWxlTG9ja2VkCiAgICAgfSk7Ci0g ICAgUkVMRUFTRV9MT0coUHJvY2VzcywgIkNyZWF0ZWQgY29udGV4dCB3aXRoIElEICVkIGZvciB2 aXNpYmlsaXR5IHByb3BhZ2F0aW9uIGZyb20gVUlQcm9jZXNzIiwgbV9jb250ZXh0Rm9yVmlzaWJp bGl0eVByb3BhZ2F0aW9uLT5jb250ZXh0SUQoKSk7CisgICAgUkVMRUFTRV9MT0dfSUZfQUxMT1dF RChQcm9jZXNzLCAiV2ViUGFnZTogQ3JlYXRlZCBjb250ZXh0IHdpdGggSUQgJWQgZm9yIHZpc2li aWxpdHkgcHJvcGFnYXRpb24gZnJvbSBVSVByb2Nlc3MiLCBtX2NvbnRleHRGb3JWaXNpYmlsaXR5 UHJvcGFnYXRpb24tPmNvbnRleHRJRCgpKTsKICAgICBzZW5kKE1lc3NhZ2VzOjpXZWJQYWdlUHJv eHk6OkRpZENyZWF0ZUNvbnRleHRGb3JWaXNpYmlsaXR5UHJvcGFnYXRpb24obV9jb250ZXh0Rm9y VmlzaWJpbGl0eVByb3BhZ2F0aW9uLT5jb250ZXh0SUQoKSkpOwogI2VuZGlmCiAKQEAgLTEwMDAs NyArMTAwMCw3IEBAIFJlZlB0cjxQbHVnaW4+IFdlYlBhZ2U6OmNyZWF0ZVBsdWdpbihXZWJGcmFt ZSogZnJhbWUsIEhUTUxQbHVnSW5FbGVtZW50KiBwbHVnaW5FCiAgICAgICAgIHJldHVybiBudWxs cHRyOwogCiAgICAgaWYgKG1fcGFnZS0+c2V0dGluZ3MoKS5ibG9ja2luZ09mU21hbGxQbHVnaW5z RW5hYmxlZCgpICYmIHBsdWdpbklzU21hbGwoKnBsdWdpbkVsZW1lbnQpKSB7Ci0gICAgICAgIFJF TEVBU0VfTE9HKFBsdWdpbnMsICJCbG9ja2luZyBhIHBsdWdpbiBiZWNhdXNlIGl0IGlzIHRvbyBz bWFsbCIpOworICAgICAgICBSRUxFQVNFX0xPR19JRl9BTExPV0VEKFBsdWdpbnMsICJjcmVhdGVQ bHVnaW46IEJsb2NraW5nIGEgcGx1Z2luIGJlY2F1c2UgaXQgaXMgdG9vIHNtYWxsIik7CiAgICAg ICAgIHBsdWdpbkVsZW1lbnQtPnNldFJlcGxhY2VtZW50KFJlbmRlckVtYmVkZGVkT2JqZWN0OjpQ bHVnaW5Ub29TbWFsbCwgcGx1Z2luVG9vU21hbGxUZXh0KCkpOwogICAgICAgICByZXR1cm4gbnVs bHB0cjsKICAgICB9CkBAIC0yNTI2LDcgKzI1MjYsNyBAQCB2b2lkIFdlYlBhZ2U6OmZyZWV6ZUxh eWVyVHJlZShMYXllclRyZWVGcmVlemVSZWFzb24gcmVhc29uKQogICAgIGF1dG8gb2xkUmVhc29u cyA9IG1fbGF5ZXJUcmVlRnJlZXplUmVhc29ucy50b1JhdygpOwogICAgIFVOVVNFRF9QQVJBTShv bGRSZWFzb25zKTsKICAgICBtX2xheWVyVHJlZUZyZWV6ZVJlYXNvbnMuYWRkKHJlYXNvbik7Ci0g ICAgUkVMRUFTRV9MT0coUHJvY2Vzc1N1c3BlbnNpb24sICIlcCAtIFdlYlBhZ2UgKHdlYlBhZ2VJ RD0lbGx1KSAtIEFkZGluZyBhIHJlYXNvbiAlZCB0byBmcmVlemUgbGF5ZXIgdHJlZSAobm93ICVk KTsgb2xkIHJlYXNvbnMgd2VyZSAlZCIsIHRoaXMsIG1faWRlbnRpZmllci50b1VJbnQ2NCgpLCBz dGF0aWNfY2FzdDx1bnNpZ25lZD4ocmVhc29uKSwgbV9sYXllclRyZWVGcmVlemVSZWFzb25zLnRv UmF3KCksIG9sZFJlYXNvbnMpOworICAgIFJFTEVBU0VfTE9HX0lGX0FMTE9XRUQoUHJvY2Vzc1N1 c3BlbnNpb24sICJmcmVlemVMYXllclRyZWU6IEFkZGluZyBhIHJlYXNvbiB0byBmcmVlemUgbGF5 ZXIgdHJlZSAocmVhc29uPSVkLCBuZXc9JWQsIG9sZD0lZCkiLCBzdGF0aWNfY2FzdDx1bnNpZ25l ZD4ocmVhc29uKSwgbV9sYXllclRyZWVGcmVlemVSZWFzb25zLnRvUmF3KCksIG9sZFJlYXNvbnMp OwogICAgIHVwZGF0ZURyYXdpbmdBcmVhTGF5ZXJUcmVlRnJlZXplU3RhdGUoKTsKIH0KIApAQCAt MjUzNSw3ICsyNTM1LDcgQEAgdm9pZCBXZWJQYWdlOjp1bmZyZWV6ZUxheWVyVHJlZShMYXllclRy ZWVGcmVlemVSZWFzb24gcmVhc29uKQogICAgIGF1dG8gb2xkUmVhc29ucyA9IG1fbGF5ZXJUcmVl RnJlZXplUmVhc29ucy50b1JhdygpOwogICAgIFVOVVNFRF9QQVJBTShvbGRSZWFzb25zKTsKICAg ICBtX2xheWVyVHJlZUZyZWV6ZVJlYXNvbnMucmVtb3ZlKHJlYXNvbik7Ci0gICAgUkVMRUFTRV9M T0coUHJvY2Vzc1N1c3BlbnNpb24sICIlcCAtIFdlYlBhZ2UgKHdlYlBhZ2VJRD0lbGx1KSAtIFJl bW92aW5nIGEgcmVhc29uICVkIHRvIGZyZWV6ZSBsYXllciB0cmVlIChub3cgJWQpOyBvbGQgcmVh c29ucyB3ZXJlICVkIiwgdGhpcywgbV9pZGVudGlmaWVyLnRvVUludDY0KCksIHN0YXRpY19jYXN0 PHVuc2lnbmVkPihyZWFzb24pLCBtX2xheWVyVHJlZUZyZWV6ZVJlYXNvbnMudG9SYXcoKSwgb2xk UmVhc29ucyk7CisgICAgUkVMRUFTRV9MT0dfSUZfQUxMT1dFRChQcm9jZXNzU3VzcGVuc2lvbiwg InVuZnJlZXplTGF5ZXJUcmVlOiBSZW1vdmluZyBhIHJlYXNvbiB0byBmcmVlemUgbGF5ZXIgdHJl ZSAocmVhc29uPSVkLCBuZXc9JWQsIG9sZD0lZCkiLCBzdGF0aWNfY2FzdDx1bnNpZ25lZD4ocmVh c29uKSwgbV9sYXllclRyZWVGcmVlemVSZWFzb25zLnRvUmF3KCksIG9sZFJlYXNvbnMpOwogICAg IHVwZGF0ZURyYXdpbmdBcmVhTGF5ZXJUcmVlRnJlZXplU3RhdGUoKTsKIH0KIApAQCAtMjU3OCw3 ICsyNTc4LDcgQEAgYm9vbCBXZWJQYWdlOjptYXJrTGF5ZXJzVm9sYXRpbGVJbW1lZGlhdGVseUlm UG9zc2libGUoKQogCiB2b2lkIFdlYlBhZ2U6Om1hcmtMYXllcnNWb2xhdGlsZShXVEY6OkZ1bmN0 aW9uPHZvaWQgKGJvb2wpPiYmIGNvbXBsZXRpb25IYW5kbGVyKQogewotICAgIFJFTEVBU0VfTE9H X0lGX0FMTE9XRUQoTGF5ZXJzLCAibWFya0xheWVyc1ZvbGF0aWxlIik7CisgICAgUkVMRUFTRV9M T0dfSUZfQUxMT1dFRChMYXllcnMsICJtYXJrTGF5ZXJzVm9sYXRpbGU6Iik7CiAKICAgICBpZiAo bV9sYXllclZvbGF0aWxpdHlUaW1lci5pc0FjdGl2ZSgpKQogICAgICAgICBtX2xheWVyVm9sYXRp bGl0eVRpbWVyLnN0b3AoKTsKQEAgLTI2MDQsNyArMjYwNCw3IEBAIHZvaWQgV2ViUGFnZTo6bWFy a0xheWVyc1ZvbGF0aWxlKFdURjo6RnVuY3Rpb248dm9pZCAoYm9vbCk+JiYgY29tcGxldGlvbkhh bmRsZXIpCiAKIHZvaWQgV2ViUGFnZTo6Y2FuY2VsTWFya0xheWVyc1ZvbGF0aWxlKCkKIHsKLSAg ICBSRUxFQVNFX0xPR19JRl9BTExPV0VEKExheWVycywgImNhbmNlbE1hcmtMYXllcnNWb2xhdGls ZSIpOworICAgIFJFTEVBU0VfTE9HX0lGX0FMTE9XRUQoTGF5ZXJzLCAiY2FuY2VsTWFya0xheWVy c1ZvbGF0aWxlOiIpOwogICAgIG1fbGF5ZXJWb2xhdGlsaXR5VGltZXIuc3RvcCgpOwogICAgIG1f bWFya0xheWVyc0FzVm9sYXRpbGVDb21wbGV0aW9uSGFuZGxlcnMuY2xlYXIoKTsKIH0KQEAgLTI5 MTIsNyArMjkxMiw3IEBAIHZvaWQgV2ViUGFnZTo6dG91Y2hFdmVudFN5bmMoY29uc3QgV2ViVG91 Y2hFdmVudCYgdG91Y2hFdmVudCwgQ29tcGxldGlvbkhhbmRsZXI8CiB7CiAgICAgLy8gQXZvaWQg VUlQcm9jZXNzIGhhbmdzIHdoZW4gdGhlIFdlYkNvbnRlbnQgcHJvY2VzcyBpcyBzdHVjayBvbiBh IHN5bmMgSVBDLgogICAgIGlmIChJUEM6OlVuYm91bmRlZFN5bmNocm9ub3VzSVBDU2NvcGU6Omhh c09uZ29pbmdVbmJvdW5kZWRTeW5jSVBDKCkpIHsKLSAgICAgICAgUkVMRUFTRV9MT0dfRVJST1Jf SUZfQUxMT1dFRChQcm9jZXNzLCAidG91Y2hFdmVudFN5bmMgLSBOb3QgcHJvY2Vzc2luZyBiZWNh dXNlIHRoZSBwcm9jZXNzIGlzIHN0dWNrIG9uIHVuYm91bmRlZCBzeW5jIElQQyIpOworICAgICAg ICBSRUxFQVNFX0xPR19FUlJPUl9JRl9BTExPV0VEKFByb2Nlc3MsICJ0b3VjaEV2ZW50U3luYzog Tm90IHByb2Nlc3NpbmcgYmVjYXVzZSB0aGUgcHJvY2VzcyBpcyBzdHVjayBvbiB1bmJvdW5kZWQg c3luYyBJUEMiKTsKICAgICAgICAgcmV0dXJuIHJlcGx5KHRydWUpOwogICAgIH0KIAo=