205627 2019-12-28 23:20:04 -0800 REGRESSION (r253926): fast/canvas/webgl/array-bounds-clamping.html fails 2020-02-12 11:42:43 -0800 1 1 1 Unclassified WebKit WebGL WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=205483 InRadar P2 Normal --- 1 ap jdarpinian dino jdarpinian kbr webkit-bug-importer oldest_to_newest 1601746 0 ap 2019-12-28 23:20:04 -0800 fast/canvas/webgl/array-bounds-clamping.html started to fail after switching to ANGLE in r253926 It got marked as expected failure in this revision for WebKit1, but not for WebKit2, so it now shows up as a failure on bots. https://results.webkit.org/?suite=layout-tests&test=fast%2Fcanvas%2Fwebgl%2Farray-bounds-clamping.html The failure is hardware specific - the test still passes on many Mac models. I didn't check very carefully, seems to be passing on AMD and failing on Intel or Nvidia. 1601747 1 webkit-bug-importer 2019-12-28 23:20:16 -0800 <rdar://problem/58229090> 1601931 2 kbr 2019-12-30 13:09:17 -0800 Possible to temporarily mark the expected failure so that r253926 isn't rolled back? Might be an option that needs to be passed to ANGLE's internal instance of its shader compiler. 1602383 3 dino 2020-01-03 02:27:45 -0800 This was a tricky test to get right - I think it might be incorrect. Our non-ANGLE code passed SH_CLAMP_INDIRECT_ARRAY_BOUNDS into the shader configuration (see Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE) I don't see a way to do this from the EGL API, but maybe it isn't necessary? Does Chrome use this option on Apple hardware? 1602533 4 kbr 2020-01-03 11:34:42 -0800 It seems likely that ANGLE's use of this workaround needs to be expanded. Currently it looks like it's only enabled on Android and AMD hardware. May need to be done always on Mac. https://source.chromium.org/chromium/chromium/src/+/master:third_party/angle/src/libANGLE/renderer/gl/renderergl_utils.cpp;l=1596;drc=34fdc18ec806aa05ed2029d723c31de0d141a742;bpv=1;bpt=1 1612261 5 jdarpinian 2020-01-28 16:52:11 -0800 The workaround was enabled upstream, so this will be fixed in the next ANGLE roll. 1618143 6 jdarpinian 2020-02-12 11:42:43 -0800 ANGLE was updated in r255782