205271 2019-12-16 07:32:38 -0800 lldbwebkittester: Conform with testing binary format 2019-12-16 16:59:36 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=187916 https://bugs.webkit.org/show_bug.cgi?id=205315 InRadar P2 Normal --- 1 jbedard jbedard ap commit-queue slewis webkit-bug-importer oldest_to_newest 1598875 0 jbedard 2019-12-16 07:32:38 -0800 lldbwebkittester should be built with all our other tooling. 1598879 1 385764 jbedard 2019-12-16 07:35:11 -0800 Created attachment 385764 Patch 1598913 2 385772 jbedard 2019-12-16 08:55:03 -0800 Created attachment 385772 Patch 1598978 3 385772 ap 2019-12-16 10:54:56 -0800 Comment on attachment 385772 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385772&action=review > Tools/ChangeLog:8 > + lldbwebkittester should be built the same way ImageDiff, TestWebKitAPI and WebKitTestRunner are. I think that it would be helpful to elaborate more. In addition to consistency, this paves the way to testing lldb scripts against WebCore and WebKit in the future, which would be a non-starter if build-lldbwebkittester was expected to rebuild everything. > Tools/ChangeLog:11 > + * Scripts/build-webkit: Does make build it already? build-webkit should be consistent with make too. 1598996 4 385772 jbedard 2019-12-16 11:23:02 -0800 Comment on attachment 385772 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385772&action=review >> Tools/ChangeLog:11 >> + * Scripts/build-webkit: > > Does make build it already? build-webkit should be consistent with make too. Make does already build it, at least in WebKit. Verifying that this is actually the case now. 1599070 5 385804 jbedard 2019-12-16 13:39:55 -0800 Created attachment 385804 Patch for landing 1599100 6 385804 commit-queue 2019-12-16 14:25:00 -0800 Comment on attachment 385804 Patch for landing Clearing flags on attachment: 385804 Committed r253577: <https://trac.webkit.org/changeset/253577> 1599101 7 commit-queue 2019-12-16 14:25:02 -0800 All reviewed patches have been landed. Closing bug. 1599104 8 webkit-bug-importer 2019-12-16 14:26:40 -0800 <rdar://problem/57985186> 385764 2019-12-16 07:35:11 -0800 2019-12-16 08:55:02 -0800 Patch bug-205271-20191216073510.patch text/plain 1937 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MzU1MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE5LTEyLTE2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBsbGRid2Via2l0dGVzdGVyOiBDb25mb3JtIHdpdGggdGVzdGluZyBiaW5h cnkgZm9ybWF0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMDUyNzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBsbGRid2Via2l0dGVzdGVyIHNob3VsZCBiZSBidWlsdCB0aGUgc2FtZSB3YXkgSW1hZ2VEaWZm LCBUZXN0V2ViS2l0QVBJIGFuZCBXZWJLaXRUZXN0UnVubmVyIGFyZS4KKworICAgICAgICAqIFNj cmlwdHMvYnVpbGQtbGxkYndlYmtpdHRlc3RlcjoKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdl YmtpdDoKKwogMjAxOS0xMi0xNiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxp YS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBHVEsgZ2FyZGVuaW5nLiBNYXJrIC93ZWJraXQv V2ViS2l0V2ViVmlldy9wb2ludGVyLWxvY2stcGVybWlzc2lvbi1yZXF1ZXN0IGFzIHRpbWVvdXQK SW5kZXg6IFRvb2xzL1NjcmlwdHMvYnVpbGQtbGxkYndlYmtpdHRlc3Rlcgo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9TY3JpcHRzL2J1aWxkLWxsZGJ3ZWJraXR0ZXN0ZXIJKHJldmlzaW9uIDI1MzU1MCkK KysrIFRvb2xzL1NjcmlwdHMvYnVpbGQtbGxkYndlYmtpdHRlc3Rlcgkod29ya2luZyBjb3B5KQpA QCAtNjcsOCArNjcsNiBAQCBjaGRpcldlYktpdCgpOwogCiBteSBAeGNvZGVPcHRpb25zID0gWGNv ZGVPcHRpb25zKCk7CiAKLWJ1aWxkUHJvamVjdE9yRGllKCJTb3VyY2UvYm1hbGxvYyIsICJibWFs bG9jIik7Ci1idWlsZFByb2plY3RPckRpZSgiU291cmNlL1dURiIsICJXVEYiKTsKIGJ1aWxkUHJv amVjdE9yRGllKCJUb29scy9sbGRiL2xsZGJXZWJLaXRUZXN0ZXIiLCAibGxkYldlYktpdFRlc3Rl ciIpOwogCiBzdWIgYnVpbGRQcm9qZWN0T3JEaWUoJCQpCkluZGV4OiBUb29scy9TY3JpcHRzL2J1 aWxkLXdlYmtpdAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdAkocmV2 aXNpb24gMjUzNTUwKQorKysgVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQJKHdvcmtpbmcgY29w eSkKQEAgLTI2Myw3ICsyNjMsNyBAQCBpZiAoaXNBcHBsZUNvY29hV2ViS2l0KCkpIHsKICAgICB9 CiAKICAgICAjIEJ1aWxkIFRvb2xzIG5lZWRlZCBmb3IgQXBwbGUgcG9ydHMKLSAgICBwdXNoIEBw cm9qZWN0cywgKCJUb29scy9EdW1wUmVuZGVyVHJlZSIsICJUb29scy9XZWJLaXRUZXN0UnVubmVy IiwgIlNvdXJjZS9UaGlyZFBhcnR5L2d0ZXN0IiwgIlRvb2xzL1Rlc3RXZWJLaXRBUEkiKTsKKyAg ICBwdXNoIEBwcm9qZWN0cywgKCJUb29scy9EdW1wUmVuZGVyVHJlZSIsICJUb29scy9XZWJLaXRU ZXN0UnVubmVyIiwgIlNvdXJjZS9UaGlyZFBhcnR5L2d0ZXN0IiwgIlRvb2xzL1Rlc3RXZWJLaXRB UEkiLCAiVG9vbHMvbGxkYi9sbGRiV2ViS2l0VGVzdGVyIik7CiAKIH0gZWxzaWYgKGlzV2luQ2Fp cm8oKSAmJiAhJHNraXBMaWJyYXJ5VXBkYXRlKSB7CiAgICAgKHN5c3RlbSgicHl0aG9uIFRvb2xz L1NjcmlwdHMvdXBkYXRlLXdlYmtpdC13aW5jYWlyby1saWJzLnB5IikgPT0gMCkgb3IgZGllOwo= 385772 2019-12-16 08:55:03 -0800 2019-12-16 13:39:54 -0800 Patch bug-205271-20191216085503.patch text/plain 1802 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MzU1NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE5LTEyLTE2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBsbGRid2Via2l0dGVzdGVyOiBDb25mb3JtIHdpdGggdGVzdGluZyBiaW5h cnkgZm9ybWF0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMDUyNzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBsbGRid2Via2l0dGVzdGVyIHNob3VsZCBiZSBidWlsdCB0aGUgc2FtZSB3YXkgSW1hZ2VEaWZm LCBUZXN0V2ViS2l0QVBJIGFuZCBXZWJLaXRUZXN0UnVubmVyIGFyZS4KKworICAgICAgICAqIFNj cmlwdHMvYnVpbGQtbGxkYndlYmtpdHRlc3RlcjoKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdl YmtpdDoKKwogMjAxOS0xMi0xNiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxp YS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBHVEsgZ2FyZGVuaW5nLiBNYXJrIC93ZWJraXQv V2ViS2l0V2ViVmlldy9wb2ludGVyLWxvY2stcGVybWlzc2lvbi1yZXF1ZXN0IGFzIHRpbWVvdXQK SW5kZXg6IFRvb2xzL1NjcmlwdHMvYnVpbGQtbGxkYndlYmtpdHRlc3Rlcgo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9TY3JpcHRzL2J1aWxkLWxsZGJ3ZWJraXR0ZXN0ZXIJKHJldmlzaW9uIDI1MzU1NCkK KysrIFRvb2xzL1NjcmlwdHMvYnVpbGQtbGxkYndlYmtpdHRlc3Rlcgkod29ya2luZyBjb3B5KQpA QCAtNjcsOCArNjcsNiBAQCBjaGRpcldlYktpdCgpOwogCiBteSBAeGNvZGVPcHRpb25zID0gWGNv ZGVPcHRpb25zKCk7CiAKLWJ1aWxkUHJvamVjdE9yRGllKCJTb3VyY2UvYm1hbGxvYyIsICJibWFs bG9jIik7Ci1idWlsZFByb2plY3RPckRpZSgiU291cmNlL1dURiIsICJXVEYiKTsKIGJ1aWxkUHJv amVjdE9yRGllKCJUb29scy9sbGRiL2xsZGJXZWJLaXRUZXN0ZXIiLCAibGxkYldlYktpdFRlc3Rl ciIpOwogCiBzdWIgYnVpbGRQcm9qZWN0T3JEaWUoJCQpCkluZGV4OiBUb29scy9TY3JpcHRzL2J1 aWxkLXdlYmtpdAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdAkocmV2 aXNpb24gMjUzNTU0KQorKysgVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQJKHdvcmtpbmcgY29w eSkKQEAgLTI2Miw2ICsyNjIsMTAgQEAgaWYgKGlzQXBwbGVDb2NvYVdlYktpdCgpKSB7CiAgICAg ICAgIChzeXN0ZW0oQGNvcHlMaWJyYXJpZXNBcmdzKSA9PSAwKSBvciBkaWU7CiAgICAgfQogCisg ICAgaWYgKGlzQXBwbGVNYWNXZWJLaXQoKSkgeworICAgICAgICBwdXNoIEBwcm9qZWN0cywgKCJU b29scy9sbGRiL2xsZGJXZWJLaXRUZXN0ZXIiKTsKKyAgICB9CisKICAgICAjIEJ1aWxkIFRvb2xz IG5lZWRlZCBmb3IgQXBwbGUgcG9ydHMKICAgICBwdXNoIEBwcm9qZWN0cywgKCJUb29scy9EdW1w UmVuZGVyVHJlZSIsICJUb29scy9XZWJLaXRUZXN0UnVubmVyIiwgIlNvdXJjZS9UaGlyZFBhcnR5 L2d0ZXN0IiwgIlRvb2xzL1Rlc3RXZWJLaXRBUEkiKTsKIAo= 385804 2019-12-16 13:39:55 -0800 2019-12-16 14:25:00 -0800 Patch for landing bug-205271-20191216133955.patch text/plain 1986 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MzU1NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE5LTEyLTE2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBsbGRid2Via2l0dGVzdGVyOiBDb25mb3JtIHdpdGggdGVzdGluZyBiaW5h cnkgZm9ybWF0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMDUyNzEKKworICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkgUHJvc2t1cnlha292LgorCisg ICAgICAgIGxsZGJ3ZWJraXR0ZXN0ZXIgc2hvdWxkIGJlIGJ1aWx0IHRoZSBzYW1lIHdheSBJbWFn ZURpZmYsIFRlc3RXZWJLaXRBUEkgYW5kIFdlYktpdFRlc3RSdW5uZXIgYXJlLgorICAgICAgICBU aGlzIGFsc28gcGF2ZXMgdGhlIHdheSBmb3IgYWRkaW5nIGxsZGIgdGVzdHMgYWdhaW5zdCBXZWJD b3JlIGFuZCBXZWJLaXQsIHNpbmNlIGxsZGJ3ZWJraXR0ZXN0cnVubmVyCisgICAgICAgIGlzIG5v dyBwYWNrYWdlZCB3aXRoIHRoZSByZXN0IG9mIFdlYktpdCdzIHRlc3RpbmcgYmluYXJpZXMuCisK KyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLWxsZGJ3ZWJraXR0ZXN0ZXI6CisgICAgICAgICogU2Ny aXB0cy9idWlsZC13ZWJraXQ6CisKIDIwMTktMTItMTYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8 Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgR1RLIGdhcmRlbmluZy4g TWFyayAvd2Via2l0L1dlYktpdFdlYlZpZXcvcG9pbnRlci1sb2NrLXBlcm1pc3Npb24tcmVxdWVz dCBhcyB0aW1lb3V0CkluZGV4OiBUb29scy9TY3JpcHRzL2J1aWxkLWxsZGJ3ZWJraXR0ZXN0ZXIK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9idWlsZC1sbGRid2Via2l0dGVzdGVyCShyZXZp c2lvbiAyNTM1NTQpCisrKyBUb29scy9TY3JpcHRzL2J1aWxkLWxsZGJ3ZWJraXR0ZXN0ZXIJKHdv cmtpbmcgY29weSkKQEAgLTY3LDggKzY3LDYgQEAgY2hkaXJXZWJLaXQoKTsKIAogbXkgQHhjb2Rl T3B0aW9ucyA9IFhjb2RlT3B0aW9ucygpOwogCi1idWlsZFByb2plY3RPckRpZSgiU291cmNlL2Jt YWxsb2MiLCAiYm1hbGxvYyIpOwotYnVpbGRQcm9qZWN0T3JEaWUoIlNvdXJjZS9XVEYiLCAiV1RG Iik7CiBidWlsZFByb2plY3RPckRpZSgiVG9vbHMvbGxkYi9sbGRiV2ViS2l0VGVzdGVyIiwgImxs ZGJXZWJLaXRUZXN0ZXIiKTsKIAogc3ViIGJ1aWxkUHJvamVjdE9yRGllKCQkKQpJbmRleDogVG9v bHMvU2NyaXB0cy9idWlsZC13ZWJraXQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9idWls ZC13ZWJraXQJKHJldmlzaW9uIDI1MzU1NCkKKysrIFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0 CSh3b3JraW5nIGNvcHkpCkBAIC0yNjIsNiArMjYyLDEwIEBAIGlmIChpc0FwcGxlQ29jb2FXZWJL aXQoKSkgewogICAgICAgICAoc3lzdGVtKEBjb3B5TGlicmFyaWVzQXJncykgPT0gMCkgb3IgZGll OwogICAgIH0KIAorICAgIGlmIChpc0FwcGxlTWFjV2ViS2l0KCkpIHsKKyAgICAgICAgcHVzaCBA cHJvamVjdHMsICgiVG9vbHMvbGxkYi9sbGRiV2ViS2l0VGVzdGVyIik7CisgICAgfQorCiAgICAg IyBCdWlsZCBUb29scyBuZWVkZWQgZm9yIEFwcGxlIHBvcnRzCiAgICAgcHVzaCBAcHJvamVjdHMs ICgiVG9vbHMvRHVtcFJlbmRlclRyZWUiLCAiVG9vbHMvV2ViS2l0VGVzdFJ1bm5lciIsICJTb3Vy Y2UvVGhpcmRQYXJ0eS9ndGVzdCIsICJUb29scy9UZXN0V2ViS2l0QVBJIik7CiAK