205148 2019-12-11 17:58:23 -0800 Web Inspector: REGRESSION(r251227): Uncaught Exception: undefined is not an object (evaluating 'target.DOMAgent.setInspectModeEnabled') 2019-12-12 00:25:21 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 200384 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1597900 0 hi 2019-12-11 17:58:23 -0800 Uncaught Exception in Web Inspector. Steps to Reproduce: 1. inspect any page 2. Develop > Start Element Selection (⇧⌘C) => element selection doesn't turn on 3. open Web Inspector through some other method => uncaught exception shown 4. Develop > Start Element Selection (⇧⌘C) => element selection turns on as expected I think this is a regression from r251227 because the connection to the actual `WebCore::Page` target hasn't been established yet, meaning that the `WI.mainTarget` is actually the `WI.MultiplexingBackendTarget`. Uncaught Exceptions: ----------------------- - undefined is not an object (evaluating 'target.DOMAgent.setInspectModeEnabled') (at DOMManager.js:589:24) inspectModeEnabled @ DOMManager.js:589:24 setElementSelectionEnabled @ InspectorFrontendAPI.js:74:22 dispatch @ InspectorFrontendAPI.js:174:54 loadCompleted @ InspectorFrontendAPI.js:182:42 ? @ Main.js:533:43 promiseReactionJob @ [native code] ----------------------- Notes: Inspected URL: (unknown) Loading completed: true Frontend User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/605.1.15 (KHTML, like Gecko) 1597903 1 385469 hi 2019-12-11 18:04:42 -0800 Created attachment 385469 Patch 1597904 2 385469 joepeck 2019-12-11 18:08:25 -0800 Comment on attachment 385469 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385469&action=review r=me > Source/WebInspectorUI/ChangeLog:22 > + * UserInterface/Base/Main.js: > + Drive-by: remove duplicate function `WI._toggleInspectMode` as it already exists. !! How did a linter not catch this? 1597942 3 385469 hi 2019-12-11 23:40:47 -0800 Comment on attachment 385469 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385469&action=review >> Source/WebInspectorUI/ChangeLog:22 >> + Drive-by: remove duplicate function `WI._toggleInspectMode` as it already exists. > > !! How did a linter not catch this? As we discussed in person, it’s not a function on a class or a variable in a scope, so it’s not as easily statically analyzable :( 1597945 4 385469 commit-queue 2019-12-12 00:24:31 -0800 Comment on attachment 385469 Patch Clearing flags on attachment: 385469 Committed r253421: <https://trac.webkit.org/changeset/253421> 1597946 5 commit-queue 2019-12-12 00:24:33 -0800 All reviewed patches have been landed. Closing bug. 1597947 6 webkit-bug-importer 2019-12-12 00:25:21 -0800 <rdar://problem/57869541> 385469 2019-12-11 18:04:42 -0800 2019-12-12 00:24:31 -0800 Patch bug-205148-20191211180442.patch text/plain 4530 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDYzZDJlZTk1YWVkMWE5N2Q0MjIxMDUxOWQ3MmRi Y2VmMjQ0YjVlNzMuLjEwY2UyNTQ5ZDNiNTVkOTE3NzM3ZmFkMzQwYzcyNzRjOTJkZTgwNTEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE5LTEyLTExICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OKHIyNTEyMjcpOiBVbmNhdWdodCBFeGNlcHRpb246IHVuZGVmaW5lZCBpcyBub3Qg YW4gb2JqZWN0IChldmFsdWF0aW5nICd0YXJnZXQuRE9NQWdlbnQuc2V0SW5zcGVjdE1vZGVFbmFi bGVkJykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw NTE0OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog VXNlckludGVyZmFjZS9Qcm90b2NvbC9JbnNwZWN0b3JGcm9udGVuZEFQSS5qczoKKyAgICAgICAg KEluc3BlY3RvckZyb250ZW5kQVBJLnNldFRpbWVsaW5lUHJvZmlsaW5nRW5hYmxlZCk6CisgICAg ICAgIChJbnNwZWN0b3JGcm9udGVuZEFQSS5zZXRFbGVtZW50U2VsZWN0aW9uRW5hYmxlZCk6Cisg ICAgICAgIElmIHRoZXJlIGFyZSBubyB0YXJnZXRzIGF2YWlsYWJsZSB5ZXQgKGBXSS50YXJnZXRz QXZhaWxhYmxlKClgKSwgdGhlbiB3YWl0IGZvciB0YXJnZXRzIHRvCisgICAgICAgIGJlIGF2YWls YWJsZSAoYFdJLndoZW5UYXJnZXRzQXZhaWxhYmxlKClgKSBiZWZvcmUgcGVyZm9ybWluZyB0aGUg aW50ZW5kZWQgbG9naWMsIGFzIHRoZQorICAgICAgICBgSW5zcGVjdG9yRnJvbnRlbmRBUElgIG9u bHkgd2FpdHMgZm9yIHRoZSBiYWNrZW5kIGNvbm5lY3Rpb24gdG8gYmUgZXN0YWJsaXNoZWQgYmVm b3JlCisgICAgICAgIGRpc3BhdGNoaW5nLCBtZWFuaW5nIHRoYXQgdGhlcmUgbWF5IG5vdCBiZSBh IHBhZ2UgdGFyZ2V0IHlldC4gT3RoZXIgYEluc3BlY3RvckZyb250ZW5kQVBJYAorICAgICAgICBm dW5jdGlvbnMgZG9uJ3QgbmVlZCB0byBiZSBjaGFuZ2VkIGJlY2F1c2UgdGhleSBkb24ndCBjYXVz ZSBjb21tYW5kcyB0byBiZSBpbnZva2VkLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Db250 cm9sbGVycy9ET01NYW5hZ2VyLmpzOgorICAgICAgICAoV0kuRE9NTWFuYWdlci5wcm90b3R5cGUu c2V0IGluc3BlY3RNb2RlRW5hYmxlZCk6CisgICAgICAgIERyaXZlLWJ5OiBkb24ndCBhc3N1bWUg dGhhdCBpbnNwZWN0IG1vZGUgaXMgZGlzYWJsZWQgaWYgYW4gZXJyb3IgaXMgdGhyb3duLgorCisg ICAgICAgICogVXNlckludGVyZmFjZS9CYXNlL01haW4uanM6CisgICAgICAgIERyaXZlLWJ5OiBy ZW1vdmUgZHVwbGljYXRlIGZ1bmN0aW9uIGBXSS5fdG9nZ2xlSW5zcGVjdE1vZGVgIGFzIGl0IGFs cmVhZHkgZXhpc3RzLgorCiAyMDE5LTEyLTEwICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxl LmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIyNTI1MjMpOiBXZWIgSW5zcGVjdG9yOiBTdHls ZXM6IHNlbWljb2xvbiBpcyB3cm9uZ2x5IHBvc2l0aW9uZWQgaW4gbXVsdGlsaW5lIHZhbHVlcwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWlu LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCmlu ZGV4IDc4OTEwZmFhMzc5ZGEwM2FhYWJmYWU3YmFlMDNkMDFkYzEyZmI1NmYuLjEzNjI1MWU3Zjcz MDEwZWU4YTgwMGNhYzIwMzY3NWUyMjczOTU3YjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKQEAgLTIzMjIsMTEgKzIzMjIsNiBAQCBX SS5fdXBkYXRlSW5zcGVjdE1vZGVUb29sYmFyQnV0dG9uID0gZnVuY3Rpb24oKQogICAgIFdJLl9p bnNwZWN0TW9kZVRvb2xiYXJCdXR0b24uaGlkZGVuID0gIUluc3BlY3RvckJhY2tlbmQuaGFzRG9t YWluKCJET00iKTsKIH07CiAKLVdJLl90b2dnbGVJbnNwZWN0TW9kZSA9IGZ1bmN0aW9uKGV2ZW50 KQotewotICAgIFdJLmRvbU1hbmFnZXIuaW5zcGVjdE1vZGVFbmFibGVkID0gIVdJLmRvbU1hbmFn ZXIuaW5zcGVjdE1vZGVFbmFibGVkOwotfTsKLQogV0kuX3Nob3dDb25zb2xlVGFiID0gZnVuY3Rp b24oZXZlbnQpCiB7CiAgICAgV0kuc2hvd0NvbnNvbGVUYWIoKTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0RPTU1hbmFnZXIuanMg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9ET01NYW5h Z2VyLmpzCmluZGV4IDhiYjgxNDNjZDFjN2Y2NjRlOWJmNTkyMTMzOWZkMTQ4OWM5MDQyYzQuLmQx OTQzYzNmYzc5MmZiNTIyZTFmNWEwM2IwMGVmMGViM2MyNzUwMDcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0RPTU1hbmFnZXIuanMK KysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRE9N TWFuYWdlci5qcwpAQCAtNTg3LDcgKzU4NywxMiBAQCBXSS5ET01NYW5hZ2VyID0gY2xhc3MgRE9N TWFuYWdlciBleHRlbmRzIFdJLk9iamVjdAogICAgICAgICAgICAgc2hvd1J1bGVyczogV0kuc2V0 dGluZ3Muc2hvd1J1bGVyc0R1cmluZ0VsZW1lbnRTZWxlY3Rpb24udmFsdWUsCiAgICAgICAgIH07 CiAgICAgICAgIHRhcmdldC5ET01BZ2VudC5zZXRJbnNwZWN0TW9kZUVuYWJsZWQuaW52b2tlKGNv bW1hbmRBcmd1bWVudHMsIChlcnJvcikgPT4gewotICAgICAgICAgICAgdGhpcy5faW5zcGVjdE1v ZGVFbmFibGVkID0gZXJyb3IgPyBmYWxzZSA6IGVuYWJsZWQ7CisgICAgICAgICAgICBpZiAoZXJy b3IpIHsKKyAgICAgICAgICAgICAgICBXSS5yZXBvcnRJbnRlcm5hbEVycm9yKGVycm9yKTsKKyAg ICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICB9CisKKyAgICAgICAgICAgIHRoaXMu X2luc3BlY3RNb2RlRW5hYmxlZCA9IGVuYWJsZWQ7CiAgICAgICAgICAgICB0aGlzLmRpc3BhdGNo RXZlbnRUb0xpc3RlbmVycyhXSS5ET01NYW5hZ2VyLkV2ZW50Lkluc3BlY3RNb2RlU3RhdGVDaGFu Z2VkKTsKICAgICAgICAgfSk7CiAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wvSW5zcGVjdG9yRnJvbnRlbmRBUEkuanMgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Qcm90b2NvbC9JbnNwZWN0b3JGcm9udGVu ZEFQSS5qcwppbmRleCBjMzFkNzYyZjEyZjI4YmZhOTI0NjJmNzE1MmRmMWJmMDYzMjlhNTA0Li5l OWE5MTY1NzlkNzY5NzhlOGFmNjhiNzgzNDhjYjRjMDY0OTAxMGJlIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Qcm90b2NvbC9JbnNwZWN0b3JGcm9udGVu ZEFQSS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Qcm90b2Nv bC9JbnNwZWN0b3JGcm9udGVuZEFQSS5qcwpAQCAtNDQsNiArNDQsMTMgQEAgSW5zcGVjdG9yRnJv bnRlbmRBUEkgPSB7CiAKICAgICBzZXRUaW1lbGluZVByb2ZpbGluZ0VuYWJsZWQ6IGZ1bmN0aW9u KGVuYWJsZWQpCiAgICAgeworICAgICAgICBpZiAoIVdJLnRhcmdldHNBdmFpbGFibGUoKSkgewor ICAgICAgICAgICAgV0kud2hlblRhcmdldHNBdmFpbGFibGUoKS50aGVuKCgpID0+IHsKKyAgICAg ICAgICAgICAgICBJbnNwZWN0b3JGcm9udGVuZEFQSS5zZXRUaW1lbGluZVByb2ZpbGluZ0VuYWJs ZWQoZW5hYmxlZCk7CisgICAgICAgICAgICB9KTsKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAg ICAgfQorCiAgICAgICAgIFdJLnNob3dUaW1lbGluZVRhYigpOwogCiAgICAgICAgIGlmIChXSS50 aW1lbGluZU1hbmFnZXIuaXNDYXB0dXJpbmcoKSA9PT0gZW5hYmxlZCkKQEAgLTU3LDYgKzY0LDEz IEBAIEluc3BlY3RvckZyb250ZW5kQVBJID0gewogCiAgICAgc2V0RWxlbWVudFNlbGVjdGlvbkVu YWJsZWQ6IGZ1bmN0aW9uKGVuYWJsZWQpCiAgICAgeworICAgICAgICBpZiAoIVdJLnRhcmdldHNB dmFpbGFibGUoKSkgeworICAgICAgICAgICAgV0kud2hlblRhcmdldHNBdmFpbGFibGUoKS50aGVu KCgpID0+IHsKKyAgICAgICAgICAgICAgICBJbnNwZWN0b3JGcm9udGVuZEFQSS5zZXRFbGVtZW50 U2VsZWN0aW9uRW5hYmxlZChlbmFibGVkKTsKKyAgICAgICAgICAgIH0pOworICAgICAgICAgICAg cmV0dXJuOworICAgICAgICB9CisKICAgICAgICAgV0kuZG9tTWFuYWdlci5pbnNwZWN0TW9kZUVu YWJsZWQgPSBlbmFibGVkOwogICAgIH0sCiAK