205035 2019-12-09 16:23:37 -0800 Web Inspector: REGRESSION(r251038): Elements: Computed: implicit shorthands are not shown when "Prefer Shorthands" is enabled 2019-12-10 15:01:56 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 200554 1 nvasilyev hi bburg commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1597006 0 nvasilyev 2019-12-09 16:23:37 -0800 Inspect: <body style="font-family: -webkit-system-font, sans-serif; font-size: 75%;"> Computed panel should include `font-family` and `font-size` values. Instead, it only shows: color: rgb(0, 0, 0); display: block; height: 90px; width: 411px; 1597007 1 webkit-bug-importer 2019-12-09 16:24:07 -0800 <rdar://problem/57773470> 1597010 2 nvasilyev 2019-12-09 16:27:47 -0800 Reduction: https://nv.github.io/webkit-inspector-bugs/205035_computed-shortcuts-bug/index.html This regressed in Bug 200554 Web Inspector: Elements: Computed: show shorthand properties in addition to longhand ones 1597044 3 385218 hi 2019-12-09 17:46:36 -0800 Created attachment 385218 Patch 1597298 4 385218 bburg 2019-12-10 12:12:02 -0800 Comment on attachment 385218 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385218&action=review r=me > Source/WebInspectorUI/ChangeLog:17 > + Drive-by: filter the list of properties to render before sorting them for performance. Does this affect the display order? Is it already being sorted? > Source/WebInspectorUI/UserInterface/Views/ComputedStyleSection.js:170 > + if (!(this._showsShorthandsInsteadOfLonghands && property.isShorthand && hasNonImplicitLonghand(property))) I wish it were possible to fold this into the guard below, but alas, it early exits too early otherwise. 1597345 5 385218 hi 2019-12-10 14:05:52 -0800 Comment on attachment 385218 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385218&action=review >> Source/WebInspectorUI/ChangeLog:17 >> + Drive-by: filter the list of properties to render before sorting them for performance. > > Does this affect the display order? Is it already being sorted? No, it was already sorted. What I mean by saying this is rather than sort-then-filter, we filter-then-sort so we don't have to sort as many items :P >> Source/WebInspectorUI/UserInterface/Views/ComputedStyleSection.js:170 >> + if (!(this._showsShorthandsInsteadOfLonghands && property.isShorthand && hasNonImplicitLonghand(property))) > > I wish it were possible to fold this into the guard below, but alas, it early exits too early otherwise. Indeed :( 1597365 6 commit-queue 2019-12-10 15:00:55 -0800 The commit-queue encountered the following flaky tests while processing attachment 385218: fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com) The commit-queue is continuing to process your patch. 1597366 7 385218 commit-queue 2019-12-10 15:01:54 -0800 Comment on attachment 385218 Patch Clearing flags on attachment: 385218 Committed r253348: <https://trac.webkit.org/changeset/253348> 1597367 8 commit-queue 2019-12-10 15:01:56 -0800 All reviewed patches have been landed. Closing bug. 385218 2019-12-09 17:46:36 -0800 2019-12-10 15:01:54 -0800 Patch 205035.diff text/plain 3864 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDE1MGY3YTliMmNmLi5hMjlkNzhjNDk1NCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTktMTItMDkgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJF R1JFU1NJT04ocjI1MTAzOCk6IEVsZW1lbnRzOiBDb21wdXRlZDogaW1wbGljaXQgc2hvcnRoYW5k cyBhcmUgbm90IHNob3duIHdoZW4gIlByZWZlciBTaG9ydGhhbmRzIiBpcyBlbmFibGVkCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDUwMzUKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzU3NzczNDcwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoZSBjb21wdXRlZCBzdHlsZSB0cmVhdHMgbW9zdCBzaG9y dGhhbmQgcHJvcGVydGllcyBhcyAiaW1wbGljaXQiLCBtZWFuaW5nIHRoYXQgaWYgIlByZWZlcgor ICAgICAgICBTaG9ydGhhbmRzIiBpcyBlbmFibGVkLCB3ZSB3b24ndCBzaG93IHRoZSBzaG9ydGhh bmQgcHJvcGVydGllcyB1bmxlc3MgIlNob3cgQWxsIiBpcyBhbHNvCisgICAgICAgIGVuYWJsZWQu IFRoZSBmcm9udGVuZCBjYW4gZml4IHRoaXMgYnkgY2hlY2tpbmcgdG8gc2VlIGlmIHRoZXJlIGFy ZSBhbnkgbm9uLWltcGxpY2l0IGxvbmdoYW5kCisgICAgICAgIHZhbHVlcyBmb3IgZWFjaCBzaG9y dGhhbmQgdmFsdWUsIGFuZCB0aGVyZWZvcmUgZGVjaWRlIG5vdCB0byBoaWRlIHRoZSAiaW1wbGlj aXQiIHNob3J0aGFuZC4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQ29tcHV0ZWRT dHlsZVNlY3Rpb24uanM6CisgICAgICAgIChXSS5Db21wdXRlZFN0eWxlU2VjdGlvbi5wcm90b3R5 cGUuZ2V0IHByb3BlcnRpZXNUb1JlbmRlcik6CisgICAgICAgIChXSS5Db21wdXRlZFN0eWxlU2Vj dGlvbi5wcm90b3R5cGUuZ2V0IHByb3BlcnRpZXNUb1JlbmRlci5oYXNOb25JbXBsaWNpdExvbmdo YW5kKTogQWRkZWQuCisgICAgICAgIERyaXZlLWJ5OiBmaWx0ZXIgdGhlIGxpc3Qgb2YgcHJvcGVy dGllcyB0byByZW5kZXIgYmVmb3JlIHNvcnRpbmcgdGhlbSBmb3IgcGVyZm9ybWFuY2UuCisKIDIw MTktMTItMDYgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IFVuY2F1Z2h0IEV4Y2VwdGlvbjogTWlzc2luZyBub2RlIGZvciBnaXZlbiBu b2RlSWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL0NvbXB1dGVkU3R5bGVTZWN0aW9uLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvQ29tcHV0ZWRTdHlsZVNlY3Rpb24uanMKaW5kZXggNTQ4NWI5OTRmNjAu LmUyYzdiNjYxNWU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9Db21wdXRlZFN0eWxlU2VjdGlvbi5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db21wdXRlZFN0eWxlU2VjdGlvbi5qcwpAQCAtMTQw LDE3ICsxNDAsMzYgQEAgV0kuQ29tcHV0ZWRTdHlsZVNlY3Rpb24gPSBjbGFzcyBDb21wdXRlZFN0 eWxlU2VjdGlvbiBleHRlbmRzIFdJLlZpZXcKICAgICAgICAgZWxzZQogICAgICAgICAgICAgcHJv cGVydGllcyA9IHRoaXMuX3N0eWxlLnByb3BlcnRpZXM7CiAKLSAgICAgICAgcHJvcGVydGllcy5z b3J0KChhLCBiKSA9PiBhLm5hbWUuZXh0ZW5kZWRMb2NhbGVDb21wYXJlKGIubmFtZSkpOworICAg ICAgICBsZXQgcHJvcGVydHlOYW1lTWFwID0gbmV3IE1hcChwcm9wZXJ0aWVzLm1hcCgocHJvcGVy dHkpID0+IFtwcm9wZXJ0eS5jYW5vbmljYWxOYW1lLCBwcm9wZXJ0eV0pKTsKKworICAgICAgICBm dW5jdGlvbiBoYXNOb25JbXBsaWNpdExvbmdoYW5kKHByb3BlcnR5KSB7CisgICAgICAgICAgICBp ZiAocHJvcGVydHkuY2Fub25pY2FsTmFtZSA9PT0gImFsbCIpCisgICAgICAgICAgICAgICAgcmV0 dXJuIGZhbHNlOworCisgICAgICAgICAgICBsZXQgbG9uZ2hhbmRQcm9wZXJ0eU5hbWVzID0gV0ku Q1NTS2V5d29yZENvbXBsZXRpb25zLkxvbmdoYW5kTmFtZXNGb3JTaG9ydGhhbmRQcm9wZXJ0eS5n ZXQocHJvcGVydHkuY2Fub25pY2FsTmFtZSk7CisgICAgICAgICAgICBpZiAoIWxvbmdoYW5kUHJv cGVydHlOYW1lcykKKyAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICAgICAgICAg IGZvciAobGV0IGxvbmdoYW5kUHJvcGVydHlOYW1lIG9mIGxvbmdoYW5kUHJvcGVydHlOYW1lcykg eworICAgICAgICAgICAgICAgIGxldCBwcm9wZXJ0eSA9IHByb3BlcnR5TmFtZU1hcC5nZXQobG9u Z2hhbmRQcm9wZXJ0eU5hbWUpOworICAgICAgICAgICAgICAgIGlmIChwcm9wZXJ0eSAmJiAhcHJv cGVydHkuaW1wbGljaXQpCisgICAgICAgICAgICAgICAgICAgIHJldHVybiB0cnVlOworICAgICAg ICAgICAgfQorCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgIH0KIAogICAgICAg ICBsZXQgaGlkZVZhcmlhYmxlcyA9IHRoaXMuX3Byb3BlcnR5VmlzaWJpbGl0eU1vZGUgPT09IENv bXB1dGVkU3R5bGVTZWN0aW9uLlByb3BlcnR5VmlzaWJpbGl0eU1vZGUuSGlkZVZhcmlhYmxlczsK ICAgICAgICAgbGV0IGhpZGVOb25WYXJpYWJsZXMgPSB0aGlzLl9wcm9wZXJ0eVZpc2liaWxpdHlN b2RlID09PSBDb21wdXRlZFN0eWxlU2VjdGlvbi5Qcm9wZXJ0eVZpc2liaWxpdHlNb2RlLkhpZGVO b25WYXJpYWJsZXM7CiAKLSAgICAgICAgcmV0dXJuIHByb3BlcnRpZXMuZmlsdGVyKChwcm9wZXJ0 eSkgPT4geworICAgICAgICBwcm9wZXJ0aWVzID0gcHJvcGVydGllcy5maWx0ZXIoKHByb3BlcnR5 KSA9PiB7CiAgICAgICAgICAgICBpZiAodGhpcy5fYWx3YXlzU2hvd1Byb3BlcnR5TmFtZXMuaGFz KHByb3BlcnR5LmNhbm9uaWNhbE5hbWUpKQogICAgICAgICAgICAgICAgIHJldHVybiB0cnVlOwog Ci0gICAgICAgICAgICBpZiAocHJvcGVydHkuaW1wbGljaXQgJiYgIXRoaXMuX3Nob3dzSW1wbGlj aXRQcm9wZXJ0aWVzKQotICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgICAg IGlmIChwcm9wZXJ0eS5pbXBsaWNpdCAmJiAhdGhpcy5fc2hvd3NJbXBsaWNpdFByb3BlcnRpZXMp IHsKKyAgICAgICAgICAgICAgICBpZiAoISh0aGlzLl9zaG93c1Nob3J0aGFuZHNJbnN0ZWFkT2ZM b25naGFuZHMgJiYgcHJvcGVydHkuaXNTaG9ydGhhbmQgJiYgaGFzTm9uSW1wbGljaXRMb25naGFu ZChwcm9wZXJ0eSkpKQorICAgICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAg ICAgICB9CiAKICAgICAgICAgICAgIGlmICh0aGlzLl9zaG93c1Nob3J0aGFuZHNJbnN0ZWFkT2ZM b25naGFuZHMpIHsKICAgICAgICAgICAgICAgICBpZiAocHJvcGVydHkuc2hvcnRoYW5kUHJvcGVy dHlOYW1lcy5sZW5ndGgpCkBAIC0xNjYsNiArMTg1LDkgQEAgV0kuQ29tcHV0ZWRTdHlsZVNlY3Rp b24gPSBjbGFzcyBDb21wdXRlZFN0eWxlU2VjdGlvbiBleHRlbmRzIFdJLlZpZXcKIAogICAgICAg ICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAgIH0pOworCisgICAgICAgIHByb3BlcnRpZXMuc29y dCgoYSwgYikgPT4gYS5uYW1lLmV4dGVuZGVkTG9jYWxlQ29tcGFyZShiLm5hbWUpKTsKKyAgICAg ICAgcmV0dXJuIHByb3BlcnRpZXM7CiAgICAgfQogCiAgICAgbGF5b3V0KCkK