204517 2019-11-22 08:18:08 -0800 [ews] Add basic commit-queue support in new EWS 2020-01-21 07:07:29 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 201934 1 aakash_jain aakash_jain aakash_jain ap jbedard webkit-bug-importer oldest_to_newest 1592803 0 aakash_jain 2019-11-22 08:18:08 -0800 Add basic commit-queue support in new EWS. 1592805 1 384155 aakash_jain 2019-11-22 08:19:43 -0800 Created attachment 384155 Patch 1592808 2 aakash_jain 2019-11-22 08:22:53 -0800 Sample run: https://ews-build.webkit-uat.org/#/builders/26/builds/4 1592835 3 384155 jbedard 2019-11-22 09:24:39 -0800 Comment on attachment 384155 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384155&action=review > Tools/BuildSlaveSupport/ews-build/config.json:517 > + "workernames": ["webkit-cq-01", "webkit-cq-02", "webkit-cq-03"] Are we actually intending to bring these online? Aren't these workers already functioning in the old commit queue? > Tools/BuildSlaveSupport/ews-build/config.json:531 > + "name": "try_commitqueue", I'm a bit confused by what we're doing here. 1592845 4 aakash_jain 2019-11-22 09:33:06 -0800 (In reply to Jonathan Bedard from comment #3) > Comment on attachment 384155 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=384155&action=review > > > Tools/BuildSlaveSupport/ews-build/config.json:517 > > + "workernames": ["webkit-cq-01", "webkit-cq-02", "webkit-cq-03"] > > Are we actually intending to bring these online? Aren't these workers already functioning in the old commit queue? No today, we will move them when commit-queue is ready on new EWS. This is just part 1 for adding the support. > > > Tools/BuildSlaveSupport/ews-build/config.json:531 > > + "name": "try_commitqueue", > > I'm a bit confused by what we're doing here. We can't trigger commit-queue when we trigger all other queues. This would be triggered explicitly. EWS django app will run another 'buildbot try' command on this port for the patches with cq+ flag. It would be done in subsequent patch. 1592850 5 384155 jbedard 2019-11-22 09:45:35 -0800 Comment on attachment 384155 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384155&action=review >>> Tools/BuildSlaveSupport/ews-build/config.json:531 >>> + "name": "try_commitqueue", >> >> I'm a bit confused by what we're doing here. > > We can't trigger commit-queue when we trigger all other queues. This would be triggered explicitly. EWS django app will run another 'buildbot try' command on this port for the patches with cq+ flag. It would be done in subsequent patch. So we basically, open up port 5557 and listen for a request to trigger commit queue? 1592851 6 aakash_jain 2019-11-22 09:47:26 -0800 (In reply to Jonathan Bedard from comment #5) > So we basically, open up port 5557 and listen for a request to trigger commit queue? Yes, just like we listen on 5555 to trigger rest of the queues. 1592857 7 aakash_jain 2019-11-22 10:02:16 -0800 Committed r252780: <https://trac.webkit.org/changeset/252780> 1592858 8 webkit-bug-importer 2019-11-22 10:03:28 -0800 <rdar://problem/57432105> 384155 2019-11-22 08:19:43 -0800 2019-11-22 09:52:41 -0800 Patch bug-204517-20191122111942.patch text/plain 3551 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1Mjc3NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTExLTIyICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBBZGQgYmFzaWMgY29tbWl0LXF1ZXVlIHN1cHBvcnQgaW4gbmV3 IEVXUworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0 NTE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBC dWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvY29uZmlnLmpzb246CisgICAgICAgICogQnVpbGRT bGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rvcmllcy5weToKKyAgICAgICAgKiBCdWlsZFNsYXZl U3VwcG9ydC9ld3MtYnVpbGQvbG9hZENvbmZpZy5weToKKwogMjAxOS0xMS0yMiAgUGF1bG8gTWF0 b3MgIDxwbWF0b3NAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZW1vdmUgSlNDIDMyYml0IEFSTXY3 IGFuZCBNaXBzRWwgb2xkIEVXUyBxdWV1ZXMKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2V3cy1idWlsZC9jb25maWcuanNvbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3Vw cG9ydC9ld3MtYnVpbGQvY29uZmlnLmpzb24JKHJldmlzaW9uIDI1Mjc3NSkKKysrIFRvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9jb25maWcuanNvbgkod29ya2luZyBjb3B5KQpAQCAt MjczLDYgKzI3MywxOCBAQAogICAgIHsKICAgICAgICJuYW1lIjogImV3czIxNSIsCiAgICAgICAi cGxhdGZvcm0iOiAid2luIgorICAgIH0sCisgICAgeworICAgICAgIm5hbWUiOiAid2Via2l0LWNx LTAxIiwKKyAgICAgICJwbGF0Zm9ybSI6ICJtYWMtaGlnaHNpZXJyYSIKKyAgICB9LAorICAgIHsK KyAgICAgICJuYW1lIjogIndlYmtpdC1jcS0wMiIsCisgICAgICAicGxhdGZvcm0iOiAibWFjLWhp Z2hzaWVycmEiCisgICAgfSwKKyAgICB7CisgICAgICAibmFtZSI6ICJ3ZWJraXQtY3EtMDMiLAor ICAgICAgInBsYXRmb3JtIjogIm1hYy1oaWdoc2llcnJhIgogICAgIH0KICAgXSwKICAgImJ1aWxk ZXJzIjogWwpAQCAtNDkzLDYgKzUwNSwxNiBAQAogICAgICAgImZhY3RvcnkiOiAiU2VydmljZXNG YWN0b3J5IiwKICAgICAgICJwbGF0Zm9ybSI6ICIqIiwKICAgICAgICJ3b3JrZXJuYW1lcyI6IFsi ZXdzMTUxIiwgIndlYmtpdC1taXNjIl0KKyAgICB9LAorICAgIHsKKyAgICAgICJuYW1lIjogIkNv bW1pdC1RdWV1ZSIsCisgICAgICAic2hvcnRuYW1lIjogImNvbW1pdCIsCisgICAgICAiaWNvbiI6 ICJidWlsZEFuZFRlc3QiLAorICAgICAgImZhY3RvcnkiOiAiQ29tbWl0UXVldWVGYWN0b3J5IiwK KyAgICAgICJwbGF0Zm9ybSI6ICJtYWMtaGlnaHNpZXJyYSIsCisgICAgICAiY29uZmlndXJhdGlv biI6ICJyZWxlYXNlIiwKKyAgICAgICJhcmNoaXRlY3R1cmVzIjogWyJ4ODZfNjQiXSwKKyAgICAg ICJ3b3JrZXJuYW1lcyI6IFsid2Via2l0LWNxLTAxIiwgIndlYmtpdC1jcS0wMiIsICJ3ZWJraXQt Y3EtMDMiXQogICAgIH0KICAgXSwKICAgInNjaGVkdWxlcnMiOiBbCkBAIC01MDYsNiArNTI4LDEy IEBACiAgICAgfSwKICAgICB7CiAgICAgICAidHlwZSI6ICJUcnlfVXNlcnBhc3MiLAorICAgICAg Im5hbWUiOiAidHJ5X2NvbW1pdHF1ZXVlIiwKKyAgICAgICJwb3J0IjogNTU1NywKKyAgICAgICJi dWlsZGVyTmFtZXMiOiBbIkNvbW1pdC1RdWV1ZSJdCisgICAgfSwKKyAgICB7CisgICAgICAidHlw ZSI6ICJUcnlfVXNlcnBhc3MiLAogICAgICAgIm5hbWUiOiAiZGlzYWJsZWQiLAogICAgICAgInBv cnQiOiA1NTU2LAogICAgICAgImJ1aWxkZXJOYW1lcyI6IFsiV2luZG93cy1FV1MiXQpJbmRleDog VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rvcmllcy5weQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvZmFjdG9yaWVzLnB5CShyZXZp c2lvbiAyNTI3NzUpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvZmFjdG9y aWVzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xODQsMyArMTg0LDggQEAgY2xhc3MgU2VydmljZXNG YWN0b3J5KEZhY3RvcnkpOgogICAgICAgICBzZWxmLmFkZFN0ZXAoUnVuRVdTVW5pdFRlc3RzKCkp CiAgICAgICAgIHNlbGYuYWRkU3RlcChSdW5FV1NCdWlsZGJvdENoZWNrQ29uZmlnKCkpCiAgICAg ICAgIHNlbGYuYWRkU3RlcChSdW5CdWlsZFdlYktpdE9yZ1VuaXRUZXN0cygpKQorCisKK2NsYXNz IENvbW1pdFF1ZXVlRmFjdG9yeShGYWN0b3J5KToKKyAgICBwYXNzCisgICAgIyBUT0RPOiBhZGQg YXBwcm9wcmlhdGUgYnVpbGQtc3RlcHMgZm9yIGNvbW1pdC1xdWV1ZQpJbmRleDogVG9vbHMvQnVp bGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2xvYWRDb25maWcucHkKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2xvYWRDb25maWcucHkJKHJldmlzaW9uIDI1 Mjc3NSkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9sb2FkQ29uZmlnLnB5 CSh3b3JraW5nIGNvcHkpCkBAIC0zMCw3ICszMCw3IEBAIGZyb20gYnVpbGRib3Quc2NoZWR1bGVy cy50cnlzY2hlZCBpbXBvcnQKIGZyb20gYnVpbGRib3Qud29ya2VyIGltcG9ydCBXb3JrZXIKIGZy b20gYnVpbGRib3QudXRpbCBpbXBvcnQgaWRlbnRpZmllcnMgYXMgYnVpbGRib3RfaWRlbnRpZmll cnMKIAotZnJvbSBmYWN0b3JpZXMgaW1wb3J0IChBUElUZXN0c0ZhY3RvcnksIEJpbmRpbmdzRmFj dG9yeSwgQnVpbGRGYWN0b3J5LCBGYWN0b3J5LCBHVEtGYWN0b3J5LAorZnJvbSBmYWN0b3JpZXMg aW1wb3J0IChBUElUZXN0c0ZhY3RvcnksIEJpbmRpbmdzRmFjdG9yeSwgQnVpbGRGYWN0b3J5LCBD b21taXRRdWV1ZUZhY3RvcnksIEZhY3RvcnksIEdUS0ZhY3RvcnksCiAgICAgICAgICAgICAgICAg ICAgICAgIEpTQ1Rlc3RzRmFjdG9yeSwgU3R5bGVGYWN0b3J5LCBUZXN0RmFjdG9yeSwgV1BFRmFj dG9yeSwgV2ViS2l0UGVybEZhY3RvcnksCiAgICAgICAgICAgICAgICAgICAgICAgIFdlYktpdFB5 RmFjdG9yeSwgV2luQ2Fpcm9GYWN0b3J5LCBXaW5kb3dzRmFjdG9yeSwgaU9TQnVpbGRGYWN0b3J5 LCBpT1NUZXN0c0ZhY3RvcnksCiAgICAgICAgICAgICAgICAgICAgICAgIG1hY09TQnVpbGRGYWN0 b3J5LCBtYWNPU1dLMUZhY3RvcnksIG1hY09TV0syRmFjdG9yeSwgU2VydmljZXNGYWN0b3J5LCBX YXRjaExpc3RGYWN0b3J5KQo=