<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>204460</bug_id>
          
          <creation_ts>2019-11-21 10:55:55 -0800</creation_ts>
          <short_desc>Null check callback in NetworkConnectionToWebProcess::didDeliverMessagePortMessages</short_desc>
          <delta_ts>2019-11-22 15:15:22 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alex Christensen">achristensen</reporter>
          <assigned_to name="Alex Christensen">achristensen</assigned_to>
          <cc>cdumez</cc>
    
    <cc>mjs</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1592441</commentid>
    <comment_count>0</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2019-11-21 10:55:55 -0800</bug_when>
    <thetext>Null check callback in NetworkConnectionToWebProcess::didDeliverMessagePortMessages</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1592443</commentid>
    <comment_count>1</comment_count>
      <attachid>384072</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2019-11-21 10:56:38 -0800</bug_when>
    <thetext>Created attachment 384072
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1592483</commentid>
    <comment_count>2</comment_count>
      <attachid>384072</attachid>
    <who name="Maciej Stachowiak">mjs</who>
    <bug_when>2019-11-21 12:17:04 -0800</bug_when>
    <thetext>Comment on attachment 384072
Patch

Do we understand why the callback can be null here?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1592484</commentid>
    <comment_count>3</comment_count>
      <attachid>384072</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-11-21 12:18:28 -0800</bug_when>
    <thetext>Comment on attachment 384072
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384072&amp;action=review

&gt; Source/WebKit/ChangeLog:5
&gt; +        &lt;rdar://57448618&gt;

This does not look like a valid radar number?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1592485</commentid>
    <comment_count>4</comment_count>
      <attachid>384072</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-11-21 12:21:06 -0800</bug_when>
    <thetext>Comment on attachment 384072
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384072&amp;action=review

&gt; Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:992
&gt; +    if (auto callback = m_messageBatchDeliveryCompletionHandlers.take(messageBatchIdentifier))

This should not be possible in theory, I think we need to find the root cause.

m_messageBatchDeliveryCompletionHandlers is only modified here and in takeAllMessagesForPort(). So either we&apos;re getting an unexpected didDeliverMessagePortMessages or the NetworkConnectionToWebProcess is stale.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1592486</commentid>
    <comment_count>5</comment_count>
      <attachid>384072</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-11-21 12:23:59 -0800</bug_when>
    <thetext>Comment on attachment 384072
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384072&amp;action=review

&gt;&gt; Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:992
&gt;&gt; +    if (auto callback = m_messageBatchDeliveryCompletionHandlers.take(messageBatchIdentifier))
&gt; 
&gt; This should not be possible in theory, I think we need to find the root cause.
&gt; 
&gt; m_messageBatchDeliveryCompletionHandlers is only modified here and in takeAllMessagesForPort(). So either we&apos;re getting an unexpected didDeliverMessagePortMessages or the NetworkConnectionToWebProcess is stale.

Maybe if the network process crashes in between the takeAllMessagesForPort() call and the didDeliverMessagePortMessages() one? Then it&apos;d be a new NetworkConnectionToWebProcess. The WebProcess would send the DidDeliverMessagePortMessages IPC to the new network process, which does not know about the takeAllMessagesForPort request.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1592488</commentid>
    <comment_count>6</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-11-21 12:24:41 -0800</bug_when>
    <thetext>(In reply to Chris Dumez from comment #5)
&gt; Comment on attachment 384072 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=384072&amp;action=review
&gt; 
&gt; &gt;&gt; Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:992
&gt; &gt;&gt; +    if (auto callback = m_messageBatchDeliveryCompletionHandlers.take(messageBatchIdentifier))
&gt; &gt; 
&gt; &gt; This should not be possible in theory, I think we need to find the root cause.
&gt; &gt; 
&gt; &gt; m_messageBatchDeliveryCompletionHandlers is only modified here and in takeAllMessagesForPort(). So either we&apos;re getting an unexpected didDeliverMessagePortMessages or the NetworkConnectionToWebProcess is stale.
&gt; 
&gt; Maybe if the network process crashes in between the takeAllMessagesForPort()
&gt; call and the didDeliverMessagePortMessages() one? Then it&apos;d be a new
&gt; NetworkConnectionToWebProcess. The WebProcess would send the
&gt; DidDeliverMessagePortMessages IPC to the new network process, which does not
&gt; know about the takeAllMessagesForPort request.

If that&apos;s what&apos;s doing on, it may be possible to write a test for this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1592927</commentid>
    <comment_count>7</comment_count>
      <attachid>384072</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2019-11-22 11:35:15 -0800</bug_when>
    <thetext>Comment on attachment 384072
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384072&amp;action=review

&gt;&gt; Source/WebKit/ChangeLog:5
&gt;&gt; +        &lt;rdar://57448618&gt;
&gt; 
&gt; This does not look like a valid radar number?

I have no idea where that came from.  Should be rdar://problem/57348618 and will update.

&gt;&gt;&gt;&gt; Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:992
&gt;&gt;&gt;&gt; +    if (auto callback = m_messageBatchDeliveryCompletionHandlers.take(messageBatchIdentifier))
&gt;&gt;&gt; 
&gt;&gt;&gt; This should not be possible in theory, I think we need to find the root cause.
&gt;&gt;&gt; 
&gt;&gt;&gt; m_messageBatchDeliveryCompletionHandlers is only modified here and in takeAllMessagesForPort(). So either we&apos;re getting an unexpected didDeliverMessagePortMessages or the NetworkConnectionToWebProcess is stale.
&gt;&gt; 
&gt;&gt; Maybe if the network process crashes in between the takeAllMessagesForPort() call and the didDeliverMessagePortMessages() one? Then it&apos;d be a new NetworkConnectionToWebProcess. The WebProcess would send the DidDeliverMessagePortMessages IPC to the new network process, which does not know about the takeAllMessagesForPort request.
&gt; 
&gt; If that&apos;s what&apos;s doing on, it may be possible to write a test for this.

I think that&apos;s what&apos;s going on and that was mentioned in https://bugs.webkit.org/show_bug.cgi?id=201299#c4 , but there doesn&apos;t seem to be a good way to call _terminateNetworkProcess exactly between these two calls.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1592938</commentid>
    <comment_count>8</comment_count>
      <attachid>384072</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-11-22 11:59:33 -0800</bug_when>
    <thetext>Comment on attachment 384072
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384072&amp;action=review

&gt;&gt;&gt;&gt;&gt; Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:992
&gt;&gt;&gt;&gt;&gt; +    if (auto callback = m_messageBatchDeliveryCompletionHandlers.take(messageBatchIdentifier))
&gt;&gt;&gt;&gt; 
&gt;&gt;&gt;&gt; This should not be possible in theory, I think we need to find the root cause.
&gt;&gt;&gt;&gt; 
&gt;&gt;&gt;&gt; m_messageBatchDeliveryCompletionHandlers is only modified here and in takeAllMessagesForPort(). So either we&apos;re getting an unexpected didDeliverMessagePortMessages or the NetworkConnectionToWebProcess is stale.
&gt;&gt;&gt; 
&gt;&gt;&gt; Maybe if the network process crashes in between the takeAllMessagesForPort() call and the didDeliverMessagePortMessages() one? Then it&apos;d be a new NetworkConnectionToWebProcess. The WebProcess would send the DidDeliverMessagePortMessages IPC to the new network process, which does not know about the takeAllMessagesForPort request.
&gt;&gt; 
&gt;&gt; If that&apos;s what&apos;s doing on, it may be possible to write a test for this.
&gt; 
&gt; I think that&apos;s what&apos;s going on and that was mentioned in https://bugs.webkit.org/show_bug.cgi?id=201299#c4 , but there doesn&apos;t seem to be a good way to call _terminateNetworkProcess exactly between these two calls.

Then the ChangeLog should state so. Also maybe a comment in the code indicating why this can happen.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1592959</commentid>
    <comment_count>9</comment_count>
      <attachid>384185</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2019-11-22 12:46:15 -0800</bug_when>
    <thetext>Created attachment 384185
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1593030</commentid>
    <comment_count>10</comment_count>
      <attachid>384185</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-11-22 14:53:13 -0800</bug_when>
    <thetext>Comment on attachment 384185
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384185&amp;action=review

&gt; Source/WebKit/ChangeLog:10
&gt; +        a web process may have an identifier that becomes stale.  In this case, we should not crsah again.

Typo: crash

&gt; Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:1001
&gt; +        ASSERT_NOT_REACHED();

Since we know this can happen in practice and we have a valid explanation for it, I do not think we should ASSERT.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1593031</commentid>
    <comment_count>11</comment_count>
      <attachid>384201</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2019-11-22 14:54:58 -0800</bug_when>
    <thetext>Created attachment 384201
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1593050</commentid>
    <comment_count>12</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2019-11-22 15:14:26 -0800</bug_when>
    <thetext>http://trac.webkit.org/r252809</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1593053</commentid>
    <comment_count>13</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-11-22 15:15:22 -0800</bug_when>
    <thetext>&lt;rdar://problem/57442544&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>384072</attachid>
            <date>2019-11-21 10:56:38 -0800</date>
            <delta_ts>2019-11-22 12:46:14 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-204460-20191121105638.patch</filename>
            <type>text/plain</type>
            <size>1574</size>
            <attacher name="Alex Christensen">achristensen</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL
aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTI3NDEpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv
Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE5LTExLTIxICBBbGV4IENocmlz
dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTnVsbCBjaGVjayBj
YWxsYmFjayBpbiBOZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzczo6ZGlkRGVsaXZlck1lc3Nh
Z2VQb3J0TWVzc2FnZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTIwNDQ2MAorICAgICAgICA8cmRhcjovLzU3NDQ4NjE4PgorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvTmV0d29y
a0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3MuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrQ29u
bmVjdGlvblRvV2ViUHJvY2Vzczo6ZGlkRGVsaXZlck1lc3NhZ2VQb3J0TWVzc2FnZXMpOgorCiAy
MDE5LTExLTIwICBDaGFuZ1Nlb2sgT2ggIDxjaGFuZ3Nlb2tAd2Via2l0Lm9yZz4KIAogICAgICAg
ICBbR1RLXSBBZGQgQU5HTEUgYmFja2VuZCB0byBHVEsgcG9ydApJbmRleDogU291cmNlL1dlYktp
dC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzcy5jcHAKPT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PQotLS0gU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrQ29ubmVjdGlvblRv
V2ViUHJvY2Vzcy5jcHAJKHJldmlzaW9uIDI1MTgxMykKKysrIFNvdXJjZS9XZWJLaXQvTmV0d29y
a1Byb2Nlc3MvTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3MuY3BwCSh3b3JraW5nIGNvcHkp
CkBAIC05ODksOSArOTg5LDggQEAgdm9pZCBOZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzczo6
dGFrZQogCiB2b2lkIE5ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzOjpkaWREZWxpdmVyTWVz
c2FnZVBvcnRNZXNzYWdlcyh1aW50NjRfdCBtZXNzYWdlQmF0Y2hJZGVudGlmaWVyKQogewotICAg
IGF1dG8gY2FsbGJhY2sgPSBtX21lc3NhZ2VCYXRjaERlbGl2ZXJ5Q29tcGxldGlvbkhhbmRsZXJz
LnRha2UobWVzc2FnZUJhdGNoSWRlbnRpZmllcik7Ci0gICAgQVNTRVJUKGNhbGxiYWNrKTsKLSAg
ICBjYWxsYmFjaygpOworICAgIGlmIChhdXRvIGNhbGxiYWNrID0gbV9tZXNzYWdlQmF0Y2hEZWxp
dmVyeUNvbXBsZXRpb25IYW5kbGVycy50YWtlKG1lc3NhZ2VCYXRjaElkZW50aWZpZXIpKQorICAg
ICAgICBjYWxsYmFjaygpOwogfQogCiB2b2lkIE5ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNz
Ojpwb3N0TWVzc2FnZVRvUmVtb3RlKE1lc3NhZ2VXaXRoTWVzc2FnZVBvcnRzJiYgbWVzc2FnZSwg
Y29uc3QgTWVzc2FnZVBvcnRJZGVudGlmaWVyJiBwb3J0KQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>384185</attachid>
            <date>2019-11-22 12:46:15 -0800</date>
            <delta_ts>2019-11-22 14:54:57 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-204460-20191122124614.patch</filename>
            <type>text/plain</type>
            <size>2128</size>
            <attacher name="Alex Christensen">achristensen</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL
aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTI3OTMpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv
Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE5LTExLTIyICBBbGV4IENocmlz
dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTnVsbCBjaGVjayBj
YWxsYmFjayBpbiBOZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzczo6ZGlkRGVsaXZlck1lc3Nh
Z2VQb3J0TWVzc2FnZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTIwNDQ2MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTczNDg2MTg+CisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiB0aGUgbmV0d29y
ayBwcm9jZXNzIGNyYXNoZXMgZHVyaW5nIGEgbWVzc2FnZSBwb3J0IGNvbm5lY3Rpb24gZXN0YWJs
aXNobWVudCwKKyAgICAgICAgYSB3ZWIgcHJvY2VzcyBtYXkgaGF2ZSBhbiBpZGVudGlmaWVyIHRo
YXQgYmVjb21lcyBzdGFsZS4gIEluIHRoaXMgY2FzZSwgd2Ugc2hvdWxkIG5vdCBjcnNhaCBhZ2Fp
bi4KKyAgICAgICAgTm8gdGVzdCBiZWNhdXNlIHRoaXMgb25seSBoYXBwZW5zIGR1cmluZyBhIHJh
cmUgcmFjZSBjb25kaXRpb24gYWZ0ZXIgYSBuZXR3b3JrIHByb2Nlc3MgY3Jhc2gsIGJ1dCB0aGUg
cmFkYXIgc2hvd3MgcmVjb3JkcyBvZiB0aGlzIGhhcHBlbmluZy4KKworICAgICAgICAqIE5ldHdv
cmtQcm9jZXNzL05ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdl
YktpdDo6TmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6OmRpZERlbGl2ZXJNZXNzYWdlUG9y
dE1lc3NhZ2VzKToKKwogMjAxOS0xMS0yMiAgQ29ucmFkIFNodWx0eiAgPGNvbnJhZF9zaHVsdHpA
YXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSAtW19XS1RodW1ibmFpbFZpZXcgdXNlc1NuYXBz
aG90L3NldFVzZXNTbmFwc2hvdDpdCkluZGV4OiBTb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNz
L05ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv
V2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmNwcAko
cmV2aXNpb24gMjUyNzgxKQorKysgU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3Jr
Q29ubmVjdGlvblRvV2ViUHJvY2Vzcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk5NCw5ICs5OTQs
MTEgQEAgdm9pZCBOZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzczo6dGFrZQogCiB2b2lkIE5l
dHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzOjpkaWREZWxpdmVyTWVzc2FnZVBvcnRNZXNzYWdl
cyh1aW50NjRfdCBtZXNzYWdlQmF0Y2hJZGVudGlmaWVyKQogewotICAgIGF1dG8gY2FsbGJhY2sg
PSBtX21lc3NhZ2VCYXRjaERlbGl2ZXJ5Q29tcGxldGlvbkhhbmRsZXJzLnRha2UobWVzc2FnZUJh
dGNoSWRlbnRpZmllcik7Ci0gICAgQVNTRVJUKGNhbGxiYWNrKTsKLSAgICBjYWxsYmFjaygpOwor
ICAgIC8vIE51bGwgY2hlY2sgb25seSBuZWNlc3NhcnkgZm9yIHJhcmUgY29uZGl0aW9uIHdoZXJl
IG5ldHdvcmsgcHJvY2VzcyBjcmFzaGVzIGR1cmluZyBtZXNzYWdlIHBvcnQgY29ubmVjdGlvbiBl
c3RhYmxpc2htZW50LgorICAgIGlmIChhdXRvIGNhbGxiYWNrID0gbV9tZXNzYWdlQmF0Y2hEZWxp
dmVyeUNvbXBsZXRpb25IYW5kbGVycy50YWtlKG1lc3NhZ2VCYXRjaElkZW50aWZpZXIpKQorICAg
ICAgICBjYWxsYmFjaygpOworICAgIGVsc2UKKyAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7
CiB9CiAKIHZvaWQgTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6OnBvc3RNZXNzYWdlVG9S
ZW1vdGUoTWVzc2FnZVdpdGhNZXNzYWdlUG9ydHMmJiBtZXNzYWdlLCBjb25zdCBNZXNzYWdlUG9y
dElkZW50aWZpZXImIHBvcnQpCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>384201</attachid>
            <date>2019-11-22 14:54:58 -0800</date>
            <delta_ts>2019-11-22 15:12:33 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-204460-20191122145457.patch</filename>
            <type>text/plain</type>
            <size>2047</size>
            <attacher name="Alex Christensen">achristensen</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL
aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTI3OTgpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv
Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE5LTExLTIyICBBbGV4IENocmlz
dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTnVsbCBjaGVjayBj
YWxsYmFjayBpbiBOZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzczo6ZGlkRGVsaXZlck1lc3Nh
Z2VQb3J0TWVzc2FnZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTIwNDQ2MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTczNDg2MTg+CisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiB0aGUgbmV0d29y
ayBwcm9jZXNzIGNyYXNoZXMgZHVyaW5nIGEgbWVzc2FnZSBwb3J0IGNvbm5lY3Rpb24gZXN0YWJs
aXNobWVudCwKKyAgICAgICAgYSB3ZWIgcHJvY2VzcyBtYXkgaGF2ZSBhbiBpZGVudGlmaWVyIHRo
YXQgYmVjb21lcyBzdGFsZS4gIEluIHRoaXMgY2FzZSwgd2Ugc2hvdWxkIG5vdCBjcmFzaCBhZ2Fp
bi4KKyAgICAgICAgTm8gdGVzdCBiZWNhdXNlIHRoaXMgb25seSBoYXBwZW5zIGR1cmluZyBhIHJh
cmUgcmFjZSBjb25kaXRpb24gYWZ0ZXIgYSBuZXR3b3JrIHByb2Nlc3MgY3Jhc2gsIGJ1dCB0aGUg
cmFkYXIgc2hvd3MgcmVjb3JkcyBvZiB0aGlzIGhhcHBlbmluZy4KKworICAgICAgICAqIE5ldHdv
cmtQcm9jZXNzL05ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdl
YktpdDo6TmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6OmRpZERlbGl2ZXJNZXNzYWdlUG9y
dE1lc3NhZ2VzKToKKwogMjAxOS0xMS0yMiAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNl
bkB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmVydCByMjUwNDIxCkluZGV4OiBTb3VyY2UvV2Vi
S2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmNwcAo9PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtDb25uZWN0aW9u
VG9XZWJQcm9jZXNzLmNwcAkocmV2aXNpb24gMjUyNzgxKQorKysgU291cmNlL1dlYktpdC9OZXR3
b3JrUHJvY2Vzcy9OZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzcy5jcHAJKHdvcmtpbmcgY29w
eSkKQEAgLTk5NCw5ICs5OTQsOSBAQCB2b2lkIE5ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNz
Ojp0YWtlCiAKIHZvaWQgTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6OmRpZERlbGl2ZXJN
ZXNzYWdlUG9ydE1lc3NhZ2VzKHVpbnQ2NF90IG1lc3NhZ2VCYXRjaElkZW50aWZpZXIpCiB7Ci0g
ICAgYXV0byBjYWxsYmFjayA9IG1fbWVzc2FnZUJhdGNoRGVsaXZlcnlDb21wbGV0aW9uSGFuZGxl
cnMudGFrZShtZXNzYWdlQmF0Y2hJZGVudGlmaWVyKTsKLSAgICBBU1NFUlQoY2FsbGJhY2spOwot
ICAgIGNhbGxiYWNrKCk7CisgICAgLy8gTnVsbCBjaGVjayBvbmx5IG5lY2Vzc2FyeSBmb3IgcmFy
ZSBjb25kaXRpb24gd2hlcmUgbmV0d29yayBwcm9jZXNzIGNyYXNoZXMgZHVyaW5nIG1lc3NhZ2Ug
cG9ydCBjb25uZWN0aW9uIGVzdGFibGlzaG1lbnQuCisgICAgaWYgKGF1dG8gY2FsbGJhY2sgPSBt
X21lc3NhZ2VCYXRjaERlbGl2ZXJ5Q29tcGxldGlvbkhhbmRsZXJzLnRha2UobWVzc2FnZUJhdGNo
SWRlbnRpZmllcikpCisgICAgICAgIGNhbGxiYWNrKCk7CiB9CiAKIHZvaWQgTmV0d29ya0Nvbm5l
Y3Rpb25Ub1dlYlByb2Nlc3M6OnBvc3RNZXNzYWdlVG9SZW1vdGUoTWVzc2FnZVdpdGhNZXNzYWdl
UG9ydHMmJiBtZXNzYWdlLCBjb25zdCBNZXNzYWdlUG9ydElkZW50aWZpZXImIHBvcnQpCg==
</data>
<flag name="review"
          id="400008"
          type_id="1"
          status="+"
          setter="cdumez"
    />
          </attachment>
      

    </bug>

</bugzilla>