204443 2019-11-20 22:27:56 -0800 [MSVC] Add /experimental:newLambdaProcessor switch for better C++ conformance 2020-03-20 13:43:49 -0700 1 1 1 Unclassified WebKit CMake WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=204437 P2 Normal --- 1 fujii fujii achristensen annulen ap bfulgham cdumez dbates don.olmstead esprehn+autocc ews-watchlist gyuyoung.kim kangil.han pvollan ross.kirsling ryuan.choi sergio sihui_liu oldest_to_newest 1592299 0 fujii 2019-11-20 22:27:56 -0800 [MSVC] Add /experimental:newLambdaProcessor switch for better C++ conformance MSVC has a bug of lambda capture of 'this'. It has caused compilation errors repeatedly. Bug 204437 – [MSVC] error C2039: 'weakPtrFactory': is not a member of 'WebCore::DocumentStorageAccess::requestStorageAccess::<lambda_3f2cfd7704f93d8fe19d5b5f064f8add>' Bug 187035 – [Win] 'deref': is not a member of 'WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains::<lambda_9d761a6dc12d95db7fa2d6f3f5aa26fa>' Bug 184120 – [Win] MSVC can't compile WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent r251999 /experimental:newLambdaProcessor https://docs.microsoft.com/en-us/cpp/overview/cpp-conformance-improvements?view=vs-2019#improvements_161 1592301 1 384030 fujii 2019-11-20 22:34:00 -0800 Created attachment 384030 Patch 1592302 2 fujii 2019-11-20 22:34:38 -0800 I expect this change will break Apple Win7 bots because they are still using VS2017. They should be shut down (Bug 197288 Comment 12). 1592378 3 ross.kirsling 2019-11-21 08:33:14 -0800 I've had to fix this in r250793, r240797, and r251999 as well. 1592382 4 don.olmstead 2019-11-21 08:48:49 -0800 (In reply to Ross Kirsling from comment #3) > I've had to fix this in r250793, r240797, and r251999 as well. Pretty sure the EWS caught all the compiler failures. Ignoring them is also a problem. 1592386 5 annulen 2019-11-21 08:54:31 -0800 Note that experimental lamba processor has its own conformance issues, e.g. https://developercommunity.visualstudio.com/content/problem/729465/experimentalnewlambdaprocessor-not-able-to-process.html, so if folks are ignoring EWS they still migth break MSVC with valid C++ code 1593303 6 fujii 2019-11-24 18:00:48 -0800 Using clang-cl seems an ideal solution (Bug 171618). Seems no objection for the patch? I believe the patch reduce the maintenance for WebKit developers. Anyone can review? 1593304 7 fujii 2019-11-24 18:04:14 -0800 (In reply to Ross Kirsling from comment #3) > I've had to fix this in r250793, r240797, and r251999 as well. IIUC, these changes don't need to be reverted in this patch. 1593464 8 ross.kirsling 2019-11-25 09:34:20 -0800 I don't object as long as the conformance is better, but I agree that having folks not ignore EWS is the most important regardless. 1594531 9 fujii 2019-12-02 01:59:40 -0800 review? 1594662 10 don.olmstead 2019-12-02 10:05:35 -0800 Are we really sure this is a good idea? I'd feel better if this was added to /permissive- https://docs.microsoft.com/en-us/cpp/build/reference/permissive-standards-conformance?view=vs-2019 or something along those lines 1594869 11 fujii 2019-12-02 18:04:24 -0800 Let's do that in: Bug 202842 – MSVC reports "wtf/RetainPtr.h(196): error C3861: 'CFAutorelease': identifier not found " with /permissive- on Windows 1594871 12 384030 fujii 2019-12-02 18:08:26 -0800 Comment on attachment 384030 Patch Clearing flags on attachment: 384030 Committed r253020: <https://trac.webkit.org/changeset/253020> 1594872 13 fujii 2019-12-02 18:08:30 -0800 All reviewed patches have been landed. Closing bug. 1594875 14 fujii 2019-12-02 18:25:08 -0800 (In reply to Fujii Hironori from comment #2) > I expect this change will break Apple Win7 bots because they are still using > VS2017. > They should be shut down (Bug 197288 Comment 12). This change didn't actually break the Win7 bots, but a lot of warning messages are started reporting. > cl : Command line warning D9002: ignoring unknown option '/experimental:newLambdaProcessor' [C:\cygwin\worker\win7-release-i386\build\WebKitBuild\Release\Tools\TestWebKitAPI\TestWTF.vcxproj] https://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Build%29/builds/8953 They should be shut down (Bug 197288 Comment 12). 1594962 15 fujii 2019-12-03 03:24:07 -0800 Oops. My patch breaks WinCairo bots which is using VS2019 16.0. But, /experimental:newLambdaProcessor needs VS2019 16.1 or newer. Don, can you upgrade your Docker image? 1594965 16 fujii 2019-12-03 03:27:32 -0800 Committed r253034: <https://trac.webkit.org/changeset/253034> 1594967 17 fujii 2019-12-03 03:28:27 -0800 Reverted in r253034. Reopened. 1612841 18 fujii 2020-01-29 19:59:51 -0800 WinCairo buildbot updated MSVC, and AppleWin removes Win7 bots (Bug 206702). I'm going to land the patch again by fixing clang-cl issue. 1612852 19 389225 fujii 2020-01-29 20:47:36 -0800 Created attachment 389225 Patch for landing 1612867 20 389225 fujii 2020-01-29 23:04:31 -0800 Comment on attachment 389225 Patch for landing Clearing flags on attachment: 389225 Committed r255418: <https://trac.webkit.org/changeset/255418> 1612868 21 fujii 2020-01-29 23:04:35 -0800 All reviewed patches have been landed. Closing bug. 1632257 22 fujii 2020-03-20 13:43:49 -0700 See also: Bug 209358 – [MSVC] Remove experimental lambda processor usage 384030 2019-11-20 22:34:00 -0800 2020-01-29 20:47:19 -0800 Patch bug-204443-20191121153359.patch text/plain 3625 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyNzI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTZmMTNmMjU5YTFkYTM2 YWZlZDg0YWI5NWFmZDJkYWM0MWIzNjI4Yy4uMjQ2MjExMDkzNDE3ZWE0MGZjOTQzMzcwMzk1ZjE5 ZjNkZTU5ZDE1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTExLTIwICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtNU1ZDXSBB ZGQgL2V4cGVyaW1lbnRhbDpuZXdMYW1iZGFQcm9jZXNzb3Igc3dpdGNoIGZvciBiZXR0ZXIgQysr IGNvbmZvcm1hbmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDQ0NDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGRvbS9Eb2N1bWVudFN0b3JhZ2VBY2Nlc3MuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 RG9jdW1lbnRTdG9yYWdlQWNjZXNzOjpyZXF1ZXN0U3RvcmFnZUFjY2Vzcyk6IFJldmVydGVkIE1T VkMgd29ya2Fyb3VuZCBvZiByMjUyNzI2LgorCiAyMDE5LTExLTIwICBGdWppaSBIaXJvbm9yaSAg PEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgogCiAgICAgICAgIFtNU1ZDXSBlcnJvciBDMjAzOTog J3dlYWtQdHJGYWN0b3J5JzogaXMgbm90IGEgbWVtYmVyIG9mICdXZWJDb3JlOjpEb2N1bWVudFN0 b3JhZ2VBY2Nlc3M6OnJlcXVlc3RTdG9yYWdlQWNjZXNzOjo8bGFtYmRhXzNmMmNmZDc3MDRmOTNk OGZlMTlkNWI1ZjA2NGY4YWRkPicKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1 bWVudFN0b3JhZ2VBY2Nlc3MuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50U3RvcmFn ZUFjY2Vzcy5jcHAKaW5kZXggMGY1MmQ2MDFlNjAwNDczNWUyZTAzZjQyMjZiNDU4NGQzOGYwY2Iy My4uYmU2OTQ0ZDYzOGNiYTJmMDZkNWVmZGIzZTE5ZjY5ZWIxNjRkOTczZCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50U3RvcmFnZUFjY2Vzcy5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvZG9tL0RvY3VtZW50U3RvcmFnZUFjY2Vzcy5jcHAKQEAgLTE4Miw3ICsxODIsNyBA QCB2b2lkIERvY3VtZW50U3RvcmFnZUFjY2Vzczo6cmVxdWVzdFN0b3JhZ2VBY2Nlc3MoUmVmPERl ZmVycmVkUHJvbWlzZT4mJiBwcm9taXNlKQogICAgICAgICBib29sIHNob3VsZFByZXNlcnZlVXNl ckdlc3R1cmUgPSB3YXNHcmFudGVkID09IFN0b3JhZ2VBY2Nlc3NXYXNHcmFudGVkOjpZZXMgfHwg cHJvbXB0V2FzU2hvd24gPT0gU3RvcmFnZUFjY2Vzc1Byb21wdFdhc1Nob3duOjpObzsKIAogICAg ICAgICBpZiAoc2hvdWxkUHJlc2VydmVVc2VyR2VzdHVyZSkgewotICAgICAgICAgICAgbV9kb2N1 bWVudC5ldmVudExvb3AoKS5xdWV1ZU1pY3JvdGFzayhbdGhpcywgd2Vha1RoaXMgPSBtYWtlV2Vh a1B0cigqd2Vha1RoaXMpXSB7CisgICAgICAgICAgICBtX2RvY3VtZW50LmV2ZW50TG9vcCgpLnF1 ZXVlTWljcm90YXNrKFt0aGlzLCB3ZWFrVGhpcyA9IG1ha2VXZWFrUHRyKCp0aGlzKV0gewogICAg ICAgICAgICAgICAgIGlmICh3ZWFrVGhpcykKICAgICAgICAgICAgICAgICAgICAgZW5hYmxlVGVt cG9yYXJ5VGltZVVzZXJHZXN0dXJlKCk7CiAgICAgICAgICAgICB9KTsKQEAgLTE5Nyw3ICsxOTcs NyBAQCB2b2lkIERvY3VtZW50U3RvcmFnZUFjY2Vzczo6cmVxdWVzdFN0b3JhZ2VBY2Nlc3MoUmVm PERlZmVycmVkUHJvbWlzZT4mJiBwcm9taXNlKQogICAgICAgICB9CiAKICAgICAgICAgaWYgKHNo b3VsZFByZXNlcnZlVXNlckdlc3R1cmUpIHsKLSAgICAgICAgICAgIG1fZG9jdW1lbnQuZXZlbnRM b29wKCkucXVldWVNaWNyb3Rhc2soW3RoaXMsIHdlYWtUaGlzID0gbWFrZVdlYWtQdHIoKndlYWtU aGlzKV0geworICAgICAgICAgICAgbV9kb2N1bWVudC5ldmVudExvb3AoKS5xdWV1ZU1pY3JvdGFz ayhbdGhpcywgd2Vha1RoaXMgPSBtYWtlV2Vha1B0cigqdGhpcyldIHsKICAgICAgICAgICAgICAg ICBpZiAod2Vha1RoaXMpCiAgICAgICAgICAgICAgICAgICAgIGNvbnN1bWVUZW1wb3JhcnlUaW1l VXNlckdlc3R1cmUoKTsKICAgICAgICAgICAgIH0pOwpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtl L09wdGlvbnNNU1ZDLmNtYWtlIGIvU291cmNlL2NtYWtlL09wdGlvbnNNU1ZDLmNtYWtlCmluZGV4 IGRmMmZmYjQzZjRkZDdhNTBkODBkNzg0NTIwNTgxMGRlOTAzZGZhMGQuLjVmOGE5YjIxMjg1ZmM4 OGY1NzJhNTFhM2UwMTZhYzA2ZTM5MzE0NTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zTVNWQy5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc01TVkMuY21ha2UKQEAgLTI5 LDYgKzI5LDkgQEAgZW5kaWYgKCkKICMgU3BlY2lmeSB0aGUgc291cmNlIGNvZGUgZW5jb2RpbmcK IGFkZF9jb21waWxlX29wdGlvbnMoL3V0Zi04IC92YWxpZGF0ZS1jaGFyc2V0KQogCisjIEVuYWJs ZSB0aGUgbmV3IGxhbWJkYSBwcm9jZXNzb3IgZm9yIGJldHRlciBDKysgY29uZm9ybWFuY2Ugd2l0 aCAvc3RkOmMrKzE3CithZGRfY29tcGlsZV9vcHRpb25zKC9leHBlcmltZW50YWw6bmV3TGFtYmRh UHJvY2Vzc29yKQorCiBpZiAoJHtDTUFLRV9CVUlMRF9UWVBFfSBNQVRDSEVTICJEZWJ1ZyIpCiAg ICAgc2V0KENNQUtFX1NIQVJFRF9MSU5LRVJfRkxBR1MgIiR7Q01BS0VfU0hBUkVEX0xJTktFUl9G TEFHU30gL09QVDpOT1JFRiAvT1BUOk5PSUNGIikKICAgICBzZXQoQ01BS0VfRVhFX0xJTktFUl9G TEFHUyAiJHtDTUFLRV9FWEVfTElOS0VSX0ZMQUdTfSAvT1BUOk5PUkVGIC9PUFQ6Tk9JQ0YiKQpk aWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDMwOWFmMTkyNTEwYWFhNTdm OGFmYjRlMjkzMzIyNjY4OTUwNDQwNzAuLjc1OGU4NzU5NjYwNGY3NWM4NjQ2ODk4MDUyNTUwMjFm YzE2ODY0ZTMgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNSBAQAorMjAxOS0xMS0yMCAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBzb255 LmNvbT4KKworICAgICAgICBbTVNWQ10gQWRkIC9leHBlcmltZW50YWw6bmV3TGFtYmRhUHJvY2Vz c29yIHN3aXRjaCBmb3IgYmV0dGVyIEMrKyBjb25mb3JtYW5jZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0NDQzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTVNWQyBoYXMgYSBidWcgb2YgbGFtYmRhIGNh cHR1cmUgb2YgJ3RoaXMnLiBJdCBoYXMgY2F1c2VkCisgICAgICAgIGNvbXBpbGF0aW9uIGVycm9y cyByZXBlYXRlZGx5LgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNNU1ZDLmNtYWtl OiBBZGRlZCAvZXhwZXJpbWVudGFsOm5ld0xhbWJkYVByb2Nlc3NvciBzd2l0Y2guCisKIDIwMTkt MTEtMjAgIENoYW5nU2VvayBPaCAgPGNoYW5nc2Vva0B3ZWJraXQub3JnPgogCiAgICAgICAgIFtH VEtdIEFkZCBBTkdMRSBiYWNrZW5kIHRvIEdUSyBwb3J0Cg== 389225 2020-01-29 20:47:36 -0800 2020-01-29 20:47:36 -0800 Patch for landing bug-204443-20200130134735.patch text/plain 3597 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1NDEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTM3N2I0NWFhZjhjODNm NWU0MjM2YjFjZTg1MzE3Mjc4NzUzNzUxOS4uN2MyMDk0NDA0MGYyOTVmNjEzYjVhMzRjMzM4NjIx YjcwNTEyMjgwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIwLTAxLTI5ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtNU1ZDXSBB ZGQgL2V4cGVyaW1lbnRhbDpuZXdMYW1iZGFQcm9jZXNzb3Igc3dpdGNoIGZvciBiZXR0ZXIgQysr IGNvbmZvcm1hbmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDQ0NDMKKworICAgICAgICBSZXZpZXdlZCBieSBBbGV4IENocmlzdGVuc2VuLgorCisg ICAgICAgICogZG9tL0RvY3VtZW50U3RvcmFnZUFjY2Vzcy5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpEb2N1bWVudFN0b3JhZ2VBY2Nlc3M6OnJlcXVlc3RTdG9yYWdlQWNjZXNzKTogUmV2ZXJ0ZWQg TVNWQyB3b3JrYXJvdW5kIG9mIHIyNTI3MjYuCisKIDIwMjAtMDEtMjkgIFJvYmluIE1vcmlzc2V0 ICA8cm1vcmlzc2V0QGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgT3B0aW9uczo6ZW5hYmxl U3BlY3RyZU1pdGlnYXRpb25zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1l bnRTdG9yYWdlQWNjZXNzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudFN0b3JhZ2VB Y2Nlc3MuY3BwCmluZGV4IDBmNTJkNjAxZTYwMDQ3MzVlMmUwM2Y0MjI2YjQ1ODRkMzhmMGNiMjMu LmJlNjk0NGQ2MzhjYmEyZjA2ZDVlZmRiM2UxOWY2OWViMTY0ZDk3M2QgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudFN0b3JhZ2VBY2Nlc3MuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9Eb2N1bWVudFN0b3JhZ2VBY2Nlc3MuY3BwCkBAIC0xODIsNyArMTgyLDcgQEAg dm9pZCBEb2N1bWVudFN0b3JhZ2VBY2Nlc3M6OnJlcXVlc3RTdG9yYWdlQWNjZXNzKFJlZjxEZWZl cnJlZFByb21pc2U+JiYgcHJvbWlzZSkKICAgICAgICAgYm9vbCBzaG91bGRQcmVzZXJ2ZVVzZXJH ZXN0dXJlID0gd2FzR3JhbnRlZCA9PSBTdG9yYWdlQWNjZXNzV2FzR3JhbnRlZDo6WWVzIHx8IHBy b21wdFdhc1Nob3duID09IFN0b3JhZ2VBY2Nlc3NQcm9tcHRXYXNTaG93bjo6Tm87CiAKICAgICAg ICAgaWYgKHNob3VsZFByZXNlcnZlVXNlckdlc3R1cmUpIHsKLSAgICAgICAgICAgIG1fZG9jdW1l bnQuZXZlbnRMb29wKCkucXVldWVNaWNyb3Rhc2soW3RoaXMsIHdlYWtUaGlzID0gbWFrZVdlYWtQ dHIoKndlYWtUaGlzKV0geworICAgICAgICAgICAgbV9kb2N1bWVudC5ldmVudExvb3AoKS5xdWV1 ZU1pY3JvdGFzayhbdGhpcywgd2Vha1RoaXMgPSBtYWtlV2Vha1B0cigqdGhpcyldIHsKICAgICAg ICAgICAgICAgICBpZiAod2Vha1RoaXMpCiAgICAgICAgICAgICAgICAgICAgIGVuYWJsZVRlbXBv cmFyeVRpbWVVc2VyR2VzdHVyZSgpOwogICAgICAgICAgICAgfSk7CkBAIC0xOTcsNyArMTk3LDcg QEAgdm9pZCBEb2N1bWVudFN0b3JhZ2VBY2Nlc3M6OnJlcXVlc3RTdG9yYWdlQWNjZXNzKFJlZjxE ZWZlcnJlZFByb21pc2U+JiYgcHJvbWlzZSkKICAgICAgICAgfQogCiAgICAgICAgIGlmIChzaG91 bGRQcmVzZXJ2ZVVzZXJHZXN0dXJlKSB7Ci0gICAgICAgICAgICBtX2RvY3VtZW50LmV2ZW50TG9v cCgpLnF1ZXVlTWljcm90YXNrKFt0aGlzLCB3ZWFrVGhpcyA9IG1ha2VXZWFrUHRyKCp3ZWFrVGhp cyldIHsKKyAgICAgICAgICAgIG1fZG9jdW1lbnQuZXZlbnRMb29wKCkucXVldWVNaWNyb3Rhc2so W3RoaXMsIHdlYWtUaGlzID0gbWFrZVdlYWtQdHIoKnRoaXMpXSB7CiAgICAgICAgICAgICAgICAg aWYgKHdlYWtUaGlzKQogICAgICAgICAgICAgICAgICAgICBjb25zdW1lVGVtcG9yYXJ5VGltZVVz ZXJHZXN0dXJlKCk7CiAgICAgICAgICAgICB9KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9P cHRpb25zTVNWQy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zTVNWQy5jbWFrZQppbmRleCBk ZjJmZmI0M2Y0ZGQ3YTUwZDgwZDc4NDUyMDU4MTBkZTkwM2RmYTBkLi5mNGZhMzJhYmQwMmIxYTU0 N2QzOTVmNTI4N2I3MDlkYzU5OTFhNzg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9u c01TVkMuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNNU1ZDLmNtYWtlCkBAIC0yOSw2 ICsyOSwxMSBAQCBlbmRpZiAoKQogIyBTcGVjaWZ5IHRoZSBzb3VyY2UgY29kZSBlbmNvZGluZwog YWRkX2NvbXBpbGVfb3B0aW9ucygvdXRmLTggL3ZhbGlkYXRlLWNoYXJzZXQpCiAKKyMgRW5hYmxl IHRoZSBuZXcgbGFtYmRhIHByb2Nlc3NvciBmb3IgYmV0dGVyIEMrKyBjb25mb3JtYW5jZSB3aXRo IC9zdGQ6YysrMTcKK2lmIChOT1QgQ09NUElMRVJfSVNfQ0xBTkdfQ0wpCisgICAgYWRkX2NvbXBp bGVfb3B0aW9ucygvZXhwZXJpbWVudGFsOm5ld0xhbWJkYVByb2Nlc3NvcikKK2VuZGlmICgpCisK IGlmICgke0NNQUtFX0JVSUxEX1RZUEV9IE1BVENIRVMgIkRlYnVnIikKICAgICBzZXQoQ01BS0Vf U0hBUkVEX0xJTktFUl9GTEFHUyAiJHtDTUFLRV9TSEFSRURfTElOS0VSX0ZMQUdTfSAvT1BUOk5P UkVGIC9PUFQ6Tk9JQ0YiKQogICAgIHNldChDTUFLRV9FWEVfTElOS0VSX0ZMQUdTICIke0NNQUtF X0VYRV9MSU5LRVJfRkxBR1N9IC9PUFQ6Tk9SRUYgL09QVDpOT0lDRiIpCmRpZmYgLS1naXQgYS9D aGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggMGI2ODE4YWM0OWY0MGIyMzNmNzg4NDM1MTdjMjlj ODdhNGEzOTY1My4uNzI4YTE5Mzk5NWVhNzUxMGQxMjRiOTljMzA5ZDBlYWU3Mjg0MDY4NiAxMDA2 NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIw LTAxLTI5ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAg ICAgIFtNU1ZDXSBBZGQgL2V4cGVyaW1lbnRhbDpuZXdMYW1iZGFQcm9jZXNzb3Igc3dpdGNoIGZv ciBiZXR0ZXIgQysrIGNvbmZvcm1hbmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMDQ0NDMKKworICAgICAgICBSZXZpZXdlZCBieSBBbGV4IENocmlz dGVuc2VuLgorCisgICAgICAgIE1TVkMgaGFzIGEgYnVnIG9mICd0aGlzJyBpbiBsYW1iZGEgY2Fw dHVyZXMuIEl0IGhhcyBjYXVzZWQKKyAgICAgICAgY29tcGlsYXRpb24gZXJyb3JzIHJlcGVhdGVk bHkuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc01TVkMuY21ha2U6IEFkZGVkIC9l eHBlcmltZW50YWw6bmV3TGFtYmRhUHJvY2Vzc29yIHN3aXRjaC4KKwogMjAyMC0wMS0yOSAgU3Rl cGhhbiBTemFibyAgPHN0ZXBoYW4uc3phYm9Ac29ueS5jb20+CiAKICAgICAgICAgW1BsYXlTdGF0 aW9uXSBBbGxvdyBzZXR0aW5nIENNQUtFX0lHTk9SRV9QQVRIIGZyb20gZW52aXJvbm1lbnQgZm9y IGJvdHMK