<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>204267</bug_id>
          
          <creation_ts>2019-11-15 17:40:30 -0800</creation_ts>
          <short_desc>REGRESSION (r252497): Multiple mediacapturefromelement tests are crashing on mac debug</short_desc>
          <delta_ts>2019-11-18 10:28:10 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>204232</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Aakash Jain">aakash_jain</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>achristensen</cc>
    
    <cc>ap</cc>
    
    <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dbates</cc>
    
    <cc>eric.carlson</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>ggaren</cc>
    
    <cc>glenn</cc>
    
    <cc>hta</cc>
    
    <cc>jbedard</cc>
    
    <cc>jer.noble</cc>
    
    <cc>kangil.han</cc>
    
    <cc>philipj</cc>
    
    <cc>rniwa</cc>
    
    <cc>sergio</cc>
    
    <cc>tommyw</cc>
    
    <cc>tsavell</cc>
    
    <cc>webkit-bot-watchers-bugzilla</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1590783</commentid>
    <comment_count>0</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2019-11-15 17:40:30 -0800</bug_when>
    <thetext>Multiple mediacapturefromelement tests are crashing on mac debug (mojave, high-sierra, Catalina), e.g.:

fast/mediacapturefromelement/CanvasCaptureMediaStream-2d-events.html
fast/mediacapturefromelement/CanvasCaptureMediaStream-clone-track.html
fast/mediacapturefromelement/CanvasCaptureMediaStream-creation.html


Build: https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK1%20(Tests)/r252500%20(6925)/results.html

Flakiness dashboard:
https://results.webkit.org/?suite=layout-tests&amp;suite=layout-tests&amp;suite=layout-tests&amp;test=fast%2Fmediacapturefromelement%2FCanvasCaptureMediaStream-clone-track.html&amp;test=fast%2Fmediacapturefromelement%2FCanvasCaptureMediaStream-creation.html&amp;test=http%2Fwpt%2Fmediarecorder%2FMediaRecorder-AV-audio-video-dataavailable.html


Seems to be regression between r252500 and r252497. Probably https://trac.webkit.org/changeset/252500/webkit</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1590798</commentid>
    <comment_count>1</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2019-11-15 19:00:56 -0800</bug_when>
    <thetext>Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.JavaScriptCore      	0x000000010bca5db0 WTFCrash + 16 (Assertions.cpp:305)
1   com.apple.WebCore             	0x000000011bb76b3b WTFCrashWithInfo(int, char const*, char const*, int) + 27
2   com.apple.WebCore             	0x000000011de910f8 WebCore::ActiveDOMObject::assertSuspendIfNeededWasCalled() const + 104 (ActiveDOMObject.cpp:102)
3   com.apple.WebCore             	0x000000011e0db9b4 WebCore::ScriptExecutionContext::checkConsistency() const + 820
4   com.apple.WebCore             	0x000000011e0dc9e0 WebCore::ScriptExecutionContext::canSuspendActiveDOMObjectsForDocumentSuspension(WTF::Vector&lt;WebCore::ActiveDOMObject*, 0ul, WTF::CrashOnOverflow, 16ul&gt;*) + 32 (ScriptExecutionContext.cpp:227)
5   com.apple.WebCore             	0x000000011e2cc050 WebCore::canCacheFrame(WebCore::Frame&amp;, WebCore::DiagnosticLoggingClient&amp;, unsigned int) + 3504 (BackForwardCache.cpp:165)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1590799</commentid>
    <comment_count>2</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-11-15 19:02:04 -0800</bug_when>
    <thetext>&lt;rdar://problem/57248130&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1590800</commentid>
    <comment_count>3</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-11-15 19:09:01 -0800</bug_when>
    <thetext>Looks like somebody forgot to call SuspendIfNeeded() for an ActiveDOMObject.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1590803</commentid>
    <comment_count>4</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-11-15 19:10:07 -0800</bug_when>
    <thetext>(In reply to Aakash Jain from comment #0)
&gt; Multiple mediacapturefromelement tests are crashing on mac debug (mojave,
&gt; high-sierra, Catalina), e.g.:
&gt; 
&gt; fast/mediacapturefromelement/CanvasCaptureMediaStream-2d-events.html
&gt; fast/mediacapturefromelement/CanvasCaptureMediaStream-clone-track.html
&gt; fast/mediacapturefromelement/CanvasCaptureMediaStream-creation.html
&gt; 
&gt; 
&gt; Build:
&gt; https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK1%20(Tests)/
&gt; r252500%20(6925)/results.html
&gt; 
&gt; Flakiness dashboard:
&gt; https://results.webkit.org/?suite=layout-tests&amp;suite=layout-
&gt; tests&amp;suite=layout-
&gt; tests&amp;test=fast%2Fmediacapturefromelement%2FCanvasCaptureMediaStream-clone-
&gt; track.html&amp;test=fast%2Fmediacapturefromelement%2FCanvasCaptureMediaStream-
&gt; creation.html&amp;test=http%2Fwpt%2Fmediarecorder%2FMediaRecorder-AV-audio-video-
&gt; dataavailable.html
&gt; 
&gt; 
&gt; Seems to be regression between r252500 and r252497. Probably
&gt; https://trac.webkit.org/changeset/252500/webkit

It cannot be https://trac.webkit.org/changeset/252500/webkit</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1590804</commentid>
    <comment_count>5</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2019-11-15 19:11:06 -0800</bug_when>
    <thetext>Actually, this is almost certainly r252497. Which was itself a fix for assertion failures.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1590805</commentid>
    <comment_count>6</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-11-15 19:12:03 -0800</bug_when>
    <thetext>(In reply to Alexey Proskuryakov from comment #5)
&gt; Actually, this is almost certainly r252497. Which was itself a fix for
&gt; assertion failures.

Looking now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1590806</commentid>
    <comment_count>7</comment_count>
      <attachid>383680</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-11-15 19:15:13 -0800</bug_when>
    <thetext>Created attachment 383680
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1590807</commentid>
    <comment_count>8</comment_count>
      <attachid>383681</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-11-15 19:17:44 -0800</bug_when>
    <thetext>Created attachment 383681
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1590833</commentid>
    <comment_count>9</comment_count>
      <attachid>383681</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-11-15 21:45:20 -0800</bug_when>
    <thetext>Comment on attachment 383681
Patch

Clearing flags on attachment: 383681

Committed r252524: &lt;https://trac.webkit.org/changeset/252524&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1590834</commentid>
    <comment_count>10</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-11-15 21:45:21 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1591059</commentid>
    <comment_count>11</comment_count>
    <who name="Truitt Savell">tsavell</who>
    <bug_when>2019-11-18 08:34:01 -0800</bug_when>
    <thetext>It looks like fast/mediacapturefromelement/CanvasCaptureMediaStream-creation.html
and fast/mediacapturefromelement/CanvasCaptureMediaStream-clone-track.html are still crashing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1591060</commentid>
    <comment_count>12</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-11-18 08:34:34 -0800</bug_when>
    <thetext>(In reply to Truitt Savell from comment #11)
&gt; It looks like
&gt; fast/mediacapturefromelement/CanvasCaptureMediaStream-creation.html
&gt; and fast/mediacapturefromelement/CanvasCaptureMediaStream-clone-track.html
&gt; are still crashing

Odd, will look now although it would help to get a link.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1591061</commentid>
    <comment_count>13</comment_count>
    <who name="Truitt Savell">tsavell</who>
    <bug_when>2019-11-18 08:37:01 -0800</bug_when>
    <thetext>history: https://results.webkit.org/?suite=layout-tests&amp;suite=layout-tests&amp;test=fast%2Fmediacapturefromelement%2FCanvasCaptureMediaStream-clone-track.html&amp;test=fast%2Fmediacapturefromelement%2FCanvasCaptureMediaStream-creation.html

Run with crashes: https://build.webkit.org/results/Apple-Catalina-Debug-WK2-Tests/r252541%20(707)/results.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1591062</commentid>
    <comment_count>14</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-11-18 08:37:24 -0800</bug_when>
    <thetext>(In reply to Chris Dumez from comment #12)
&gt; (In reply to Truitt Savell from comment #11)
&gt; &gt; It looks like
&gt; &gt; fast/mediacapturefromelement/CanvasCaptureMediaStream-creation.html
&gt; &gt; and fast/mediacapturefromelement/CanvasCaptureMediaStream-clone-track.html
&gt; &gt; are still crashing
&gt; 
&gt; Odd, will look now although it would help to get a link.

I can reproduce the crash for fast/mediacapturefromelement/CanvasCaptureMediaStream-creation.html and will get a fix shortly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1591063</commentid>
    <comment_count>15</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-11-18 08:45:13 -0800</bug_when>
    <thetext>Reopening for follow-up fix.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1591064</commentid>
    <comment_count>16</comment_count>
      <attachid>383751</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-11-18 08:47:30 -0800</bug_when>
    <thetext>Created attachment 383751
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1591083</commentid>
    <comment_count>17</comment_count>
      <attachid>383751</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-11-18 09:34:41 -0800</bug_when>
    <thetext>Comment on attachment 383751
Patch

Clearing flags on attachment: 383751

Committed r252545: &lt;https://trac.webkit.org/changeset/252545&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1591084</commentid>
    <comment_count>18</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-11-18 09:34:43 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>383680</attachid>
            <date>2019-11-15 19:15:13 -0800</date>
            <delta_ts>2019-11-15 19:17:42 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-204267-20191115191510.patch</filename>
            <type>text/plain</type>
            <size>2122</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyNTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzliYTkzMjRhYjg5Njg1
NGVkM2VjNzBiYTFjYTA3ZDQ0YTIzNWEwNy4uZDFiNTY4NmRlYWExYWFmZjE5ODk5MTIxZGU2YjY1
ZDY2ZjhiMzdlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTExLTE1ICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI1MjQ5
Nyk6IE11bHRpcGxlIG1lZGlhY2FwdHVyZWZyb21lbGVtZW50IHRlc3RzIGFyZSBjcmFzaGluZyBv
biBtYWMgZGVidWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTIwNDI2NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTcyNDgxMzA+CisKKyAgICAgICAg
UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBzdXJlIHRoZSBDYW52
YXNDYXB0dXJlTWVkaWFTdHJlYW1UcmFjayBmYWN0b3J5IGZ1bmN0aW9uIGNhbGxzIHN1c3BlbmRJ
Zk5lZWRlZCgpCisgICAgICAgIHNpbmNlIHRoZSBjbGFzcyBpbmhlaGl0cyBBY3RpdmVET01PYmpl
Y3QuCisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc3RyZWFtL0NhbnZhc0NhcHR1cmVNZWRpYVN0
cmVhbVRyYWNrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNhbnZhc0NhcHR1cmVNZWRpYVN0cmVh
bVRyYWNrOjpjcmVhdGUpOgorCiAyMDE5LTExLTE1ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhm
aWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgW0FwcGxlXSBFbmFibGUgdmFyaWF0aW9uIGZvbnRz
IG9uIGFsbCBBcHBsZSBwbGF0Zm9ybXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVs
ZXMvbWVkaWFzdHJlYW0vQ2FudmFzQ2FwdHVyZU1lZGlhU3RyZWFtVHJhY2suY3BwIGIvU291cmNl
L1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9DYW52YXNDYXB0dXJlTWVkaWFTdHJlYW1UcmFj
ay5jcHAKaW5kZXggMmU5YmVmZTRlYjUxNWEwZjAxYTQ2ZGNmZTMwOGRjMDlmZDM1NzFkMi4uOTlk
NTFiOGNlZGNkOTQzMDE4YjBhNjczMTVmODJkMTI4NWQ1ZmNiNyAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9DYW52YXNDYXB0dXJlTWVkaWFTdHJlYW1UcmFj
ay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9DYW52YXNDYXB0
dXJlTWVkaWFTdHJlYW1UcmFjay5jcHAKQEAgLTM5LDcgKzM5LDkgQEAgV1RGX01BS0VfSVNPX0FM
TE9DQVRFRF9JTVBMKENhbnZhc0NhcHR1cmVNZWRpYVN0cmVhbVRyYWNrKTsKIFJlZjxDYW52YXND
YXB0dXJlTWVkaWFTdHJlYW1UcmFjaz4gQ2FudmFzQ2FwdHVyZU1lZGlhU3RyZWFtVHJhY2s6OmNy
ZWF0ZShEb2N1bWVudCYgZG9jdW1lbnQsIFJlZjxIVE1MQ2FudmFzRWxlbWVudD4mJiBjYW52YXMs
IE9wdGlvbmFsPGRvdWJsZT4mJiBmcmFtZVJlcXVlc3RSYXRlKQogewogICAgIGF1dG8gc291cmNl
ID0gQ2FudmFzQ2FwdHVyZU1lZGlhU3RyZWFtVHJhY2s6OlNvdXJjZTo6Y3JlYXRlKGNhbnZhcy5n
ZXQoKSwgV1RGTW92ZShmcmFtZVJlcXVlc3RSYXRlKSk7Ci0gICAgcmV0dXJuIGFkb3B0UmVmKCpu
ZXcgQ2FudmFzQ2FwdHVyZU1lZGlhU3RyZWFtVHJhY2soZG9jdW1lbnQsIFdURk1vdmUoY2FudmFz
KSwgV1RGTW92ZShzb3VyY2UpKSk7CisgICAgYXV0byB0cmFjayA9IGFkb3B0UmVmKCpuZXcgQ2Fu
dmFzQ2FwdHVyZU1lZGlhU3RyZWFtVHJhY2soZG9jdW1lbnQsIFdURk1vdmUoY2FudmFzKSwgV1RG
TW92ZShzb3VyY2UpKSk7CisgICAgdHJhY2stPnN1c3BlbmRJZk5lZWRlZCgpOworICAgIHJldHVy
biB0cmFjaygpOwogfQogCiBDYW52YXNDYXB0dXJlTWVkaWFTdHJlYW1UcmFjazo6Q2FudmFzQ2Fw
dHVyZU1lZGlhU3RyZWFtVHJhY2soRG9jdW1lbnQmIGRvY3VtZW50LCBSZWY8SFRNTENhbnZhc0Vs
ZW1lbnQ+JiYgY2FudmFzLCBSZWY8Q2FudmFzQ2FwdHVyZU1lZGlhU3RyZWFtVHJhY2s6OlNvdXJj
ZT4mJiBzb3VyY2UpCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>383681</attachid>
            <date>2019-11-15 19:17:44 -0800</date>
            <delta_ts>2019-11-18 08:47:29 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-204267-20191115191741.patch</filename>
            <type>text/plain</type>
            <size>2125</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyNTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzliYTkzMjRhYjg5Njg1
NGVkM2VjNzBiYTFjYTA3ZDQ0YTIzNWEwNy4uNTU4ZmEwZjU0OGFhNTQwMjQ3YjI2ZjVmNWMzYzc5
ZGIwYjUzNGJlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTExLTE1ICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI1MjQ5
Nyk6IE11bHRpcGxlIG1lZGlhY2FwdHVyZWZyb21lbGVtZW50IHRlc3RzIGFyZSBjcmFzaGluZyBv
biBtYWMgZGVidWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTIwNDI2NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTcyNDgxMzA+CisKKyAgICAgICAg
UmV2aWV3ZWQgYnkgQWxleGV5IFByb3NrdXJ5YWtvdi4KKworICAgICAgICBNYWtlIHN1cmUgdGhl
IENhbnZhc0NhcHR1cmVNZWRpYVN0cmVhbVRyYWNrIGZhY3RvcnkgZnVuY3Rpb24gY2FsbHMgc3Vz
cGVuZElmTmVlZGVkKCkKKyAgICAgICAgc2luY2UgdGhlIGNsYXNzIGluaGVoaXRzIEFjdGl2ZURP
TU9iamVjdC4KKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0vQ2FudmFzQ2FwdHVyZU1l
ZGlhU3RyZWFtVHJhY2suY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2FudmFzQ2FwdHVyZU1lZGlh
U3RyZWFtVHJhY2s6OmNyZWF0ZSk6CisKIDIwMTktMTEtMTUgIE15bGVzIEMuIE1heGZpZWxkICA8
bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAgICBbQXBwbGVdIEVuYWJsZSB2YXJpYXRpb24g
Zm9udHMgb24gYWxsIEFwcGxlIHBsYXRmb3JtcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv
TW9kdWxlcy9tZWRpYXN0cmVhbS9DYW52YXNDYXB0dXJlTWVkaWFTdHJlYW1UcmFjay5jcHAgYi9T
b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL0NhbnZhc0NhcHR1cmVNZWRpYVN0cmVh
bVRyYWNrLmNwcAppbmRleCAyZTliZWZlNGViNTE1YTBmMDFhNDZkY2ZlMzA4ZGMwOWZkMzU3MWQy
Li4yYzVhZDhjOTJjYzY4ZTJiZDZhMGU0YzdiMDc4ODkwZjU2NWUwM2FlIDEwMDY0NAotLS0gYS9T
b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL0NhbnZhc0NhcHR1cmVNZWRpYVN0cmVh
bVRyYWNrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL0NhbnZh
c0NhcHR1cmVNZWRpYVN0cmVhbVRyYWNrLmNwcApAQCAtMzksNyArMzksOSBAQCBXVEZfTUFLRV9J
U09fQUxMT0NBVEVEX0lNUEwoQ2FudmFzQ2FwdHVyZU1lZGlhU3RyZWFtVHJhY2spOwogUmVmPENh
bnZhc0NhcHR1cmVNZWRpYVN0cmVhbVRyYWNrPiBDYW52YXNDYXB0dXJlTWVkaWFTdHJlYW1UcmFj
azo6Y3JlYXRlKERvY3VtZW50JiBkb2N1bWVudCwgUmVmPEhUTUxDYW52YXNFbGVtZW50PiYmIGNh
bnZhcywgT3B0aW9uYWw8ZG91YmxlPiYmIGZyYW1lUmVxdWVzdFJhdGUpCiB7CiAgICAgYXV0byBz
b3VyY2UgPSBDYW52YXNDYXB0dXJlTWVkaWFTdHJlYW1UcmFjazo6U291cmNlOjpjcmVhdGUoY2Fu
dmFzLmdldCgpLCBXVEZNb3ZlKGZyYW1lUmVxdWVzdFJhdGUpKTsKLSAgICByZXR1cm4gYWRvcHRS
ZWYoKm5ldyBDYW52YXNDYXB0dXJlTWVkaWFTdHJlYW1UcmFjayhkb2N1bWVudCwgV1RGTW92ZShj
YW52YXMpLCBXVEZNb3ZlKHNvdXJjZSkpKTsKKyAgICBhdXRvIHRyYWNrID0gYWRvcHRSZWYoKm5l
dyBDYW52YXNDYXB0dXJlTWVkaWFTdHJlYW1UcmFjayhkb2N1bWVudCwgV1RGTW92ZShjYW52YXMp
LCBXVEZNb3ZlKHNvdXJjZSkpKTsKKyAgICB0cmFjay0+c3VzcGVuZElmTmVlZGVkKCk7CisgICAg
cmV0dXJuIHRyYWNrOwogfQogCiBDYW52YXNDYXB0dXJlTWVkaWFTdHJlYW1UcmFjazo6Q2FudmFz
Q2FwdHVyZU1lZGlhU3RyZWFtVHJhY2soRG9jdW1lbnQmIGRvY3VtZW50LCBSZWY8SFRNTENhbnZh
c0VsZW1lbnQ+JiYgY2FudmFzLCBSZWY8Q2FudmFzQ2FwdHVyZU1lZGlhU3RyZWFtVHJhY2s6OlNv
dXJjZT4mJiBzb3VyY2UpCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>383751</attachid>
            <date>2019-11-18 08:47:30 -0800</date>
            <delta_ts>2019-11-18 09:34:41 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-204267-20191118084730.patch</filename>
            <type>text/plain</type>
            <size>4716</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyNTQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDJiNzEyYzQwMDc2Zjg2
YmE2NTA3NjNjNmM5MTQwZTQ1ODMyZTQ3OS4uMDRiYmRmNzc1NjljMGZlZDk0MDZhOWJlMDAwZGRi
ZTFhODc2ODc2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE5LTExLTE4ICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI1MjQ5
Nyk6IE11bHRpcGxlIG1lZGlhY2FwdHVyZWZyb21lbGVtZW50IHRlc3RzIGFyZSBjcmFzaGluZyBv
biBtYWMgZGVidWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTIwNDI2NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTcyNDgxMzA+CisKKyAgICAgICAg
UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBjb3Zl
cmVkIGJ5IGZhc3QvbWVkaWFjYXB0dXJlZnJvbWVsZW1lbnQvQ2FudmFzQ2FwdHVyZU1lZGlhU3Ry
ZWFtLWNyZWF0aW9uLmh0bWwuCisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc3RyZWFtL0NhbnZh
c0NhcHR1cmVNZWRpYVN0cmVhbVRyYWNrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNhbnZhc0Nh
cHR1cmVNZWRpYVN0cmVhbVRyYWNrOjphY3RpdmVET01PYmplY3ROYW1lIGNvbnN0KToKKyAgICAg
ICAgKFdlYkNvcmU6OkNhbnZhc0NhcHR1cmVNZWRpYVN0cmVhbVRyYWNrOjpjbG9uZSk6CisgICAg
ICAgIFdlIHdlcmUgZmFpbGluZyB0byBjYWxsIHN1c3BlbmRJZk5lZWRlZCgpIG9uIHRoZSB0cmFj
ayBhZnRlciBjb25zdHJ1Y3RpbmcgaXQuCisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc3RyZWFt
L0NhbnZhc0NhcHR1cmVNZWRpYVN0cmVhbVRyYWNrLmg6CisgICAgICAgICogTW9kdWxlcy9tZWRp
YXN0cmVhbS9NZWRpYVN0cmVhbVRyYWNrLmg6CisKKyAgICAgICAgKiBkb20vQWN0aXZlRE9NT2Jq
ZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFjdGl2ZURPTU9iamVjdDo6YXNzZXJ0U3VzcGVu
ZElmTmVlZGVkV2FzQ2FsbGVkIGNvbnN0KToKKyAgICAgICAgQWRkIGxvZ2dpbmcgd2hlbiB0aGUg
c3VzcGVuZElmTmVlZGVkIGFzc2VydGlvbiBmYWlscyB0byBmYWNpbGl0YXRlIGRlYnVnZ2luZyBz
dWNoIGlzc3VlcworICAgICAgICBpbiB0aGUgZnV0dXJlLgorCiAyMDE5LTExLTE4ICBQaGlsaXBw
ZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBm
aXggYnVpbGQgKGFnYWluKSBmb3IgYTExeSBkaXNhYmxlZCwgYWZ0ZXIgcjI1MjQxNy4KZGlmZiAt
LWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vQ2FudmFzQ2FwdHVyZU1l
ZGlhU3RyZWFtVHJhY2suY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9D
YW52YXNDYXB0dXJlTWVkaWFTdHJlYW1UcmFjay5jcHAKaW5kZXggMmM1YWQ4YzkyY2M2OGUyYmQ2
YTBlNGM3YjA3ODg5MGY1NjVlMDNhZS4uZTliZjRjODE3NzMyMGZkMTYwMGM4Y2JjNzE1ZTQ4NzE4
YjQwYzJiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9D
YW52YXNDYXB0dXJlTWVkaWFTdHJlYW1UcmFjay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9k
dWxlcy9tZWRpYXN0cmVhbS9DYW52YXNDYXB0dXJlTWVkaWFTdHJlYW1UcmFjay5jcHAKQEAgLTY5
LDYgKzY5LDExIEBAIFJlZjxDYW52YXNDYXB0dXJlTWVkaWFTdHJlYW1UcmFjazo6U291cmNlPiBD
YW52YXNDYXB0dXJlTWVkaWFTdHJlYW1UcmFjazo6U291cmNlCiAgICAgcmV0dXJuIHNvdXJjZTsK
IH0KIAorY29uc3QgY2hhciogQ2FudmFzQ2FwdHVyZU1lZGlhU3RyZWFtVHJhY2s6OmFjdGl2ZURP
TU9iamVjdE5hbWUoKSBjb25zdAoreworICAgIHJldHVybiAiQ2FudmFzQ2FwdHVyZU1lZGlhU3Ry
ZWFtVHJhY2siOworfQorCiAvLyBGSVhNRTogR2l2ZSBzb3VyY2UgaWQgYW5kIG5hbWUKIENhbnZh
c0NhcHR1cmVNZWRpYVN0cmVhbVRyYWNrOjpTb3VyY2U6OlNvdXJjZShIVE1MQ2FudmFzRWxlbWVu
dCYgY2FudmFzLCBPcHRpb25hbDxkb3VibGU+JiYgZnJhbWVSZXF1ZXN0UmF0ZSkKICAgICA6IFJl
YWx0aW1lTWVkaWFTb3VyY2UoVHlwZTo6VmlkZW8sICJDYW52YXNDYXB0dXJlTWVkaWFTdHJlYW1U
cmFjayJfcykKQEAgLTE5NSw3ICsyMDAsOSBAQCBSZWZQdHI8TWVkaWFTdHJlYW1UcmFjaz4gQ2Fu
dmFzQ2FwdHVyZU1lZGlhU3RyZWFtVHJhY2s6OmNsb25lKCkKICAgICBpZiAoIXNjcmlwdEV4ZWN1
dGlvbkNvbnRleHQoKSkKICAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAgICAgCi0gICAgcmV0dXJu
IGFkb3B0UmVmKCpuZXcgQ2FudmFzQ2FwdHVyZU1lZGlhU3RyZWFtVHJhY2soZG93bmNhc3Q8RG9j
dW1lbnQ+KCpzY3JpcHRFeGVjdXRpb25Db250ZXh0KCkpLCBtX2NhbnZhcy5jb3B5UmVmKCksIG1f
cHJpdmF0ZS0+Y2xvbmUoKSkpOworICAgIGF1dG8gdHJhY2sgPSBhZG9wdFJlZigqbmV3IENhbnZh
c0NhcHR1cmVNZWRpYVN0cmVhbVRyYWNrKGRvd25jYXN0PERvY3VtZW50Pigqc2NyaXB0RXhlY3V0
aW9uQ29udGV4dCgpKSwgbV9jYW52YXMuY29weVJlZigpLCBtX3ByaXZhdGUtPmNsb25lKCkpKTsK
KyAgICB0cmFjay0+c3VzcGVuZElmTmVlZGVkKCk7CisgICAgcmV0dXJuIHRyYWNrOwogfQogCiB9
CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL0NhbnZhc0Nh
cHR1cmVNZWRpYVN0cmVhbVRyYWNrLmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3Ry
ZWFtL0NhbnZhc0NhcHR1cmVNZWRpYVN0cmVhbVRyYWNrLmgKaW5kZXggYzg2NTlmZjc4MWQ3Mjc2
MTIyMjcwNmJjY2E1NjNkMTczMGFlODM4YS4uZTJiOWNmM2UwOTRhZWEyYTgyNTliMDY3YmRlZDQy
Nzk2OTc0MTg0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVh
bS9DYW52YXNDYXB0dXJlTWVkaWFTdHJlYW1UcmFjay5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01v
ZHVsZXMvbWVkaWFzdHJlYW0vQ2FudmFzQ2FwdHVyZU1lZGlhU3RyZWFtVHJhY2suaApAQCAtNDgs
NiArNDgsOCBAQCBwdWJsaWM6CiAgICAgUmVmUHRyPE1lZGlhU3RyZWFtVHJhY2s+IGNsb25lKCkg
ZmluYWw7CiAKIHByaXZhdGU6CisgICAgY29uc3QgY2hhciogYWN0aXZlRE9NT2JqZWN0TmFtZSgp
IGNvbnN0IG92ZXJyaWRlOworCiAgICAgY2xhc3MgU291cmNlIGZpbmFsIDogcHVibGljIFJlYWx0
aW1lTWVkaWFTb3VyY2UsIHByaXZhdGUgQ2FudmFzT2JzZXJ2ZXIgewogICAgIHB1YmxpYzoKICAg
ICAgICAgc3RhdGljIFJlZjxTb3VyY2U+IGNyZWF0ZShIVE1MQ2FudmFzRWxlbWVudCYsIE9wdGlv
bmFsPGRvdWJsZT4mJiBmcmFtZVJlcXVlc3RSYXRlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD
b3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW1UcmFjay5oIGIvU291cmNlL1dlYkNv
cmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbVRyYWNrLmgKaW5kZXggZjU4MDQxZjI0
YmJmZDhmNGVjZmExMWJjYjViNTBiYzMyODgwNTYxOS4uYjEyOThlMTRmZTQwZmMyYTgxYTE4ZTMx
OWYwMDg0NmZiNzI4YjFiYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRp
YXN0cmVhbS9NZWRpYVN0cmVhbVRyYWNrLmgKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9t
ZWRpYXN0cmVhbS9NZWRpYVN0cmVhbVRyYWNrLmgKQEAgLTE3Niw3ICsxNzYsNyBAQCBwcml2YXRl
OgogCiAgICAgLy8gQWN0aXZlRE9NT2JqZWN0IEFQSS4KICAgICB2b2lkIHN0b3AoKSBmaW5hbDsK
LSAgICBjb25zdCBjaGFyKiBhY3RpdmVET01PYmplY3ROYW1lKCkgY29uc3QgZmluYWw7CisgICAg
Y29uc3QgY2hhciogYWN0aXZlRE9NT2JqZWN0TmFtZSgpIGNvbnN0IG92ZXJyaWRlOwogICAgIHZv
aWQgc3VzcGVuZChSZWFzb25Gb3JTdXNwZW5zaW9uKSBmaW5hbDsKIAogICAgIC8vIEV2ZW50VGFy
Z2V0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vQWN0aXZlRE9NT2JqZWN0LmNwcCBi
L1NvdXJjZS9XZWJDb3JlL2RvbS9BY3RpdmVET01PYmplY3QuY3BwCmluZGV4IDRmNzA4NDhlNGQ5
OWNhMzlkYmFhZjEwYzNlZWZkMjg4MmQwNTUxNzQuLjBhOGU4YTFlODg2OTE0NGIwYzJmYmY2MjVj
MjJkZmQzZTM0M2FkNzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9BY3RpdmVET01P
YmplY3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9BY3RpdmVET01PYmplY3QuY3BwCkBA
IC05OSw2ICs5OSwxMCBAQCB2b2lkIEFjdGl2ZURPTU9iamVjdDo6c3VzcGVuZElmTmVlZGVkKCkK
IAogdm9pZCBBY3RpdmVET01PYmplY3Q6OmFzc2VydFN1c3BlbmRJZk5lZWRlZFdhc0NhbGxlZCgp
IGNvbnN0CiB7CisjaWYgIUFTU0VSVF9ESVNBQkxFRAorICAgIGlmICghbV9zdXNwZW5kSWZOZWVk
ZWRXYXNDYWxsZWQpCisgICAgICAgIFdURkxvZ0Fsd2F5cygiRmFpbGVkIHRvIGNhbGwgc3VzcGVu
ZElmTmVlZGVkKCkgZm9yICVzIiwgYWN0aXZlRE9NT2JqZWN0TmFtZSgpKTsKKyNlbmRpZgogICAg
IEFTU0VSVChtX3N1c3BlbmRJZk5lZWRlZFdhc0NhbGxlZCk7CiB9CiAK
</data>

          </attachment>
      

    </bug>

</bugzilla>