204183 2019-11-13 17:47:10 -0800 webkitpy: Clarify webkitpy/style/optparser_unittest.py by removing parse variables 2019-11-14 07:00:23 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=203761 InRadar P2 Normal --- 1 jbedard jbedard commit-queue ews-watchlist glenn slewis webkit-bug-importer oldest_to_newest 1590139 0 jbedard 2019-11-13 17:47:10 -0800 There is not good reason to define a lambda pointing to a member function of the class running tests. 1590143 1 383530 jbedard 2019-11-13 17:51:19 -0800 Created attachment 383530 Patch 1590240 2 383530 commit-queue 2019-11-14 06:59:02 -0800 Comment on attachment 383530 Patch Clearing flags on attachment: 383530 Committed r252456: <https://trac.webkit.org/changeset/252456> 1590241 3 commit-queue 2019-11-14 06:59:04 -0800 All reviewed patches have been landed. Closing bug. 1590242 4 webkit-bug-importer 2019-11-14 07:00:23 -0800 <rdar://problem/57189381> 383530 2019-11-13 17:51:19 -0800 2019-11-14 06:59:02 -0800 Patch bug-204183-20191113175118.patch text/plain 6655 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MjQ0MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE5LTExLTEzICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogQ2xhcmlmeSB3ZWJraXRweS9zdHlsZS9vcHRwYXJzZXJf dW5pdHRlc3QucHkgYnkgcmVtb3ZpbmcgcGFyc2UgdmFyaWFibGVzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQxODMKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUv b3B0cGFyc2VyX3VuaXR0ZXN0LnB5OgorICAgICAgICAoQXJndW1lbnRQYXJzZXJUZXN0LnRlc3Rf cGFyc2VfZG9jdW1lbnRhdGlvbik6IFJlbW92ZSBwYXJzZSB2YXJpYWJsZS4KKyAgICAgICAgKEFy Z3VtZW50UGFyc2VyVGVzdC50ZXN0X3BhcnNlX2JhZF92YWx1ZXMpOiBEaXR0by4KKyAgICAgICAg KEFyZ3VtZW50UGFyc2VyVGVzdC50ZXN0X3BhcnNlX2RlZmF1bHRfYXJndW1lbnRzKTogRGl0dG8u CisgICAgICAgIChBcmd1bWVudFBhcnNlclRlc3QudGVzdF9wYXJzZV9leHBsaWNpdF9hcmd1bWVu dHMpOiBEaXR0by4KKyAgICAgICAgKEFyZ3VtZW50UGFyc2VyVGVzdC50ZXN0X3BhcnNlX2ZpbGVz KTogRGl0dG8uCisKIDIwMTktMTEtMTMgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUu Y29tPgogCiAgICAgICAgIFB5dGhvbiAzOiBBZGQgc3VwcG9ydCBpbiB3ZWJraXRweS5zdHlsZS5j aGVja2VycwpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9vcHRwYXJzZXJfdW5p dHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9vcHRw YXJzZXJfdW5pdHRlc3QucHkJKHJldmlzaW9uIDI1MjQ0MCkKKysrIFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvc3R5bGUvb3B0cGFyc2VyX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC05Nyw1 MCArOTcsNDQgQEAgY2xhc3MgQXJndW1lbnRQYXJzZXJUZXN0KExvZ2dpbmdUZXN0Q2FzZQogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgdXNhZ2U9InRlc3QgdXNhZ2UiKQogCiAgICAgZGVm IHRlc3RfcGFyc2VfZG9jdW1lbnRhdGlvbihzZWxmKToKLSAgICAgICAgcGFyc2UgPSBzZWxmLl9w YXJzZQotCiAgICAgICAgICMgRklYTUU6IFRlc3QgYm90aCB0aGUgcHJpbnRpbmcgb2YgdGhlIHVz YWdlIHN0cmluZyBhbmQgdGhlCiAgICAgICAgICMgICAgICAgIGZpbHRlciBjYXRlZ29yaWVzIGhl bHAuCiAKICAgICAgICAgIyBSZXF1ZXN0IHRoZSB1c2FnZSBzdHJpbmcuCi0gICAgICAgIHNlbGYu YXNzZXJ0UmFpc2VzKFN5c3RlbUV4aXQsIHBhcnNlLCBbJy0taGVscCddKQorICAgICAgICBzZWxm LmFzc2VydFJhaXNlcyhTeXN0ZW1FeGl0LCBzZWxmLl9wYXJzZSwgWyctLWhlbHAnXSkKICAgICAg ICAgIyBSZXF1ZXN0IGRlZmF1bHQgZmlsdGVyIHJ1bGVzIGFuZCBhdmFpbGFibGUgc3R5bGUgY2F0 ZWdvcmllcy4KLSAgICAgICAgc2VsZi5hc3NlcnRSYWlzZXMoU3lzdGVtRXhpdCwgcGFyc2UsIFsn LS1maWx0ZXI9J10pCisgICAgICAgIHNlbGYuYXNzZXJ0UmFpc2VzKFN5c3RlbUV4aXQsIHNlbGYu X3BhcnNlLCBbJy0tZmlsdGVyPSddKQogCiAgICAgZGVmIHRlc3RfcGFyc2VfYmFkX3ZhbHVlcyhz ZWxmKToKLSAgICAgICAgcGFyc2UgPSBzZWxmLl9wYXJzZQotCiAgICAgICAgICMgUGFzcyBhbiB1 bnN1cHBvcnRlZCBhcmd1bWVudC4KLSAgICAgICAgc2VsZi5hc3NlcnRSYWlzZXMoU3lzdGVtRXhp dCwgcGFyc2UsIFsnLS1iYWQnXSkKKyAgICAgICAgc2VsZi5hc3NlcnRSYWlzZXMoU3lzdGVtRXhp dCwgc2VsZi5fcGFyc2UsIFsnLS1iYWQnXSkKICAgICAgICAgc2VsZi5hc3NlcnRMb2coWydFUlJP Ujogbm8gc3VjaCBvcHRpb246IC0tYmFkXG4nXSkKIAotICAgICAgICBzZWxmLmFzc2VydFJhaXNl cyhTeXN0ZW1FeGl0LCBwYXJzZSwgWyctLW1pbi1jb25maWRlbmNlPWJhZCddKQorICAgICAgICBz ZWxmLmFzc2VydFJhaXNlcyhTeXN0ZW1FeGl0LCBzZWxmLl9wYXJzZSwgWyctLW1pbi1jb25maWRl bmNlPWJhZCddKQogICAgICAgICBzZWxmLmFzc2VydExvZyhbJ0VSUk9SOiBvcHRpb24gLS1taW4t Y29uZmlkZW5jZTogJwogICAgICAgICAgICAgICAgICAgICAgICAgImludmFsaWQgaW50ZWdlciB2 YWx1ZTogJ2JhZCdcbiJdKQotICAgICAgICBzZWxmLmFzc2VydFJhaXNlcyhTeXN0ZW1FeGl0LCBw YXJzZSwgWyctLW1pbi1jb25maWRlbmNlPTAnXSkKKyAgICAgICAgc2VsZi5hc3NlcnRSYWlzZXMo U3lzdGVtRXhpdCwgc2VsZi5fcGFyc2UsIFsnLS1taW4tY29uZmlkZW5jZT0wJ10pCiAgICAgICAg IHNlbGYuYXNzZXJ0TG9nKFsnRVJST1I6IG9wdGlvbiAtLW1pbi1jb25maWRlbmNlOiBpbnZhbGlk IGludGVnZXI6IDA6ICcKICAgICAgICAgICAgICAgICAgICAgICAgICd2YWx1ZSBtdXN0IGJlIGJl dHdlZW4gMSBhbmQgNVxuJ10pCi0gICAgICAgIHNlbGYuYXNzZXJ0UmFpc2VzKFN5c3RlbUV4aXQs IHBhcnNlLCBbJy0tbWluLWNvbmZpZGVuY2U9NiddKQorICAgICAgICBzZWxmLmFzc2VydFJhaXNl cyhTeXN0ZW1FeGl0LCBzZWxmLl9wYXJzZSwgWyctLW1pbi1jb25maWRlbmNlPTYnXSkKICAgICAg ICAgc2VsZi5hc3NlcnRMb2coWydFUlJPUjogb3B0aW9uIC0tbWluLWNvbmZpZGVuY2U6IGludmFs aWQgaW50ZWdlcjogNjogJwogICAgICAgICAgICAgICAgICAgICAgICAgJ3ZhbHVlIG11c3QgYmUg YmV0d2VlbiAxIGFuZCA1XG4nXSkKLSAgICAgICAgcGFyc2UoWyctLW1pbi1jb25maWRlbmNlPTEn XSkgICMgd29ya3MKLSAgICAgICAgcGFyc2UoWyctLW1pbi1jb25maWRlbmNlPTUnXSkgICMgd29y a3MKKyAgICAgICAgc2VsZi5fcGFyc2UoWyctLW1pbi1jb25maWRlbmNlPTEnXSkgICMgd29ya3MK KyAgICAgICAgc2VsZi5fcGFyc2UoWyctLW1pbi1jb25maWRlbmNlPTUnXSkgICMgd29ya3MKIAot ICAgICAgICBzZWxmLmFzc2VydFJhaXNlcyhTeXN0ZW1FeGl0LCBwYXJzZSwgWyctLW91dHB1dD1i YWQnXSkKKyAgICAgICAgc2VsZi5hc3NlcnRSYWlzZXMoU3lzdGVtRXhpdCwgc2VsZi5fcGFyc2Us IFsnLS1vdXRwdXQ9YmFkJ10pCiAgICAgICAgIHNlbGYuYXNzZXJ0TG9nKFsnRVJST1I6IG9wdGlv biAtLW91dHB1dC1mb3JtYXQ6IGludmFsaWQgY2hvaWNlOiAnCiAgICAgICAgICAgICAgICAgICAg ICAgICAiJ2JhZCcgKGNob29zZSBmcm9tICdlbWFjcycsICd2czcnKVxuIl0pCi0gICAgICAgIHBh cnNlKFsnLS1vdXRwdXQ9dnM3J10pICAjIHdvcmtzCisgICAgICAgIHNlbGYuX3BhcnNlKFsnLS1v dXRwdXQ9dnM3J10pICAjIHdvcmtzCiAKICAgICAgICAgIyBQYXNzIGEgZmlsdGVyIHJ1bGUgbm90 IGJlZ2lubmluZyB3aXRoICsgb3IgLS4KLSAgICAgICAgc2VsZi5hc3NlcnRSYWlzZXMoU3lzdGVt RXhpdCwgcGFyc2UsIFsnLS1maWx0ZXI9YnVpbGQnXSkKKyAgICAgICAgc2VsZi5hc3NlcnRSYWlz ZXMoU3lzdGVtRXhpdCwgc2VsZi5fcGFyc2UsIFsnLS1maWx0ZXI9YnVpbGQnXSkKICAgICAgICAg c2VsZi5hc3NlcnRMb2coWydFUlJPUjogSW52YWxpZCBmaWx0ZXIgcnVsZSAiYnVpbGQiOiAnCiAg ICAgICAgICAgICAgICAgICAgICAgICAnZXZlcnkgcnVsZSBtdXN0IHN0YXJ0IHdpdGggKyBvciAt LlxuJ10pCi0gICAgICAgIHBhcnNlKFsnLS1maWx0ZXI9K2J1aWxkJ10pICAjIHdvcmtzCisgICAg ICAgIHNlbGYuX3BhcnNlKFsnLS1maWx0ZXI9K2J1aWxkJ10pICAjIHdvcmtzCiAKICAgICBkZWYg dGVzdF9wYXJzZV9kZWZhdWx0X2FyZ3VtZW50cyhzZWxmKToKLSAgICAgICAgcGFyc2UgPSBzZWxm Ll9wYXJzZQotCi0gICAgICAgIChmaWxlcywgb3B0aW9ucykgPSBwYXJzZShbXSkKKyAgICAgICAg KGZpbGVzLCBvcHRpb25zKSA9IHNlbGYuX3BhcnNlKFtdKQogCiAgICAgICAgIHNlbGYuYXNzZXJ0 RXF1YWwoZmlsZXMsIFtdKQogCkBAIC0xNTIsNDIgKzE0NiwzOCBAQCBjbGFzcyBBcmd1bWVudFBh cnNlclRlc3QoTG9nZ2luZ1Rlc3RDYXNlCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwob3B0aW9u cy5vdXRwdXRfZm9ybWF0LCAndnM3JykKIAogICAgIGRlZiB0ZXN0X3BhcnNlX2V4cGxpY2l0X2Fy Z3VtZW50cyhzZWxmKToKLSAgICAgICAgcGFyc2UgPSBzZWxmLl9wYXJzZQotCiAgICAgICAgICMg UGFzcyBub24tZGVmYXVsdCBleHBsaWNpdCB2YWx1ZXMuCi0gICAgICAgIChmaWxlcywgb3B0aW9u cykgPSBwYXJzZShbJy0tbWluLWNvbmZpZGVuY2U9NCddKQorICAgICAgICAoZmlsZXMsIG9wdGlv bnMpID0gc2VsZi5fcGFyc2UoWyctLW1pbi1jb25maWRlbmNlPTQnXSkKICAgICAgICAgc2VsZi5h c3NlcnRFcXVhbChvcHRpb25zLm1pbl9jb25maWRlbmNlLCA0KQotICAgICAgICAoZmlsZXMsIG9w dGlvbnMpID0gcGFyc2UoWyctLW91dHB1dD1lbWFjcyddKQorICAgICAgICAoZmlsZXMsIG9wdGlv bnMpID0gc2VsZi5fcGFyc2UoWyctLW91dHB1dD1lbWFjcyddKQogICAgICAgICBzZWxmLmFzc2Vy dEVxdWFsKG9wdGlvbnMub3V0cHV0X2Zvcm1hdCwgJ2VtYWNzJykKLSAgICAgICAgKGZpbGVzLCBv cHRpb25zKSA9IHBhcnNlKFsnLWcnLCAnY29tbWl0J10pCisgICAgICAgIChmaWxlcywgb3B0aW9u cykgPSBzZWxmLl9wYXJzZShbJy1nJywgJ2NvbW1pdCddKQogICAgICAgICBzZWxmLmFzc2VydEVx dWFsKG9wdGlvbnMuZ2l0X2NvbW1pdCwgJ2NvbW1pdCcpCi0gICAgICAgIChmaWxlcywgb3B0aW9u cykgPSBwYXJzZShbJy0tZ2l0LWNvbW1pdD1jb21taXQnXSkKKyAgICAgICAgKGZpbGVzLCBvcHRp b25zKSA9IHNlbGYuX3BhcnNlKFsnLS1naXQtY29tbWl0PWNvbW1pdCddKQogICAgICAgICBzZWxm LmFzc2VydEVxdWFsKG9wdGlvbnMuZ2l0X2NvbW1pdCwgJ2NvbW1pdCcpCi0gICAgICAgIChmaWxl cywgb3B0aW9ucykgPSBwYXJzZShbJy0tZ2l0LWRpZmY9Y29tbWl0J10pCisgICAgICAgIChmaWxl cywgb3B0aW9ucykgPSBzZWxmLl9wYXJzZShbJy0tZ2l0LWRpZmY9Y29tbWl0J10pCiAgICAgICAg IHNlbGYuYXNzZXJ0RXF1YWwob3B0aW9ucy5naXRfY29tbWl0LCAnY29tbWl0JykKLSAgICAgICAg KGZpbGVzLCBvcHRpb25zKSA9IHBhcnNlKFsnLS12ZXJib3NlJ10pCisgICAgICAgIChmaWxlcywg b3B0aW9ucykgPSBzZWxmLl9wYXJzZShbJy0tdmVyYm9zZSddKQogICAgICAgICBzZWxmLmFzc2Vy dFRydWUob3B0aW9ucy5pc192ZXJib3NlKQotICAgICAgICAoZmlsZXMsIG9wdGlvbnMpID0gcGFy c2UoWyctLWRpZmYtZmlsZXMnLCAnZmlsZS50eHQnXSkKKyAgICAgICAgKGZpbGVzLCBvcHRpb25z KSA9IHNlbGYuX3BhcnNlKFsnLS1kaWZmLWZpbGVzJywgJ2ZpbGUudHh0J10pCiAgICAgICAgIHNl bGYuYXNzZXJ0VHJ1ZShvcHRpb25zLmRpZmZfZmlsZXMpCiAKICAgICAgICAgIyBQYXNzIHVzZXJf cnVsZXMuCi0gICAgICAgIChmaWxlcywgb3B0aW9ucykgPSBwYXJzZShbJy0tZmlsdGVyPStidWls ZCwtd2hpdGVzcGFjZSddKQorICAgICAgICAoZmlsZXMsIG9wdGlvbnMpID0gc2VsZi5fcGFyc2Uo WyctLWZpbHRlcj0rYnVpbGQsLXdoaXRlc3BhY2UnXSkKICAgICAgICAgc2VsZi5hc3NlcnRFcXVh bChvcHRpb25zLmZpbHRlcl9ydWxlcywKICAgICAgICAgICAgICAgICAgICAgICAgICAgWyIrYnVp bGQiLCAiLXdoaXRlc3BhY2UiXSkKIAogICAgICAgICAjIFBhc3Mgc3B1cmlvdXMgd2hpdGUgc3Bh Y2UgaW4gdXNlciBydWxlcy4KLSAgICAgICAgKGZpbGVzLCBvcHRpb25zKSA9IHBhcnNlKFsnLS1m aWx0ZXI9K2J1aWxkLCAtd2hpdGVzcGFjZSddKQorICAgICAgICAoZmlsZXMsIG9wdGlvbnMpID0g c2VsZi5fcGFyc2UoWyctLWZpbHRlcj0rYnVpbGQsIC13aGl0ZXNwYWNlJ10pCiAgICAgICAgIHNl bGYuYXNzZXJ0RXF1YWwob3B0aW9ucy5maWx0ZXJfcnVsZXMsCiAgICAgICAgICAgICAgICAgICAg ICAgICAgIFsiK2J1aWxkIiwgIi13aGl0ZXNwYWNlIl0pCiAKICAgICBkZWYgdGVzdF9wYXJzZV9m aWxlcyhzZWxmKToKLSAgICAgICAgcGFyc2UgPSBzZWxmLl9wYXJzZQotCi0gICAgICAgIChmaWxl cywgb3B0aW9ucykgPSBwYXJzZShbJ2Zvby5jcHAnXSkKKyAgICAgICAgKGZpbGVzLCBvcHRpb25z KSA9IHNlbGYuX3BhcnNlKFsnZm9vLmNwcCddKQogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKGZp bGVzLCBbJ2Zvby5jcHAnXSkKIAogICAgICAgICAjIFBhc3MgbXVsdGlwbGUgZmlsZXMuCi0gICAg ICAgIChmaWxlcywgb3B0aW9ucykgPSBwYXJzZShbJy0tb3V0cHV0PWVtYWNzJywgJ2Zvby5jcHAn LCAnYmFyLmNwcCddKQorICAgICAgICAoZmlsZXMsIG9wdGlvbnMpID0gc2VsZi5fcGFyc2UoWyct LW91dHB1dD1lbWFjcycsICdmb28uY3BwJywgJ2Jhci5jcHAnXSkKICAgICAgICAgc2VsZi5hc3Nl cnRFcXVhbChmaWxlcywgWydmb28uY3BwJywgJ2Jhci5jcHAnXSkKIAogCg==