204099 2019-11-11 19:00:40 -0800 [LFC] InlineFormattingState::addInlineRun should take a unique_ptr<Display::Run> 2019-11-12 17:08:17 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1589436 0 zalan 2019-11-11 19:00:40 -0800 instead of a const Display::Run and create a unique_ptr right away. 1589437 1 webkit-bug-importer 2019-11-11 19:01:31 -0800 <rdar://problem/57102586> 1589440 2 383331 zalan 2019-11-11 19:04:19 -0800 Created attachment 383331 Patch 1589710 3 commit-queue 2019-11-12 17:07:36 -0800 The commit-queue encountered the following flaky tests while processing attachment 383331: inspector/model/remote-object-weak-collection.html bug 202932 (authors: drousso@apple.com and joepeck@webkit.org) The commit-queue is continuing to process your patch. 1589711 4 383331 commit-queue 2019-11-12 17:08:15 -0800 Comment on attachment 383331 Patch Clearing flags on attachment: 383331 Committed r252380: <https://trac.webkit.org/changeset/252380> 1589712 5 commit-queue 2019-11-12 17:08:17 -0800 All reviewed patches have been landed. Closing bug. 383331 2019-11-11 19:04:19 -0800 2019-11-12 17:08:15 -0800 Patch bug-204099-20191111190406.patch text/plain 3373 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyMzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTM3NDk3ZWM3M2M4ZDY2 Y2YzNjk5NzBkMjZlZmIyMjkyNjYwZGYwYy4uY2NjMDBmZmY4ZTgwNzUzM2I5NGVjNzg1ZWYwOTIw ZGU0NTlhOTMwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTExLTExICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ10gSW5saW5lRm9ybWF0 dGluZ1N0YXRlOjphZGRJbmxpbmVSdW4gc2hvdWxkIHRha2UgYSB1bmlxdWVfcHRyPERpc3BsYXk6 OlJ1bj4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw NDA5OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTcxMDI1ODY+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQncyByYXRoZXIgd2FzdGVmdWwgdG8g Y3JlYXRlIGEgRGlzcGxheTo6UnVuIGp1c3QgdG8gcGFzcyBpdCBpbiB0byBJbmxpbmVGb3JtYXR0 aW5nU3RhdGU6OmFkZElubGluZVJ1bi4KKworICAgICAgICAqIGxheW91dC9pbmxpbmVmb3JtYXR0 aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91 dDo6SW5saW5lRm9ybWF0dGluZ0NvbnRleHQ6OnNldERpc3BsYXlCb3hlc0ZvckxpbmUpOgorICAg ICAgICAqIGxheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdTdGF0ZS5oOgor ICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpJbmxpbmVGb3JtYXR0aW5nU3RhdGU6OmFkZElubGlu ZVJ1bik6CisKIDIwMTktMTEtMTEgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAog ICAgICAgICBbTEZDXVtJRkNdIExpbmU6Om1fdHJpbW1hYmxlUnVucyBkb2VzIG5vdCBuZWVkIHRv IGJlIGEgTGlzdEhhc2hTZXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxp bmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0LmNwcAppbmRl eCA2NmFiMTdhN2MyNzk0ODI0MmQ2ZGM5NzQ3ZTUyNDU3ZTlmMGE4ZDgxLi43MzkxYjI3Y2YzZTRl NWQ3MzgzOTUwNzc3ZDg0NDlmMzViNGM0ZDY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9s YXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29udGV4dC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0Nv bnRleHQuY3BwCkBAIC00MzgsNyArNDM4LDcgQEAgdm9pZCBJbmxpbmVGb3JtYXR0aW5nQ29udGV4 dDo6c2V0RGlzcGxheUJveGVzRm9yTGluZShjb25zdCBMaW5lTGF5b3V0OjpMaW5lQ29udGUKICAg ICAgICAgLy8gQ29tcGxldGVseSBjb2xsYXBzZWQgbGluZSBydW5zIGRvbid0IGdlbmVyYXRlIGRp c3BsYXkgcnVucyBlaXRoZXIuCiAgICAgICAgIGlmIChsaW5lUnVuLmlzQ29sbGFwc2VkVG9WaXN1 YWxseUVtcHR5KCkpCiAgICAgICAgICAgICBjb250aW51ZTsKLSAgICAgICAgZm9ybWF0dGluZ1N0 YXRlLmFkZElubGluZVJ1bih7IGxpbmVSdW4ubGF5b3V0Qm94KCkuc3R5bGUoKSwgbGluZVJ1bi5s b2dpY2FsUmVjdCgpLCBsaW5lUnVuLnRleHRDb250ZXh0KCkgfSwgY3VycmVudExpbmUpOworICAg ICAgICBmb3JtYXR0aW5nU3RhdGUuYWRkSW5saW5lUnVuKG1ha2VVbmlxdWU8RGlzcGxheTo6UnVu PihsaW5lUnVuLmxheW91dEJveCgpLnN0eWxlKCksIGxpbmVSdW4ubG9naWNhbFJlY3QoKSwgbGlu ZVJ1bi50ZXh0Q29udGV4dCgpKSwgY3VycmVudExpbmUpOwogICAgIH0KIAogICAgIC8vIENvbXB1 dGUgYm94IGZpbmFsIGdlb21ldHJ5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0 L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ1N0YXRlLmggYi9Tb3VyY2UvV2ViQ29y ZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nU3RhdGUuaAppbmRleCAw MDZhZTZkODk1ZDYyOWU4MDk1YjAzMWJhNjIxNWQ3NjdmZWE3MWE5Li5hNjU5ZTM3NzM4NDk5ZmZj MGViZDBhYzY1YzE0OGU1ODk5MDQyNjUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlv dXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nU3RhdGUuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nU3RhdGUuaApA QCAtNTQsNyArNTQsNyBAQCBwdWJsaWM6CiAKICAgICBjb25zdCBJbmxpbmVSdW5zJiBpbmxpbmVS dW5zKCkgY29uc3QgeyByZXR1cm4gbV9pbmxpbmVSdW5zOyB9CiAgICAgSW5saW5lUnVucyYgaW5s aW5lUnVucygpIHsgcmV0dXJuIG1faW5saW5lUnVuczsgfQotICAgIHZvaWQgYWRkSW5saW5lUnVu KGNvbnN0IERpc3BsYXk6OlJ1biYsIGNvbnN0IExpbmVCb3gmKTsKKyAgICB2b2lkIGFkZElubGlu ZVJ1bihzdGQ6OnVuaXF1ZV9wdHI8RGlzcGxheTo6UnVuPiYmLCBjb25zdCBMaW5lQm94Jik7CiAK ICAgICBjb25zdCBMaW5lQm94ZXMmIGxpbmVCb3hlcygpIGNvbnN0IHsgcmV0dXJuIG1fbGluZUJv eGVzOyB9CiAgICAgTGluZUJveGVzJiBsaW5lQm94ZXMoKSB7IHJldHVybiBtX2xpbmVCb3hlczsg fQpAQCAtNzAsMTEgKzcwLDEwIEBAIHByaXZhdGU6CiAgICAgSGFzaE1hcDxjb25zdCBEaXNwbGF5 OjpSdW4qLCBjb25zdCBMaW5lQm94Kj4gbV9pbmxpbmVSdW5Ub0xpbmVNYXA7CiB9OwogCi1pbmxp bmUgdm9pZCBJbmxpbmVGb3JtYXR0aW5nU3RhdGU6OmFkZElubGluZVJ1bihjb25zdCBEaXNwbGF5 OjpSdW4mIGlubGluZVJ1biwgY29uc3QgTGluZUJveCYgbGluZSkKK2lubGluZSB2b2lkIElubGlu ZUZvcm1hdHRpbmdTdGF0ZTo6YWRkSW5saW5lUnVuKHN0ZDo6dW5pcXVlX3B0cjxEaXNwbGF5OjpS dW4+JiYgZGlzcGxheVJ1biwgY29uc3QgTGluZUJveCYgbGluZSkKIHsKLSAgICBhdXRvIHJ1biA9 IG1ha2VVbmlxdWU8RGlzcGxheTo6UnVuPihpbmxpbmVSdW4pOwotICAgIG1faW5saW5lUnVuVG9M aW5lTWFwLnNldChydW4uZ2V0KCksICZsaW5lKTsKLSAgICBtX2lubGluZVJ1bnMuYXBwZW5kKFdU Rk1vdmUocnVuKSk7CisgICAgbV9pbmxpbmVSdW5Ub0xpbmVNYXAuc2V0KGRpc3BsYXlSdW4uZ2V0 KCksICZsaW5lKTsKKyAgICBtX2lubGluZVJ1bnMuYXBwZW5kKFdURk1vdmUoZGlzcGxheVJ1bikp OwogfQogCiB9Cg==