204015 2019-11-08 13:01:09 -0800 Use separate cache directory for development WebKit on Mac 2019-11-08 17:16:32 -0800 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned beidson cdumez cgarcia commit-queue ews-watchlist ggaren webkit-bug-importer youennf oldest_to_newest 1588771 0 koivisto 2019-11-08 13:01:09 -0800 Replace the NetworkCache::lastStableVersion scheme with completely separate directory. This way bugs in development WebKit can't end up affecting system Safari cache. This also removes the need to keep lastStableVersion updated. 1588775 1 383156 koivisto 2019-11-08 13:06:17 -0800 Created attachment 383156 patch 1588854 2 commit-queue 2019-11-08 15:00:56 -0800 The commit-queue encountered the following flaky tests while processing attachment 383156: inspector/model/remote-object-weak-collection.html bug 204016 (authors: drousso@apple.com and joepeck@webkit.org) The commit-queue is continuing to process your patch. 1588855 3 383156 commit-queue 2019-11-08 15:01:47 -0800 Comment on attachment 383156 patch Clearing flags on attachment: 383156 Committed r252264: <https://trac.webkit.org/changeset/252264> 1588856 4 commit-queue 2019-11-08 15:01:49 -0800 All reviewed patches have been landed. Closing bug. 1588909 5 webkit-bug-importer 2019-11-08 17:16:32 -0800 <rdar://problem/57040593> 383156 2019-11-08 13:06:17 -0800 2019-11-08 15:01:47 -0800 patch separate-development-cache.patch text/plain 4036 koivisto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggM2NlNzFiYTA0NDkuLmE1MzgyODUyOGMyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDI2IEBACisyMDE5LTExLTA4ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKwor ICAgICAgICBVc2Ugc2VwYXJhdGUgY2FjaGUgZGlyZWN0b3J5IGZvciBkZXZlbG9wbWVudCBXZWJL aXQgb24gTWFjCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMDQwMTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSZXBsYWNlIHRoZSBOZXR3b3JrQ2FjaGU6Omxhc3RTdGFibGVWZXJzaW9uIHNjaGVtZSB3aXRo IGEgY29tcGxldGVseSBzZXBhcmF0ZSBkaXJlY3RvcnkuCisgICAgICAgIFRoaXMgd2F5IHBvdGVu dGlhbCBidWdzIGluIGRldmVsb3BtZW50IFdlYktpdCBjYW4ndCBlbmQgdXAgYWZmZWN0aW5nIHN5 c3RlbSBXZWJLaXQgY2FjaGUuCisgICAgICAgIFRoaXMgYWxzbyByZW1vdmVzIHRoZSBuZWVkIHRv IGtlZXAgbGFzdFN0YWJsZVZlcnNpb24gdXBkYXRlZC4KKworICAgICAgICAqIE5ldHdvcmtQcm9j ZXNzL2NhY2hlL05ldHdvcmtDYWNoZVN0b3JhZ2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3 b3JrQ2FjaGU6Om1ha2VDYWNoZVBhdGgpOgorCisgICAgICAgIEFkZCAnL0RldmVsb3BtZW50JyB0 byBjYWNoZSBwYXRoIGlmIHRoaXMgaXMgbm90IHN5c3RlbSBXZWJLaXQuCisKKyAgICAgICAgKFdl YktpdDo6TmV0d29ya0NhY2hlOjpTdG9yYWdlOjpvcGVuKToKKyAgICAgICAgKFdlYktpdDo6TmV0 d29ya0NhY2hlOjpTdG9yYWdlOjpkZWxldGVPbGRWZXJzaW9ucyk6CisKKyAgICAgICAgTm8gbmVl ZCB0byBhdm9pZCBkZWxldGluZyBsYXN0U3RhYmxlVmVyc2lvbiBhbnltb3JlLgorCisgICAgICAg ICogTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3RvcmFnZS5oOgorCiAyMDE5LTEx LTA3ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9T XSBBZGQgbG9nZ2luZyBhbmQgdGVsZW1ldHJ5IHRvIG1vcmUgbWFjaCBsb29rdXAgcnVsZXMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hl U3RvcmFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtD YWNoZVN0b3JhZ2UuY3BwCmluZGV4IGEzOTI0ZTYwZjdjLi5hMDE4NmE0Zjg3YiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVTdG9yYWdl LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNo ZVN0b3JhZ2UuY3BwCkBAIC0xNDMsNiArMTQzLDE2IEBAIHB1YmxpYzoKICAgICB1bnNpZ25lZCBh Y3RpdmVDb3VudCB7IDAgfTsKIH07CiAKK3N0YXRpYyBTdHJpbmcgbWFrZUNhY2hlUGF0aChjb25z dCBTdHJpbmcmIGJhc2VDYWNoZVBhdGgpCit7CisjaWYgUExBVEZPUk0oTUFDKQorICAgIC8vIFB1 dCBkZXZlbG9wbWVudCBjYWNoZSB0byBhIGRpZmZlcmVudCBkaXJlY3RvcnkgdG8gYXZvaWQgYWZm ZWN0aW5nIHRoZSBzeXN0ZW0gY2FjaGUuCisgICAgaWYgKCFBdXhpbGlhcnlQcm9jZXNzOjppc1N5 c3RlbVdlYktpdCgpKQorICAgICAgICByZXR1cm4gRmlsZVN5c3RlbTo6cGF0aEJ5QXBwZW5kaW5n Q29tcG9uZW50KGJhc2VDYWNoZVBhdGgsICJEZXZlbG9wbWVudCJfcyk7CisjZW5kaWYKKyAgICBy ZXR1cm4gYmFzZUNhY2hlUGF0aDsKK30KKwogc3RhdGljIFN0cmluZyBtYWtlVmVyc2lvbmVkRGly ZWN0b3J5UGF0aChjb25zdCBTdHJpbmcmIGJhc2VEaXJlY3RvcnlQYXRoKQogewogICAgIFN0cmlu ZyB2ZXJzaW9uU3ViZGlyZWN0b3J5ID0gbWFrZVN0cmluZyh2ZXJzaW9uRGlyZWN0b3J5UHJlZml4 LCBTdG9yYWdlOjp2ZXJzaW9uKTsKQEAgLTE2NCwxNSArMTc0LDE5IEBAIHN0YXRpYyBTdHJpbmcg bWFrZVNhbHRGaWxlUGF0aChjb25zdCBTdHJpbmcmIGJhc2VEaXJlY3RvcnlQYXRoKQogICAgIHJl dHVybiBGaWxlU3lzdGVtOjpwYXRoQnlBcHBlbmRpbmdDb21wb25lbnQobWFrZVZlcnNpb25lZERp cmVjdG9yeVBhdGgoYmFzZURpcmVjdG9yeVBhdGgpLCBzYWx0RmlsZU5hbWUpOwogfQogCi1SZWZQ dHI8U3RvcmFnZT4gU3RvcmFnZTo6b3Blbihjb25zdCBTdHJpbmcmIGNhY2hlUGF0aCwgTW9kZSBt b2RlKQorUmVmUHRyPFN0b3JhZ2U+IFN0b3JhZ2U6Om9wZW4oY29uc3QgU3RyaW5nJiBiYXNlQ2Fj aGVQYXRoLCBNb2RlIG1vZGUpCiB7CiAgICAgQVNTRVJUKFJ1bkxvb3A6OmlzTWFpbigpKTsKIAor ICAgIGF1dG8gY2FjaGVQYXRoID0gbWFrZUNhY2hlUGF0aChiYXNlQ2FjaGVQYXRoKTsKKwogICAg IGlmICghRmlsZVN5c3RlbTo6bWFrZUFsbERpcmVjdG9yaWVzKG1ha2VWZXJzaW9uZWREaXJlY3Rv cnlQYXRoKGNhY2hlUGF0aCkpKQogICAgICAgICByZXR1cm4gbnVsbHB0cjsKKwogICAgIGF1dG8g c2FsdCA9IHJlYWRPck1ha2VTYWx0KG1ha2VTYWx0RmlsZVBhdGgoY2FjaGVQYXRoKSk7CiAgICAg aWYgKCFzYWx0KQogICAgICAgICByZXR1cm4gbnVsbHB0cjsKKwogICAgIHJldHVybiBhZG9wdFJl ZihuZXcgU3RvcmFnZShjYWNoZVBhdGgsIG1vZGUsICpzYWx0KSk7CiB9CiAKQEAgLTExMjIsMTAg KzExMzYsNiBAQCB2b2lkIFN0b3JhZ2U6OmRlbGV0ZU9sZFZlcnNpb25zKCkKICAgICAgICAgICAg ICAgICByZXR1cm47CiAgICAgICAgICAgICBpZiAoZGlyZWN0b3J5VmVyc2lvbiA+PSB2ZXJzaW9u KQogICAgICAgICAgICAgICAgIHJldHVybjsKLSNpZiBQTEFURk9STShNQUMpCi0gICAgICAgICAg ICBpZiAoIUF1eGlsaWFyeVByb2Nlc3M6OmlzU3lzdGVtV2ViS2l0KCkgJiYgZGlyZWN0b3J5VmVy c2lvbiA9PSBsYXN0U3RhYmxlVmVyc2lvbikKLSAgICAgICAgICAgICAgICByZXR1cm47Ci0jZW5k aWYKIAogICAgICAgICAgICAgYXV0byBvbGRWZXJzaW9uUGF0aCA9IEZpbGVTeXN0ZW06OnBhdGhC eUFwcGVuZGluZ0NvbXBvbmVudChjYWNoZVBhdGgsIHN1YmRpck5hbWUpOwogICAgICAgICAgICAg TE9HKE5ldHdvcmtDYWNoZVN0b3JhZ2UsICIoTmV0d29ya1Byb2Nlc3MpIGRlbGV0aW5nIG9sZCBj YWNoZSB2ZXJzaW9uLCBwYXRoICVzIiwgb2xkVmVyc2lvblBhdGgudXRmOCgpLmRhdGEoKSk7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNo ZVN0b3JhZ2UuaCBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0Nh Y2hlU3RvcmFnZS5oCmluZGV4IDQyZTU1NjI5NzFkLi44YzU0ZTIyNjliYSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVTdG9yYWdlLmgK KysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVTdG9y YWdlLmgKQEAgLTEwOCwxMCArMTA4LDYgQEAgcHVibGljOgogCiAgICAgLy8gSW5jcmVtZW50aW5n IHRoaXMgbnVtYmVyIHdpbGwgZGVsZXRlIGFsbCBleGlzdGluZyBjYWNoZSBjb250ZW50IGZvciBl dmVyeW9uZS4gRG8geW91IHJlYWxseSBuZWVkIHRvIGRvIGl0PwogICAgIHN0YXRpYyBjb25zdCB1 bnNpZ25lZCB2ZXJzaW9uID0gMTU7Ci0jaWYgUExBVEZPUk0oTUFDKQotICAgIC8vLyBBbGxvdyB0 aGUgbGFzdCBzdGFibGUgdmVyc2lvbiBvZiB0aGUgY2FjaGUgdG8gY28tZXhpc3Qgd2l0aCB0aGUg bGF0ZXN0IGRldmVsb3BtZW50IG9uZS4KLSAgICBzdGF0aWMgY29uc3QgdW5zaWduZWQgbGFzdFN0 YWJsZVZlcnNpb24gPSAxMzsKLSNlbmRpZgogCiAgICAgU3RyaW5nIGJhc2VQYXRoSXNvbGF0ZWRD b3B5KCkgY29uc3Q7CiAgICAgU3RyaW5nIHZlcnNpb25QYXRoKCkgY29uc3Q7Cg==