203984 2019-11-07 16:41:06 -0800 webgl/1.0.3/conformance/context/context-release-upon-reload.html is flaky 2019-11-20 15:31:11 -0800 1 1 1 Unclassified WebKit Layout and Rendering Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=203949 https://bugs.webkit.org/show_bug.cgi?id=204029 InRadar P2 Normal --- 1 aakash_jain justin_fan aakash_jain ap bfulgham commit-queue jbedard justin_fan simon.fraser webkit-bot-watchers-bugzilla webkit-bug-importer zalan oldest_to_newest 1588492 0 aakash_jain 2019-11-07 16:41:06 -0800 webgl/1.0.3/conformance/context/context-release-upon-reload.html is flaky on High Sierra Debug WK1. History: https://results.webkit.org/?suite=layout-tests&test=webgl%2F1.0.3%2Fconformance%2Fcontext%2Fcontext-release-upon-reload.html e.g.: it flaked in https://ews-build.webkit.org/#/builders/17/builds/5974 , it crashed in layout-tests step, but passed in re-run-layout-tests step. Possible regression from https://trac.webkit.org/changeset/252121/webkit. 1588493 1 webkit-bug-importer 2019-11-07 16:41:50 -0800 <rdar://problem/57004328> 1588505 2 383094 justin_fan 2019-11-07 17:08:40 -0800 Created attachment 383094 Patch 1588509 3 383094 justin_fan 2019-11-07 17:15:28 -0800 Comment on attachment 383094 Patch Clearing flags on attachment: 383094 Committed r252222: <https://trac.webkit.org/changeset/252222> 1588510 4 justin_fan 2019-11-07 17:15:29 -0800 All reviewed patches have been landed. Closing bug. 1589125 5 ap 2019-11-10 15:47:01 -0800 Re-opening, because this patch only skipped the test. Also the same test in 2.0.0 directory crashes too: https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK1%20(Tests)/r252185%20(11696)/results.html Are these even really entirely separate test suites? ASSERTION FAILED: !needsLayout() ./rendering/RenderView.cpp(306) : virtual void WebCore::RenderView::paint(WebCore::PaintInfo &, const WebCore::LayoutPoint &) 1 0x10ea0cf29 WTFCrash 2 0x11b04997b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x11ea60c3b WebCore::RenderView::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&) 4 0x11e918303 WebCore::RenderLayer::paintBackgroundForFragments(WTF::Vector<WebCore::LayerFragment, 1ul, WTF::CrashOnOverflow, 16ul> const&, WebCore::GraphicsContext&, WebCore::GraphicsContext&, WebCore::LayoutRect const&, bool, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::RenderObject*) 5 0x11e914bc0 WebCore::RenderLayer::paintLayerContents(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 6 0x11e9365bc WebCore::RenderLayerBacking::paintIntoLayer(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::IntRect const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::EventRegionContext*)::$_10::operator()(WebCore::RenderLayer&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) const 7 0x11e935fa7 WebCore::RenderLayerBacking::paintIntoLayer(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::IntRect const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::EventRegionContext*) 8 0x11e937acc WebCore::RenderLayerBacking::paintContents(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int) 9 0x11e3b9462 WebCore::GraphicsLayer::paintGraphicsLayerContents(WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int) 10 0x11e42d52c WebCore::GraphicsLayerCA::platformCALayerPaintContents(WebCore::PlatformCALayer*, WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int) 11 0x11c5bdea5 WebCore::PlatformCALayer::drawLayerContents(CGContext*, WebCore::PlatformCALayer*, WTF::Vector<WebCore::FloatRect, 5ul, WTF::CrashOnOverflow, 16ul>&, unsigned int) 12 0x11c6fee23 -[WebLayer drawInContext:] 13 0x7fff55ef0556 CABackingStoreUpdate_ 14 0x7fff55ef041b invocation function for block in CA::Layer::display_() 15 0x7fff55eefcb2 -[CALayer _display] 16 0x11c6ff3eb -[WebSimpleLayer display] 17 0x7fff55ee0e29 CA::Layer::display_if_needed(CA::Transaction*) 18 0x7fff55ee08e7 CA::Layer::layout_and_display_if_needed(CA::Transaction*) 19 0x7fff55edf8d8 CA::Context::commit_transaction(CA::Transaction*) 20 0x7fff55edf475 CA::Transaction::commit() 21 0x7fff55eeb8ca CA::Transaction::observer_callback(__CFRunLoopObserver*, unsigned long, void*) 22 0x7fff4ab6df87 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ 23 0x7fff4ab6deaf __CFRunLoopDoObservers 24 0x7fff4ab50ae0 __CFRunLoopRun 25 0x7fff4ab50207 CFRunLoopRunSpecific 26 0x10b48df69 runTest(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) 27 0x10b48bfff runTestingServerLoop() 28 0x10b48b48e dumpRenderTree(int, char const**) 29 0x10b48e9ff DumpRenderTreeMain(int, char const**) 30 0x10b523162 main 31 0x7fff72aff015 start 1589283 6 justin_fan 2019-11-11 12:08:15 -0800 They are separate test suites because the tests under 2.0.0 are meant to be run with a WebGL 2 context as opposed to a WebGL 1 context. 1589298 7 ap 2019-11-11 13:15:17 -0800 Are we running them with a WebGL 2 context in practice now? 1591826 8 aakash_jain 2019-11-19 18:27:04 -0800 This is still crashing sometimes. e.g.: https://ews-build.webkit.org/#/builders/17/builds/6931 https://ews-build.webkit.org/#/builders/17/builds/6786 https://ews-build.webkit.org/#/builders/17/builds/6776 1591827 9 aakash_jain 2019-11-19 18:28:02 -0800 From https://ews-build.webkit.org/results/macOS-High-Sierra-Debug-WK1-Tests-EWS/r383904-6931/results.html Application Specific Information: CRASHING TEST: webgl/2.0.0/conformance/context/context-release-upon-reload.html Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.JavaScriptCore 0x000000010127bd80 WTFCrash + 16 1 com.apple.WebCore 0x000000010f895b0b WTFCrashWithInfo(int, char const*, char const*, int) + 27 2 com.apple.WebCore 0x000000011327267b WebCore::RenderView::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&) + 123 3 com.apple.WebCore 0x000000011312f8d3 WebCore::RenderLayer::paintBackgroundForFragments(WTF::Vector<WebCore::LayerFragment, 1ul, WTF::CrashOnOverflow, 16ul> const&, WebCore::GraphicsContext&, WebCore::GraphicsContext&, WebCore::LayoutRect const&, bool, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::RenderObject*) + 595 4 com.apple.WebCore 0x000000011312c190 WebCore::RenderLayer::paintLayerContents(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) + 3184 5 com.apple.WebCore 0x000000011314db8c WebCore::RenderLayerBacking::paintIntoLayer(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::IntRect const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::EventRegionContext*)::$_10::operator()(WebCore::RenderLayer&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) const + 396 6 com.apple.WebCore 0x000000011314d577 WebCore::RenderLayerBacking::paintIntoLayer(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::IntRect const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::EventRegionContext*) + 375 7 com.apple.WebCore 0x000000011314f09c WebCore::RenderLayerBacking::paintContents(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int) + 748 8 com.apple.WebCore 0x0000000112bd22c2 WebCore::GraphicsLayer::paintGraphicsLayerContents(WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int) + 258 9 com.apple.WebCore 0x0000000112c4637c WebCore::GraphicsLayerCA::platformCALayerPaintContents(WebCore::PlatformCALayer*, WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int) + 1628 10 com.apple.WebCore 0x0000000110e0f065 WebCore::PlatformCALayer::drawLayerContents(CGContext*, WebCore::PlatformCALayer*, WTF::Vector<WebCore::FloatRect, 5ul, WTF::CrashOnOverflow, 16ul>&, unsigned int) + 901 11 com.apple.WebCore 0x0000000110f59403 -[WebLayer drawInContext:] + 163 12 com.apple.QuartzCore 0x00007fff4b02d556 CABackingStoreUpdate_ + 300 13 com.apple.QuartzCore 0x00007fff4b02d41b invocation function for block in CA::Layer::display_() + 53 14 com.apple.QuartzCore 0x00007fff4b02ccb2 -[CALayer _display] + 2238 15 com.apple.WebCore 0x0000000110f599cb -[WebSimpleLayer display] + 139 16 com.apple.QuartzCore 0x00007fff4b01de29 CA::Layer::display_if_needed(CA::Transaction*) + 633 17 com.apple.QuartzCore 0x00007fff4b01d8e7 CA::Layer::layout_and_display_if_needed(CA::Transaction*) + 35 18 com.apple.QuartzCore 0x00007fff4b01c8d8 CA::Context::commit_transaction(CA::Transaction*) + 326 19 com.apple.QuartzCore 0x00007fff4b01c475 CA::Transaction::commit() + 487 20 com.apple.QuartzCore 0x00007fff4b0288ca CA::Transaction::observer_callback(__CFRunLoopObserver*, unsigned long, void*) + 66 21 com.apple.CoreFoundation 0x00007fff3fcaaf87 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ + 23 22 com.apple.CoreFoundation 0x00007fff3fcaaeaf __CFRunLoopDoObservers + 511 23 com.apple.CoreFoundation 0x00007fff3fc8dae0 __CFRunLoopRun + 1600 24 com.apple.CoreFoundation 0x00007fff3fc8d207 CFRunLoopRunSpecific + 487 25 DumpRenderTree 0x000000010007c0e9 runTest(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 7865 (DumpRenderTree.mm:2104) 1592117 10 justin_fan 2019-11-20 13:25:25 -0800 Skipping for now. We will reset all test expecations soon after ANGLE backend switch, at which point this will be revisited. 1592118 11 383980 justin_fan 2019-11-20 13:27:42 -0800 Created attachment 383980 Patch 1592175 12 383980 commit-queue 2019-11-20 15:31:09 -0800 Comment on attachment 383980 Patch Clearing flags on attachment: 383980 Committed r252715: <https://trac.webkit.org/changeset/252715> 1592176 13 commit-queue 2019-11-20 15:31:11 -0800 All reviewed patches have been landed. Closing bug. 383094 2019-11-07 17:08:40 -0800 2019-11-20 13:27:38 -0800 Patch bug-203984-20191107170839.patch text/plain 1467 justin_fan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyMjE0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZmZlNDZmYTNjMjBhNjRlY2MxNGRh NWQyMzVmOWY4ZTUwODA2ZWZlNy4uYjUwNDU1YTQwMzVhYWU2YzIxYzI2MGEzNDUzYzAzYzE1Mjgx NzFlZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTExLTA3ICBKdXN0aW4gRmFuICA8anVz dGluX2ZhbkBhcHBsZS5jb20+CisKKyAgICAgICAgd2ViZ2wvMS4wLjMvY29uZm9ybWFuY2UvY29u dGV4dC9jb250ZXh0LXJlbGVhc2UtdXBvbi1yZWxvYWQuaHRtbCBpcyBmbGFreQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAzOTg0CisKKyAgICAgICAg VW5yZXZpZXdlZCB0ZXN0IGV4cGVjdGF0aW9uIGFkZGl0aW9uLgorCisgICAgICAgIFNraXAgY29u dGV4dC1yZWxlYXNlLXVwb24tcmVsb2FkLmh0bWwgb24gSGlnaCBTaWVycmEgV0sxIGRlYnVnIGJv dHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMtaGlnaHNpZXJyYS13azEvVGVzdEV4cGVjdGF0 aW9uczogQWRkZWQuCisKIDIwMTktMTEtMDcgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogaHR0cC90ZXN0cy9pbnNwZWN0b3Iv dGFyZ2V0L3RhcmdldC1ldmVudHMtZm9yLXByb3Zpc2lvbmFsLXBhZ2UuaHRtbCBpcyBmbGFreSB3 aGVuIHJ1bm5pbmcgd2l0aCBvdGhlciB0ZXN0cwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxh dGZvcm0vbWFjLWhpZ2hzaWVycmEtd2sxL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9tYWMtaGlnaHNpZXJyYS13azEvVGVzdEV4cGVjdGF0aW9ucwpuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi45 YjVhMjlmM2Y3NDI5MGQxYTg2MjZjMDYwNGJiNGM5MDg4ZWNkMWNiCi0tLSAvZGV2L251bGwKKysr IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLWhpZ2hzaWVycmEtd2sxL1Rlc3RFeHBlY3RhdGlv bnMKQEAgLTAsMCArMSw2IEBACisjIFRoZXNlIGFyZSB0aGUgbGF5b3V0IHRlc3QgZXhwZWN0YXRp b25zIGZvciBBcHBsZSdzIE1hYyBwb3J0IG9mIFdlYktpdCBMZWdhY3kKKyMKKyMgU2VlIGh0dHA6 Ly90cmFjLndlYmtpdC5vcmcvd2lraS9UZXN0RXhwZWN0YXRpb25zIGZvciBtb3JlIGluZm9ybWF0 aW9uIG9uIHRoaXMgZmlsZS4KKyMKKword2Via2l0Lm9yZy9iLzIwMzk4NCBbIERlYnVnIF0gd2Vi Z2wvMS4wLjMvY29uZm9ybWFuY2UvY29udGV4dC9jb250ZXh0LXJlbGVhc2UtdXBvbi1yZWxvYWQu aHRtbCBbIFNraXAgXQpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK 383980 2019-11-20 13:27:42 -0800 2019-11-20 15:31:09 -0800 Patch bug-203984-20191120132740.patch text/plain 1542 justin_fan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyNzAyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOTdjMjllZWNiMDliNDNiN2JhYzk3 OGY5ZDY1YWQ3NWUzZjIyZDI5NS4uODhmMWY1Y2I1NGYyMDk1MjgxNDczZGRhYjRjM2E1YTI5ODFj YjM0NCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE5LTExLTIwICBKdXN0aW4gRmFuICA8anVz dGluX2ZhbkBhcHBsZS5jb20+CisKKyAgICAgICAgd2ViZ2wvMS4wLjMvY29uZm9ybWFuY2UvY29u dGV4dC9jb250ZXh0LXJlbGVhc2UtdXBvbi1yZWxvYWQuaHRtbCBpcyBmbGFreQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAzOTg0CisKKyAgICAgICAg VW5yZXZpZXdlZCB0ZXN0IGdhcmRlbmluZy4gU2tpcCB0aGUgMi4wLjAgdmVyc2lvbiBvZiB0aGlz IHRlc3QgYXMgd2VsbC4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy1oaWdoc2llcnJhLXdrMS9U ZXN0RXhwZWN0YXRpb25zOgorCiAyMDE5LTExLTIwICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFz ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFR1cm4gb2ZmIGFudGlhbGlhc2luZyB3aGVuIHJlbmRl cmluZyB3aXRoIEFoZW0sIGZvciB0ZXN0aW5nCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9tYWMtaGlnaHNpZXJyYS13azEvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL21hYy1oaWdoc2llcnJhLXdrMS9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDliNWEyOWYz Zjc0MjkwZDFhODYyNmMwNjA0YmI0YzkwODhlY2QxY2IuLmJjNTdlOWRhM2E4NTk5MDFhMGM2MzU0 ZTVmZDU1MmI0ODY5NjViYTQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy1o aWdoc2llcnJhLXdrMS9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3Jt L21hYy1oaWdoc2llcnJhLXdrMS9UZXN0RXhwZWN0YXRpb25zCkBAIC0zLDQgKzMsNSBAQAogIyBT ZWUgaHR0cDovL3RyYWMud2Via2l0Lm9yZy93aWtpL1Rlc3RFeHBlY3RhdGlvbnMgZm9yIG1vcmUg aW5mb3JtYXRpb24gb24gdGhpcyBmaWxlLgogIwogCi13ZWJraXQub3JnL2IvMjAzOTg0IFsgRGVi dWcgXSB3ZWJnbC8xLjAuMy9jb25mb3JtYW5jZS9jb250ZXh0L2NvbnRleHQtcmVsZWFzZS11cG9u LXJlbG9hZC5odG1sIFsgU2tpcCBdClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQord2Via2l0 Lm9yZy9iLzIwMzk4NCBbIERlYnVnIF0gd2ViZ2wvMS4wLjMvY29uZm9ybWFuY2UvY29udGV4dC9j b250ZXh0LXJlbGVhc2UtdXBvbi1yZWxvYWQuaHRtbCBbIFNraXAgXQord2Via2l0Lm9yZy9iLzIw Mzk4NCBbIERlYnVnIF0gd2ViZ2wvMi4wLjAvY29uZm9ybWFuY2UvY29udGV4dC9jb250ZXh0LXJl bGVhc2UtdXBvbi1yZWxvYWQuaHRtbCBbIFNraXAgXQpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZp bGUK