203932 2019-11-06 16:53:26 -0800 Web Inspector: REGRESSION(r251958): console prompt is automatically focused when page is reloaded 2019-11-07 15:41:23 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 203743 1 hi hi bburg commit-queue eric.carlson hi inspector-bugzilla-changes timothy webkit-bug-importer oldest_to_newest 1588001 0 hi 2019-11-06 16:53:26 -0800 # STEPS TO REPRODUCE: 1. inspect any page 2. go to the Timelines Tab 3. select something in the Timelines Tab (e.g. a record row in the table) 4. reload the page => console prompt becomes focused 1588003 1 382987 hi 2019-11-06 16:54:44 -0800 Created attachment 382987 Patch 1588300 2 382987 timothy 2019-11-07 11:03:14 -0800 Comment on attachment 382987 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382987&action=review > Source/WebInspectorUI/UserInterface/Base/Main.js:1565 > + if (WI._didAutofocusConsolePrompt === undefined) { !WI._didAutofocusConsolePrompt 1588301 3 382987 hi 2019-11-07 11:05:37 -0800 Comment on attachment 382987 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382987&action=review >> Source/WebInspectorUI/UserInterface/Base/Main.js:1565 >> + if (WI._didAutofocusConsolePrompt === undefined) { > > !WI._didAutofocusConsolePrompt I actually specifically want to use `undefined` because it's set to `false` inside `WI._focusChanged`. 1588344 4 382987 commit-queue 2019-11-07 12:18:41 -0800 Comment on attachment 382987 Patch Rejecting attachment 382987 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 382987, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=382987&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=203932&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 382987 from bug 203932. Fetching: https://bugs.webkit.org/attachment.cgi?id=382987 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebInspectorUI/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebInspectorUI/UserInterface/Base/Main.js Hunk #1 FAILED at 1561. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebInspectorUI/UserInterface/Base/Main.js.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/13223707 1588433 5 383079 hi 2019-11-07 15:08:50 -0800 Created attachment 383079 Patch 1588456 6 383079 commit-queue 2019-11-07 15:40:04 -0800 Comment on attachment 383079 Patch Clearing flags on attachment: 383079 Committed r252213: <https://trac.webkit.org/changeset/252213> 1588457 7 commit-queue 2019-11-07 15:40:05 -0800 All reviewed patches have been landed. Closing bug. 1588458 8 webkit-bug-importer 2019-11-07 15:41:23 -0800 <rdar://problem/57001696> 382987 2019-11-06 16:54:44 -0800 2019-11-07 15:08:49 -0800 Patch bug-203932-20191106165443.patch text/plain 1890 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGQ4MjRkOWM3ZWVjMzQ4MTk3ZmJmNGU0N2Q1MzVj NWNlMDE5Y2E3OGEuLjg5ZjJhNjJhYTQxZmZhNWMzNDU0YTVlNzMzYmM0MWM2NzI4MmM5MDMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTExLTA2ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OKHIyNTE5NTgpOiBjb25zb2xlIHByb21wdCBpcyBhdXRvbWF0aWNhbGx5IGZvY3Vz ZWQgd2hlbiBwYWdlIGlzIHJlbG9hZGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMDM5MzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzOgorICAgICAgICAo V0kuX3Jlc3RvcmVDb29raWVGb3JPcGVuVGFicyk6CisgICAgICAgIE9ubHkgYXR0ZW1wdCB0byBh dXRvZm9jdXMgd2hlbiBXZWIgSW5zcGVjdG9yIGlzIGZpcnN0IG9wZW5lZC4KKwogMjAxOS0xMS0w NCAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3Bl Y3RvcjogIlRvZ2dsZSBWaXNpYmlsaXR5IiBkb2VzIG5vdCB3b3JrIGZvciBlbGVtZW50IGluc2lk ZSBTaGFkb3cgRE9NCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9CYXNlL01haW4uanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9C YXNlL01haW4uanMKaW5kZXggZTYyZGY3YzBjZWJjYWIyMzU5MzlkODI1Mzk0YjUyMjBkYjdlOTU5 Mi4uMDg2ZWFjMWI3ZDVkOGQzNGI1MGVmODA1MjQ5MDY4NzY4ZjRmOTIxMiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwpAQCAtMTU2MSwx MyArMTU2MSwxNiBAQCBXSS5fcmVzdG9yZUNvb2tpZUZvck9wZW5UYWJzID0gZnVuY3Rpb24ocmVz dG9yYXRpb25UeXBlKQogICAgICAgICB0YWJDb250ZW50Vmlldy5yZXN0b3JlU3RhdGVGcm9tQ29v a2llKHJlc3RvcmF0aW9uVHlwZSk7CiAgICAgfQogCi0gICAgd2luZG93LnJlcXVlc3RBbmltYXRp b25GcmFtZSgoKSA9PiB7Ci0gICAgICAgIGlmIChXSS5pc0NvbnRlbnRBcmVhRm9jdXNlZCgpKQot ICAgICAgICAgICAgcmV0dXJuOworICAgIC8vIE9ubHkgYXR0ZW1wdCB0byBhdXRvZm9jdXMgd2hl biBXZWIgSW5zcGVjdG9yIGlzIGZpcnN0IG9wZW5lZC4KKyAgICBpZiAoV0kuX2RpZEF1dG9mb2N1 c0NvbnNvbGVQcm9tcHQgPT09IHVuZGVmaW5lZCkgeworICAgICAgICB3aW5kb3cucmVxdWVzdEFu aW1hdGlvbkZyYW1lKCgpID0+IHsKKyAgICAgICAgICAgIGlmIChXSS5pc0NvbnRlbnRBcmVhRm9j dXNlZCgpKQorICAgICAgICAgICAgICAgIHJldHVybjsKIAotICAgICAgICBXSS5xdWlja0NvbnNv bGUucHJvbXB0LmZvY3VzKCk7Ci0gICAgICAgIFdJLl9kaWRBdXRvZm9jdXNDb25zb2xlUHJvbXB0 ID0gdHJ1ZTsKLSAgICB9KTsKKyAgICAgICAgICAgIFdJLnF1aWNrQ29uc29sZS5wcm9tcHQuZm9j dXMoKTsKKyAgICAgICAgICAgIFdJLl9kaWRBdXRvZm9jdXNDb25zb2xlUHJvbXB0ID0gdHJ1ZTsK KyAgICAgICAgfSk7CisgICAgfQogfTsKIAogV0kuX3NhdmVDb29raWVGb3JPcGVuVGFicyA9IGZ1 bmN0aW9uKCkK 383079 2019-11-07 15:08:50 -0800 2019-11-07 15:40:04 -0800 Patch bug-203932-20191107150849.patch text/plain 2007 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDBmMzdkOWFhYTcxNWY2NmYwNTNjNzBmY2E3ZTJk NDQwMmJmMDczNDkuLjE3NzNmNDljNGQxOWY0MDg3N2VjMWMyZGZlYWRhZmNjY2JhZmQyNzAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTExLTA3ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OKHIyNTE5NTgpOiBjb25zb2xlIHByb21wdCBpcyBhdXRvbWF0aWNhbGx5IGZvY3Vz ZWQgd2hlbiBwYWdlIGlzIHJlbG9hZGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMDM5MzIKKworICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhh dGNoZXIuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qczoKKyAgICAgICAg KFdJLl9yZXN0b3JlQ29va2llRm9yT3BlblRhYnMpOgorICAgICAgICBPbmx5IGF0dGVtcHQgdG8g YXV0b2ZvY3VzIHdoZW4gV2ViIEluc3BlY3RvciBpcyBmaXJzdCBvcGVuZWQuCisKIDIwMTktMTEt MDcgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFJFR1JFU1NJT04ocjI1MDA4Nyk6IGluc3BlY3Rvci9tb2RlbC9yZW1vdGUtb2JqZWN0 Lmh0bWwgaXMgdGltaW5nIG91dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvQmFzZS9NYWluLmpzCmluZGV4IDQ5NmQzMTZiYWViMWIwNzFmMWZhMWE0YWQ2NWZjYzhj N2U3MDczNzEuLjc3NWRjODJiZGJmMTgyNjA2YThmODUyMjMwZTgwMjYxZWE3MmVhMzEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwor KysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKQEAg LTE1NzEsMTMgKzE1NzEsMTYgQEAgV0kuX3Jlc3RvcmVDb29raWVGb3JPcGVuVGFicyA9IGZ1bmN0 aW9uKHJlc3RvcmF0aW9uVHlwZSkKICAgICAgICAgdGFiQ29udGVudFZpZXcucmVzdG9yZVN0YXRl RnJvbUNvb2tpZShyZXN0b3JhdGlvblR5cGUpOwogICAgIH0KIAotICAgIHdpbmRvdy5yZXF1ZXN0 QW5pbWF0aW9uRnJhbWUoKCkgPT4gewotICAgICAgICBpZiAoV0kuaXNDb250ZW50QXJlYUZvY3Vz ZWQoKSB8fCBXSS5pc1Nob3dpbmdUaW1lbGluZVRhYigpIHx8IFdJLmlzU2hvd2luZ0F1ZGl0VGFi KCkpCi0gICAgICAgICAgICByZXR1cm47CisgICAgLy8gT25seSBhdHRlbXB0IHRvIGF1dG9mb2N1 cyB3aGVuIFdlYiBJbnNwZWN0b3IgaXMgZmlyc3Qgb3BlbmVkLgorICAgIGlmIChXSS5fZGlkQXV0 b2ZvY3VzQ29uc29sZVByb21wdCA9PT0gdW5kZWZpbmVkKSB7CisgICAgICAgIHdpbmRvdy5yZXF1 ZXN0QW5pbWF0aW9uRnJhbWUoKCkgPT4geworICAgICAgICAgICAgaWYgKFdJLmlzQ29udGVudEFy ZWFGb2N1c2VkKCkgfHwgV0kuaXNTaG93aW5nVGltZWxpbmVUYWIoKSB8fCBXSS5pc1Nob3dpbmdB dWRpdFRhYigpKQorICAgICAgICAgICAgICAgIHJldHVybjsKIAotICAgICAgICBXSS5xdWlja0Nv bnNvbGUucHJvbXB0LmZvY3VzKCk7Ci0gICAgICAgIFdJLl9kaWRBdXRvZm9jdXNDb25zb2xlUHJv bXB0ID0gdHJ1ZTsKLSAgICB9KTsKKyAgICAgICAgICAgIFdJLnF1aWNrQ29uc29sZS5wcm9tcHQu Zm9jdXMoKTsKKyAgICAgICAgICAgIFdJLl9kaWRBdXRvZm9jdXNDb25zb2xlUHJvbXB0ID0gdHJ1 ZTsKKyAgICAgICAgfSk7CisgICAgfQogfTsKIAogV0kuX3NhdmVDb29raWVGb3JPcGVuVGFicyA9 IGZ1bmN0aW9uKCkK