203776 2019-11-01 21:42:43 -0700 "ValueError('too many values to unpack') raised:" on imported css-backgrounds tests 2021-05-03 06:56:20 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID https://bugs.webkit.org/show_bug.cgi?id=203783 InRadar P2 Normal --- 207734 1 simon.fraser simon.fraser ap clopez ews-watchlist glenn gsnedders jbedard simon.fraser webkit-bug-importer youennf oldest_to_newest 1586709 0 simon.fraser 2019-11-01 21:42:43 -0700 After importing css/css-backgrounds WPT, I hit this error when trying to run the tests: worker/2: ValueError('too many values to unpack') raised: File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/common/message_pool.py", line 268, in run worker.handle(message.name, message.src, *message.args) File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 290, in handle self._run_test(test_input, test_list_name) File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 311, in _run_test self._update_test_input(test_input) File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 297, in _update_test_input test_input.reference_files = self._port.reference_files(test_input.test_name, device_type=self._port.target_host(self._worker_number).device_type) File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/port/base.py", line 539, in reference_files result = self._get_reftest_list(test_name) File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/port/base.py", line 512, in _get_reftest_list self._reftest_list[dirname] = Port._parse_reftest_list(self._filesystem, dirname) File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/port/base.py", line 529, in _parse_reftest_list expectation_type, test_file, ref_file = split_line split_line is: [u'fails', u'==', u'tall--cover--nonpercent-width-nonpercent-height.html', u'ref-tall-lime256x512-aqua256x256.html'] and this comes from line 89 in css/cass-backgrounds/background-size/vector/reftest.list which looks like: # We smear the background image when scaling it in these two tests... fails == tall--cover--nonpercent-width-nonpercent-height.html ref-tall-lime256x512-aqua256x256.html fails == tall--cover--nonpercent-width-nonpercent-height-viewbox.html ref-tall-lime256x512-aqua256x256.html We fail to handle lines with "fail" at the start. 1586752 1 simon.fraser 2019-11-02 11:58:03 -0700 *** Bug 203785 has been marked as a duplicate of this bug. *** 1586759 2 382682 simon.fraser 2019-11-02 12:07:32 -0700 Created attachment 382682 Patch 1586775 3 ap 2019-11-02 14:54:33 -0700 EWS is failing webkitpy tests. 1586976 4 jbedard 2019-11-04 07:32:51 -0800 (In reply to Alexey Proskuryakov from comment #3) > EWS is failing webkitpy tests. My hunch is the tests aren't one of the two special cases, probably need to to edit them. 1690550 5 webkit-bug-importer 2020-09-21 15:36:59 -0700 <rdar://problem/69332016> 1755899 6 gsnedders 2021-04-30 18:43:05 -0700 reftest.list support was removed in bug 203783 382682 2019-11-02 12:07:32 -0700 2021-05-03 06:56:20 -0700 Patch bug-203776-20191102120731.patch text/plain 2188 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxOTYyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2Q0NjM3MjE5MGE3ZjIxZTc0YjI1ZGZiZDhjMDEyN2Ji NmZmOGExZS4uNjJhYjMyMDQ0ZjQ3MGY5Y2NiOTI3ZmVjYTYwZTA0YjgxODBiNmYxNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE5LTExLTAyICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgor CisgICAgICAgICJWYWx1ZUVycm9yKCd0b28gbWFueSB2YWx1ZXMgdG8gdW5wYWNrJykgcmFpc2Vk OiIgb24gaW1wb3J0ZWQgY3NzLWJhY2tncm91bmRzIHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDM3NzYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBIGZldyBkaXJlY3RvcmllcyAoaW5jbHVkaW5n IG5vdC15ZXQtaW1wb3J0ZWQgY3NzLWJhY2tncm91bmRzIHdwdCkgY29udGFpbgorICAgICAgICB0 aGUgb2Jzb2xldGUgcmVmdGVzdC5saXN0IGZpbGVzLiBUaGVzZSBuZWVkIHRvIGJlIGRlcHJlY2F0 ZWQgKHdlYmtpdC5vcmcvYi8yMDM3ODMpCisgICAgICAgIGJ1dCBmb3Igbm93LCBvbmx5IHN1cHBv cnQgdGhlbSBpbiB0aGUgdHdvIGRpcmVjdG9yaWVzIHRoYXQgbmVlZCB0aGVtLiBOZXdseQorICAg ICAgICBpbXBvcnRlZCB3cHQgc2hvdWxkIG5ldmVyIHVzZSB0aGVtLCBhbmQgdGhlIG9uZXMgaW4g Y3NzLWJhY2tncm91bmRzIGhhdmUgYSBzbGlnaHRseSBkaWZmZXJlbnQKKyAgICAgICAgZm9ybWF0 IHRoYXQgdGhpcyBwYXJzZXIgZmFpbHMgb24uCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L3BvcnQvYmFzZS5weToKKyAgICAgICAgKFBvcnQuX3BhcnNlX3JlZnRlc3RfbGlzdCk6CisKIDIw MTktMTEtMDEgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAg IFB5dGhvbiAzOiBBZGQgc3VwcG9ydCBpbiB3ZWJraXRweS5sYXlvdXRfdGVzdHMubW9kZWwKZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9iYXNlLnB5IGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9wb3J0L2Jhc2UucHkKaW5kZXggNjgwMGIxN2VkZjhlZDE2N2RhZDJlNjc4 Njg5ZGViNTcwZWFjMjk5NS4uOGQ0MGE5NTI2OTQ4MDRkNzA2M2FlOGQ4ZTI1ODcxZjlmNDU0NjFj MSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Jhc2UucHkKKysrIGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Jhc2UucHkKQEAgLTUxNyw2ICs1MTcsMTQgQEAg Y2xhc3MgUG9ydChvYmplY3QpOgogICAgICAgICByZWZ0ZXN0X2xpc3RfcGF0aCA9IGZpbGVzeXN0 ZW0uam9pbih0ZXN0X2RpcnBhdGgsICdyZWZ0ZXN0Lmxpc3QnKQogICAgICAgICBpZiBub3QgZmls ZXN5c3RlbS5pc2ZpbGUocmVmdGVzdF9saXN0X3BhdGgpOgogICAgICAgICAgICAgcmV0dXJuIE5v bmUKKworICAgICAgICAjIEZJWE1FOiBXZSBzaG91bGQgc3RvcCBwYXJzaW5nIHJlZnRlc3QubGlz dCBmaWxlcy4gT25seSB0d28gZGlyZWN0b3JpZXMgbmVlZCB0aGVtOiB3ZWJraXQub3JnL2IvMjAz NzgzCisgICAgICAgIGVuY29kaW5nX3Rlc3RzX3N1YnBhdGggPSBvcy5wYXRoLmpvaW4oJ2ltcG9y dGVkJywgJ3czYycsICd3ZWItcGxhdGZvcm0tdGVzdHMnLCAnZW5jb2RpbmcnKQorICAgICAgICB3 ZWJ2dHRfdGVzdHNfc3VicGF0aCA9IG9zLnBhdGguam9pbignbWVkaWEnLCAndHJhY2snLCAnb3Bl cmEnLCAndHJhY2snLCAnd2VidnR0JywgJ3JlbmRlcmluZycsICdyZWZ0ZXN0JykKKyAgICAgICAg aWYgZW5jb2RpbmdfdGVzdHNfc3VicGF0aCBub3QgaW4gdGVzdF9kaXJwYXRoIGFuZCB3ZWJ2dHRf dGVzdHNfc3VicGF0aCBub3QgaW4gdGVzdF9kaXJwYXRoOgorICAgICAgICAgICAgX2xvZy5kZWJ1 ZygiSWdub3JpbmcgcmVmdGVzdC5saXN0IGZpbGUgaW4ge30iLmZvcm1hdChyZWZ0ZXN0X2xpc3Rf cGF0aCkpCisgICAgICAgICAgICByZXR1cm4gTm9uZQorCiAgICAgICAgIHJlZnRlc3RfbGlzdF9m aWxlID0gZmlsZXN5c3RlbS5yZWFkX3RleHRfZmlsZShyZWZ0ZXN0X2xpc3RfcGF0aCkKIAogICAg ICAgICBwYXJzZWRfbGlzdCA9IHt9Cg==