203771 2019-11-01 16:26:44 -0700 [WebAuthn] CtapAuthenticator::tryDowngrade should distinguish requestData().options 2019-11-04 16:04:41 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 181943 1 jiewen_tan jiewen_tan bfulgham commit-queue jiewen_tan webkit-bug-importer oldest_to_newest 1586639 0 jiewen_tan 2019-11-01 16:26:44 -0700 CtapAuthenticator::tryDowngrade should distinguish requestData().options. 1586650 1 webkit-bug-importer 2019-11-01 16:42:16 -0700 <rdar://problem/56832618> 1586672 2 382657 jiewen_tan 2019-11-01 17:06:53 -0700 Created attachment 382657 Patch 1586683 3 382657 bfulgham 2019-11-01 17:28:00 -0700 Comment on attachment 382657 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382657&action=review > Source/WebKit/ChangeLog:14 > + No tests given there is no way to spoof google.com in our test infrastructures. It might be better to say, "... no way to simulate google.com in our test infrastructure." 1586687 4 382657 jiewen_tan 2019-11-01 17:37:51 -0700 Comment on attachment 382657 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382657&action=review Thanks Brent for r+ this patch. Waiting EWS before landing. >> Source/WebKit/ChangeLog:14 >> + No tests given there is no way to spoof google.com in our test infrastructures. > > It might be better to say, "... no way to simulate google.com in our test infrastructure." Fixed. 1586890 5 382716 jiewen_tan 2019-11-03 22:34:00 -0800 Created attachment 382716 Patch for landing 1586896 6 commit-queue 2019-11-03 23:32:50 -0800 The commit-queue encountered the following flaky tests while processing attachment 382716: imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker.html bug 202003 (author: youennf@gmail.com) The commit-queue is continuing to process your patch. 1586897 7 382716 commit-queue 2019-11-03 23:33:35 -0800 Comment on attachment 382716 Patch for landing Clearing flags on attachment: 382716 Committed r251979: <https://trac.webkit.org/changeset/251979> 382657 2019-11-01 17:06:53 -0700 2019-11-01 17:28:00 -0700 Patch bug-203771-20191101170652.patch text/plain 2501 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxODIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJlZDVlN2M4ZTNmMzgyZTk3 NmM5MjhlZGJkNDYyOGQyYmFlNjBkMmIuLjZmZjI2MTVhNDE4ODA4Y2M0MTYxYzZhNThlODU5N2Vj YTY4ZjNlZDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTktMTEtMDEgIEppZXdlbiBU YW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViQXV0aG5dIEN0YXBBdXRo ZW50aWNhdG9yOjp0cnlEb3duZ3JhZGUgc2hvdWxkIGRpc3Rpbmd1aXNoIHJlcXVlc3REYXRhKCku b3B0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjAzNzcxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NjgzMjYxOD4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDdGFwQXV0aGVudGljYXRvcjo6dHJ5 RG93bmdyYWRlIGFzc3VtZXMgdGhlIHJlcXVlc3QgaXMgYSBnZXRBc3NlcnRpb24gcmVxdWVzdC4g VGhpcyBpcyB0cnVlCisgICAgICAgIGZvciBtb3N0IGNhc2VzIGJ1dCBub3QgZm9yIEdvb2dsZSdz IHJlZ2lzdHJhdGlvbi4gRm9yIEdvb2dsZSdzIHJlZ2lzdHJhdGlvbiwgYSBxdWlyayBpcworICAg ICAgICBpbXBsZW1lbnRlZCB0byB1c2UgVTJGIGNvbW1hbmRzIGZvciByZWdpc3RyYXRpb24gaWYg R29vZ2xlTGVnYWN5QXBwSWRTdXBwb3J0RXh0ZW5zaW9uIGFza3MKKyAgICAgICAgdXMgdG8gZG8g c28uCisKKyAgICAgICAgTm8gdGVzdHMgZ2l2ZW4gdGhlcmUgaXMgbm8gd2F5IHRvIHNwb29mIGdv b2dsZS5jb20gaW4gb3VyIHRlc3QgaW5mcmFzdHJ1Y3R1cmVzLgorCisgICAgICAgICogVUlQcm9j ZXNzL1dlYkF1dGhlbnRpY2F0aW9uL2ZpZG8vQ3RhcEF1dGhlbnRpY2F0b3IuY3BwOgorICAgICAg ICAoV2ViS2l0OjpDdGFwQXV0aGVudGljYXRvcjo6dHJ5RG93bmdyYWRlKToKKwogMjAxOS0xMC0z MCAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihy MjUxNTY4KSBJZiB3ZSBkaWRuJ3Qgc3RhcnQgYSBTZXJ2aWNlIFdvcmtlciwgZG9uJ3QgdHJ5IHRh bGtpbmcgdG8gaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkF1dGhl bnRpY2F0aW9uL2ZpZG8vQ3RhcEF1dGhlbnRpY2F0b3IuY3BwIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvV2ViQXV0aGVudGljYXRpb24vZmlkby9DdGFwQXV0aGVudGljYXRvci5jcHAKaW5kZXgg NzU0Y2VkYjllYTUzNzRkOWNmY2M0M2ZlZDRhNjZjZmU3N2M1OTJlMi4uZmQyMzQ2ZmQyZDc3OWU2 Mjc1Y2U4M2EzOTFkNjA2MWVmZjZlOWNiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvV2ViQXV0aGVudGljYXRpb24vZmlkby9DdGFwQXV0aGVudGljYXRvci5jcHAKKysrIGIv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vZmlkby9DdGFwQXV0aGVu dGljYXRvci5jcHAKQEAgLTEwNywxMSArMTA3LDE4IEBAIGJvb2wgQ3RhcEF1dGhlbnRpY2F0b3I6 OnRyeURvd25ncmFkZSgpCiB7CiAgICAgaWYgKG1faW5mby52ZXJzaW9ucygpLmZpbmQoUHJvdG9j b2xWZXJzaW9uOjprVTJmKSA9PSBtX2luZm8udmVyc2lvbnMoKS5lbmQoKSkKICAgICAgICAgcmV0 dXJuIGZhbHNlOwotICAgIGlmICghaXNDb252ZXJ0aWJsZVRvVTJmU2lnbkNvbW1hbmQoV1RGOjpn ZXQ8UHVibGljS2V5Q3JlZGVudGlhbFJlcXVlc3RPcHRpb25zPihyZXF1ZXN0RGF0YSgpLm9wdGlv bnMpKSkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIGlmICghb2JzZXJ2ZXIoKSkKICAgICAg ICAgcmV0dXJuIGZhbHNlOwogCisgICAgYm9vbCBpc0NvbnZlcnRpYmxlID0gZmFsc2U7CisgICAg V1RGOjpzd2l0Y2hPbihyZXF1ZXN0RGF0YSgpLm9wdGlvbnMsIFsmXShjb25zdCBQdWJsaWNLZXlD cmVkZW50aWFsQ3JlYXRpb25PcHRpb25zJiBvcHRpb25zKSB7CisgICAgICAgIGlzQ29udmVydGli bGUgPSBpc0NvbnZlcnRpYmxlVG9VMmZSZWdpc3RlckNvbW1hbmQob3B0aW9ucyk7CisgICAgfSwg WyZdKGNvbnN0IFB1YmxpY0tleUNyZWRlbnRpYWxSZXF1ZXN0T3B0aW9ucyYgb3B0aW9ucykgewor ICAgICAgICBpc0NvbnZlcnRpYmxlID0gaXNDb252ZXJ0aWJsZVRvVTJmU2lnbkNvbW1hbmQob3B0 aW9ucyk7CisgICAgfSk7CisgICAgaWYgKCFpc0NvbnZlcnRpYmxlKQorICAgICAgICByZXR1cm4g ZmFsc2U7CisKICAgICBtX2lzRG93bmdyYWRlZCA9IHRydWU7CiAgICAgZHJpdmVyKCkuc2V0UHJv dG9jb2woUHJvdG9jb2xWZXJzaW9uOjprVTJmKTsKICAgICBvYnNlcnZlcigpLT5kb3duZ3JhZGUo dGhpcywgVTJmQXV0aGVudGljYXRvcjo6Y3JlYXRlKHJlbGVhc2VEcml2ZXIoKSkpOwo= 382716 2019-11-03 22:34:00 -0800 2019-11-03 23:33:35 -0800 Patch for landing bug-203771-20191103223400.patch text/plain 2503 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxODIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJlZDVlN2M4ZTNmMzgyZTk3 NmM5MjhlZGJkNDYyOGQyYmFlNjBkMmIuLjZmZTA1NzM4ZmU4ZGNiZTMyNmNkMWNiMDAyYmM2ZGJl OTk0YzU4ZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTktMTEtMDEgIEppZXdlbiBU YW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViQXV0aG5dIEN0YXBBdXRo ZW50aWNhdG9yOjp0cnlEb3duZ3JhZGUgc2hvdWxkIGRpc3Rpbmd1aXNoIHJlcXVlc3REYXRhKCku b3B0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjAzNzcxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NjgzMjYxOD4KKworICAgICAgICBSZXZp ZXdlZCBieSBCcmVudCBGdWxnaGFtLgorCisgICAgICAgIEN0YXBBdXRoZW50aWNhdG9yOjp0cnlE b3duZ3JhZGUgYXNzdW1lcyB0aGUgcmVxdWVzdCBpcyBhIGdldEFzc2VydGlvbiByZXF1ZXN0LiBU aGlzIGlzIHRydWUKKyAgICAgICAgZm9yIG1vc3QgY2FzZXMgYnV0IG5vdCBmb3IgR29vZ2xlJ3Mg cmVnaXN0cmF0aW9uLiBGb3IgR29vZ2xlJ3MgcmVnaXN0cmF0aW9uLCBhIHF1aXJrIGlzCisgICAg ICAgIGltcGxlbWVudGVkIHRvIHVzZSBVMkYgY29tbWFuZHMgZm9yIHJlZ2lzdHJhdGlvbiBpZiBH b29nbGVMZWdhY3lBcHBJZFN1cHBvcnRFeHRlbnNpb24gYXNrcworICAgICAgICB1cyB0byBkbyBz by4KKworICAgICAgICBObyB0ZXN0cyBnaXZlbiB0aGVyZSBpcyBubyB3YXkgdG8gc2ltdWxhdGUg Z29vZ2xlLmNvbSBpbiBvdXIgdGVzdCBpbmZyYXN0cnVjdHVyZXMuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvV2ViQXV0aGVudGljYXRpb24vZmlkby9DdGFwQXV0aGVudGljYXRvci5jcHA6CisgICAg ICAgIChXZWJLaXQ6OkN0YXBBdXRoZW50aWNhdG9yOjp0cnlEb3duZ3JhZGUpOgorCiAyMDE5LTEw LTMwICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9O KHIyNTE1NjgpIElmIHdlIGRpZG4ndCBzdGFydCBhIFNlcnZpY2UgV29ya2VyLCBkb24ndCB0cnkg dGFsa2luZyB0byBpdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0 aGVudGljYXRpb24vZmlkby9DdGFwQXV0aGVudGljYXRvci5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9XZWJBdXRoZW50aWNhdGlvbi9maWRvL0N0YXBBdXRoZW50aWNhdG9yLmNwcAppbmRl eCA3NTRjZWRiOWVhNTM3NGQ5Y2ZjYzQzZmVkNGE2NmNmZTc3YzU5MmUyLi5mZDIzNDZmZDJkNzc5 ZTYyNzVjZTgzYTM5MWQ2MDYxZWZmNmU5Y2IyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9XZWJBdXRoZW50aWNhdGlvbi9maWRvL0N0YXBBdXRoZW50aWNhdG9yLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJBdXRoZW50aWNhdGlvbi9maWRvL0N0YXBBdXRo ZW50aWNhdG9yLmNwcApAQCAtMTA3LDExICsxMDcsMTggQEAgYm9vbCBDdGFwQXV0aGVudGljYXRv cjo6dHJ5RG93bmdyYWRlKCkKIHsKICAgICBpZiAobV9pbmZvLnZlcnNpb25zKCkuZmluZChQcm90 b2NvbFZlcnNpb246OmtVMmYpID09IG1faW5mby52ZXJzaW9ucygpLmVuZCgpKQogICAgICAgICBy ZXR1cm4gZmFsc2U7Ci0gICAgaWYgKCFpc0NvbnZlcnRpYmxlVG9VMmZTaWduQ29tbWFuZChXVEY6 OmdldDxQdWJsaWNLZXlDcmVkZW50aWFsUmVxdWVzdE9wdGlvbnM+KHJlcXVlc3REYXRhKCkub3B0 aW9ucykpKQotICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgaWYgKCFvYnNlcnZlcigpKQogICAg ICAgICByZXR1cm4gZmFsc2U7CiAKKyAgICBib29sIGlzQ29udmVydGlibGUgPSBmYWxzZTsKKyAg ICBXVEY6OnN3aXRjaE9uKHJlcXVlc3REYXRhKCkub3B0aW9ucywgWyZdKGNvbnN0IFB1YmxpY0tl eUNyZWRlbnRpYWxDcmVhdGlvbk9wdGlvbnMmIG9wdGlvbnMpIHsKKyAgICAgICAgaXNDb252ZXJ0 aWJsZSA9IGlzQ29udmVydGlibGVUb1UyZlJlZ2lzdGVyQ29tbWFuZChvcHRpb25zKTsKKyAgICB9 LCBbJl0oY29uc3QgUHVibGljS2V5Q3JlZGVudGlhbFJlcXVlc3RPcHRpb25zJiBvcHRpb25zKSB7 CisgICAgICAgIGlzQ29udmVydGlibGUgPSBpc0NvbnZlcnRpYmxlVG9VMmZTaWduQ29tbWFuZChv cHRpb25zKTsKKyAgICB9KTsKKyAgICBpZiAoIWlzQ29udmVydGlibGUpCisgICAgICAgIHJldHVy biBmYWxzZTsKKwogICAgIG1faXNEb3duZ3JhZGVkID0gdHJ1ZTsKICAgICBkcml2ZXIoKS5zZXRQ cm90b2NvbChQcm90b2NvbFZlcnNpb246OmtVMmYpOwogICAgIG9ic2VydmVyKCktPmRvd25ncmFk ZSh0aGlzLCBVMmZBdXRoZW50aWNhdG9yOjpjcmVhdGUocmVsZWFzZURyaXZlcigpKSk7Cg==