203744 2019-11-01 09:57:42 -0700 Web Inspector: switching tabs should re-focus the previously focused element 2019-11-01 18:28:16 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 203743 1 hi hi bburg commit-queue eric.carlson hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1586410 0 hi 2019-11-01 09:57:42 -0700 # STEPS TO REPRODUCE: 1. inspect any page 2. select any item in the navigation sidebar of the Storage Tab 3. go to a different tab 4. go back to the Storage Tab => item selected in step #2 is no longer focused 1586413 1 382591 hi 2019-11-01 10:02:14 -0700 Created attachment 382591 Patch 1586487 2 382591 bburg 2019-11-01 12:04:52 -0700 Comment on attachment 382591 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382591&action=review r=me > Source/WebInspectorUI/UserInterface/Views/ContentBrowserTabContentView.js:317 > + if (treeElement) We still want selectedByUser = false, otherwise this will cause an extra history entry in the back/forward for the content area. 1586531 3 382591 hi 2019-11-01 13:52:38 -0700 Comment on attachment 382591 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382591&action=review >> Source/WebInspectorUI/UserInterface/Views/ContentBrowserTabContentView.js:317 >> + if (treeElement) > > We still want selectedByUser = false, otherwise this will cause an extra history entry in the back/forward for the content area. `selectedByUser` defaults to `false` if not provided (both due to the fact that `undefined` is falsy and that `WI.TreeOutline.prototype.selectTreeElementInternal` has an optional parameter) so the only change here should be to `omitFocus`. 1586705 4 382591 commit-queue 2019-11-01 18:27:21 -0700 Comment on attachment 382591 Patch Clearing flags on attachment: 382591 Committed r251962: <https://trac.webkit.org/changeset/251962> 1586706 5 commit-queue 2019-11-01 18:27:23 -0700 All reviewed patches have been landed. Closing bug. 1586707 6 webkit-bug-importer 2019-11-01 18:28:16 -0700 <rdar://problem/56834780> 382591 2019-11-01 10:02:14 -0700 2019-11-01 18:27:21 -0700 Patch 203744.diff text/plain 6729 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDhhOWE1NDI5OTA0Li44MTU3ZDJlZDJmYiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMTktMTEtMDEgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IHN3 aXRjaGluZyB0YWJzIHNob3VsZCByZS1mb2N1cyB0aGUgcHJldmlvdXNseSBmb2N1c2VkIGVsZW1l bnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMzc0 NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNl ckludGVyZmFjZS9WaWV3cy9UYWJCcm93c2VyLmpzOgorICAgICAgICAoV0kuVGFiQnJvd3Nlci5w cm90b3R5cGUuX3RhYkJhckl0ZW1TZWxlY3RlZCk6CisgICAgICAgIChXSS5UYWJCcm93c2VyLnBy b3RvdHlwZS5fc2F2ZUZvY3VzZWROb2RlRm9yVGFiQ29udGVudFZpZXcpOiBBZGRlZC4KKyAgICAg ICAgKFdJLlRhYkJyb3dzZXIucHJvdG90eXBlLl9yZXN0b3JlRm9jdXNlZE5vZGVGb3JUYWJDb250 ZW50Vmlldyk6IEFkZGVkLgorICAgICAgICBTdG9yZSB0aGUgYGRvY3VtZW50LmFjdGl2ZUVsZW1l bnRgIG9uIHRoZSBgV0kuVGFiQ29udGVudFZpZXdgIGFuZCBgLmZvY3VzKClgIGl0IGFmdGVyIHdl J3JlCisgICAgICAgIGRvbmUgc2hvd2luZyB0aGUgbmV3bHkgc2VsZWN0ZWQgdGFiLCBidXQgb25s eSBpZiB0aGVyZSBpc24ndCBhbHJlYWR5IHNvbWV0aGluZyBmb2N1c2VkLgorCisgICAgICAgICog VXNlckludGVyZmFjZS9WaWV3cy9UYWJCYXIuanM6CisgICAgICAgIChXSS5UYWJCYXIucHJvdG90 eXBlLnNldCBzZWxlY3RlZFRhYkJhckl0ZW0pOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmll d3MvTGVnYWN5VGFiQmFyLmpzOgorICAgICAgICAoV0kuTGVnYWN5VGFiQmFyLnByb3RvdHlwZS5z ZXQgc2VsZWN0ZWRUYWJCYXJJdGVtKToKKyAgICAgICAgSW5jbHVkZSB0aGUgcHJldmlvdXNseSBz ZWxlY3RlZCB0YWIgYmFyIGl0ZW0gd2hlbiBkaXNwYXRjaGluZyBzZWxlY3Rpb24gY2hhbmdlIGV2 ZW50cy4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQ29udGVudEJyb3dzZXJUYWJD b250ZW50Vmlldy5qczoKKyAgICAgICAgKFdJLkNvbnRlbnRCcm93c2VyVGFiQ29udGVudFZpZXcu cHJvdG90eXBlLl9yZXZlYWxBbmRTZWxlY3RSZXByZXNlbnRlZE9iamVjdCk6CisgICAgICAgIERv bid0IG9taXQgZm9jdXMgd2hlbiByZXZlYWxpbmcgcmVwcmVzZW50ZWQgb2JqZWN0cy4KKwogMjAx OS0xMC0zMSAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogVGltZWxpbmVzOiBhZGQgYSB0aW1lbGluZSB0aGF0IHNob3dzIGluZm9ybWF0 aW9uIGFib3V0IGFueSByZWNvcmRlZCBDU1MgYW5pbWF0aW9uL3RyYW5zaXRpb24KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnRlbnRCcm93 c2VyVGFiQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9Db250ZW50QnJvd3NlclRhYkNvbnRlbnRWaWV3LmpzCmluZGV4IGI2YmEwNTUwNmI1 Li4yZDc1YzBkYTY2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvQ29udGVudEJyb3dzZXJUYWJDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db250ZW50QnJvd3NlclRhYkNvbnRl bnRWaWV3LmpzCkBAIC0zMTQsMTIgKzMxNCw5IEBAIFdJLkNvbnRlbnRCcm93c2VyVGFiQ29udGVu dFZpZXcgPSBjbGFzcyBDb250ZW50QnJvd3NlclRhYkNvbnRlbnRWaWV3IGV4dGVuZHMgV0kuCiAK ICAgICAgICAgbGV0IHRyZWVFbGVtZW50ID0gdGhpcy50cmVlRWxlbWVudEZvclJlcHJlc2VudGVk T2JqZWN0KHJlcHJlc2VudGVkT2JqZWN0KTsKIAotICAgICAgICBpZiAodHJlZUVsZW1lbnQpIHsK LSAgICAgICAgICAgIGNvbnN0IG9taXRGb2N1cyA9IHRydWU7Ci0gICAgICAgICAgICBjb25zdCBz ZWxlY3RlZEJ5VXNlciA9IGZhbHNlOwotICAgICAgICAgICAgY29uc3Qgc3VwcHJlc3NOb3RpZmlj YXRpb24gPSBmYWxzZTsKLSAgICAgICAgICAgIHRyZWVFbGVtZW50LnJldmVhbEFuZFNlbGVjdChv bWl0Rm9jdXMsIHNlbGVjdGVkQnlVc2VyLCBzdXBwcmVzc05vdGlmaWNhdGlvbik7Ci0gICAgICAg IH0gZWxzZSBpZiAodGhpcy5uYXZpZ2F0aW9uU2lkZWJhclBhbmVsICYmIHRoaXMubmF2aWdhdGlv blNpZGViYXJQYW5lbC5jb250ZW50VHJlZU91dGxpbmUuc2VsZWN0ZWRUcmVlRWxlbWVudCkKKyAg ICAgICAgaWYgKHRyZWVFbGVtZW50KQorICAgICAgICAgICAgdHJlZUVsZW1lbnQucmV2ZWFsQW5k U2VsZWN0KCk7CisgICAgICAgIGVsc2UgaWYgKHRoaXMubmF2aWdhdGlvblNpZGViYXJQYW5lbCAm JiB0aGlzLm5hdmlnYXRpb25TaWRlYmFyUGFuZWwuY29udGVudFRyZWVPdXRsaW5lLnNlbGVjdGVk VHJlZUVsZW1lbnQpCiAgICAgICAgICAgICB0aGlzLm5hdmlnYXRpb25TaWRlYmFyUGFuZWwuY29u dGVudFRyZWVPdXRsaW5lLnNlbGVjdGVkVHJlZUVsZW1lbnQuZGVzZWxlY3QodHJ1ZSk7CiAgICAg fQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9MZWdhY3lUYWJCYXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9MZWdhY3lUYWJCYXIuanMKaW5kZXggMTBlMDdiMGZiOTAuLjY0ZmUyM2RkYjY5IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9MZWdhY3lU YWJCYXIuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv TGVnYWN5VGFiQmFyLmpzCkBAIC0zNzEsNiArMzcxLDggQEAgV0kuTGVnYWN5VGFiQmFyID0gY2xh c3MgTGVnYWN5VGFiQmFyIGV4dGVuZHMgV0kuVmlldwogICAgICAgICBpZiAodGhpcy5fc2VsZWN0 ZWRUYWJCYXJJdGVtID09PSB0YWJCYXJJdGVtKQogICAgICAgICAgICAgcmV0dXJuOwogCisgICAg ICAgIGxldCBwcmV2aW91c1RhYkJhckl0ZW0gPSB0aGlzLl9zZWxlY3RlZFRhYkJhckl0ZW07CisK ICAgICAgICAgaWYgKHRoaXMuX3NlbGVjdGVkVGFiQmFySXRlbSkKICAgICAgICAgICAgIHRoaXMu X3NlbGVjdGVkVGFiQmFySXRlbS5zZWxlY3RlZCA9IGZhbHNlOwogCkBAIC0zODIsNyArMzg0LDcg QEAgV0kuTGVnYWN5VGFiQmFyID0gY2xhc3MgTGVnYWN5VGFiQmFyIGV4dGVuZHMgV0kuVmlldwog ICAgICAgICAgICAgICAgIHRoaXMubmVlZHNMYXlvdXQoKTsKICAgICAgICAgfQogCi0gICAgICAg IHRoaXMuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdJLlRhYkJhci5FdmVudC5UYWJCYXJJdGVt U2VsZWN0ZWQpOworICAgICAgICB0aGlzLmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycyhXSS5UYWJC YXIuRXZlbnQuVGFiQmFySXRlbVNlbGVjdGVkLCB7cHJldmlvdXNUYWJCYXJJdGVtfSk7CiAgICAg fQogCiAgICAgZ2V0IHRhYkJhckl0ZW1zKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYkJhci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYkJhci5qcwppbmRleCA4ZmY3YzVlOTJmMy4uYTJiNWNi MDg4MDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL1RhYkJhci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9UYWJCYXIuanMKQEAgLTM0NCw2ICszNDQsOCBAQCBXSS5UYWJCYXIgPSBjbGFzcyBUYWJC YXIgZXh0ZW5kcyBXSS5WaWV3CiAgICAgICAgIGlmICh0aGlzLl9zZWxlY3RlZFRhYkJhckl0ZW0g PT09IHRhYkJhckl0ZW0pCiAgICAgICAgICAgICByZXR1cm47CiAKKyAgICAgICAgbGV0IHByZXZp b3VzVGFiQmFySXRlbSA9IHRoaXMuX3NlbGVjdGVkVGFiQmFySXRlbTsKKwogICAgICAgICBpZiAo dGhpcy5fc2VsZWN0ZWRUYWJCYXJJdGVtKQogICAgICAgICAgICAgdGhpcy5fc2VsZWN0ZWRUYWJC YXJJdGVtLnNlbGVjdGVkID0gZmFsc2U7CiAKQEAgLTM1NSw3ICszNTcsNyBAQCBXSS5UYWJCYXIg PSBjbGFzcyBUYWJCYXIgZXh0ZW5kcyBXSS5WaWV3CiAgICAgICAgICAgICAgICAgdGhpcy5uZWVk c0xheW91dCgpOwogICAgICAgICB9CiAKLSAgICAgICAgdGhpcy5kaXNwYXRjaEV2ZW50VG9MaXN0 ZW5lcnMoV0kuVGFiQmFyLkV2ZW50LlRhYkJhckl0ZW1TZWxlY3RlZCk7CisgICAgICAgIHRoaXMu ZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdJLlRhYkJhci5FdmVudC5UYWJCYXJJdGVtU2VsZWN0 ZWQsIHtwcmV2aW91c1RhYkJhckl0ZW19KTsKICAgICB9CiAKICAgICBnZXQgdGFiQmFySXRlbXMo KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv VGFiQnJvd3Nlci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1RhYkJyb3dzZXIuanMKaW5kZXggMmRlNzU5MmExNDAuLjY4OGJmZjc3MzU5IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UYWJCcm93c2VyLmpz CisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYkJyb3dz ZXIuanMKQEAgLTIyNiw2ICsyMjYsOCBAQCBXSS5UYWJCcm93c2VyID0gY2xhc3MgVGFiQnJvd3Nl ciBleHRlbmRzIFdJLlZpZXcKIAogICAgIF90YWJCYXJJdGVtU2VsZWN0ZWQoZXZlbnQpCiAgICAg eworICAgICAgICB0aGlzLl9zYXZlRm9jdXNlZE5vZGVGb3JUYWJDb250ZW50VmlldyhldmVudC5k YXRhLnByZXZpb3VzVGFiQmFySXRlbSA/IGV2ZW50LmRhdGEucHJldmlvdXNUYWJCYXJJdGVtLnJl cHJlc2VudGVkT2JqZWN0IDogbnVsbCk7CisKICAgICAgICAgbGV0IHRhYkNvbnRlbnRWaWV3ID0g dGhpcy5fdGFiQmFyLnNlbGVjdGVkVGFiQmFySXRlbSA/IHRoaXMuX3RhYkJhci5zZWxlY3RlZFRh YkJhckl0ZW0ucmVwcmVzZW50ZWRPYmplY3QgOiBudWxsOwogCiAgICAgICAgIGlmICh0YWJDb250 ZW50VmlldykgewpAQCAtMjU2LDYgKzI1OCw4IEBAIFdJLlRhYkJyb3dzZXIgPSBjbGFzcyBUYWJC cm93c2VyIGV4dGVuZHMgV0kuVmlldwogICAgICAgICB9CiAKICAgICAgICAgdGhpcy5kaXNwYXRj aEV2ZW50VG9MaXN0ZW5lcnMoV0kuVGFiQnJvd3Nlci5FdmVudC5TZWxlY3RlZFRhYkNvbnRlbnRW aWV3RGlkQ2hhbmdlKTsKKworICAgICAgICB0aGlzLl9yZXN0b3JlRm9jdXNlZE5vZGVGb3JUYWJD b250ZW50Vmlldyh0YWJDb250ZW50Vmlldyk7CiAgICAgfQogCiAgICAgX3RhYkJhckl0ZW1BZGRl ZChldmVudCkKQEAgLTM0MSw2ICszNDUsMjkgQEAgV0kuVGFiQnJvd3NlciA9IGNsYXNzIFRhYkJy b3dzZXIgZXh0ZW5kcyBXSS5WaWV3CiAgICAgICAgIH0KICAgICB9CiAKKyAgICBfc2F2ZUZvY3Vz ZWROb2RlRm9yVGFiQ29udGVudFZpZXcodGFiQ29udGVudFZpZXcpCisgICAgeworICAgICAgICBp ZiAoIXRhYkNvbnRlbnRWaWV3KQorICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgIGlmICgh V0kuaXNDb250ZW50QXJlYUZvY3VzZWQoKSkKKyAgICAgICAgICAgIHJldHVybjsKKworICAgICAg ICB0YWJDb250ZW50Vmlld1tXSS5UYWJCcm93c2VyLkZvY3VzZWROb2RlU3ltYm9sXSA9IGRvY3Vt ZW50LmFjdGl2ZUVsZW1lbnQ7CisgICAgfQorCisgICAgX3Jlc3RvcmVGb2N1c2VkTm9kZUZvclRh YkNvbnRlbnRWaWV3KHRhYkNvbnRlbnRWaWV3KQorICAgIHsKKyAgICAgICAgaWYgKCF0YWJDb250 ZW50VmlldykKKyAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICBsZXQgbm9kZSA9IHRhYkNv bnRlbnRWaWV3W1dJLlRhYkJyb3dzZXIuRm9jdXNlZE5vZGVTeW1ib2xdOworICAgICAgICBpZiAo bm9kZSAmJiAhV0kuaXNDb250ZW50QXJlYUZvY3VzZWQoKSkKKyAgICAgICAgICAgIG5vZGUuZm9j dXMoKTsKKworICAgICAgICB0YWJDb250ZW50Vmlld1tXSS5UYWJCcm93c2VyLkZvY3VzZWROb2Rl U3ltYm9sXSA9IG51bGw7CisgICAgfQorCiAgICAgX3Nob3dOYXZpZ2F0aW9uU2lkZWJhclBhbmVs Rm9yVGFiQ29udGVudFZpZXcodGFiQ29udGVudFZpZXcpCiAgICAgewogICAgICAgICBpZiAoIXRo aXMuX25hdmlnYXRpb25TaWRlYmFyKQpAQCAtNDU2LDYgKzQ4Myw3IEBAIFdJLlRhYkJyb3dzZXIg PSBjbGFzcyBUYWJCcm93c2VyIGV4dGVuZHMgV0kuVmlldwogfTsKIAogV0kuVGFiQnJvd3Nlci5O ZWVkc1Jlc2l6ZUxheW91dFN5bWJvbCA9IFN5bWJvbCgibmVlZHMtcmVzaXplLWxheW91dCIpOwor V0kuVGFiQnJvd3Nlci5Gb2N1c2VkTm9kZVN5bWJvbCA9IFN5bWJvbCgiZm9jdXNlZC1ub2RlIik7 CiAKIFdJLlRhYkJyb3dzZXIuRXZlbnQgPSB7CiAgICAgU2VsZWN0ZWRUYWJDb250ZW50Vmlld0Rp ZENoYW5nZTogInRhYi1icm93c2VyLXNlbGVjdGVkLXRhYi1jb250ZW50LXZpZXctZGlkLWNoYW5n ZSIK