203733 2019-11-01 06:11:39 -0700 TestWebKitAPI.EditorStateTests.TypingAttributesTextAlignmentStartEnd is flaky in iOS simulator 2019-11-01 11:27:08 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain wenson_hsieh aakash_jain ap bdakin commit-queue jbedard megan_gardner thorton webkit-bot-watchers-bugzilla webkit-bug-importer wenson_hsieh oldest_to_newest 1586329 0 aakash_jain 2019-11-01 06:11:39 -0700 TestWebKitAPI.EditorStateTests.TypingAttributesTextAlignmentStartEnd seems flaky on iOS. In https://ews-build.webkit.org/#/builders/9/builds/11291, the test passed in run-api-tests step. However, in the immediately next retry step (re-run-api-tests), it failed. 1586332 1 webkit-bug-importer 2019-11-01 06:20:35 -0700 <rdar://problem/56814640> 1586358 2 wenson_hsieh 2019-11-01 08:11:54 -0700 I’m unable to reproduce this failure locally (both by using --iterations 100, and by wrapping the test in a loop for 100 iterations and using --no-timeout). 1586380 3 382584 wenson_hsieh 2019-11-01 09:01:28 -0700 Created attachment 382584 Speculative fix 1586399 4 jbedard 2019-11-01 09:31:02 -0700 We had a string of failures awhile back on post-commit testers, https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.EditorStateTests.TypingAttributesTextAlignmentStartEnd&before_id=251111, but I doubt that's the same bug. My hunch here is that this is a timing problem and that our EWS bots are much faster than our trunk bots. 1586404 5 wenson_hsieh 2019-11-01 09:36:11 -0700 (In reply to Jonathan Bedard from comment #4) > We had a string of failures awhile back on post-commit testers, > https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI. > EditorStateTests.TypingAttributesTextAlignmentStartEnd&before_id=251111, but > I doubt that's the same bug. > > My hunch here is that this is a timing problem and that our EWS bots are > much faster than our trunk bots. Those failures appear to be due to an unrelated assertion that was presumably caused by r251090 (and later fixed in a rollout in r251106). ~2000 API tests were all failing in tandem during that time. 1586424 6 382584 thorton 2019-11-01 10:23:45 -0700 Comment on attachment 382584 Speculative fix View in context: https://bugs.webkit.org/attachment.cgi?id=382584&action=review > Tools/TestWebKitAPI/EditingTestHarness.mm:197 > + const NSTimeInterval loggingTimeout = 3; I think you should consider not having a timeout here, just depending on the test-wide timeout, to better integrate with e.g. --no-timeout 1586429 7 wenson_hsieh 2019-11-01 10:28:40 -0700 (In reply to Tim Horton from comment #6) > Comment on attachment 382584 [details] > Speculative fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=382584&action=review > > > Tools/TestWebKitAPI/EditingTestHarness.mm:197 > > + const NSTimeInterval loggingTimeout = 3; > > I think you should consider not having a timeout here, just depending on the > test-wide timeout, to better integrate with e.g. --no-timeout (We chatted about this over Slack) The timeout here is just for logging, to make sure that something useful gets logged to stdout in the case where the test does timeout. This would still respect any --time-out option specified via the harness. 1586457 8 commit-queue 2019-11-01 11:26:14 -0700 The commit-queue encountered the following flaky tests while processing attachment 382584: requestidlecallback/requestidlecallback-document-gc.html bug 203745 (author: rniwa@webkit.org) The commit-queue is continuing to process your patch. 1586458 9 382584 commit-queue 2019-11-01 11:27:07 -0700 Comment on attachment 382584 Speculative fix Clearing flags on attachment: 382584 Committed r251931: <https://trac.webkit.org/changeset/251931> 1586459 10 commit-queue 2019-11-01 11:27:08 -0700 All reviewed patches have been landed. Closing bug. 382584 2019-11-01 09:01:28 -0700 2019-11-01 11:27:07 -0700 Speculative fix bug-203733-20191101090128.patch text/plain 2669 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxOTA4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2RkMDcwM2QwMjAyYjNhNjBmMzc3MjNmNjU4N2IwYjUx MjU4YTYyNy4uMjU3MmVjODgwZjIyYzYxYTcwODZlZmY3YjI5ZDJhNzAwNDNhMmQ2YiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDE5LTExLTAxICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgor CisgICAgICAgIFRlc3RXZWJLaXRBUEkuRWRpdG9yU3RhdGVUZXN0cy5UeXBpbmdBdHRyaWJ1dGVz VGV4dEFsaWdubWVudFN0YXJ0RW5kIGlzIGZsYWt5IGluIGlPUyBzaW11bGF0b3IKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMzczMworICAgICAgICA8 cmRhcjovL3Byb2JsZW0vNTY4MTQ2NDA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVHJ5IHRvIGZpeCB0aGUgZmxha3kgdGVzdCBieSBtYWtpbmcgRWRp dGluZ1Rlc3RIYXJuZXNzIG1vcmUgcm9idXN0LiBJbnN0ZWFkIG9mIGNoZWNraW5nIGZvciBleHBl Y3RlZCBlZGl0b3IKKyAgICAgICAgc3RhdGUgZW50cmllcyBhZnRlciB0aGUgbmV4dCBwcmVzZW50 YXRpb24gdXBkYXRlLCB3YWl0IGZvciB0aGUgbGF0ZXN0IGVkaXRvciBzdGF0ZSBlbnRyeSB0byBj b250YWluIHRoZSBleHBlY3RlZAorICAgICAgICB2YWx1ZXMuCisKKyAgICAgICAgKiBUZXN0V2Vi S2l0QVBJL0VkaXRpbmdUZXN0SGFybmVzcy5tbToKKyAgICAgICAgKC1bRWRpdGluZ1Rlc3RIYXJu ZXNzIF9leGVjQ29tbWFuZDphcmd1bWVudDpleHBlY3RFbnRyaWVzOl0pOgorCisgICAgICAgIFBy ZXNlcnZlIHRoZSBleGlzdGluZyBsb2cgc3RhdGVtZW50IGJ5IHByaW50aW5nIGl0IG91dCBvbmNl IGFmdGVyIGEgZmV3IHNlY29uZHMsIGlmIHRoZSBlbnRyeSBpcyBzdGlsbCBub3QgZm91bmQKKyAg ICAgICAgaW4gdGhlIGxhc3Qga25vd24gZWRpdG9yIHN0YXRlLgorCiAyMDE5LTEwLTMxICBKb25h dGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChy MjUxODA4KTogcnVuLXdlYmtpdC10ZXN0IGNhbm5vdCBzaG93IHJlc3VsdHMuaHRtbApkaWZmIC0t Z2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9FZGl0aW5nVGVzdEhhcm5lc3MubW0gYi9Ub29scy9U ZXN0V2ViS2l0QVBJL0VkaXRpbmdUZXN0SGFybmVzcy5tbQppbmRleCAwYTgyMzdhNzE4MDc2MGRl MzQ4MzIxNTgzNmY3ZWZjYmZjNmRmMTBiLi5mMDk2ZmI3NTZmMDA0M2U2MzY2ZGVjNGYwMWE5MGJj MWQwNzM3YzNiIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL0VkaXRpbmdUZXN0SGFy bmVzcy5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL0VkaXRpbmdUZXN0SGFybmVzcy5tbQpA QCAtMTkwLDE2ICsxOTAsMjIgQEAgLSAodm9pZClfZXhlY0NvbW1hbmQ6KE5TU3RyaW5nICopY29t bWFuZCBhcmd1bWVudDooTlNTdHJpbmcgKilhcmd1bWVudCBleHBlY3RFbnQKICAgICB9XTsKICAg ICBUZXN0V2ViS2l0QVBJOjpVdGlsOjpydW4oJmRvbmUpOwogCi0gICAgW193ZWJWaWV3IHdhaXRG b3JOZXh0UHJlc2VudGF0aW9uVXBkYXRlXTsKLQogICAgIEVYUEVDVF9UUlVFKHJlc3VsdCk7CiAg ICAgaWYgKCFyZXN1bHQpCiAgICAgICAgIE5TTG9nKEAiRmFpbGVkIHRvIGV4ZWN1dGUgZWRpdGlu ZyBjb21tYW5kOiAoJyVAJywgJyVAJykiLCBjb21tYW5kLCBhcmd1bWVudCA/OiBAIiIpOwogCi0g ICAgQk9PTCBjb250YWluc0VudHJpZXMgPSBbc2VsZiBsYXRlc3RFZGl0b3JTdGF0ZUNvbnRhaW5z OmVudHJpZXNdOwotICAgIEVYUEVDVF9UUlVFKGNvbnRhaW5zRW50cmllcyk7Ci0gICAgaWYgKCFj b250YWluc0VudHJpZXMpCi0gICAgICAgIE5TTG9nKEAiRXhwZWN0ZWQgJUAgdG8gY29udGFpbiAl QCIsIHNlbGYubGF0ZXN0RWRpdG9yU3RhdGUsIGVudHJpZXMpOworICAgIGNvbnN0IE5TVGltZUlu dGVydmFsIGxvZ2dpbmdUaW1lb3V0ID0gMzsKKyAgICBhdXRvIHN0YXJ0VGltZSA9IHJldGFpblB0 cihbTlNEYXRlIGRhdGVdKTsKKyAgICBCT09MIGhhc0xvZ2dlZFdhcm5pbmcgPSBOTzsKKyAgICBC T09MIGNvbnRhaW5zRW50cmllczsKKyAgICBkbyB7CisgICAgICAgIFtfd2ViVmlldyB3YWl0Rm9y TmV4dFByZXNlbnRhdGlvblVwZGF0ZV07CisgICAgICAgIGNvbnRhaW5zRW50cmllcyA9IFtzZWxm IGxhdGVzdEVkaXRvclN0YXRlQ29udGFpbnM6ZW50cmllc107CisgICAgICAgIGlmICghaGFzTG9n Z2VkV2FybmluZyAmJiBbW05TRGF0ZSBkYXRlXSB0aW1lSW50ZXJ2YWxTaW5jZURhdGU6c3RhcnRU aW1lLmdldCgpXSA+IGxvZ2dpbmdUaW1lb3V0KSB7CisgICAgICAgICAgICBOU0xvZyhAIkV4cGVj dGVkICVAIHRvIGNvbnRhaW4gJUAiLCBzZWxmLmxhdGVzdEVkaXRvclN0YXRlLCBlbnRyaWVzKTsK KyAgICAgICAgICAgIGhhc0xvZ2dlZFdhcm5pbmcgPSBZRVM7CisgICAgICAgIH0KKyAgICB9IHdo aWxlICghY29udGFpbnNFbnRyaWVzKTsKIH0KIAogLSAoQk9PTClsYXRlc3RFZGl0b3JTdGF0ZUNv bnRhaW5zOihOU0RpY3Rpb25hcnk8TlNTdHJpbmcgKiwgaWQ+ICopZW50cmllcwo=