203689 2019-10-31 12:19:47 -0700 AX: Restrict WebSpeech voices to built-in voices only 2019-11-01 17:54:13 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach commit-queue pvollan webkit-bug-importer oldest_to_newest 1586005 0 cfleizach 2019-10-31 12:19:47 -0700 Restrict the list of voices to built-in voices when requested over the web to reduce fingerprinting abilities. <rdar://problem/56232533> 1586015 1 382486 cfleizach 2019-10-31 12:36:15 -0700 Created attachment 382486 patch 1586016 2 cfleizach 2019-10-31 12:36:44 -0700 Per can you review? 1586641 3 382486 pvollan 2019-11-01 16:30:46 -0700 Comment on attachment 382486 patch View in context: https://bugs.webkit.org/attachment.cgi?id=382486&action=review > Source/WebCore/platform/ios/PlatformSpeechSynthesizerIOS.mm:268 > + if (voice.quality == AVSpeechSynthesisVoiceQualityDefault) Does only the built-in voices have this quality? 1586642 4 382486 cfleizach 2019-11-01 16:31:35 -0700 Comment on attachment 382486 patch View in context: https://bugs.webkit.org/attachment.cgi?id=382486&action=review >> Source/WebCore/platform/ios/PlatformSpeechSynthesizerIOS.mm:268 >> + if (voice.quality == AVSpeechSynthesisVoiceQualityDefault) > > Does only the built-in voices have this quality? yes 1586653 5 382486 pvollan 2019-11-01 16:45:34 -0700 Comment on attachment 382486 patch R=me. 1586696 6 commit-queue 2019-11-01 17:53:19 -0700 The commit-queue encountered the following flaky tests while processing attachment 382486: imported/w3c/web-platform-tests/svg/text/visualtests/text-inline-size-003-visual.svg bug 203172 (author: sabouhallawa@apple.com) imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker.html bug 202003 (author: youennf@gmail.com) The commit-queue is continuing to process your patch. 1586697 7 382486 commit-queue 2019-11-01 17:54:11 -0700 Comment on attachment 382486 patch Clearing flags on attachment: 382486 Committed r251960: <https://trac.webkit.org/changeset/251960> 1586698 8 commit-queue 2019-11-01 17:54:13 -0700 All reviewed patches have been landed. Closing bug. 382486 2019-10-31 12:36:15 -0700 2019-11-01 17:54:11 -0700 patch file_203689.txt text/plain 1719 cfleizach ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZw0KaW5kZXggYmVkMDAwOWZlMTguLjdjZjFhZDYxMGMyIDEwMDY0NA0KLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nDQorKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cNCkBA IC0xLDMgKzEsMTUgQEANCisyMDE5LTEwLTMxICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBh cHBsZS5jb20+DQorDQorICAgICAgICBBWDogUmVzdHJpY3QgV2ViU3BlZWNoIHZvaWNlcyB0byBi dWlsdC1pbiB2b2ljZXMgb25seQ0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIwMzY4OQ0KKw0KKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuDQorDQorICAgICAgICBPbmx5IHNob3cgYnVpbHQtaW4gdm9pY2VzIHdoZW4gcmVxdWVzdGlu ZyB0aHJvdWdoIFdlYktpdCB0byByZWR1Y2UgZmluZ2VycHJpbnRpbmcgc3VyZmFjZSBhcmVhLiAN CisNCisgICAgICAgICogcGxhdGZvcm0vaW9zL1BsYXRmb3JtU3BlZWNoU3ludGhlc2l6ZXJJT1Mu bW06DQorICAgICAgICAoV2ViQ29yZTo6UGxhdGZvcm1TcGVlY2hTeW50aGVzaXplcjo6aW5pdGlh bGl6ZVZvaWNlTGlzdCk6DQorDQogMjAxOS0xMC0zMSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Vi a2l0Lm9yZz4NCiANCiAgICAgICAgIEludGVncmF0ZSByZXNpemUgZXZlbnQgd2l0aCBIVE1MNSBl dmVudCBsb29wDQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1BsYXRm b3JtU3BlZWNoU3ludGhlc2l6ZXJJT1MubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mv UGxhdGZvcm1TcGVlY2hTeW50aGVzaXplcklPUy5tbQ0KaW5kZXggN2NhZjQ4MmQ3MGYuLmJjOGJm YzI3Yzg2IDEwMDY0NA0KLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1BsYXRmb3Jt U3BlZWNoU3ludGhlc2l6ZXJJT1MubW0NCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lv cy9QbGF0Zm9ybVNwZWVjaFN5bnRoZXNpemVySU9TLm1tDQpAQCAtMjYzLDcgKzI2MywxMCBAQCB2 b2lkIFBsYXRmb3JtU3BlZWNoU3ludGhlc2l6ZXI6OmluaXRpYWxpemVWb2ljZUxpc3QoKQ0KICAg ICAgICAgYm9vbCBpc0RlZmF1bHQgPSB0cnVlOw0KICAgICAgICAgTlNTdHJpbmcgKnZvaWNlVVJJ ID0gW3ZvaWNlIGlkZW50aWZpZXJdOw0KICAgICAgICAgTlNTdHJpbmcgKm5hbWUgPSBbdm9pY2Ug bmFtZV07DQotICAgICAgICBtX3ZvaWNlTGlzdC5hcHBlbmQoUGxhdGZvcm1TcGVlY2hTeW50aGVz aXNWb2ljZTo6Y3JlYXRlKHZvaWNlVVJJLCBuYW1lLCBsYW5ndWFnZSwgdHJ1ZSwgaXNEZWZhdWx0 KSk7DQorICAgICAgICANCisgICAgICAgIC8vIE9ubHkgc2hvdyBidWlsdC1pbiB2b2ljZXMgd2hl biByZXF1ZXN0aW5nIHRocm91Z2ggV2ViS2l0IHRvIHJlZHVjZSBmaW5nZXJwcmludGluZyBzdXJm YWNlIGFyZWEuDQorICAgICAgICBpZiAodm9pY2UucXVhbGl0eSA9PSBBVlNwZWVjaFN5bnRoZXNp c1ZvaWNlUXVhbGl0eURlZmF1bHQpDQorICAgICAgICAgICAgbV92b2ljZUxpc3QuYXBwZW5kKFBs YXRmb3JtU3BlZWNoU3ludGhlc2lzVm9pY2U6OmNyZWF0ZSh2b2ljZVVSSSwgbmFtZSwgbGFuZ3Vh Z2UsIHRydWUsIGlzRGVmYXVsdCkpOw0KICAgICB9DQogICAgIEVORF9CTE9DS19PQkpDX0VYQ0VQ VElPTlMNCiB9