203488 2019-10-28 08:02:30 -0700 REGRESSION(r251651): It's causing crashes in several tests (Requested by KaL on #webkit). 2019-10-28 08:08:42 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 201727 1 commit-queue commit-queue cgarcia cturner webkit-bug-importer oldest_to_newest 1584447 0 commit-queue 2019-10-28 08:02:30 -0700 https://trac.webkit.org/changeset/251651 broke the build: It's causing crashes in several tests (Requested by KaL on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1584449 1 382070 commit-queue 2019-10-28 08:02:37 -0700 Created attachment 382070 ROLLOUT of r251651 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1584450 2 382070 commit-queue 2019-10-28 08:06:14 -0700 Comment on attachment 382070 ROLLOUT of r251651 Clearing flags on attachment: 382070 Committed r251654: <https://trac.webkit.org/changeset/251654> 1584451 3 commit-queue 2019-10-28 08:06:16 -0700 All reviewed patches have been landed. Closing bug. 1584452 4 webkit-bug-importer 2019-10-28 08:08:42 -0700 <rdar://problem/56669547> 382070 2019-10-28 08:02:37 -0700 2019-10-28 08:06:14 -0700 ROLLOUT of r251651 bug-203488-20191028080236.patch text/plain 5601 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxNjUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzY0NDU5MjViMzRiYTM4 NmViMzBiZjdjNmEzN2QwYzI1MzViYzQxYy4uMmIyN2U1NjVjYzI1NTk2NzY0YTViZjJkMmEyMDNh OGM1NDc4NmExZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTEwLTI4ICBDb21t aXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KKworICAgICAgICBVbnJldmlld2Vk LCByb2xsaW5nIG91dCByMjUxNjUxLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjAzNDg4CisKKyAgICAgICAgSXQncyBjYXVzaW5nIGNyYXNoZXMgaW4g c2V2ZXJhbCB0ZXN0cyAoUmVxdWVzdGVkIGJ5IEthTCBvbgorICAgICAgICAjd2Via2l0KS4KKwor ICAgICAgICBSZXZlcnRlZCBjaGFuZ2VzZXQ6CisKKyAgICAgICAgIkltYWdlRGVjb2RlcnM6IHVz ZSBhIHRocmVhZCBzYWZlIGRhdGEgYnVmZmVyIGZvciBDYWlybworICAgICAgICBiYWNraW5nIHN0 b3JlIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAx NzI3CisgICAgICAgIGh0dHBzOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8yNTE2NTEKKwog MjAxOS0xMC0yOCAgQ2hhcmxpZSBUdXJuZXIgIDxjdHVybmVyQGlnYWxpYS5jb20+CiAKICAgICAg ICAgSW1hZ2VEZWNvZGVyczogdXNlIGEgdGhyZWFkIHNhZmUgZGF0YSBidWZmZXIgZm9yIENhaXJv IGJhY2tpbmcgc3RvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL0ltYWdlQmFja2luZ1N0b3JlLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9JbWFnZUJhY2tpbmdTdG9yZS5oCmluZGV4IGZiMDRhYjUwYjNhNDA2OWFmNWE5MzVhNjNiZTQ5 NmI0MTQ4ZWEwY2EuLmFlNjVjZDAyNGVkNTk1YjE1NTUyN2NlMDhmOTQ1ZjFlZWU5Zjc3YWYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlQmFja2luZ1N0 b3JlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VCYWNraW5n U3RvcmUuaApAQCAtNTksMTEgKzU5LDE1IEBAIHB1YmxpYzoKICAgICAgICAgaWYgKHNpemUuaXNF bXB0eSgpKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgICAgIG1fcGl4ZWxzID0g UkdCQVBpeGVsQnVmZmVyVGhyZWFkU2FmZVJlZkNvdW50ZWQ6OmNyZWF0ZShzaXplKTsKKyAgICAg ICAgVmVjdG9yPGNoYXI+IGJ1ZmZlcjsKKyAgICAgICAgc2l6ZV90IGJ1ZmZlclNpemUgPSBzaXpl LmFyZWEoKS51bnNhZmVHZXQoKSAqIHNpemVvZihSR0JBMzIpOwogCi0gICAgICAgIGlmICghbV9w aXhlbHMtPmlzVmFsaWQoKSkKKyAgICAgICAgaWYgKCFidWZmZXIudHJ5UmVzZXJ2ZUNhcGFjaXR5 KGJ1ZmZlclNpemUpKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogCisgICAgICAgIGJ1ZmZl ci5ncm93KGJ1ZmZlclNpemUpOworICAgICAgICBtX3BpeGVscyA9IFNoYXJlZEJ1ZmZlcjo6Y3Jl YXRlKFdURk1vdmUoYnVmZmVyKSk7CisgICAgICAgIG1fcGl4ZWxzUHRyID0gcmVpbnRlcnByZXRf Y2FzdDxSR0JBMzIqPihjb25zdF9jYXN0PGNoYXIqPihtX3BpeGVscy0+ZGF0YSgpKSk7CiAgICAg ICAgIG1fc2l6ZSA9IHNpemU7CiAgICAgICAgIG1fZnJhbWVSZWN0ID0gSW50UmVjdChJbnRQb2lu dCgpLCBtX3NpemUpOwogICAgICAgICBjbGVhcigpOwpAQCAtODIsNyArODYsNyBAQCBwdWJsaWM6 CiAKICAgICB2b2lkIGNsZWFyKCkKICAgICB7Ci0gICAgICAgIG1fcGl4ZWxzLT56ZXJvUGl4ZWxE YXRhKCk7CisgICAgICAgIG1lbXNldChtX3BpeGVsc1B0ciwgMCwgKG1fc2l6ZS5hcmVhKCkgKiBz aXplb2YoUkdCQTMyKSkudW5zYWZlR2V0KCkpOwogICAgIH0KIAogICAgIHZvaWQgY2xlYXJSZWN0 KGNvbnN0IEludFJlY3QmIHJlY3QpCkBAIC0xMjksNyArMTMzLDcgQEAgcHVibGljOgogICAgIFJH QkEzMiogcGl4ZWxBdChpbnQgeCwgaW50IHkpIGNvbnN0CiAgICAgewogICAgICAgICBBU1NFUlQo aW5Cb3VuZHMoSW50UG9pbnQoeCwgeSkpKTsKLSAgICAgICAgcmV0dXJuIG1fcGl4ZWxzLT5waXhl bEF0KHgsIHkpOworICAgICAgICByZXR1cm4gbV9waXhlbHNQdHIgKyB5ICogbV9zaXplLndpZHRo KCkgKyB4OwogICAgIH0KIAogICAgIHZvaWQgc2V0UGl4ZWwoUkdCQTMyKiBkZXN0LCB1bnNpZ25l ZCByLCB1bnNpZ25lZCBnLCB1bnNpZ25lZCBiLCB1bnNpZ25lZCBhKQpAQCAtMTg1LDI3ICsxODks NiBAQCBwdWJsaWM6CiAgICAgfQogCiBwcml2YXRlOgotICAgIGNsYXNzIFJHQkFQaXhlbEJ1ZmZl clRocmVhZFNhZmVSZWZDb3VudGVkIDogcHVibGljIFRocmVhZFNhZmVSZWZDb3VudGVkPFJHQkFQ aXhlbEJ1ZmZlclRocmVhZFNhZmVSZWZDb3VudGVkPiB7Ci0gICAgcHVibGljOgotICAgICAgICBz dGF0aWMgUmVmPFJHQkFQaXhlbEJ1ZmZlclRocmVhZFNhZmVSZWZDb3VudGVkPiBjcmVhdGUoY29u c3QgSW50U2l6ZSYgaW5pdGlhbFNpemUpIHsgcmV0dXJuIGFkb3B0UmVmKCpuZXcgUkdCQVBpeGVs QnVmZmVyVGhyZWFkU2FmZVJlZkNvdW50ZWQoaW5pdGlhbFNpemUpKTsgfQotICAgICAgICB2b2lk IHplcm9QaXhlbERhdGEoKSB7IG1fcGl4ZWxzLmZpbGwoMCk7IH0KLSAgICAgICAgUkdCQTMyKiBw aXhlbEF0KGludCB4LCBpbnQgeSkgY29uc3QgeyByZXR1cm4gY29uc3RfY2FzdDx1bnNpZ25lZCo+ KCZtX3BpeGVscy5kYXRhKClbeSAqIG1fc2l6ZS53aWR0aCgpICsgeF0pOyB9Ci0gICAgICAgIGNv bnN0IFJHQkEzMiogZGF0YSgpIGNvbnN0IHsgcmV0dXJuIG1fcGl4ZWxzLmRhdGEoKTsgfQotICAg ICAgICBib29sIGlzVmFsaWQoKSBjb25zdCB7IHJldHVybiBtX2lzVmFsaWQ7IH0KLSAgICBwcml2 YXRlOgotICAgICAgICBSR0JBUGl4ZWxCdWZmZXJUaHJlYWRTYWZlUmVmQ291bnRlZChjb25zdCBJ bnRTaXplJiBpbml0aWFsU2l6ZSkKLSAgICAgICAgICAgIDogbV9zaXplKGluaXRpYWxTaXplKQot ICAgICAgICB7Ci0gICAgICAgICAgICB1bnNpZ25lZCBidWZmZXJTaXplID0gaW5pdGlhbFNpemUu YXJlYSgpLnVuc2FmZUdldCgpOwotICAgICAgICAgICAgbV9pc1ZhbGlkID0gbV9waXhlbHMudHJ5 UmVzZXJ2ZUNhcGFjaXR5KGJ1ZmZlclNpemUpOwotICAgICAgICAgICAgaWYgKG1faXNWYWxpZCkK LSAgICAgICAgICAgICAgICBtX3BpeGVscy5yZXNpemUoYnVmZmVyU2l6ZSk7Ci0gICAgICAgIH0K LSAgICAgICAgSW50U2l6ZSBtX3NpemU7Ci0gICAgICAgIFZlY3RvcjxSR0JBMzI+IG1fcGl4ZWxz OwotICAgICAgICBib29sIG1faXNWYWxpZCB7IGZhbHNlIH07Ci0gICAgfTsKLQogICAgIEltYWdl QmFja2luZ1N0b3JlKGNvbnN0IEludFNpemUmIHNpemUsIGJvb2wgcHJlbXVsdGlwbHlBbHBoYSA9 IHRydWUpCiAgICAgICAgIDogbV9wcmVtdWx0aXBseUFscGhhKHByZW11bHRpcGx5QWxwaGEpCiAg ICAgewpAQCAtMjE4LDYgKzIwMSw4IEBAIHByaXZhdGU6CiAgICAgICAgICwgbV9wcmVtdWx0aXBs eUFscGhhKG90aGVyLm1fcHJlbXVsdGlwbHlBbHBoYSkKICAgICB7CiAgICAgICAgIEFTU0VSVCgh bV9zaXplLmlzRW1wdHkoKSAmJiAhaXNPdmVyU2l6ZShtX3NpemUpKTsKKyAgICAgICAgbV9waXhl bHMgPSBTaGFyZWRCdWZmZXI6OmNyZWF0ZShvdGhlci5tX3BpeGVscy0+ZGF0YSgpLCBvdGhlci5t X3BpeGVscy0+c2l6ZSgpKTsKKyAgICAgICAgbV9waXhlbHNQdHIgPSByZWludGVycHJldF9jYXN0 PFJHQkEzMio+KGNvbnN0X2Nhc3Q8Y2hhcio+KG1fcGl4ZWxzLT5kYXRhKCkpKTsKICAgICB9CiAK ICAgICBib29sIGluQm91bmRzKGNvbnN0IEludFBvaW50JiBwb2ludCkgY29uc3QKQEAgLTI0MSw4 ICsyMjYsOCBAQCBwcml2YXRlOgogICAgICAgICByZXR1cm4gbWFrZVJHQkEociwgZywgYiwgYSk7 CiAgICAgfQogCi0gICAgUmVmUHRyPFJHQkFQaXhlbEJ1ZmZlclRocmVhZFNhZmVSZWZDb3VudGVk PiBtX3BpeGVsczsKLQorICAgIFJlZlB0cjxTaGFyZWRCdWZmZXI+IG1fcGl4ZWxzOworICAgIFJH QkEzMiogbV9waXhlbHNQdHIgeyBudWxscHRyIH07CiAgICAgSW50U2l6ZSBtX3NpemU7CiAgICAg SW50UmVjdCBtX2ZyYW1lUmVjdDsgLy8gVGhpcyB3aWxsIGFsd2F5cyBqdXN0IGJlIHRoZSBlbnRp cmUgYnVmZmVyIGV4Y2VwdCBmb3IgR0lGIGFuZCBQTkcgZnJhbWVzCiAgICAgYm9vbCBtX3ByZW11 bHRpcGx5QWxwaGEgeyB0cnVlIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9pbWFnZS1kZWNvZGVycy9jYWlyby9JbWFnZUJhY2tpbmdTdG9yZUNhaXJvLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2NhaXJvL0ltYWdlQmFja2luZ1N0b3Jl Q2Fpcm8uY3BwCmluZGV4IGM1ZmY4ZjMyOTU1OWJlODU5NmM5Yjc0NjliMTgwMTg4ZTFlNGY2NGYu LmU4MjcwYjBlOTdmMjhkNTI3NTNiMzY3MTQ0NmZiYWY2YmRkYmIwM2YgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2NhaXJvL0ltYWdlQmFja2luZ1N0 b3JlQ2Fpcm8uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJz L2NhaXJvL0ltYWdlQmFja2luZ1N0b3JlQ2Fpcm8uY3BwCkBAIC0zNCwxMCArMzQsMTAgQEAgTmF0 aXZlSW1hZ2VQdHIgSW1hZ2VCYWNraW5nU3RvcmU6OmltYWdlKCkgY29uc3QKIHsKICAgICBtX3Bp eGVscy0+cmVmKCk7CiAgICAgUmVmUHRyPGNhaXJvX3N1cmZhY2VfdD4gc3VyZmFjZSA9IGFkb3B0 UmVmKGNhaXJvX2ltYWdlX3N1cmZhY2VfY3JlYXRlX2Zvcl9kYXRhKAotICAgICAgICByZWludGVy cHJldF9jYXN0PHVuc2lnbmVkIGNoYXIqPihjb25zdF9jYXN0PHVpbnQzMl90Kj4obV9waXhlbHMt PmRhdGEoKSkpLAorICAgICAgICByZWludGVycHJldF9jYXN0PHVuc2lnbmVkIGNoYXIqPihjb25z dF9jYXN0PHVpbnQzMl90Kj4obV9waXhlbHNQdHIpKSwKICAgICAgICAgQ0FJUk9fRk9STUFUX0FS R0IzMiwgc2l6ZSgpLndpZHRoKCksIHNpemUoKS5oZWlnaHQoKSwgc2l6ZSgpLndpZHRoKCkgKiBz aXplb2YodWludDMyX3QpKSk7CiAgICAgc3RhdGljIGNhaXJvX3VzZXJfZGF0YV9rZXlfdCBzX3N1 cmZhY2VEYXRhS2V5OwotICAgIGNhaXJvX3N1cmZhY2Vfc2V0X3VzZXJfZGF0YShzdXJmYWNlLmdl dCgpLCAmc19zdXJmYWNlRGF0YUtleSwgbV9waXhlbHMuZ2V0KCksIFtdKHZvaWQqIGRhdGEpIHsg c3RhdGljX2Nhc3Q8UkdCQVBpeGVsQnVmZmVyVGhyZWFkU2FmZVJlZkNvdW50ZWQqPihkYXRhKS0+ ZGVyZWYoKTsgfSk7CisgICAgY2Fpcm9fc3VyZmFjZV9zZXRfdXNlcl9kYXRhKHN1cmZhY2UuZ2V0 KCksICZzX3N1cmZhY2VEYXRhS2V5LCBtX3BpeGVscy5nZXQoKSwgW10odm9pZCogZGF0YSkgeyBz dGF0aWNfY2FzdDxTaGFyZWRCdWZmZXIqPihkYXRhKS0+ZGVyZWYoKTsgfSk7CiAKICAgICByZXR1 cm4gc3VyZmFjZTsKIH0K