<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>20342</bug_id>
          
          <creation_ts>2008-08-10 19:56:35 -0700</creation_ts>
          <short_desc>REGRESSION: fast/dom/cssTarget-crash.html fails</short_desc>
          <delta_ts>2011-03-08 11:57:31 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>http://build.webkit.org/results/trunk-mac-ppc-release/14064/fast/dom/cssTarget-crash-diffs.txt</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar, LayoutTestFailure, Regression</keywords>
          <priority>P1</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>mitz</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>ap</cc>
    
    <cc>arv</cc>
    
    <cc>darin</cc>
    
    <cc>ddkilzer</cc>
    
    <cc>eric</cc>
    
    <cc>japhet</cc>
    
    <cc>maheshk</cc>
    
    <cc>tonikitoo</cc>
    
    <cc>webkit.review.bot</cc>
    
    <cc>yael</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>88190</commentid>
    <comment_count>0</comment_count>
    <who name="">mitz</who>
    <bug_when>2008-08-10 19:56:35 -0700</bug_when>
    <thetext>fast/dom/cssTarget-crash.html fails on build.webkit.org and locally.

I think that is also what&apos;s causing fast/dom/defaultView.html to appear to be failing.

The failure may be related to &lt;http://trac.webkit.org/changeset/35611&gt;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>88191</commentid>
    <comment_count>1</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2008-08-10 20:22:55 -0700</bug_when>
    <thetext>Test was added in in r29311.

http://trac.webkit.org/changeset/29311

Reading the source of the HTML test, I don&apos;t understand how it would ever stop (e.g., layoutTestController.notifyDone() would get called) after the form is submitted.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>88194</commentid>
    <comment_count>2</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2008-08-10 21:57:56 -0700</bug_when>
    <thetext>FWIW, this test works in Firefox, too (after replacing layoutTestController call with an alert(), of course).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>88196</commentid>
    <comment_count>3</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2008-08-10 23:05:57 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; FWIW, this test works in Firefox, too (after replacing layoutTestController
&gt; call with an alert(), of course).

Hmm...need to understand why this should work, then.

</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>88334</commentid>
    <comment_count>4</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2008-08-12 13:54:14 -0700</bug_when>
    <thetext>(In reply to comment #0)
&gt; I think that is also what&apos;s causing fast/dom/defaultView.html to appear to be
&gt; failing.
&gt; 
&gt; The failure may be related to &lt;http://trac.webkit.org/changeset/35611&gt;.

That was the fix for Bug 20038.

That change was fall-out from &lt;http://trac.webkit.org/changeset/35151&gt; (Bug 13067).

I haven&apos;t had time to look at this yet.

</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>88372</commentid>
    <comment_count>5</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2008-08-12 21:42:50 -0700</bug_when>
    <thetext>&lt;rdar://problem/6145826&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>88397</commentid>
    <comment_count>6</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2008-08-13 07:33:17 -0700</bug_when>
    <thetext>I&apos;m close to an update for the layout test itself.
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>88405</commentid>
    <comment_count>7</comment_count>
      <attachid>22777</attachid>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2008-08-13 09:50:40 -0700</bug_when>
    <thetext>Created attachment 22777
Patch v1

Proposed fix.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>88407</commentid>
    <comment_count>8</comment_count>
      <attachid>22777</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2008-08-13 10:05:02 -0700</bug_when>
    <thetext>Comment on attachment 22777
Patch v1

What about the fact that the test work on Firefox as is? This patch may fix the test results, but we still have a P1/regression bug, don&apos;t we?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>88429</commentid>
    <comment_count>9</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2008-08-13 12:26:19 -0700</bug_when>
    <thetext>(In reply to comment #8)
&gt; (From update of attachment 22777 [edit])
&gt; What about the fact that the test work on Firefox as is? This patch may fix the
&gt; test results, but we still have a P1/regression bug, don&apos;t we?

Please attach the modified test (with alerts) that &quot;works&quot; on Firefox 2/3.

I disagree that the original test should ever have worked--shouldn&apos;t a form submission cancel all setTimeout methods and stop JavaScript execution (assuming there&apos;s no &quot;onsubmit&quot; action)?

</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>88432</commentid>
    <comment_count>10</comment_count>
      <attachid>22779</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2008-08-13 12:58:11 -0700</bug_when>
    <thetext>Created attachment 22779
modified test

(In reply to comment #9)&amp;#10;&gt; Please attach the modified test (with alerts) that &quot;works&quot; on Firefox 2/3.&amp;#10;&amp;#10;Hmm... Ok.&amp;#10;&amp;#10;&gt; I disagree that the original test should ever have worked--shouldn&apos;t a form&amp;#10;&gt; submission cancel all setTimeout methods and stop JavaScript execution&amp;#10;&gt; (assuming there&apos;s no &quot;onsubmit&quot; action)?&amp;#10;&amp;#10;You can try with IE (I haven&apos;t), but for compatibility with Firefox, it clearly shoudn&apos;t.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>88464</commentid>
    <comment_count>11</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2008-08-13 23:15:07 -0700</bug_when>
    <thetext>In IE, this works when loading the test from network. When loading it from a local file, an alert never appears.

Shipping Safari behavior matched Firefox, while ToT matches IE on this test.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>88787</commentid>
    <comment_count>12</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2008-08-18 17:57:27 -0700</bug_when>
    <thetext>(In reply to comment #11)
&gt; In IE, this works when loading the test from network. When loading it from a
&gt; local file, an alert never appears.
&gt; 
&gt; Shipping Safari behavior matched Firefox, while ToT matches IE on this test.

So is Firefox saying, &quot;submitting a form with no form elements is equivalent to loading the URL as if it were clicked on&quot;?  That would certainly explain the FF behavior, although it just seems wrong on so many levels.  :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>88800</commentid>
    <comment_count>13</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2008-08-19 00:54:09 -0700</bug_when>
    <thetext>Not necessarily - it could be a timing issue (given that the test behaves differently in IE and ToT WebKit depending on where it is loaded from).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>88809</commentid>
    <comment_count>14</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2008-08-19 04:56:33 -0700</bug_when>
    <thetext>So, I think that is almost OK to land, but it would be good to find out what exactly other browsers do.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>88812</commentid>
    <comment_count>15</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2008-08-19 06:43:55 -0700</bug_when>
    <thetext>(In reply to comment #14)
&gt; So, I think that is almost OK to land, but it would be good to find out what
&gt; exactly other browsers do.

Yes, i want to do some more research first.

</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>89092</commentid>
    <comment_count>16</comment_count>
      <attachid>22777</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2008-08-22 02:03:41 -0700</bug_when>
    <thetext>Comment on attachment 22777
Patch v1

Marking as r+ based on ap&apos;s comments.  I trust David to finish his research and make an educated decision as to if this should really be landed or not.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>89101</commentid>
    <comment_count>17</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2008-08-22 04:11:08 -0700</bug_when>
    <thetext>Remember to take the test off the Skipped list when landing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>95108</commentid>
    <comment_count>18</comment_count>
      <attachid>22777</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2008-10-12 17:03:03 -0700</bug_when>
    <thetext>Comment on attachment 22777
Patch v1

Clearing the review flag on this patch for now so it doesn&apos;t show up in the &quot;reviewed, to be committed&quot; list.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>129725</commentid>
    <comment_count>19</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2009-07-03 10:34:11 -0700</bug_when>
    <thetext>(In reply to comment #15)
&gt; (In reply to comment #14)
&gt; &gt; So, I think that is almost OK to land, but it would be good to find out what
&gt; &gt; exactly other browsers do.
&gt; 
&gt; Yes, i want to do some more research first.

@david: (sorry for this kind of annoying question but) do you plan to post here your research results for the desired behaviour ? and maybe move forward in this bug ...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>129727</commentid>
    <comment_count>20</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2009-07-03 10:38:55 -0700</bug_when>
    <thetext>(In reply to comment #19)
&gt; @david: (sorry for this kind of annoying question but) do you plan to post here
&gt; your research results for the desired behaviour ? and maybe move forward in
&gt; this bug ...

Sorry, I haven&apos;t had time and this hasn&apos;t been a priority.  I&apos;ll try to get to it in the next week or so, but anyone else with a Windows PC and a Mac are welcome to do the research and post their results here.  :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>129729</commentid>
    <comment_count>21</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2009-07-03 10:46:06 -0700</bug_when>
    <thetext>&gt; Sorry, I haven&apos;t had time and this hasn&apos;t been a priority.  I&apos;ll try to get to
&gt; it in the next week or so, but anyone else with a Windows PC and a Mac are
&gt; welcome to do the research and post their results here.  :)

david, anything I could help w/ with a linux box and qtwebkit build ?

we are facing a crash running this specific layouttest in qtwebkit (see below). I am not sure if on Mac it was crashing or just &quot;failing&quot;  though ...

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0xb469a700 (LWP 23201)]
0xb6d610c8 in WebCore::Node::childNeedsStyleRecalc (this=0x8) at ../../../../WebCore/dom/Node.h:270
270	    bool childNeedsStyleRecalc() const { return m_childNeedsStyleRecalc; }
(gdb) 
(gdb) 
(gdb) bt
#0  0xb6d610c8 in WebCore::Node::childNeedsStyleRecalc (this=0x8) at ../../../../WebCore/dom/Node.h:270
#1  0xb6ddc903 in WebCore::Node::setNeedsStyleRecalc (this=0x98f1ca8, changeType=WebCore::FullStyleChange) at ../../../../WebCore/dom/Node.cpp:701
#2  0xb6d9291c in WebCore::Document::setCSSTarget (this=0x98db1d8, n=0x0) at ../../../../WebCore/dom/Document.cpp:2638
#3  0xb6fd7044 in WebCore::FrameLoader::gotoAnchor (this=0x9795b8c, name=@0xbffde9a8) at ../../../../WebCore/loader/FrameLoader.cpp:1583
#4  0xb6fd810b in WebCore::FrameLoader::gotoAnchor (this=0x9795b8c) at ../../../../WebCore/loader/FrameLoader.cpp:1198
#5  0xb707485c in WebCore::FrameView::layout (this=0x97a9450, allowSubtree=true) at ../../../../WebCore/page/FrameView.cpp:672
#6  0xb7074e03 in WebCore::FrameView::layoutTimerFired (this=0x97a9450) at ../../../../WebCore/page/FrameView.cpp:924
#7  0xb706c55f in WebCore::Timer&lt;WebCore::FrameView&gt;::fired (this=0x97a9518) at ../../../../WebCore/platform/Timer.h:98
#8  0xb710799b in WebCore::ThreadTimers::fireTimers (this=0x978f0f0, fireTime=1246599950.3275959, firingTimers=@0xbffdeb34)
    at ../../../../WebCore/platform/ThreadTimers.cpp:111
#9  0xb7108550 in WebCore::ThreadTimers::sharedTimerFiredInternal (this=0x978f0f0) at ../../../../WebCore/platform/ThreadTimers.cpp:141
#10 0xb71085cf in WebCore::ThreadTimers::sharedTimerFired () at ../../../../WebCore/platform/ThreadTimers.cpp:122
#11 0xb72a3836 in WebCore::SharedTimerQt::timerEvent (this=0x978f1b0, ev=0xbffdf02c) at ../../../../WebCore/platform/qt/SharedTimerQt.cpp:105
#12 0xb4fc58c6 in QObject::event (this=0x978f1b0, e=0xbffdf02c) at kernel/qobject.cpp:1073
#13 0xb5245f37 in QApplicationPrivate::notify_helper (this=0x96ab860, receiver=0x978f1b0, e=0xbffdf02c) at kernel/qapplication.cpp:4057
#14 0xb52462ac in QApplication::notify (this=0xbffdf39c, receiver=0x978f1b0, e=0xbffdf02c) at kernel/qapplication.cpp:3604
#15 0xb4fadad4 in QCoreApplication::notifyInternal (this=0xbffdf39c, receiver=0x978f1b0, event=0xbffdf02c) at kernel/qcoreapplication.cpp:610
#16 0x0805166c in QCoreApplication::sendEvent (receiver=0x978f1b0, event=0xbffdf02c) at /usr/include/QtCore/qcoreapplication.h:213
#17 0xb4fe84a4 in QTimerInfoList::activateTimers (this=0x9692f34) at kernel/qeventdispatcher_unix.cpp:572
#18 0xb4fe5c6a in timerSourceDispatch (source=0x9692f00) at kernel/qeventdispatcher_glib.cpp:164
#19 0xb4766b88 in IA__g_main_context_dispatch (context=0x9692e80) at /build/buildd/glib2.0-2.20.1/glib/gmain.c:1814
#20 0xb476a0eb in g_main_context_iterate (context=0x9692e80, block=1, dispatch=1, self=0x9693b38) at /build/buildd/glib2.0-2.20.1/glib/gmain.c:2448
#21 0xb476a268 in IA__g_main_context_iteration (context=0x9692e80, may_block=1) at /build/buildd/glib2.0-2.20.1/glib/gmain.c:2511
#22 0xb4fe4d66 in QEventDispatcherGlib::processEvents (this=0x969f1b0, flags={i = -1073876556}) at kernel/qeventdispatcher_glib.cpp:324
#23 0xb5312174 in QGuiEventDispatcherGlib::processEvents (this=0x969f1b0, flags={i = -1073876508}) at kernel/qguieventdispatcher_glib.cpp:202
#24 0xb4faa0f0 in QEventLoop::processEvents (this=0xbffdf278, flags={i = -1073876436}) at kernel/qeventloop.cpp:149
#25 0xb4faa34b in QEventLoop::exec (this=0xbffdf278, flags={i = -1073876352}) at kernel/qeventloop.cpp:200
#26 0xb4fae429 in QCoreApplication::exec () at kernel/qcoreapplication.cpp:888
#27 0xb5245c50 in QApplication::exec () at kernel/qapplication.cpp:3526</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>129730</commentid>
    <comment_count>22</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2009-07-03 11:02:51 -0700</bug_when>
    <thetext>(In reply to comment #21)
&gt; &gt; Sorry, I haven&apos;t had time and this hasn&apos;t been a priority.  I&apos;ll try to get to
&gt; &gt; it in the next week or so, but anyone else with a Windows PC and a Mac are
&gt; &gt; welcome to do the research and post their results here.  :)
&gt; 
&gt; david, anything I could help w/ with a linux box and qtwebkit build ?
&gt; 
&gt; we are facing a crash running this specific layouttest in qtwebkit (see below).
&gt; I am not sure if on Mac it was crashing or just &quot;failing&quot;  though ...
&gt; 
&gt; Program received signal SIGSEGV, Segmentation fault.
&gt; [Switching to Thread 0xb469a700 (LWP 23201)]
&gt; 0xb6d610c8 in WebCore::Node::childNeedsStyleRecalc (this=0x8) at
&gt; ../../../../WebCore/dom/Node.h:270
&gt; 270        bool childNeedsStyleRecalc() const { return m_childNeedsStyleRecalc;
&gt; }

On the Mac, this test timed out (would hang) because it kept loading over and over again.  I haven&apos;t tried re-enabling the test recently, so I don&apos;t know what the current behavior is.

I suspect you&apos;re running into a different issue, though, since the test never crashed on the Mac.

It appears that the &quot;this&quot; pointer is almost NULL (0x8) when Node::childNeedsStyleRecalc() is called, which is bad.  You might try running this single test under valgrind to see if you find any issues before it crashes (like some kind of memory smasher).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>129731</commentid>
    <comment_count>23</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2009-07-03 11:40:48 -0700</bug_when>
    <thetext>(In reply to comment #22)
&gt; I suspect you&apos;re running into a different issue, though, since the test never
&gt; crashed on the Mac.

Well, obviously it crashed at one point, hence the name of the test, but when I filed this bug it was not crashing.

You might also try to look at the original patch committed with this test to see how the original crash was fixed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>129742</commentid>
    <comment_count>24</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2009-07-03 13:46:00 -0700</bug_when>
    <thetext>&gt; (In reply to comment #22)
&gt; &gt; I suspect you&apos;re running into a different issue, though, since the test never crashed on the Mac.
&gt; Well, obviously it crashed at one point, hence the name of the test, but when I filed this bug it was not crashing.
&gt; 
&gt; You might also try to look at the original patch committed with this test to
&gt; see how the original crash was fixed.

So I found the original commit of this test. See http://code.staikos.net/cgi-bin/gitweb.cgi?p=webkit;a=commit;h=460c62b8190c48d964755f694942045ed791100d

in this patch we have:

(...)
@@ -847,6 +847,9 @@ void Node::insertedIntoDocument()
void Node::removedFromDocument()
{
+    if (m_document &amp;&amp; m_document-&gt;getCSSTarget() == this)
+        m_document-&gt;setCSSTarget(0);
+
    setInDocument(false);
    removedFromTree(false);
}
(...)

in ToT method looks like this though:

(...)
void Node::removedFromDocument()
{
    if (!eventListeners().isEmpty())
        document()-&gt;registerDisconnectedNodeWithEventListeners(this);

    setInDocument(false);
}
(...)

you can note that the &quot;fix&quot; in the former commit was removed in this commit http://code.staikos.net/cgi-bin/gitweb.cgi?p=webkit;a=commit;h=e8c3a2adfa7874c152f431d48423a104f974f170  

* dom/Node.cpp:
(WebCore::Node::insertedIntoDocument): Removed call to InsertedIntoTree, since it&apos;s only non-empty in subclasses of ContainerNode.
(WebCore::Node::removedFromDocument): Ditto. Also removed setCSSTarget. Since a CSS target has to be an Element, this can be moved down to ContainerNode (or it could be moved down to Element for that matter).

If I re-add 

+    if (m_document &amp;&amp; m_document-&gt;getCSSTarget() == this)
+        m_document-&gt;setCSSTarget(0);

all goes fine: test succeeds in both release and debug builds.

@david what do you suggest?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>129754</commentid>
    <comment_count>25</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2009-07-03 17:17:17 -0700</bug_when>
    <thetext>(In reply to comment #24)
&gt; If I re-add 
&gt; 
&gt; +    if (m_document &amp;&amp; m_document-&gt;getCSSTarget() == this)
&gt; +        m_document-&gt;setCSSTarget(0);
&gt; 
&gt; all goes fine: test succeeds in both release and debug builds.
&gt; 
&gt; @david what do you suggest?

Please post a patch with a &quot;review?&quot; flag that adds the above code back.  This test now crashes on the Mac as well when run individually.  :(

$ ./WebKitTools/Scripts/run-webkit-tests --debug LayoutTests/fast/dom/cssTarget-crash.html
[...]
Running tests from /Volumes/Data/WebKit.git/LayoutTests
Testing 1 test cases.
fast/dom .
fast/dom/cssTarget-crash.html -&gt; crashed

35.30s total testing time

1 test case (100%) crashed

ddkilzer-- for not re-enabling this test sooner.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>129891</commentid>
    <comment_count>26</comment_count>
      <attachid>32285</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2009-07-05 20:59:19 -0700</bug_when>
    <thetext>Created attachment 32285
patch 0.2

Re-added original fix the cssTarget-crash.

it fixes running this test in QtWebKit for both release and debug modes. Should fix mac (and make it possible to unskip it).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>129892</commentid>
    <comment_count>27</comment_count>
      <attachid>32285</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2009-07-05 21:55:18 -0700</bug_when>
    <thetext>Comment on attachment 32285
patch 0.2

http://trac.webkit.org/changeset/40475 moved the setCSSTarget call from Node::removedFromDocument into ContainerNode::removedFromDocument. But that wasn&apos;t when this bug was introduced.

It was introduced by a bad merge back in http://trac.webkit.org/changeset/40499. The right fix is to add the code back, but to add it back to ContainerNode::removedFromDocument, not Node::removedFromDocument.

I&apos;ll take care of this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>129893</commentid>
    <comment_count>28</comment_count>
      <attachid>32285</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2009-07-05 22:23:13 -0700</bug_when>
    <thetext>Comment on attachment 32285
patch 0.2

Clearing the review flag since I landed the fix as http://trac.webkit.org/changeset/45557 but not closing the bug, because the test still fails. The crash is gone, but now the test doesn&apos;t terminate. That&apos;s presumably because of loader changes that happened while it was disabled.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>129931</commentid>
    <comment_count>29</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2009-07-06 05:12:25 -0700</bug_when>
    <thetext>(In reply to comment #28)
&gt; (From update of attachment 32285 [details])
&gt; Clearing the review flag since I landed the fix as
&gt; http://trac.webkit.org/changeset/45557 but not closing the bug, because the
&gt; test still fails. The crash is gone, but now the test doesn&apos;t terminate. That&apos;s
&gt; presumably because of loader changes that happened while it was disabled.

No, the test never terminating was why this bug was filed in the first place.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>129949</commentid>
    <comment_count>30</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2009-07-06 07:56:28 -0700</bug_when>
    <thetext>(In reply to comment #29)
&gt; No, the test never terminating was why this bug was filed in the first place.

In that case, we probably want to change the title back to remove the particular version from the title and perhaps even assign back to ddkilzer (if you still plan to work on it).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>129963</commentid>
    <comment_count>31</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2009-07-06 10:11:55 -0700</bug_when>
    <thetext>See also Bug 26886.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>152387</commentid>
    <comment_count>32</comment_count>
    <who name="Erik Arvidsson">arv</who>
    <bug_when>2009-10-05 11:23:15 -0700</bug_when>
    <thetext>I have a modified version of the layout test that terminates under both circumstances.

However, it would be good if we could decide what behavior we want. Do we want the form to get submitted to the server like IE and Opera or do we want to stay on the current page without a submit like Firefox?

My vote is for the form to get submitted (current behavior).

I can also add another layout test that ensures that behavior if that is the behavior we want.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>152398</commentid>
    <comment_count>33</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2009-10-05 11:40:13 -0700</bug_when>
    <thetext>(In reply to comment #32)
&gt; I have a modified version of the layout test that terminates under both
&gt; circumstances.
&gt; 
&gt; However, it would be good if we could decide what behavior we want. Do we want
&gt; the form to get submitted to the server like IE and Opera or do we want to stay
&gt; on the current page without a submit like Firefox?
&gt; 
&gt; My vote is for the form to get submitted (current behavior).

As I understand it, the issue is: When you submit a form from JavaScript, is the decision of what URL to submit to at the time you call submit() or decided later on when the actual submission is done? Is that the right question?

You say that current behavior matches IE and Opera, but not Firefox. Does it also match Safari 4? Does HTML 5 have anything to say about this?

&gt; I can also add another layout test that ensures that behavior if that is the
&gt; behavior we want.

We definitely want that no matter what!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>152412</commentid>
    <comment_count>34</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2009-10-05 12:40:50 -0700</bug_when>
    <thetext>Resetting to the default assignee as I haven&apos;t had time to look into this thoroughly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>152463</commentid>
    <comment_count>35</comment_count>
    <who name="Erik Arvidsson">arv</who>
    <bug_when>2009-10-05 14:37:34 -0700</bug_when>
    <thetext>(In reply to comment #33)
&gt; (In reply to comment #32)
&gt; &gt; I have a modified version of the layout test that terminates under both
&gt; &gt; circumstances.
&gt; &gt; 
&gt; &gt; However, it would be good if we could decide what behavior we want. Do we want
&gt; &gt; the form to get submitted to the server like IE and Opera or do we want to stay
&gt; &gt; on the current page without a submit like Firefox?
&gt; &gt; 
&gt; &gt; My vote is for the form to get submitted (current behavior).
&gt; 
&gt; As I understand it, the issue is: When you submit a form from JavaScript, is
&gt; the decision of what URL to submit to at the time you call submit() or decided
&gt; later on when the actual submission is done? Is that the right question?

There are two orthogonal issues here:

1. In Firefox, if there is no form data, the method is GET and the action is a named element on the page (eg. #a) submitting the form does not leave the page. It adds sets the hash to #a. If there is form data or there is no matching named element on the page the form submit works as usual.

2. Changing the action after submit is called should not change the action of the in flight submit.

&gt; 
&gt; You say that current behavior matches IE and Opera, but not Firefox. Does it
&gt; also match Safari 4? Does HTML 5 have anything to say about this?

The current behavior of 1 matches IE, Opera and Safari 4. HTML5 says the following:

Step 15 at http://dev.w3.org/html5/spec/Overview.html#concept-form-submit says to do a Mutate action. Mutate action says to do a Navigate, http://dev.w3.org/html5/spec/Overview.html#navigate. Point 4 of that says:

&quot;Fragment identifiers: If the absolute URL of the new resource is the same as the address of the active document of the browsing context being navigated, ignoring any &lt;fragment&gt; components of those URLs, and the new resource is to be fetched using HTTP GET or equivalent, and the absolute URL of the new resource has a &lt;fragment&gt; component (even if it is empty), then navigate to that fragment identifier and abort these steps.&quot;

&quot;abort these steps&quot; means that we should not fetch the resource and therefore it seems like we are NOT doing the right thing in case 1.



The current behavior of 2 matches HTML5. The following happens when submit() is called http://dev.w3.org/html5/spec/Overview.html#concept-form-submit and it states in point 8 that it should use the action of the form when submitting, not the action of the form when the js thread is done. 

&gt; 
&gt; &gt; I can also add another layout test that ensures that behavior if that is the
&gt; &gt; behavior we want.
&gt; 
&gt; We definitely want that no matter what!


Conclusion: 

1. We need to fix the case where a GET form is submitted to the same URL + fragment identifier.
2. The current layout test should pass and never time out
3. Add a layout test that tests that we submit to the current action when submit() was called and later changes should not change that. This can be done independently from the other fixes.
4. Add a new clearer layout test that tests that submitting an empty form to the same url + fragment identifier does not replace the current page.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>327135</commentid>
    <comment_count>36</comment_count>
    <who name="Yael">yael</who>
    <bug_when>2010-12-27 16:01:24 -0800</bug_when>
    <thetext>(In reply to comment #35)
&gt; Conclusion: 
&gt; 
&gt; 1. We need to fix the case where a GET form is submitted to the same URL + fragment identifier.
&gt; 2. The current layout test should pass and never time out
&gt; 3. Add a layout test that tests that we submit to the current action when submit() was called and later changes should not change that. This can be done independently from the other fixes.
&gt; 4. Add a new clearer layout test that tests that submitting an empty form to the same url + fragment identifier does not replace the current page.

I agree with your analysis with one exception. This behavior has nothing to do with the form being empty or not. It is about checking if the action URL and the location URL match or not. If the form is empty, there is no query string, thus it is more likely that you would get matching URLs when running tests.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>327140</commentid>
    <comment_count>37</comment_count>
      <attachid>77524</attachid>
    <who name="Yael">yael</who>
    <bug_when>2010-12-27 16:10:23 -0800</bug_when>
    <thetext>Created attachment 77524
Patch

Do not reload the page when submitting a form using &quot;GET&quot; method and the form action url matches the location url, except for the fragment.
This matches the behavior of Firefox and Opera, but not IE. It also matches the HTML5 spec, as described above in comment #35.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>327948</commentid>
    <comment_count>38</comment_count>
      <attachid>77524</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2010-12-30 09:54:00 -0800</bug_when>
    <thetext>Comment on attachment 77524
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77524&amp;action=review

This bug as a somewhat complicated history, but from my reading of the history, this patch is what we want.

&gt; LayoutTests/fast/forms/submit-change-fragment.html:12
&gt; +    setTimeout(&quot;continueTest();&quot;, 20);

Can we use onHashChange instead of setTimeout?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>327973</commentid>
    <comment_count>39</comment_count>
    <who name="Yael">yael</who>
    <bug_when>2010-12-30 11:32:06 -0800</bug_when>
    <thetext>(In reply to comment #38)
&gt; (From update of attachment 77524 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=77524&amp;action=review
&gt; 
&gt; This bug as a somewhat complicated history, but from my reading of the history, this patch is what we want.
&gt; 
&gt; &gt; LayoutTests/fast/forms/submit-change-fragment.html:12
&gt; &gt; +    setTimeout(&quot;continueTest();&quot;, 20);
&gt; 
&gt; Can we use onHashChange instead of setTimeout?

Thank you for the review. I just updated the test to use onhashchange.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>327977</commentid>
    <comment_count>40</comment_count>
    <who name="Yael">yael</who>
    <bug_when>2010-12-30 11:33:23 -0800</bug_when>
    <thetext>Committed r74801 &lt;http://trac.webkit.org/changeset/74801&gt;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>328020</commentid>
    <comment_count>41</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-12-30 13:16:01 -0800</bug_when>
    <thetext>http://trac.webkit.org/changeset/74801 might have broken Leopard Intel Debug (Tests)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>328023</commentid>
    <comment_count>42</comment_count>
    <who name="Yael">yael</who>
    <bug_when>2010-12-30 13:21:36 -0800</bug_when>
    <thetext>(In reply to comment #41)
&gt; http://trac.webkit.org/changeset/74801 might have broken Leopard Intel Debug (Tests)

I doubt that.
The same exact set of failures is also in &lt;http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Tests%29/builds/25253/steps/layout-test/logs/stdio&gt; , (build results for http://trac.webkit.org/changeset/74796).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>364078</commentid>
    <comment_count>43</comment_count>
    <who name="Mahesh Kulkarni">maheshk</who>
    <bug_when>2011-03-08 11:57:31 -0800</bug_when>
    <thetext>*** Bug 22590 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>22777</attachid>
            <date>2008-08-13 09:50:40 -0700</date>
            <delta_ts>2009-07-05 21:55:48 -0700</delta_ts>
            <desc>Patch v1</desc>
            <filename>bug-20342-v1.diff</filename>
            <type>text/plain</type>
            <size>2469</size>
            <attacher name="David Kilzer (:ddkilzer)">ddkilzer</attacher>
            
              <data encoding="base64">SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D
aGFuZ2VMb2cJKHJldmlzaW9uIDM1NzE4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr
aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjMgQEAKKzIwMDgtMDgtMTMgIERhdmlkIEtpbHplciAgPGRk
a2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBCdWcgMjAzNDI6IFJFR1JFU1NJT046IGZhc3Qv
ZG9tL2Nzc1RhcmdldC1jcmFzaC5odG1sIGZhaWxzCisKKyAgICAgICAgPGh0dHBzOi8vYnVncy53
ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDM0Mj4KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt
LzYxNDU4MjY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg
ICAgQmVmb3JlIHIzNTYxMSwgdGhlIGZvcm0gaW4gdGhlIHRlc3QgY2FzZSB3YXNuJ3QgYWN0dWFs
bHkgYmVpbmcKKyAgICAgICAgc3VibWl0dGVkLS1pbnN0ZWFkIGl0IHdhcyBzY3JvbGxpbmcgdG8g
dGhlIGFuY2hvciBvbiB0aGUgcGFnZS4KKyAgICAgICAgQWZ0ZXIgdGhpcyBidWcgd2FzIGZpeGVk
LCBpdCBjYXVzZWQgdGhlIHRlc3QgdG8gZmFpbCBieSBuZXZlcgorICAgICAgICBjYWxsaW5nIG5v
dGlmeURvbmUoKS4gIFRoZSBmaXggaXMgdG8gcmVzdG9yZSB0aGUgb3JpZ2luYWwgYmVoYXZpb3IK
KyAgICAgICAgb2YgdGhlIHRlc3QgY2FzZSBieSBzZXR0aW5nIGxvY2F0aW9uLmhhc2ggaW4gcGxh
Y2Ugb2Ygc3VibWl0dGluZworICAgICAgICB0aGUgZm9ybS4gIFRoaXMgdHJpZ2dlcnMgdGhlIHNh
bWUgY29kZSBpbgorICAgICAgICBOb2RlOjpyZW1vdmVkRnJvbURvY3VtZW50KCkgZnJvbSByMjkz
MTEsIGJ1dCByZW1vdmluZyB0aGF0IGZpeAorICAgICAgICBkb2Vzbid0IGxlYWQgdG8gYSBjcmFz
aCBpbiB0cnVuayBhbnltb3JlLgorCisgICAgICAgICogZmFzdC9kb20vY3NzVGFyZ2V0LWNyYXNo
Lmh0bWw6IFJlc3RvcmUgYmVoYXZpb3IgYWZ0ZXIgcjM1NjExLgorCiAyMDA4LTA4LTEzICBBbGV4
ZXkgUHJvc2t1cnlha292ICA8YXBAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmluZyBodHRw
L3Rlc3RzL3htbGh0dHByZXF1ZXN0L3JlYWR5c3RhdGVjaGFuZ2UuaHRtbCBmcm9tIFdpbmRvd3Mg
c2tpcHBlZCBsaXN0IC0KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL2Nzc1RhcmdldC1jcmFz
aC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL2Nzc1RhcmdldC1jcmFz
aC5odG1sCShyZXZpc2lvbiAzNTYxMikKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL2Nzc1Rhcmdl
dC1jcmFzaC5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0xLDcgKzEsNiBAQAogPGh0bWw+CiA8Ym9k
eT4KIDxkaXY+PGEgaHJlZj0icmRhcjovLzQ1MDQ4MDUmNDU3NzMyMyY0NjQzMDI4JjU2NTk4MTIi
PlNob3VsZCBub3QgY3Jhc2guPC9hPjwvZGl2PgotPGZvcm0gbmFtZT0iZiIgbWV0aG9kPSJHRVQi
IGFjdGlvbj0iI2EiPjwvZm9ybT4KIDxkaXYgaWQ9ImFuY2hvcnMiPjxhIG5hbWU9ImEiPjwvYT48
L2Rpdj4KIDxzY3JpcHQ+CiBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CkBAIC0x
MCwxOSArOSwyMCBAQCBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CiB9CiAKIHZh
ciBzdG9wcGVkID0gZmFsc2U7Ci1zZXRUaW1lb3V0KCJkb0l0KCkiLCAwKTsKK3NldFRpbWVvdXQo
ImRvSXQoJyNhJykiLCAwKTsKIHNldFRpbWVvdXQoInN0b3BwZWQgPSB0cnVlOyIsIDEwMCk7Ci1m
dW5jdGlvbiBkb0l0KCkgeworCitmdW5jdGlvbiBkb0l0KG15YWN0aW9uKQorewogICAgIGlmIChz
dG9wcGVkKSB7CiAgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCiAgICAg
ICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CiAgICAgICAgIHJldHVy
bjsKICAgICB9Ci0gICAgZG9jdW1lbnQuZm9ybXMuZi5zdWJtaXQoKTsKLSAgICB2YXIgeD1NYXRo
LnJhbmRvbSgpOwotICAgIHNldFRpbWVvdXQoImRvSXQoIit4KyIpIiwxMCk7Ci0gICAgZG9jdW1l
bnQuZm9ybXMuZi5hY3Rpb249IiMiK3g7Ci0gICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImFu
Y2hvcnMiKS5pbm5lckhUTUwrPQorICAgIGxvY2F0aW9uLmhhc2ggPSBteWFjdGlvbjsKKyAgICB2
YXIgeCA9IE1hdGgucmFuZG9tKCk7CisgICAgc2V0VGltZW91dCgiZG9JdCgnIyIreCsiJykiLCAx
MCk7CisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImFuY2hvcnMiKS5pbm5lckhUTUwgKz0K
ICAgICAgICAgIjxpbWcgd2lkdGg9MTAwIGhlaWdodD0xMDA+PGEgbmFtZT1cIiIreCsiXCI+PC9h
PiI7CiB9CiA8L3NjcmlwdD4K
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>22779</attachid>
            <date>2008-08-13 12:58:11 -0700</date>
            <delta_ts>2008-08-13 12:58:11 -0700</delta_ts>
            <desc>modified test</desc>
            <filename>cssTarget-crash.html</filename>
            <type>text/html</type>
            <size>854</size>
            <attacher name="Alexey Proskuryakov">ap</attacher>
            
              <data encoding="base64">PGh0bWw+Cjxib2R5Pgo8ZGl2PjxhIGhyZWY9InJkYXI6Ly80NTA0ODA1JjQ1NzczMjMmNDY0MzAy
OCY1NjU5ODEyIj5TaG91bGQgbm90IGNyYXNoLjwvYT48L2Rpdj4KPGZvcm0gbmFtZT0iZiIgbWV0
aG9kPSJHRVQiIGFjdGlvbj0iI2EiPjwvZm9ybT4KPGRpdiBpZD0iYW5jaG9ycyI+PGEgbmFtZT0i
YSI+PC9hPjwvZGl2Pgo8c2NyaXB0PgppZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7
CiAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CiAgICBsYXlvdXRUZXN0Q29u
dHJvbGxlci53YWl0VW50aWxEb25lKCk7Cn0KCnZhciBzdG9wcGVkID0gZmFsc2U7CnNldFRpbWVv
dXQoImRvSXQoKSIsIDApOwpzZXRUaW1lb3V0KCJzdG9wcGVkID0gdHJ1ZTsiLCAxMDApOwpmdW5j
dGlvbiBkb0l0KCkgewogICAgaWYgKHN0b3BwZWQpIHsKICAgICAgICBhbGVydCgiWW91IHNob3Vs
ZCBzZWUgdGhpcyBhbGVydCIpOwovLyAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJv
bGxlcikKLy8gICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CiAg
ICAgICAgcmV0dXJuOwogICAgfQogICAgZG9jdW1lbnQuZm9ybXMuZi5zdWJtaXQoKTsKICAgIHZh
ciB4PU1hdGgucmFuZG9tKCk7CiAgICBzZXRUaW1lb3V0KCJkb0l0KCIreCsiKSIsMTApOwogICAg
ZG9jdW1lbnQuZm9ybXMuZi5hY3Rpb249IiMiK3g7CiAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJ
ZCgiYW5jaG9ycyIpLmlubmVySFRNTCs9CiAgICAgICAgIjxpbWcgd2lkdGg9MTAwIGhlaWdodD0x
MDA+PGEgbmFtZT1cIiIreCsiXCI+PC9hPiI7Cn0KPC9zY3JpcHQ+CjwvYm9keT4KPC9odG1sPgo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>32285</attachid>
            <date>2009-07-05 20:59:19 -0700</date>
            <delta_ts>2010-06-10 19:14:36 -0700</delta_ts>
            <desc>patch 0.2</desc>
            <filename>BUG_20342_v1.diff</filename>
            <type>text/plain</type>
            <size>1103</size>
            <attacher name="Antonio Gomes">tonikitoo</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
NzVjM2NlZC4uMjFkZDk5OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0wNy0wNSAgQW50b25pbyBHb21l
cyAgIDxhbnRvbmlvLmdvbWVzQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUkVHUkVTU0lPTjogZmFzdC9kb20vY3NzVGFyZ2V0
LWNyYXNoLmh0bWwgZmFpbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTIwMzQyCisKKyAgICAgICAgUmUtYWRkZWQgY3Jhc2ggZml4IHJlbW92ZWQgYnkg
Y29tbWl0IHI0MDQ3NS4KKworICAgICAgICBXaXRob3V0IHRoaXMgY2hlY2ssIGJvdGggUXQgYW5k
IE1hYyB3ZXJlIGNyYXNoaW5nIHdoaWxlIHJ1bm5pbmcgdGhlIHRlc3QuCisJCisgICAgICAgICog
ZG9tL05vZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Tm9kZTo6cmVtb3ZlZEZyb21Eb2N1bWVu
dCk6CisKIDIwMDktMDctMDUgIENocmlzIE1hcnJpbiAgPGNtYXJyaW5AYXBwbGUuY29tPgogCiAg
ICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvZG9t
L05vZGUuY3BwIGIvV2ViQ29yZS9kb20vTm9kZS5jcHAKaW5kZXggM2RkZjRjMC4uODEyZTRkMCAx
MDA2NDQKLS0tIGEvV2ViQ29yZS9kb20vTm9kZS5jcHAKKysrIGIvV2ViQ29yZS9kb20vTm9kZS5j
cHAKQEAgLTIyNzEsNiArMjI3MSw5IEBAIHZvaWQgTm9kZTo6aW5zZXJ0ZWRJbnRvRG9jdW1lbnQo
KQogCiB2b2lkIE5vZGU6OnJlbW92ZWRGcm9tRG9jdW1lbnQoKQogeworICAgIGlmIChtX2RvY3Vt
ZW50ICYmIG1fZG9jdW1lbnQtPmNzc1RhcmdldCgpID09IHRoaXMpCisgICAgICAgIG1fZG9jdW1l
bnQtPnNldENTU1RhcmdldCgwKTsKKwogICAgIGlmICghZXZlbnRMaXN0ZW5lcnMoKS5pc0VtcHR5
KCkpCiAgICAgICAgIGRvY3VtZW50KCktPnJlZ2lzdGVyRGlzY29ubmVjdGVkTm9kZVdpdGhFdmVu
dExpc3RlbmVycyh0aGlzKTsKIAo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>77524</attachid>
            <date>2010-12-27 16:10:23 -0800</date>
            <delta_ts>2010-12-30 09:54:00 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>20342.patch</filename>
            <type>text/plain</type>
            <size>8319</size>
            <attacher name="Yael">yael</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA3NDY5NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMjEgQEAKKzIwMTAtMTItMjcgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25Abm9r
aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IFJFR1JFU1NJT046IGZhc3QvZG9tL2Nzc1RhcmdldC1jcmFzaC5odG1sIGZhaWxzCisgICAgICAg
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDM0MgorCisgICAgICAg
IERvIG5vdCByZWxvYWQgdGhlIHBhZ2Ugd2hlbiBzdWJtaXR0aW5nIGEgZm9ybSwgdXNpbmcgIkdF
VCIgbWV0aG9kLCBhbmQgdGhlCisgICAgICAgIGZvcm0gYWN0aW9uIHVybCBtYXRjaGVzIHRoZSBs
b2NhdGlvbiB1cmwsIGV4Y2VwdCBmb3IgdGhlIGZyYWdtZW50LgorICAgICAgCisgICAgICAgIFRl
c3Q6IGZhc3QvZm9ybXMvc3VibWl0LWNoYW5nZS1mcmFnbWVudC5odG1sCisKKyAgICAgICAgKiBs
b2FkZXIvRnJhbWVMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6Omxv
YWRVUkwpOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OmxvYWRXaXRoRG9jdW1lbnRM
b2FkZXIpOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OnNob3VsZFNjcm9sbFRvQW5j
aG9yKToKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuaDoKKwogMjAxMC0xMi0yNyAgTWFy
dGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg
YnkgRGFuaWVsIEJhdGVzLgpJbmRleDogV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCj09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT0KLS0tIFdlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAkocmV2aXNpb24gNzQ2
NjEpCisrKyBXZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAg
LTEzMTksMTEgKzEzMTksMTIgQEAgdm9pZCBGcmFtZUxvYWRlcjo6bG9hZFVSTChjb25zdCBLVVJM
JiBuZQogICAgIFJlZlB0cjxEb2N1bWVudExvYWRlcj4gb2xkRG9jdW1lbnRMb2FkZXIgPSBtX2Rv
Y3VtZW50TG9hZGVyOwogCiAgICAgYm9vbCBzYW1lVVJMID0gc2hvdWxkVHJlYXRVUkxBc1NhbWVB
c0N1cnJlbnQobmV3VVJMKTsKKyAgICBjb25zdCBTdHJpbmcmIGh0dHBNZXRob2QgPSByZXF1ZXN0
Lmh0dHBNZXRob2QoKTsKICAgICAKICAgICAvLyBNYWtlIHN1cmUgdG8gZG8gc2Nyb2xsIHRvIGFu
Y2hvciBwcm9jZXNzaW5nIGV2ZW4gaWYgdGhlIFVSTCBpcwogICAgIC8vIGV4YWN0bHkgdGhlIHNh
bWUgc28gcGFnZXMgd2l0aCAnIycgbGlua3MgYW5kIERIVE1MIHNpZGUgZWZmZWN0cwogICAgIC8v
IHdvcmsgcHJvcGVybHkuCi0gICAgaWYgKHNob3VsZFNjcm9sbFRvQW5jaG9yKGlzRm9ybVN1Ym1p
c3Npb24sIG5ld0xvYWRUeXBlLCBuZXdVUkwpKSB7CisgICAgaWYgKHNob3VsZFNjcm9sbFRvQW5j
aG9yKGlzRm9ybVN1Ym1pc3Npb24sIGh0dHBNZXRob2QsIG5ld0xvYWRUeXBlLCBuZXdVUkwpKSB7
CiAgICAgICAgIG9sZERvY3VtZW50TG9hZGVyLT5zZXRUcmlnZ2VyaW5nQWN0aW9uKGFjdGlvbik7
CiAgICAgICAgIHBvbGljeUNoZWNrZXIoKS0+c3RvcENoZWNrKCk7CiAgICAgICAgIHBvbGljeUNo
ZWNrZXIoKS0+c2V0TG9hZFR5cGUobmV3TG9hZFR5cGUpOwpAQCAtMTQ0Miw4ICsxNDQzLDkgQEAg
dm9pZCBGcmFtZUxvYWRlcjo6bG9hZFdpdGhEb2N1bWVudExvYWRlcgogICAgIGJvb2wgaXNGb3Jt
U3VibWlzc2lvbiA9IGZvcm1TdGF0ZTsKIAogICAgIGNvbnN0IEtVUkwmIG5ld1VSTCA9IGxvYWRl
ci0+cmVxdWVzdCgpLnVybCgpOworICAgIGNvbnN0IFN0cmluZyYgaHR0cE1ldGhvZCA9IGxvYWRl
ci0+cmVxdWVzdCgpLmh0dHBNZXRob2QoKTsKIAotICAgIGlmIChzaG91bGRTY3JvbGxUb0FuY2hv
cihpc0Zvcm1TdWJtaXNzaW9uLCBwb2xpY3lDaGVja2VyKCktPmxvYWRUeXBlKCksIG5ld1VSTCkp
IHsKKyAgICBpZiAoc2hvdWxkU2Nyb2xsVG9BbmNob3IoaXNGb3JtU3VibWlzc2lvbiwgIGh0dHBN
ZXRob2QsIHBvbGljeUNoZWNrZXIoKS0+bG9hZFR5cGUoKSwgbmV3VVJMKSkgewogICAgICAgICBS
ZWZQdHI8RG9jdW1lbnRMb2FkZXI+IG9sZERvY3VtZW50TG9hZGVyID0gbV9kb2N1bWVudExvYWRl
cjsKICAgICAgICAgTmF2aWdhdGlvbkFjdGlvbiBhY3Rpb24obmV3VVJMLCBwb2xpY3lDaGVja2Vy
KCktPmxvYWRUeXBlKCksIGlzRm9ybVN1Ym1pc3Npb24pOwogCkBAIC0yODE4LDE3ICsyODIwLDE3
IEBAIHZvaWQgRnJhbWVMb2FkZXI6OmNvbnRpbnVlRnJhZ21lbnRTY3JvbGwKICAgICBsb2FkSW5T
YW1lRG9jdW1lbnQocmVxdWVzdC51cmwoKSwgMCwgIWlzUmVkaXJlY3QpOwogfQogCi1ib29sIEZy
YW1lTG9hZGVyOjpzaG91bGRTY3JvbGxUb0FuY2hvcihib29sIGlzRm9ybVN1Ym1pc3Npb24sIEZy
YW1lTG9hZFR5cGUgbG9hZFR5cGUsIGNvbnN0IEtVUkwmIHVybCkKK2Jvb2wgRnJhbWVMb2FkZXI6
OnNob3VsZFNjcm9sbFRvQW5jaG9yKGJvb2wgaXNGb3JtU3VibWlzc2lvbiwgY29uc3QgU3RyaW5n
JiBodHRwTWV0aG9kLCBGcmFtZUxvYWRUeXBlIGxvYWRUeXBlLCBjb25zdCBLVVJMJiB1cmwpCiB7
CiAgICAgLy8gU2hvdWxkIHdlIGRvIGFuY2hvciBuYXZpZ2F0aW9uIHdpdGhpbiB0aGUgZXhpc3Rp
bmcgY29udGVudD8KIAotICAgIC8vIFdlIGRvbid0IGRvIHRoaXMgaWYgd2UgYXJlIHN1Ym1pdHRp
bmcgYSBmb3JtLCBleHBsaWNpdGx5IHJlbG9hZGluZywKKyAgICAvLyBXZSBkb24ndCBkbyB0aGlz
IGlmIHdlIGFyZSBzdWJtaXR0aW5nIGEgZm9ybSB3aXRoIG1ldGhvZCBvdGhlciB0aGFuICJHRVQi
LCBleHBsaWNpdGx5IHJlbG9hZGluZywKICAgICAvLyBjdXJyZW50bHkgZGlzcGxheWluZyBhIGZy
YW1lc2V0LCBvciBpZiB0aGUgVVJMIGRvZXMgbm90IGhhdmUgYSBmcmFnbWVudC4KICAgICAvLyBU
aGVzZSBydWxlcyB3ZXJlIG9yaWdpbmFsbHkgYmFzZWQgb24gd2hhdCBLSFRNTCB3YXMgZG9pbmcg
aW4gS0hUTUxQYXJ0OjpvcGVuVVJMLgogCiAgICAgLy8gRklYTUU6IFdoYXQgYWJvdXQgbG9hZCB0
eXBlcyBvdGhlciB0aGFuIFN0YW5kYXJkIGFuZCBSZWxvYWQ/CiAKLSAgICByZXR1cm4gIWlzRm9y
bVN1Ym1pc3Npb24KKyAgICByZXR1cm4gKCFpc0Zvcm1TdWJtaXNzaW9uIHx8IGVxdWFsSWdub3Jp
bmdDYXNlKGh0dHBNZXRob2QsICJHRVQiKSkKICAgICAgICAgJiYgbG9hZFR5cGUgIT0gRnJhbWVM
b2FkVHlwZVJlbG9hZAogICAgICAgICAmJiBsb2FkVHlwZSAhPSBGcmFtZUxvYWRUeXBlUmVsb2Fk
RnJvbU9yaWdpbgogICAgICAgICAmJiBsb2FkVHlwZSAhPSBGcmFtZUxvYWRUeXBlU2FtZQpJbmRl
eDogV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2xv
YWRlci9GcmFtZUxvYWRlci5oCShyZXZpc2lvbiA3NDY2MSkKKysrIFdlYkNvcmUvbG9hZGVyL0Zy
YW1lTG9hZGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTM2Niw3ICszNjYsNyBAQCBwcml2YXRlOgog
ICAgIHZvaWQgY29udGludWVMb2FkQWZ0ZXJOZXdXaW5kb3dQb2xpY3koY29uc3QgUmVzb3VyY2VS
ZXF1ZXN0JiwgUGFzc1JlZlB0cjxGb3JtU3RhdGU+LCBjb25zdCBTdHJpbmcmIGZyYW1lTmFtZSwg
Y29uc3QgTmF2aWdhdGlvbkFjdGlvbiYsIGJvb2wgc2hvdWxkQ29udGludWUpOwogICAgIHZvaWQg
Y29udGludWVGcmFnbWVudFNjcm9sbEFmdGVyTmF2aWdhdGlvblBvbGljeShjb25zdCBSZXNvdXJj
ZVJlcXVlc3QmLCBib29sIHNob3VsZENvbnRpbnVlKTsKIAotICAgIGJvb2wgc2hvdWxkU2Nyb2xs
VG9BbmNob3IoYm9vbCBpc0Zvcm1TdWJtaXNzaW9uLCBGcmFtZUxvYWRUeXBlLCBjb25zdCBLVVJM
Jik7CisgICAgYm9vbCBzaG91bGRTY3JvbGxUb0FuY2hvcihib29sIGlzRm9ybVN1Ym1pc3Npb24s
IGNvbnN0IFN0cmluZyYgaHR0cE1ldGhvZCwgRnJhbWVMb2FkVHlwZSwgY29uc3QgS1VSTCYpOwog
CiAgICAgdm9pZCBjaGVja0xvYWRDb21wbGV0ZUZvclRoaXNGcmFtZSgpOwogCkluZGV4OiBMYXlv
dXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShy
ZXZpc2lvbiA3NDY5NykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA
QCAtMSwzICsxLDE1IEBACisyMDEwLTEyLTI3ICBZYWVsIEFoYXJvbiAgPHlhZWwuYWhhcm9uQG5v
a2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg
ICBSRUdSRVNTSU9OOiBmYXN0L2RvbS9jc3NUYXJnZXQtY3Jhc2guaHRtbCBmYWlscworICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAzNDIKKworICAgICAg
ICAqIGZhc3QvZm9ybXMvc3VibWl0LWNoYW5nZS1mcmFnbWVudC1leHBlY3RlZC50eHQ6IEFkZGVk
LgorICAgICAgICAqIGZhc3QvZm9ybXMvc3VibWl0LWNoYW5nZS1mcmFnbWVudC5odG1sOiBBZGRl
ZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvU2tpcHBlZDoKKyAgICAgICAgKiBwbGF0Zm9ybS9x
dC9Ta2lwcGVkOgorCiAyMDEwLTEyLTI3ICBLZW5qaSBJbWFzYWtpICA8aW1hc2FraUBjaHJvbWl1
bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCkluZGV4OiBMYXlvdXRU
ZXN0cy9mYXN0L2Zvcm1zL3N1Ym1pdC1jaGFuZ2UtZnJhZ21lbnQtZXhwZWN0ZWQudHh0Cj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvc3VibWl0LWNoYW5nZS1mcmFnbWVudC1l
eHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3N1Ym1p
dC1jaGFuZ2UtZnJhZ21lbnQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDcg
QEAKK2h0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDM0MgorVGVzdCB0
aGF0IHdoZW4gdGhlIGZvcm0gbWV0aG9kIGlzIGdldCwgYW5kIHRoZSBmb3JtIGFjdGlvbiBpcyB0
aGUgc2FtZSBhcyB0aGUgY3VycmVudCBsb2NhdGlvbiB1cmwsIGJ1dCB3aXRoIGRpZmZlcmVudCBm
cmFnbWVudCwgd2UgZG8gbm90IHJlbG9hZCB0aGUgcGFnZSwgYW5kIHRoZSBvbmxvYWQgaGFuZGxl
ciBpcyBub3QgY2FsbGVkIGFnYWluLgorCitBbHNvIHRlc3QgdGhhdCBjaGFuZ2luZyB0aGUgZm9y
bSBhY3Rpb24gYWZ0ZXIgdGhlIGZvcm0gd2FzIHN1Ym1pdHRlZCBoYXMgbm8gZWZmZWN0LgorCisK
K1BBU1MKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZm9ybXMvc3VibWl0LWNoYW5nZS1mcmFnbWVu
dC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvc3VibWl0LWNoYW5n
ZS1mcmFnbWVudC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9z
dWJtaXQtY2hhbmdlLWZyYWdtZW50Lmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMzUgQEAK
KzxodG1sPgorPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAg
ICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgbGF5b3V0VGVzdENvbnRy
b2xsZXIud2FpdFVudGlsRG9uZSgpOworfQorCitmdW5jdGlvbiBydW5UZXN0KCkgeworICAgIGRv
Y3VtZW50LmZvcm1zLmYuYWN0aW9uPSIjZmlyc3RhY3Rpb24iOworICAgIGRvY3VtZW50LmZvcm1z
LmYuc3VibWl0KCk7CisgICAgZG9jdW1lbnQuZm9ybXMuZi5hY3Rpb249IiNzZWNvbmRhY3Rpb24i
OworICAgIHNldFRpbWVvdXQoImNvbnRpbnVlVGVzdCgpOyIsIDIwKTsKK30KKworZnVuY3Rpb24g
Y29udGludWVUZXN0KCkgeworICAgIGlmIChkb2N1bWVudC5sb2NhdGlvbi5ocmVmLmluZGV4T2Yo
ImZpcnN0YWN0aW9uIikgIT0gLTEpIHsKKyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo
ImNvbnNvbGUiKS5pbm5lckhUTUw9IlBBU1MiOworICAgICAgICBpZiAod2luZG93LmxheW91dFRl
c3RDb250cm9sbGVyKQorICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9u
ZSgpOworICAgIH0KK30KKworCis8L3NjcmlwdD4KKzxib2R5IG9ubG9hZD0icnVuVGVzdCgpOyI+
Cis8ZGl2PjxhIGhyZWY9Imh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y
MDM0MiI+aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMzQyPC9hPjwv
ZGl2PgorPHA+VGVzdCB0aGF0IHdoZW4gdGhlIGZvcm0gbWV0aG9kIGlzIGdldCwgYW5kIHRoZSBm
b3JtIGFjdGlvbiBpcyB0aGUgc2FtZSBhcyB0aGUgY3VycmVudCBsb2NhdGlvbiB1cmwsIGJ1dCB3
aXRoIGRpZmZlcmVudCBmcmFnbWVudCwgd2UgZG8gbm90IHJlbG9hZCB0aGUgcGFnZSwgYW5kIHRo
ZSBvbmxvYWQgaGFuZGxlciBpcyBub3QgY2FsbGVkIGFnYWluLjwvcD4KKzxwPkFsc28gdGVzdCB0
aGF0IGNoYW5naW5nIHRoZSBmb3JtIGFjdGlvbiBhZnRlciB0aGUgZm9ybSB3YXMgc3VibWl0dGVk
IGhhcyBubyBlZmZlY3QuPC9wPgorCis8Zm9ybSBuYW1lPSJmIiBtZXRob2Q9IkdFVCIgYWN0aW9u
PSIjYWN0aW9uIj48aW5wdXQgbmFtZT0ibiIgdmFsdWU9InYiPjwvZm9ybT4KKzxkaXYgaWQ9ImNv
bnNvbGUiPkZBSUw8L2Rpdj4KKzxzY3JpcHQ+Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K
SW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9Ta2lwcGVkCj09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh
eW91dFRlc3RzL3BsYXRmb3JtL21hYy9Ta2lwcGVkCShyZXZpc2lvbiA3NDY2MSkKKysrIExheW91
dFRlc3RzL3BsYXRmb3JtL21hYy9Ta2lwcGVkCSh3b3JraW5nIGNvcHkpCkBAIC0zNSw5ICszNSw2
IEBAIGZhc3QvZXZlbnRzL2F0dGVtcHQtc2Nyb2xsLXdpdGgtbm8tc2Nyb2wKICMgU2tpcCBiZWNh
dXNlIGZpeCBmb3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI2Nzcw
IHdhcyByZXZlcnRlZAogY29tcG9zaXRpbmcvYW5pbWF0aW9uL2FuaW1hdGVkLWNvbXBvc2l0ZWQt
aW5zaWRlLWhpZGRlbi5odG1sCiAKLSMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTIwMzQyIFJFR1JFU1NJT046IGZhc3QvZG9tL2Nzc1RhcmdldC1jcmFzaC5odG1sIGZh
aWxzCi1mYXN0L2RvbS9jc3NUYXJnZXQtY3Jhc2guaHRtbAotCiAjIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTkxNiBQaXhlbCB0ZXN0IGRvZXNuJ3QgcmVwYWludCBl
bnRpcmUgdmlldyBzbyByZXN1bHQgaXMgY29ycnVwdGVkIGJ5IHByZXZpb3VzIHRlc3QKIHRhYmxl
cy9tb3ppbGxhX2V4cGVjdGVkX2ZhaWx1cmVzL2J1Z3MvYnVnMTc4ODU1LnhtbAogCkluZGV4OiBM
YXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz
L3BsYXRmb3JtL3F0L1NraXBwZWQJKHJldmlzaW9uIDc0NjYxKQorKysgTGF5b3V0VGVzdHMvcGxh
dGZvcm0vcXQvU2tpcHBlZAkod29ya2luZyBjb3B5KQpAQCAtMjUxMiw3ICsyNTEyLDYgQEAgZmFz
dC90cmFuc2Zvcm1zL3RyYW5zZm9ybS1wb3NpdGlvbmVkLWFuYwogIyAtLSB0aW1lZG91dCB3aXRo
IC0tcGxhdGZvcm0gbWFjIC0taWdub3JlLW1ldHJpY3MKIGZhc3QvZXZlbnRzLzUwNTY2MTkuaHRt
bAogZmFzdC9ldmVudHMvZHJhZy1pbi1mcmFtZXMuaHRtbAotZmFzdC9kb20vY3NzVGFyZ2V0LWNy
YXNoLmh0bWwKIGZhc3QvbG9hZGVyL251bGwtcmVxdWVzdC1hZnRlci13aWxsU2VuZFJlcXVlc3Qu
aHRtbAogZmFzdC90ZXh0L2ludGVybmF0aW9uYWwvdGhhaS1saW5lLWJyZWFrcy5odG1sCiAK
</data>
<flag name="review"
          id="68662"
          type_id="1"
          status="+"
          setter="abarth"
    />
          </attachment>
      

    </bug>

</bugzilla>