203193 2019-10-21 04:30:50 -0700 [GTK][WPE] Test PublicSuffix.TopPrivatelyControlledDomain is failing since r250589 2019-10-27 13:24:38 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia csaavedra bfulgham bugs-noreply commit-queue csaavedra pgriffis svillar wilander oldest_to_newest 1581836 0 cgarcia 2019-10-21 04:30:50 -0700 The new test case added in r250589 is failing: **FAIL** PublicSuffix.TopPrivatelyControlledDomain ../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:182 Expected equality of these values: String("test.com") Which is: test.com topPrivatelyControlledDomain(".test.com") Which is: This is because libsoup considers that hostnames starting with a dot are not valid and SOUP_TLD_ERROR_INVALID_HOSTNAME is returned. I don't know if we should just remove the leading dot before passing the hostname to soup_tld_get_base_domain(). 1581837 1 csaavedra 2019-10-21 04:40:34 -0700 libsoup since the TLD API was added considers domains starting with one or more dots not to be valid domains: /* Valid hostnames neither start with a dot nor have more than one * dot together. */ if (*hostname == '.') { g_set_error_literal (error, SOUP_TLD_ERROR, SOUP_TLD_ERROR_INVALID_HOSTNAME, _("Invalid hostname")); return NULL; } This is why the soup cookies API does a round of normalization before using the TLD API: normalized_cookie_domain = normalize_cookie_domain (cookie->domain); cookie_base_domain = soup_tld_get_base_domain (normalized_cookie_domain, NULL); I think that if we're dealing also with cookie domains, we need to remove the leading dot before using the soup API. 1582777 2 381670 csaavedra 2019-10-23 03:18:56 -0700 Created attachment 381670 Patch 1582783 3 381670 cgarcia 2019-10-23 03:30:59 -0700 Comment on attachment 381670 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381670&action=review > Source/WebCore/platform/soup/PublicSuffixSoup.cpp:59 > + unsigned pos = 0; pos -> position > Source/WebCore/platform/soup/PublicSuffixSoup.cpp:64 > + while (domainUTF8.data()[pos] == '.') > + pos++; > + > + GUniqueOutPtr<GError> error; > + if (const char* baseDomain = soup_tld_get_base_domain(domainUTF8.data() + pos, &error.outPtr())) We are returning early if domain is empty, it might become empty here if there are only dots. 1582788 4 381670 svillar 2019-10-23 03:43:17 -0700 Comment on attachment 381670 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381670&action=review > Source/WebCore/platform/soup/PublicSuffixSoup.cpp:61 > + pos++; this might lead to an invalid access in the case of having only dots in the domain 1582809 5 csaavedra 2019-10-23 08:15:05 -0700 (In reply to Sergio Villar Senin from comment #4) > Comment on attachment 381670 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=381670&action=review > > > Source/WebCore/platform/soup/PublicSuffixSoup.cpp:61 > > + pos++; > > this might lead to an invalid access in the case of having only dots in the > domain CStringBuffer (the underlying type containing the data) is implicitly allocated with an extra 0 byte, so this shouldn't happen unless the domain was empty, but we return earlier if that's the case, so I think this is safe. 1583745 6 381902 csaavedra 2019-10-25 03:13:47 -0700 Created attachment 381902 Patch 1583783 7 381902 cgarcia 2019-10-25 06:14:44 -0700 Comment on attachment 381902 Patch Make sure the new test you added passes in all other platforms before landing, please. 1584320 8 commit-queue 2019-10-27 13:23:49 -0700 The commit-queue encountered the following flaky tests while processing attachment 381902: imported/w3c/web-platform-tests/css/css-position/position-absolute-container-dynamic-002.html bug 203473 (author: simon.fraser@apple.com) imported/w3c/web-platform-tests/css/css-position/position-absolute-crash-chrome-005.html bug 203474 (author: simon.fraser@apple.com) imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity.html bug 203394 (author: ysuzuki@apple.com) The commit-queue is continuing to process your patch. 1584321 9 381902 commit-queue 2019-10-27 13:24:36 -0700 Comment on attachment 381902 Patch Clearing flags on attachment: 381902 Committed r251643: <https://trac.webkit.org/changeset/251643> 1584322 10 commit-queue 2019-10-27 13:24:38 -0700 All reviewed patches have been landed. Closing bug. 381670 2019-10-23 03:18:56 -0700 2019-10-25 03:13:43 -0700 Patch bug-203193-20191023131855.patch text/plain 2064 csaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxNDc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDQyNDY4ZGZhMWZjZTBi ZGIxMTI1NDE1OTIyNDE0MWEzNGQ4NWVkNi4uOTQ4MDQyMDRmNmM3NTEzZDdhMWUyNjY4NDhiZmRj NDkyYWFkOTFkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTEwLTIzICBDbGF1 ZGlvIFNhYXZlZHJhICA8Y3NhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bV1BF XSBUZXN0IFB1YmxpY1N1ZmZpeC5Ub3BQcml2YXRlbHlDb250cm9sbGVkRG9tYWluIGlzIGZhaWxp bmcgc2luY2UgcjI1MDU4OQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjAzMTkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9zb3VwL1B1YmxpY1N1ZmZpeFNvdXAuY3BwOgorICAgICAgICAo V2ViQ29yZTo6dG9wUHJpdmF0ZWx5Q29udHJvbGxlZERvbWFpbik6IFNraXAgYW55IGxlYWRpbmcg ZG90cyBiZWZvcmUgdXNpbmcgbGlic291cCBUTEQgQVBJLgorCiAyMDE5LTEwLTIyICBTaW1vbiBG cmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIHdwdC9jc3MvY3NzLWlt YWdlcy9ncmFkaWVudC9jb2xvci1zdG9wcy1wYXJzaW5nLmh0bWwgZmFpbHMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3NvdXAvUHVibGljU3VmZml4U291cC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9zb3VwL1B1YmxpY1N1ZmZpeFNvdXAuY3BwCmluZGV4IGY5MjA5 NzE3ODk2MmNkOTZkY2U0YWM4MTg5ZThmMWNkYzJiZjllYmUuLmE5NGNmZDZkNzU2ZDFkZTU2NWMw OGI1NTlkN2RmNThjY2FmNGM2MGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L3NvdXAvUHVibGljU3VmZml4U291cC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v c291cC9QdWJsaWNTdWZmaXhTb3VwLmNwcApAQCAtNTMsMTAgKzUzLDE1IEBAIFN0cmluZyB0b3BQ cml2YXRlbHlDb250cm9sbGVkRG9tYWluKGNvbnN0IFN0cmluZyYgZG9tYWluKQogICAgIGlmIChs b3dlcmNhc2VEb21haW4gPT0gImxvY2FsaG9zdCIpCiAgICAgICAgIHJldHVybiBsb3dlcmNhc2VE b21haW47CiAKLSAgICBHVW5pcXVlT3V0UHRyPEdFcnJvcj4gZXJyb3I7CiAgICAgQ1N0cmluZyBk b21haW5VVEY4ID0gbG93ZXJjYXNlRG9tYWluLnV0ZjgoKTsKIAotICAgIGlmIChjb25zdCBjaGFy KiBiYXNlRG9tYWluID0gc291cF90bGRfZ2V0X2Jhc2VfZG9tYWluKGRvbWFpblVURjguZGF0YSgp LCAmZXJyb3Iub3V0UHRyKCkpKQorICAgIC8vIFRoaXMgZnVuY3Rpb24gaXMgZXhwZWN0ZWQgdG8g d29yayB3aXRoIHRoZSBmb3JtYXQgdXNlZCBieSBjb29raWVzLCBzbyBza2lwIGFueSBsZWFkaW5n IGRvdHMuCisgICAgdW5zaWduZWQgcG9zID0gMDsKKyAgICB3aGlsZSAoZG9tYWluVVRGOC5kYXRh KClbcG9zXSA9PSAnLicpCisgICAgICAgIHBvcysrOworCisgICAgR1VuaXF1ZU91dFB0cjxHRXJy b3I+IGVycm9yOworICAgIGlmIChjb25zdCBjaGFyKiBiYXNlRG9tYWluID0gc291cF90bGRfZ2V0 X2Jhc2VfZG9tYWluKGRvbWFpblVURjguZGF0YSgpICsgcG9zLCAmZXJyb3Iub3V0UHRyKCkpKQog ICAgICAgICByZXR1cm4gU3RyaW5nOjpmcm9tVVRGOChiYXNlRG9tYWluKTsKIAogICAgIGlmIChn X2Vycm9yX21hdGNoZXMoZXJyb3IuZ2V0KCksIFNPVVBfVExEX0VSUk9SLCBTT1VQX1RMRF9FUlJP Ul9JTlZBTElEX0hPU1ROQU1FKSB8fCBnX2Vycm9yX21hdGNoZXMoZXJyb3IuZ2V0KCksIFNPVVBf VExEX0VSUk9SLCBTT1VQX1RMRF9FUlJPUl9OT1RfRU5PVUdIX0RPTUFJTlMpIHx8IGdfZXJyb3Jf bWF0Y2hlcyhlcnJvci5nZXQoKSwgU09VUF9UTERfRVJST1IsIFNPVVBfVExEX0VSUk9SX05PX0JB U0VfRE9NQUlOKSkK 381902 2019-10-25 03:13:47 -0700 2019-10-27 13:24:36 -0700 Patch bug-203193-20191025131345.patch text/plain 3585 csaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxNDc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDQyNDY4ZGZhMWZjZTBi ZGIxMTI1NDE1OTIyNDE0MWEzNGQ4NWVkNi4uODRmYzM0YzJjMjQ0MTg2NzhmYWJmYzU1ZDBlYjZj YWFkMmJlZWYwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTEwLTI1ICBDbGF1 ZGlvIFNhYXZlZHJhICA8Y3NhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bV1BF XSBUZXN0IFB1YmxpY1N1ZmZpeC5Ub3BQcml2YXRlbHlDb250cm9sbGVkRG9tYWluIGlzIGZhaWxp bmcgc2luY2UgcjI1MDU4OQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjAzMTkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9zb3VwL1B1YmxpY1N1ZmZpeFNvdXAuY3BwOgorICAgICAgICAo V2ViQ29yZTo6dG9wUHJpdmF0ZWx5Q29udHJvbGxlZERvbWFpbik6IFNraXAgYW55IGxlYWRpbmcg ZG90cyBiZWZvcmUgdXNpbmcgbGlic291cCBUTEQgQVBJLgorCiAyMDE5LTEwLTIyICBTaW1vbiBG cmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIHdwdC9jc3MvY3NzLWlt YWdlcy9ncmFkaWVudC9jb2xvci1zdG9wcy1wYXJzaW5nLmh0bWwgZmFpbHMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3NvdXAvUHVibGljU3VmZml4U291cC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9zb3VwL1B1YmxpY1N1ZmZpeFNvdXAuY3BwCmluZGV4IGY5MjA5 NzE3ODk2MmNkOTZkY2U0YWM4MTg5ZThmMWNkYzJiZjllYmUuLjk2NjA5ZDA4ZDlhYjkzZDA2ODEw MWZiZGE0OTk1MDIzYTEyZmZjNTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L3NvdXAvUHVibGljU3VmZml4U291cC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v c291cC9QdWJsaWNTdWZmaXhTb3VwLmNwcApAQCAtNTMsMTAgKzUzLDE4IEBAIFN0cmluZyB0b3BQ cml2YXRlbHlDb250cm9sbGVkRG9tYWluKGNvbnN0IFN0cmluZyYgZG9tYWluKQogICAgIGlmIChs b3dlcmNhc2VEb21haW4gPT0gImxvY2FsaG9zdCIpCiAgICAgICAgIHJldHVybiBsb3dlcmNhc2VE b21haW47CiAKLSAgICBHVW5pcXVlT3V0UHRyPEdFcnJvcj4gZXJyb3I7CiAgICAgQ1N0cmluZyBk b21haW5VVEY4ID0gbG93ZXJjYXNlRG9tYWluLnV0ZjgoKTsKIAotICAgIGlmIChjb25zdCBjaGFy KiBiYXNlRG9tYWluID0gc291cF90bGRfZ2V0X2Jhc2VfZG9tYWluKGRvbWFpblVURjguZGF0YSgp LCAmZXJyb3Iub3V0UHRyKCkpKQorICAgIC8vIFRoaXMgZnVuY3Rpb24gaXMgZXhwZWN0ZWQgdG8g d29yayB3aXRoIHRoZSBmb3JtYXQgdXNlZCBieSBjb29raWVzLCBzbyBza2lwIGFueSBsZWFkaW5n IGRvdHMuCisgICAgdW5zaWduZWQgcG9zaXRpb24gPSAwOworICAgIHdoaWxlIChkb21haW5VVEY4 LmRhdGEoKVtwb3NpdGlvbl0gPT0gJy4nKQorICAgICAgICBwb3NpdGlvbisrOworCisgICAgaWYg KHBvc2l0aW9uID09IGRvbWFpblVURjgubGVuZ3RoKCkpCisgICAgICAgIHJldHVybiBTdHJpbmco KTsKKworICAgIEdVbmlxdWVPdXRQdHI8R0Vycm9yPiBlcnJvcjsKKyAgICBpZiAoY29uc3QgY2hh ciogYmFzZURvbWFpbiA9IHNvdXBfdGxkX2dldF9iYXNlX2RvbWFpbihkb21haW5VVEY4LmRhdGEo KSArIHBvc2l0aW9uLCAmZXJyb3Iub3V0UHRyKCkpKQogICAgICAgICByZXR1cm4gU3RyaW5nOjpm cm9tVVRGOChiYXNlRG9tYWluKTsKIAogICAgIGlmIChnX2Vycm9yX21hdGNoZXMoZXJyb3IuZ2V0 KCksIFNPVVBfVExEX0VSUk9SLCBTT1VQX1RMRF9FUlJPUl9JTlZBTElEX0hPU1ROQU1FKSB8fCBn X2Vycm9yX21hdGNoZXMoZXJyb3IuZ2V0KCksIFNPVVBfVExEX0VSUk9SLCBTT1VQX1RMRF9FUlJP Ul9OT1RfRU5PVUdIX0RPTUFJTlMpIHx8IGdfZXJyb3JfbWF0Y2hlcyhlcnJvci5nZXQoKSwgU09V UF9UTERfRVJST1IsIFNPVVBfVExEX0VSUk9SX05PX0JBU0VfRE9NQUlOKSkKZGlmZiAtLWdpdCBh L1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmZmU4ODgwYWNkZWM0YzQ3 MWVmMjM5Y2RmMDk2YjA0ZGVkM2IzZDcxLi44MmJmYWE4OTM2YjdhMmM0ZDQ0NWRjYjU4MGQyYzll NTNkZmQ5MDQ0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMTAtMjMgIENsYXVkaW8gU2FhdmVkcmEgIDxjc2Fh dmVkcmFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVtXUEVdIFRlc3QgUHVibGljU3VmZml4 LlRvcFByaXZhdGVseUNvbnRyb2xsZWREb21haW4gaXMgZmFpbGluZyBzaW5jZSByMjUwNTg5Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDMxOTMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RXZWJL aXRBUEkvVGVzdHMvV2ViQ29yZS9QdWJsaWNTdWZmaXguY3BwOgorICAgICAgICAoVGVzdFdlYktp dEFQSTo6VEVTVF9GKTogQWRkIGEgdGVzdCBmb3IgYSBkb21haW4gY29uc2lzdGluZyBvbmx5IG9m IGRvdHMuCisKIDIwMTktMTAtMjIgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29t PgogCiAgICAgICAgIFtld3NdIFN0YXR1cyBidWJibGUgc2hvdWxkIHNob3cgcHJldmlvdXMgZmFp bHVyZXMgaWYgYW55IGluIGNhc2UgcGF0Y2ggaXMgc2tpcHBlZApkaWZmIC0tZ2l0IGEvVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1B1YmxpY1N1ZmZpeC5jcHAgYi9Ub29scy9UZXN0 V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvUHVibGljU3VmZml4LmNwcAppbmRleCBkZmUxZDBhMDRl MDFiOWUzZjRkODE4NTVmOWI5MmM3M2E5MzNhYWIxLi5mZGJlNzc1NzZhY2VjMThjYjFiNGIyM2Qw OWZkYmY4MzQ0ZmNjYzlmIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dl YkNvcmUvUHVibGljU3VmZml4LmNwcAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dl YkNvcmUvUHVibGljU3VmZml4LmNwcApAQCAtMTgwLDYgKzE4MCw3IEBAIFRFU1RfRihQdWJsaWNT dWZmaXgsIFRvcFByaXZhdGVseUNvbnRyb2xsZWREb21haW4pCiAgICAgRVhQRUNUX0VRKFN0cmlu Zygiw6XDpMO2IiksIHRvcFByaXZhdGVseUNvbnRyb2xsZWREb21haW4oIsOlw6TDtiIpKTsKICAg ICBFWFBFQ1RfRVEoU3RyaW5nKCLDhcOEw5YiKSwgdG9wUHJpdmF0ZWx5Q29udHJvbGxlZERvbWFp bigiw4XDhMOWIikpOwogICAgIEVYUEVDVF9FUShTdHJpbmcoInRlc3QuY29tIiksIHRvcFByaXZh dGVseUNvbnRyb2xsZWREb21haW4oIi50ZXN0LmNvbSIpKTsKKyAgICBFWFBFQ1RfRVEoU3RyaW5n KCksIHRvcFByaXZhdGVseUNvbnRyb2xsZWREb21haW4oIi4uLi4iKSk7CiB9CiAKIH0K