203075 2019-10-17 00:55:13 -0700 [Web Animations] Enable the Web Animations JavaScript API by default 2020-03-26 04:25:41 -0700 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=203088 InRadar P2 Normal --- 1 graouts graouts cdumez commit-queue dino dvoytenko fred.wang ggaren graouts koivisto webkit-bug-importer oldest_to_newest 1580895 0 graouts 2019-10-17 00:55:13 -0700 [Web Animations] Enable the Web Animations JavaScript API by default 1580896 1 381175 graouts 2019-10-17 00:55:49 -0700 Created attachment 381175 Patch 1580947 2 381175 koivisto 2019-10-17 07:48:25 -0700 Comment on attachment 381175 Patch Yay! 1580984 3 381175 commit-queue 2019-10-17 09:24:56 -0700 Comment on attachment 381175 Patch Clearing flags on attachment: 381175 Committed r251237: <https://trac.webkit.org/changeset/251237> 1580985 4 commit-queue 2019-10-17 09:24:58 -0700 All reviewed patches have been landed. Closing bug. 1580986 5 webkit-bug-importer 2019-10-17 09:25:34 -0700 <rdar://problem/56372801> 1580987 6 381175 cdumez 2019-10-17 09:26:30 -0700 Comment on attachment 381175 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381175&action=review > Source/WebCore/page/RuntimeEnabledFeatures.h:408 > + bool m_areWebAnimationsEnabled { true }; WebAnimation is not well-behaved when it comes to the back/forward cache and I do not think we should enable this until it is. We have a feature to make the back/forward cache work all the time and enabling this is a step backward. 1581339 7 graouts 2019-10-18 00:08:56 -0700 (In reply to Chris Dumez from comment #6) > Comment on attachment 381175 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=381175&action=review > > > Source/WebCore/page/RuntimeEnabledFeatures.h:408 > > + bool m_areWebAnimationsEnabled { true }; > > WebAnimation is not well-behaved when it comes to the back/forward cache and > I do not think we should enable this until it is. We have a feature to make > the back/forward cache work all the time and enabling this is a step > backward. This is tracked by 203088. 1581535 8 ggaren 2019-10-18 14:39:42 -0700 Antoine, does that mean that you intend to fix bug 203088 soon? If so, how soon? 1581691 9 graouts 2019-10-19 07:32:41 -0700 I do intend to fix it soon. I'm busy working on a performance regression with the "CSS Animations via Web Animations" flag (rdar://56017038), and as soon as I'm done with this, I will work on it. 1634093 10 dvoytenko 2020-03-25 16:05:01 -0700 Could you please confirm the status of Web Animations? All the relevant issues seem to be RESOLVED FIXED, and I can even find some blog posts on the feature. But I'm still not seeing it enabled in the latest desktop Safari. 1634273 11 graouts 2020-03-26 04:25:41 -0700 (In reply to Dima Voytenko from comment #10) > Could you please confirm the status of Web Animations? All the relevant > issues seem to be RESOLVED FIXED, and I can even find some blog posts on the > feature. But I'm still not seeing it enabled in the latest desktop Safari. Web Animations has been enabled for the first time in a shipping version of Safari this week with Safari 13.1 for macOS Catalina 10.15.4. There is also a newer version of Safari 12 for macOS High Sierra and macOS Mojave, but I'm not sure what the version number is. If you have the latest and greatest shipping Safari but somehow Web Animations is still disabled, you most likely disabled it manually yourself under Develop > Experimental Features. You can reset all of those flags using the "Reset All to Defaults" item at the bottom of the experimental features menu. 381175 2019-10-17 00:55:49 -0700 2019-10-17 09:24:56 -0700 Patch bug-203075-20191017095548.patch text/plain 2652 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxMjI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDQwMmZlZDMxNzJiNTE4 NzVjM2Q5MTY5MWNkYTBlMGJjNTYzMzUzNy4uZjllMGFiNGI0MzA0YzZmZWViOWZkMjlmM2EwNjhh Mjc5NzJmYTcwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE5LTEwLTE3ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYiBBbmltYXRpb25z XSBFbmFibGUgdGhlIFdlYiBBbmltYXRpb25zIEphdmFTY3JpcHQgQVBJIGJ5IGRlZmF1bHQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMzA3NQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGFnZS9SdW50 aW1lRW5hYmxlZEZlYXR1cmVzLmg6CisKIDIwMTktMTAtMTYgIFdlbnNvbiBIc2llaCAgPHdlbnNv bl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgW0NsaXBib2FyZCBBUEldIFtpT1NdIFJlZmFj dG9yIGxvZ2ljIGZvciBzdXBwcmVzc2luZyBVUkwgZGF0YSB3aGVuIHRoZSBwYXN0ZWJvYXJkIG1h eSBjb250YWluIGZpbGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1Nv dXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI0YTEyZDBiZmViYTE3ZGI4NTY1Yjc4MDU0MWIx N2M1OTg0ZTBhOWIuLmQ1Njk4MDZiOGMxMDlhOTBiMTVhMGIyMjRhOTY4OGNkMzFmMGMxY2QgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTktMTAtMTcgIEFudG9pbmUgUXVpbnQgIDxncmFv dXRzQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViIEFuaW1hdGlvbnNdIEVuYWJsZSB0aGUgV2Vi IEFuaW1hdGlvbnMgSmF2YVNjcmlwdCBBUEkgYnkgZGVmYXVsdAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAzMDc1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFt bDoKKwogMjAxOS0xMC0xNiAgRW1pbGlvIENvYm9zIMOBbHZhcmV6ICA8ZW1pbGlvQGNyaXNhbC5p bz4KIAogICAgICAgICBQYXNzIG5ldHdvcmsgY2FjaGUgZGlyZWN0b3J5IGluIFdlYnNpdGVEYXRh U3RvcmU6OnBhcmFtZXRlcnMoKSBmb3Igbm9uLUNvY29hIHBsYXRmb3Jtcy4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BhZ2UvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5oIGIvU291cmNlL1dl YkNvcmUvcGFnZS9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmgKaW5kZXggM2Q0YzU2YmY0MzI0NWMz MTk0MWYwNjRlYWU1NDU1NDZlZDQ2NzJhZS4uYzEyNzNjMGFkNzRiMDViNTFlZTY5YWJmNGVjZDJi YjYyMzg3ZmU0OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9SdW50aW1lRW5hYmxl ZEZlYXR1cmVzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9SdW50aW1lRW5hYmxlZEZlYXR1 cmVzLmgKQEAgLTQwNSw3ICs0MDUsNyBAQCBwcml2YXRlOgogICAgIGJvb2wgbV9pc0N1c3RvbVBh c3RlYm9hcmREYXRhRW5hYmxlZCB7IGZhbHNlIH07CiAgICAgYm9vbCBtX2lzV2ViU2hhcmVFbmFi bGVkIHsgZmFsc2UgfTsKICAgICBib29sIG1faW5wdXRFdmVudHNFbmFibGVkIHsgdHJ1ZSB9Owot ICAgIGJvb2wgbV9hcmVXZWJBbmltYXRpb25zRW5hYmxlZCB7IGZhbHNlIH07CisgICAgYm9vbCBt X2FyZVdlYkFuaW1hdGlvbnNFbmFibGVkIHsgdHJ1ZSB9OwogICAgIGJvb2wgbV9pc1dlYkFuaW1h dGlvbnNDU1NJbnRlZ3JhdGlvbkVuYWJsZWQgeyBmYWxzZSB9OwogICAgIGJvb2wgbV9pc0ltYWdl Qml0bWFwT2Zmc2NyZWVuQ2FudmFzRW5hYmxlZCB7IHRydWUgfTsKICAgICBib29sIG1faXNDYWNo ZUFQSUVuYWJsZWQgeyBmYWxzZSB9OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQv V2ViUHJlZmVyZW5jZXMueWFtbCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2Vz LnlhbWwKaW5kZXggNGYwYjZjNjQ0NjQ1NDk3NzhmZGRhYzBmMDg4NDg3ZTc2YzUxMjk1OC4uNzZj NmIwMDI1NjljZDQwNjNlZmVkOWFiNWY0NTE4YjU3ZDdkYTQ1OSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbAorKysgYi9Tb3VyY2UvV2ViS2l0L1No YXJlZC9XZWJQcmVmZXJlbmNlcy55YW1sCkBAIC0xMzA2LDcgKzEzMDYsNyBAQCBCbG9ja2luZ09m U21hbGxQbHVnaW5zRW5hYmxlZDoKIAogV2ViQW5pbWF0aW9uc0VuYWJsZWQ6CiAgIHR5cGU6IGJv b2wKLSAgZGVmYXVsdFZhbHVlOiBERUZBVUxUX0VYUEVSSU1FTlRBTF9GRUFUVVJFU19FTkFCTEVE CisgIGRlZmF1bHRWYWx1ZTogdHJ1ZQogICBodW1hblJlYWRhYmxlTmFtZTogIldlYiBBbmltYXRp b25zIgogICBodW1hblJlYWRhYmxlRGVzY3JpcHRpb246ICJXZWIgQW5pbWF0aW9ucyBwcm90b3R5 cGUiCiAgIGNhdGVnb3J5OiBleHBlcmltZW50YWwK