203016 2019-10-15 17:25:29 -0700 adoptRef DOMTimer in install instead of its constructor 2019-10-17 21:51:55 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 203137 1 rniwa rniwa cdumez fujii ggaren simon.fraser webkit-bug-importer oldest_to_newest 1580391 0 rniwa 2019-10-15 17:25:29 -0700 Make DOMTimer less insane. 1580392 1 381039 rniwa 2019-10-15 17:26:54 -0700 Created attachment 381039 Patch 1580433 2 rniwa 2019-10-15 19:32:07 -0700 Committed r251177: <https://trac.webkit.org/changeset/251177> 1580434 3 webkit-bug-importer 2019-10-15 19:33:17 -0700 <rdar://problem/56317774> 1580496 4 fujii 2019-10-16 02:11:50 -0700 Committed r251183: <https://trac.webkit.org/changeset/251183> 381039 2019-10-15 17:26:54 -0700 2019-10-15 17:30:26 -0700 Patch bug-203016-20191015172653.patch text/plain 5127 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1MTE3MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE5LTEwLTE1ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIGFkb3B0UmVmIERPTVRpbWVyIGlu IGluc3RhbGwgaW5zdGVhZCBvZiBpdHMgY29uc3RydWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMzAxNgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vdmVkIHRoZSBjb2RlIHRvIGFkZCBET01UaW1l ciB0byBTY3JpcHRFeGVjdXRpb25Db250ZXh0J3MgbWFwIHRvIERPTVRpbWVyOjppbnN0YWxsCisg ICAgICAgIGluc3RlYWQgb2YgaXRzIGNvbnN0cnVjdG9yIHNvIHRoYXQgd2UgY2FuIGFkb3B0UmVm IHRoZXJlIGluc3RlYWQgZm9yIGNsYXJpdHkgJiBzaW1wbGljaXR5LgorCisgICAgICAgICogZG9t L1NjcmlwdEV4ZWN1dGlvbkNvbnRleHQuaDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdEV4ZWN1 dGlvbkNvbnRleHQ6OmFkZFRpbWVvdXQpOgorICAgICAgICAqIHBhZ2UvRE9NVGltZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6RE9NVGltZXI6OkRPTVRpbWVyKToKKyAgICAgICAgKFdlYkNvcmU6 OkRPTVRpbWVyOjppbnN0YWxsKToKKyAgICAgICAgKFdlYkNvcmU6OkRPTVRpbWVyOjpmaXJlZCk6 CisKIDIwMTktMTAtMTUgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgW2lPU10gQ3Jhc2ggaW4gV2ViQ29yZTo6RE9NV2luZG93OjppbmNyZW1lbnRTY3JvbGxFdmVu dExpc3RlbmVyc0NvdW50CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vU2NyaXB0RXhlY3V0aW9u Q29udGV4dC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHRFeGVjdXRp b25Db250ZXh0LmgJKHJldmlzaW9uIDI1MTE2NCkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9TY3Jp cHRFeGVjdXRpb25Db250ZXh0LmgJKHdvcmtpbmcgY29weSkKQEAgLTIwMiw3ICsyMDIsNyBAQCBw dWJsaWM6CiAgICAgLy8gR2V0cyB0aGUgbmV4dCBpZCBpbiBhIGNpcmN1bGFyIHNlcXVlbmNlIGZy b20gMSB0byAyXjMxLTEuCiAgICAgaW50IGNpcmN1bGFyU2VxdWVudGlhbElEKCk7CiAKLSAgICBi b29sIGFkZFRpbWVvdXQoaW50IHRpbWVvdXRJZCwgRE9NVGltZXImIHRpbWVyKSB7IHJldHVybiBt X3RpbWVvdXRzLmFkZCh0aW1lb3V0SWQsICZ0aW1lcikuaXNOZXdFbnRyeTsgfQorICAgIGJvb2wg YWRkVGltZW91dChpbnQgdGltZW91dElkLCBET01UaW1lciYgdGltZXIpIHsgcmV0dXJuIG1fdGlt ZW91dHMuYWRkKHRpbWVvdXRJZCwgdGltZXIpLmlzTmV3RW50cnk7IH0KICAgICB2b2lkIHJlbW92 ZVRpbWVvdXQoaW50IHRpbWVvdXRJZCkgeyBtX3RpbWVvdXRzLnJlbW92ZSh0aW1lb3V0SWQpOyB9 CiAgICAgRE9NVGltZXIqIGZpbmRUaW1lb3V0KGludCB0aW1lb3V0SWQpIHsgcmV0dXJuIG1fdGlt ZW91dHMuZ2V0KHRpbWVvdXRJZCk7IH0KIApAQCAtMzA3LDcgKzMwNyw3IEBAIHByaXZhdGU6CiAg ICAgSGFzaFNldDxDb250ZXh0RGVzdHJ1Y3Rpb25PYnNlcnZlcio+IG1fZGVzdHJ1Y3Rpb25PYnNl cnZlcnM7CiAgICAgSGFzaFNldDxBY3RpdmVET01PYmplY3QqPiBtX2FjdGl2ZURPTU9iamVjdHM7 CiAKLSAgICBIYXNoTWFwPGludCwgUmVmUHRyPERPTVRpbWVyPj4gbV90aW1lb3V0czsKKyAgICBI YXNoTWFwPGludCwgUmVmPERPTVRpbWVyPj4gbV90aW1lb3V0czsKIAogICAgIHN0cnVjdCBQZW5k aW5nRXhjZXB0aW9uOwogICAgIHN0ZDo6dW5pcXVlX3B0cjxWZWN0b3I8c3RkOjp1bmlxdWVfcHRy PFBlbmRpbmdFeGNlcHRpb24+Pj4gbV9wZW5kaW5nRXhjZXB0aW9uczsKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL3BhZ2UvRE9NVGltZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Bh Z2UvRE9NVGltZXIuY3BwCShyZXZpc2lvbiAyNTExNjQpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdl L0RPTVRpbWVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTY5LDEzICsxNjksNiBAQCBET01UaW1l cjo6RE9NVGltZXIoU2NyaXB0RXhlY3V0aW9uQ29udGV4CiAgICAgLCBtX2N1cnJlbnRUaW1lcklu dGVydmFsKGludGVydmFsQ2xhbXBlZFRvTWluaW11bSgpKQogICAgICwgbV91c2VyR2VzdHVyZVRv a2VuVG9Gb3J3YXJkKFVzZXJHZXN0dXJlSW5kaWNhdG9yOjpjdXJyZW50VXNlckdlc3R1cmUoKSkK IHsKLSAgICBSZWZQdHI8RE9NVGltZXI+IHJlZmVyZW5jZSA9IGFkb3B0UmVmKHRoaXMpOwotCi0g ICAgLy8gS2VlcCBhc2tpbmcgZm9yIHRoZSBuZXh0IGlkIHVudGlsIHdlJ3JlIGdpdmVuIG9uZSB0 aGF0IHdlIGRvbid0IGFscmVhZHkgaGF2ZS4KLSAgICBkbyB7Ci0gICAgICAgIG1fdGltZW91dElk ID0gY29udGV4dC5jaXJjdWxhclNlcXVlbnRpYWxJRCgpOwotICAgIH0gd2hpbGUgKCFjb250ZXh0 LmFkZFRpbWVvdXQobV90aW1lb3V0SWQsICp0aGlzKSk7Ci0KICAgICBpZiAoc2luZ2xlU2hvdCkK ICAgICAgICAgc3RhcnRPbmVTaG90KG1fY3VycmVudFRpbWVySW50ZXJ2YWwpOwogICAgIGVsc2UK QEAgLTE4NiwyMiArMTc5LDI1IEBAIERPTVRpbWVyOjp+RE9NVGltZXIoKSA9IGRlZmF1bHQ7CiAK IGludCBET01UaW1lcjo6aW5zdGFsbChTY3JpcHRFeGVjdXRpb25Db250ZXh0JiBjb250ZXh0LCBz dGQ6OnVuaXF1ZV9wdHI8U2NoZWR1bGVkQWN0aW9uPiBhY3Rpb24sIFNlY29uZHMgdGltZW91dCwg Ym9vbCBzaW5nbGVTaG90KQogewotICAgIC8vIERPTVRpbWVyIGNvbnN0cnVjdG9yIHBhc3NlcyBv d25lcnNoaXAgb2YgdGhlIGluaXRpYWwgcmVmIG9uIHRoZSBvYmplY3QgdG8gdGhlIGNvbnN0cnVj dG9yLgotICAgIC8vIFRoaXMgcmVmZXJlbmNlIHdpbGwgYmUgcmVsZWFzZWQgYXV0b21hdGljYWxs eSB3aGVuIGEgb25lLXNob3QgdGltZXIgZmlyZXMsIHdoZW4gdGhlIGNvbnRleHQKLSAgICAvLyBp cyBkZXN0cm95ZWQsIG9yIGlmIGV4cGxpY2l0bHkgY2FuY2VsbGVkIGJ5IHJlbW92ZUJ5SWQuIAot ICAgIERPTVRpbWVyKiB0aW1lciA9IG5ldyBET01UaW1lcihjb250ZXh0LCBXVEZNb3ZlKGFjdGlv biksIHRpbWVvdXQsIHNpbmdsZVNob3QpOworICAgIFJlZjxET01UaW1lcj4gdGltZXIgPSBhZG9w dFJlZigqbmV3IERPTVRpbWVyKGNvbnRleHQsIFdURk1vdmUoYWN0aW9uKSwgdGltZW91dCwgc2lu Z2xlU2hvdCkpOwogICAgIHRpbWVyLT5zdXNwZW5kSWZOZWVkZWQoKTsKKworICAgIC8vIEtlZXAg YXNraW5nIGZvciB0aGUgbmV4dCBpZCB1bnRpbCB3ZSdyZSBnaXZlbiBvbmUgdGhhdCB3ZSBkb24n dCBhbHJlYWR5IGhhdmUuCisgICAgZG8geworICAgICAgICB0aW1lci0+bV90aW1lb3V0SWQgPSBj b250ZXh0LmNpcmN1bGFyU2VxdWVudGlhbElEKCk7CisgICAgfSB3aGlsZSAoIWNvbnRleHQuYWRk VGltZW91dCh0aW1lci0+bV90aW1lb3V0SWQsIHRpbWVyLmdldCgpKSk7CisKICAgICBJbnNwZWN0 b3JJbnN0cnVtZW50YXRpb246OmRpZEluc3RhbGxUaW1lcihjb250ZXh0LCB0aW1lci0+bV90aW1l b3V0SWQsIHRpbWVvdXQsIHNpbmdsZVNob3QpOwogCiAgICAgLy8gS2VlcCB0cmFjayBvZiBuZXN0 ZWQgdGltZXIgaW5zdGFsbHMuCiAgICAgaWYgKE5lc3RlZFRpbWVyc01hcCogbmVzdGVkVGltZXJz ID0gTmVzdGVkVGltZXJzTWFwOjppbnN0YW5jZUZvckNvbnRleHQoY29udGV4dCkpCi0gICAgICAg IG5lc3RlZFRpbWVycy0+YWRkKHRpbWVyLT5tX3RpbWVvdXRJZCwgKnRpbWVyKTsKKyAgICAgICAg bmVzdGVkVGltZXJzLT5hZGQodGltZXItPm1fdGltZW91dElkLCB0aW1lci5nZXQoKSk7CiAjaWYg UExBVEZPUk0oSU9TX0ZBTUlMWSkKICAgICBpZiAoaXM8RG9jdW1lbnQ+KGNvbnRleHQpKSB7CiAg ICAgICAgIGF1dG8mIGRvY3VtZW50ID0gZG93bmNhc3Q8RG9jdW1lbnQ+KGNvbnRleHQpOwotICAg ICAgICBkb2N1bWVudC5jb250ZW50Q2hhbmdlT2JzZXJ2ZXIoKS5kaWRJbnN0YWxsRE9NVGltZXIo KnRpbWVyLCB0aW1lb3V0LCBzaW5nbGVTaG90KTsKKyAgICAgICAgZG9jdW1lbnQuY29udGVudENo YW5nZU9ic2VydmVyKCkuZGlkSW5zdGFsbERPTVRpbWVyKHRpbWVyLmdldCgpLCB0aW1lb3V0LCBz aW5nbGVTaG90KTsKICAgICAgICAgaWYgKERlZmVyRE9NVGltZXJzRm9yU2NvcGU6OmlzRGVmZXJy aW5nKCkpCi0gICAgICAgICAgICBkb2N1bWVudC5kb21UaW1lckhvbGRpbmdUYW5rKCkuYWRkKCp0 aW1lcik7CisgICAgICAgICAgICBkb2N1bWVudC5kb21UaW1lckhvbGRpbmdUYW5rKCkuYWRkKHRp bWVyLmdldCgpKTsKICAgICB9CiAjZW5kaWYKICAgICByZXR1cm4gdGltZXItPm1fdGltZW91dElk OwpAQCAtMjg3LDcgKzI4Myw3IEBAIHZvaWQgRE9NVGltZXI6OmZpcmVkKCkKICAgICAvLyBSZXRh aW4gdGhpcyAtIGlmIHRoZSB0aW1lciBpcyBjYW5jZWxsZWQgd2hpbGUgdGhpcyBmdW5jdGlvbiBp cyBvbiB0aGUgc3RhY2sgKGltcGxpY2l0bHkgYW5kIGFsd2F5cwogICAgIC8vIGZvciBvbmUtc2hv dCB0aW1lcnMsIG9yIGlmIHJlbW92ZUJ5SWQgaXMgY2FsbGVkIG9uIGl0c2VsZiBmcm9tIHdpdGhp biBhbiBpbnRlcnZhbCB0aW1lciBmaXJlKSB0aGVuCiAgICAgLy8gd2FpdCB1bml0IHRoZSBlbmQg b2YgdGhpcyBmdW5jdGlvbiB0byBkZWxldGUgRE9NVGltZXIuCi0gICAgUmVmUHRyPERPTVRpbWVy PiByZWZlcmVuY2UgPSB0aGlzOworICAgIFJlZjxET01UaW1lcj4gcHJvdGVjdGVkVGhpcygqdGhp cyk7CiAKICAgICBBU1NFUlQoc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpKTsKICAgICBTY3JpcHRF eGVjdXRpb25Db250ZXh0JiBjb250ZXh0ID0gKnNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKTsK