202892 2019-10-13 05:18:05 -0700 [JSC] Make ConcurrentJSLock Lock even if ENABLE_CONCURRENT_JS=OFF 2019-12-18 18:19:28 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=200983 InRadar P2 Normal --- 1 ysuzuki ysuzuki benjamin cdumez cmarcelo dbates ews-watchlist keith_miller mark.lam msaboff prti saam tzagallo webkit-bug-importer oldest_to_newest 1579481 0 ysuzuki 2019-10-13 05:18:05 -0700 We are not respecting ConcurrentJS status when enabling ConcurrentGC. And concurrent GC sometimes use ConcurrentJSLock to get lock. We should just make ConcurrentJSLock as Lock. 1581556 1 381338 ysuzuki 2019-10-18 15:22:20 -0700 Created attachment 381338 Patch 1581562 2 381338 mark.lam 2019-10-18 15:28:02 -0700 Comment on attachment 381338 Patch r=me 1581591 3 ysuzuki 2019-10-18 16:32:09 -0700 Committed r251307: <https://trac.webkit.org/changeset/251307> 1581592 4 webkit-bug-importer 2019-10-18 16:33:17 -0700 <rdar://problem/56424123> 1600096 5 ysuzuki 2019-12-18 18:19:28 -0800 *** Bug 200983 has been marked as a duplicate of this bug. *** 381338 2019-10-18 15:22:20 -0700 2019-10-18 15:28:02 -0700 Patch bug-202892-20191018152219.patch text/plain 5632 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxMjk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 MzExNmUyZjQ5NGQ4YTQ0NTY3N2VlNWFiNTk0NWRjNTY0NDRjODI2Li4yMDVlOWRhMTBiYTA5YmMz YjU1NjNmZmZhNTE2N2Y5ODQ4OTAyMzQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSw0MCBAQAorMjAxOS0xMC0xOCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIE1ha2UgQ29uY3VycmVudEpTTG9jayBMb2NrIGV2ZW4gaWYgRU5B QkxFX0NPTkNVUlJFTlRfSlM9T0ZGCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDI4OTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBXZSBhcmUgdXNpbmcgQ29uY3VycmVudEpTTG9jayB0byBndWFyZCBkYXRh IHN0cnVjdHVyZSBhZ2FpbnN0IGNvbmN1cnJlbnQgY29tcGlsZXJzLgorICAgICAgICBCdXQgdGhl c2UgZGF0YSBzdHJ1Y3R1cmVzIHNob3VsZCBiZSBndWFyZGVkIGJ5IEdDIGNvbmN1cnJlbnQgY29s bGVjdG9yLCBzbyB3ZSBhcmUgdXNpbmcgdGhpcyBDb25jdXJyZW50SlNMb2NrCisgICAgICAgIHRv IGd1YXJkIHRoZW0gYWdhaW5zdCBjb25jdXJyZW50IGNvbGxlY3RvciB0b28uCisgICAgICAgIFRo ZSBwcm9ibGVtIGlzIHRoYXQgRU5BQkxFKENPTkNVUlJFTlRfSlMpIHJlbGllcyBvbiBFTkFCTEUo REZHX0pJVCkuIElmIHdlIGNvbmZpZ3VyZSBKU0Mgd2l0aCB0aGUgb3B0aW9ucyBsaWtlLAorCisg ICAgICAgICAgICBFTkFCTEVfREZHX0pJVCAwCisgICAgICAgICAgICBFTkFCTEVfRlRMX0pJVCAw CisKKyAgICAgICAgVGhlbiwgdGhlIGJ1aWx0IEpTQyBiZWNvbWVzCisKKyAgICAgICAgICAgIEVO QUJMRV9DT05DVVJSRU5UX0pTIDAKKyAgICAgICAgICAgIEJ1dCwgQ29uY3VycmVudCBHQyBpcyBl bmFibGVkLgorCisgICAgICAgIFRoaXMgaXMgd3JvbmcgZHVlIHRvIHNldmVyYWwgcmVhc29ucy4K KworICAgICAgICAgICAgMS4gQmFzZWxpbmUgSklUIGNhbiBwcm9kdWNlIEpJVCByZWxhdGVkIGRh dGEgc3RydWN0dXJlcyB0aGF0IGFyZSB0cmFjZWQgYnkgY29uY3VycmVudCBjb2xsZWN0b3IuIElu IHRoZSBhYm92ZSBvcHRpb25zLAorICAgICAgICAgICAgICAgdGhlc2UgZGF0YSBzdHJ1Y3R1cmVz IGFyZSBub3QgZ3VhcmRlZCBieSBsb2NrLgorICAgICAgICAgICAgMi4gQmFzZWxpbmUgSklUIGFs c28gaGFzIGNvbmN1cnJlbnQgSklUIGNvbXBpbGVyLiBCdXQgRU5BQkxFX0NPTkNVUlJFTlRfSlMg ZG9lcyBub3QgcmVmbGVjdCB0aGlzLgorCisgICAgICAgIEluIHRoaXMgcGF0Y2gsIHdlIGZpeCB0 d28gdGhpbmdzLgorCisgICAgICAgIDEuIFdlIHNob3VsZCBtYWtlIENvbmN1cnJlbnRKU0xvY2sg YWx3YXlzIExvY2suIEluIDY0Yml0IGVudmlyb25tZW50IHdlIGFyZSBzdXBwb3J0aW5nIGFjdGl2 ZWx5IChpbmNsdWRpbmcgd2F0Y2hPUyBBUk02NF8zMiksCisgICAgICAgICAgIHdlIGFyZSBlbmFi bGluZyBFTkFCTEUoSklUKSByZWdhcmRsZXNzIG9mIHdlIGFyZSBhY3R1YWxseSB1c2luZyBKSVQu IFNvLCBhbnl3YXksIHRoaXMgaXMgYWxyZWFkeSBhIExvY2suIEZsaXBwaW5nIHRoZXNlCisgICAg ICAgICAgIGJpdHMgZG9lcyBub3QgbWF0dGVyIGluIDMyYml0IGFyY2hpdGVjdHVyZXMgc2luY2Ug dGhleSBkbyBub3QgaGF2ZSBjb25jdXJyZW50IGNvbXBpbGVycyBhbnl3YXkuIFRoaXMgbWFrZXMg dGhpbmdzIHNpbXBsZXI6CisgICAgICAgICAgIGl0IGlzIGFsd2F5cyBhIExvY2suIEFuZCBjb25j dXJyZW50IGNvbGxlY3RvciBjYW4gdXNlIGl0LgorICAgICAgICAyLiBXZSBzaG91bGQgbWFrZSBg RU5BQkxFKENPTkNVUlJFTlRfSlMpYCBPTiB3aGVuIGBFTkFCTEUoSklUKWAgaXMgdHJ1ZSwgdG8g cmVmbGVjdCB0aGUgZmFjdCB0aGF0IEJhc2VsaW5lIEpJVCBoYXMgY29uY3VycmVudCBjb21waWxl ci4KKworICAgICAgICAqIHJ1bnRpbWUvQ29uY3VycmVudEpTTG9jay5oOgorICAgICAgICAoSlND OjpDb25jdXJyZW50SlNMb2NrZXI6OkNvbmN1cnJlbnRKU0xvY2tlcik6CisKIDIwMTktMTAtMTgg IEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CiAKICAgICAgICAgW0Ns YW5nXVtXaW5kb3dzXSBPcHRpb25zLmNwcCgzMTcsMjUpOiBlcnJvcjogbm8gbWF0Y2hpbmcgZnVu Y3Rpb24gZm9yIGNhbGwgdG8gJ29wdGlvblR5cGVTcGVjaWZpY0luZGV4JwpkaWZmIC0tZ2l0IGEv U291cmNlL1dURi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwppbmRleCAxMGNlODFi MzYzMWRlM2JiMmFlZTlkYmQ5ODE0OWYxNTA4N2JhYmJmLi5mYzFhNmJhNjAzYTI5NzQwMmMwMzIy NmJkMGQ4Yjk0MGZmNGNjYTU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTEwLTE4ICBZdXN1 a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAgICAgICAgW0pTQ10gTWFrZSBDb25j dXJyZW50SlNMb2NrIExvY2sgZXZlbiBpZiBFTkFCTEVfQ09OQ1VSUkVOVF9KUz1PRkYKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjg5MgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJhc2VsaW5lSklUIGFs c28gaGFzIGNvbmN1cnJlbnQgY29tcGlsZXIuIEVOQUJMRShDT05DVVJSRU5UX0pTKSBzaG91bGQg bm90IHJlbHkgb24gRU5BQkxFKERGR19KSVQpLgorICAgICAgICBJdCBzaG91bGQgcmVseSBvbiBF TkFCTEUoSklUKSBpbnN0ZWFkLgorCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6CisKIDIwMTkt MTAtMTcgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFVzZSBjb25z dGV4cHIgaW4gbW9yZSBwbGFjZXMgYW5kIHJlbW92ZSBzb21lIHVubmVjZXNzYXJ5IGV4dGVybmFs IGxpbmthZ2UuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db25j dXJyZW50SlNMb2NrLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db25jdXJyZW50 SlNMb2NrLmgKaW5kZXggNGM3YzEwYjBlZmUyOWEyYWVmOWY5M2YxYWE5NmFhZjE3OTMyMjY1ZC4u YWEyNzNiYWRiZWZhNzM3YTBlYWE1MzRmYmViYTlmNTAxZmRiODYyNyAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29uY3VycmVudEpTTG9jay5oCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbmN1cnJlbnRKU0xvY2suaApAQCAtMzIsMTMgKzMy LDggQEAKIAogbmFtZXNwYWNlIEpTQyB7CiAKLSNpZiBFTkFCTEUoQ09OQ1VSUkVOVF9KUykKLXR5 cGVkZWYgTG9jayBDb25jdXJyZW50SlNMb2NrOwotdHlwZWRlZiBMb2NrSG9sZGVyIENvbmN1cnJl bnRKU0xvY2tlckltcGw7Ci0jZWxzZQotdHlwZWRlZiBOb0xvY2sgQ29uY3VycmVudEpTTG9jazsK LXR5cGVkZWYgTm9Mb2NrTG9ja2VyIENvbmN1cnJlbnRKU0xvY2tlckltcGw7Ci0jZW5kaWYKK3Vz aW5nIENvbmN1cnJlbnRKU0xvY2sgPSBMb2NrOwordXNpbmcgQ29uY3VycmVudEpTTG9ja2VySW1w bCA9IExvY2tIb2xkZXI7CiAKIHN0YXRpY19hc3NlcnQoc2l6ZW9mKENvbmN1cnJlbnRKU0xvY2sp ID09IDEsICJSZWdhcmRsZXNzIG9mIHN0YXR1cyBvZiBjb25jdXJyZW50IEpTIGZsYWcsIHNpemUg b2YgQ29udXJyZW50SlNMb2NrIGlzIGFsd2F5cyBvbmUgYnl0ZS4iKTsKIApAQCAtMTAzLDcgKzk4 LDcgQEAgY2xhc3MgQ29uY3VycmVudEpTTG9ja2VyIDogcHVibGljIENvbmN1cnJlbnRKU0xvY2tl ckJhc2UgewogcHVibGljOgogICAgIENvbmN1cnJlbnRKU0xvY2tlcihDb25jdXJyZW50SlNMb2Nr JiBsb2NrYWJsZSkKICAgICAgICAgOiBDb25jdXJyZW50SlNMb2NrZXJCYXNlKGxvY2thYmxlKQot I2lmIEVOQUJMRShDT05DVVJSRU5UX0pTKSAmJiAhZGVmaW5lZChOREVCVUcpCisjaWYgIWRlZmlu ZWQoTkRFQlVHKQogICAgICAgICAsIG1fZGlzYWxsb3dHQyhzdGQ6OmluX3BsYWNlKQogI2VuZGlm CiAgICAgewpAQCAtMTExLDcgKzEwNiw3IEBAIGNsYXNzIENvbmN1cnJlbnRKU0xvY2tlciA6IHB1 YmxpYyBDb25jdXJyZW50SlNMb2NrZXJCYXNlIHsKIAogICAgIENvbmN1cnJlbnRKU0xvY2tlcihD b25jdXJyZW50SlNMb2NrKiBsb2NrYWJsZSkKICAgICAgICAgOiBDb25jdXJyZW50SlNMb2NrZXJC YXNlKGxvY2thYmxlKQotI2lmIEVOQUJMRShDT05DVVJSRU5UX0pTKSAmJiAhZGVmaW5lZChOREVC VUcpCisjaWYgIWRlZmluZWQoTkRFQlVHKQogICAgICAgICAsIG1fZGlzYWxsb3dHQyhzdGQ6Omlu X3BsYWNlKQogI2VuZGlmCiAgICAgewpAQCAtMTE5LDcgKzExNCw3IEBAIGNsYXNzIENvbmN1cnJl bnRKU0xvY2tlciA6IHB1YmxpYyBDb25jdXJyZW50SlNMb2NrZXJCYXNlIHsKIAogICAgIENvbmN1 cnJlbnRKU0xvY2tlcihOb0xvY2tpbmdOZWNlc3NhcnlUYWcpCiAgICAgICAgIDogQ29uY3VycmVu dEpTTG9ja2VyQmFzZShOb0xvY2tpbmdOZWNlc3NhcnkpCi0jaWYgRU5BQkxFKENPTkNVUlJFTlRf SlMpICYmICFkZWZpbmVkKE5ERUJVRykKKyNpZiAhZGVmaW5lZChOREVCVUcpCiAgICAgICAgICwg bV9kaXNhbGxvd0dDKFdURjo6bnVsbG9wdCkKICNlbmRpZgogICAgIHsKQEAgLTEyNyw3ICsxMjIs NyBAQCBjbGFzcyBDb25jdXJyZW50SlNMb2NrZXIgOiBwdWJsaWMgQ29uY3VycmVudEpTTG9ja2Vy QmFzZSB7CiAgICAgCiAgICAgQ29uY3VycmVudEpTTG9ja2VyKGludCkgPSBkZWxldGU7CiAKLSNp ZiBFTkFCTEUoQ09OQ1VSUkVOVF9KUykgJiYgIWRlZmluZWQoTkRFQlVHKQorI2lmICFkZWZpbmVk KE5ERUJVRykKIHByaXZhdGU6CiAgICAgT3B0aW9uYWw8RGlzYWxsb3dHQz4gbV9kaXNhbGxvd0dD OwogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oIGIvU291cmNl L1dURi93dGYvUGxhdGZvcm0uaAppbmRleCBjZTE3ODVkNDQ4YmE1MDM4YWU0ZmJhMmE4YmZjZDQy MzUyYjVkNDdmLi4wNWEzYzA5YjdiMGFhNDYwOTBkMGZiZWMxZWFhMjg5ODUxZDUwOTA5IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1Bs YXRmb3JtLmgKQEAgLTg0MSw3ICs4NDEsNyBAQAogICAgdmFsdWVzIGdldCBzdG9yZWQgdG8gYXRv bWljYWxseS4gVGhpcyBpcyB0cml2aWFsbHkgdHJ1ZSBvbiA2NC1iaXQgcGxhdGZvcm1zLAogICAg YnV0IG5vdCB0cnVlIGF0IGFsbCBvbiAzMi1iaXQgcGxhdGZvcm1zIHdoZXJlIHZhbHVlcyBhcmUg Y29tcG9zZWQgb2YgdHdvCiAgICBzZXBhcmF0ZSBzdWItdmFsdWVzLiAqLwotI2lmIEVOQUJMRShE RkdfSklUKSAmJiBVU0UoSlNWQUxVRTY0KQorI2lmIEVOQUJMRShKSVQpICYmIFVTRShKU1ZBTFVF NjQpCiAjZGVmaW5lIEVOQUJMRV9DT05DVVJSRU5UX0pTIDEKICNlbmRpZgogCg==