202850 2019-10-11 09:16:37 -0700 Regression(r250786) API Test TestWebKitAPI.WebKit.DefaultQuota is flaky 2019-10-30 18:33:24 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=202553 https://bugs.webkit.org/show_bug.cgi?id=202590 InRadar P2 Normal --- 1 aakash_jain cdumez aakash_jain achristensen ap cdumez commit-queue esprehn+autocc ews-watchlist ggaren jbedard kondapallykalyan webkit-bot-watchers-bugzilla webkit-bug-importer youennf oldest_to_newest 1579119 0 aakash_jain 2019-10-11 09:16:37 -0700 API Test TestWebKitAPI.WebKit.DefaultQuota is failing consistently on macOS Release build. e.g.: https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20%28Tests%29/builds/13637/steps/run-api-tests/logs/stdio https://ews-build.webkit.org/#/builders/3/builds/10036 1579120 1 aakash_jain 2019-10-11 09:17:55 -0700 This test was modified recently in https://trac.webkit.org/changeset/250728/webkit 1579229 2 achristensen 2019-10-11 13:48:23 -0700 That was a week ago. Has it been failing consistently since then? A sampling of the latest API test failures shows it is not failing consistently. 1579239 3 jbedard 2019-10-11 14:05:23 -0700 Pretty much always fails on OpenSource High Sierra: <https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.WebKit.DefaultQuota> (unfortunately, we just brought up the database with the Catalina testers, so we don't have more results....) 1579267 4 aakash_jain 2019-10-11 15:00:56 -0700 Actually it's not consistently failing, it's very flaky. For e.g.: in https://ews-build.webkit.org/#/builders/3/builds/10056, the test failed in run-api-tests step, but in immediate retry (re-run-api-tests) it passed. Similar thing happened in: https://ews-build.webkit.org/#/builders/3/builds/10054 https://ews-build.webkit.org/#/builders/3/builds/10048 https://ews-build.webkit.org/#/builders/3/builds/10018 https://ews-build.webkit.org/#/builders/3/builds/10005 Also, in following patches, it was flaky in a manner, which caused EWS to wrongly blame the patch being tested: https://ews-build.webkit.org/#/builders/3/builds/10037 https://ews-build.webkit.org/#/builders/3/builds/10019 https://ews-build.webkit.org/#/builders/3/builds/10014 https://ews-build.webkit.org/#/builders/3/builds/10006 1579268 5 aakash_jain 2019-10-11 15:06:02 -0700 The first failure seems to be in https://ews-build.webkit.org/#/builders/3/builds/9629 followed by https://ews-build.webkit.org/#/builders/3/builds/9643 and https://ews-build.webkit.org/#/builders/3/builds/9729. All these patches belongs to Bug 202590. Bug 202590 has red EWS bubble for api-mac, indicating this failure, and that patch was committed. Seems like that commit broke this test. 1579272 6 cdumez 2019-10-11 15:12:02 -0700 (In reply to Aakash Jain from comment #5) > The first failure seems to be in > https://ews-build.webkit.org/#/builders/3/builds/9629 > followed by https://ews-build.webkit.org/#/builders/3/builds/9643 and > https://ews-build.webkit.org/#/builders/3/builds/9729. All these patches > belongs to Bug 202590. > > Bug 202590 has red EWS bubble for api-mac, indicating this failure, and that > patch was committed. Seems like that commit broke this test. I will take a look but Bug 202590 is a PageCache patch and should have nothing to do with quotas. 1579281 7 cdumez 2019-10-11 15:33:46 -0700 The test passes for me locally. 1579282 8 cdumez 2019-10-11 15:40:18 -0700 +Youenn who wrote this test because I doubt this can be related to my PageCache change. Looking at this, I have no idea how it could be related. 1579285 9 cdumez 2019-10-11 15:50:20 -0700 I was able to reproduce the timeout one time. I'll try running the test in a loop for make it more reproducible. 1579286 10 cdumez 2019-10-11 15:52:10 -0700 (In reply to Chris Dumez from comment #9) > I was able to reproduce the timeout one time. I'll try running the test in a > loop for make it more reproducible. So, then it reproduces, with some extra logging I see: doTest(10) BEGIN (0) doTest(10) END (0) doTest(10) BEGIN (1) doTest(10) END (1) doTest(10) BEGIN (2) doTest(10) END (2) doTest(10) BEGIN (3) doTest(10) END (3) doTest(10) BEGIN (4) doTest(10) END (4) doTest(10) BEGIN (5) doTest(10) END (5) doTest(10) BEGIN (6) doTest(10) END (6) doTest(10) BEGIN (7) So the 7 first calls to doTest() caused us to receive a message back from the page, but the 8th one did not. 1579289 11 cdumez 2019-10-11 15:59:28 -0700 (In reply to Chris Dumez from comment #10) > (In reply to Chris Dumez from comment #9) > > I was able to reproduce the timeout one time. I'll try running the test in a > > loop for make it more reproducible. > > So, then it reproduces, with some extra logging I see: > doTest(10) BEGIN (0) > doTest(10) END (0) > doTest(10) BEGIN (1) > doTest(10) END (1) > doTest(10) BEGIN (2) > doTest(10) END (2) > doTest(10) BEGIN (3) > doTest(10) END (3) > doTest(10) BEGIN (4) > doTest(10) END (4) > doTest(10) BEGIN (5) > doTest(10) END (5) > doTest(10) BEGIN (6) > doTest(10) END (6) > doTest(10) BEGIN (7) > > > So the 7 first calls to doTest() caused us to receive a message back from > the page, but the 8th one did not. I am making good progress debugging this. I should be able to fix this shortly. 1579293 12 380798 cdumez 2019-10-11 16:23:07 -0700 Created attachment 380798 Patch 1579326 13 380798 commit-queue 2019-10-11 17:12:09 -0700 Comment on attachment 380798 Patch Clearing flags on attachment: 380798 Committed r251031: <https://trac.webkit.org/changeset/251031> 1579327 14 commit-queue 2019-10-11 17:12:11 -0700 All reviewed patches have been landed. Closing bug. 1580376 15 webkit-bug-importer 2019-10-15 16:48:10 -0700 <rdar://problem/56313729> 1585704 16 aakash_jain 2019-10-30 18:33:24 -0700 This test flaked again 2 days ago. In https://ews-build.webkit.org/#/builders/3/builds/11094, it timed out in run-api-tests step. However, in the immediately next retry step (re-run-api-tests), it passed. 380798 2019-10-11 16:23:07 -0700 2019-10-11 17:12:09 -0700 Patch bug-202850-20191011162306.patch text/plain 4389 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxMDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTkxOGYzZWUxNTcyZjE2 ZmJmNmVjNTc5ZmRkYzI5MmY4YTk2MmFkZC4uOGZlNzMzODkyMGVkYzRiMzM3NzMxOTdjZDMxYTE5 Y2I4YzQ3OGM5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE5LTEwLTExICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQVBJIFRlc3QgVGVzdFdlYktp dEFQSS5XZWJLaXQuRGVmYXVsdFF1b3RhIGlzIHZlcnkgZmxha3kgb24gSGlnaCBTaWVycmEKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjg1MAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ugc3VyZSB0 aGUgRE9NQ2FjaGUgLyBET01DYWNoZVN0b3JhZ2Ugb2JqZWN0cyBzdGF5IGFsaXZlIHdoaWxlIHRo ZXkgaGF2ZSBwZW5kaW5nCisgICAgICAgIHByb21pc2VzIHRvIGJlIHJlc29sdmVkLgorCisgICAg ICAgICogTW9kdWxlcy9jYWNoZS9ET01DYWNoZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpET01D YWNoZTo6aGFzUGVuZGluZ0FjdGl2aXR5IGNvbnN0KToKKyAgICAgICAgKiBNb2R1bGVzL2NhY2hl L0RPTUNhY2hlLmg6CisgICAgICAgICogTW9kdWxlcy9jYWNoZS9ET01DYWNoZS5pZGw6CisgICAg ICAgICogTW9kdWxlcy9jYWNoZS9ET01DYWNoZVN0b3JhZ2UuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RE9NQ2FjaGVTdG9yYWdlOjpoYXNQZW5kaW5nQWN0aXZpdHkgY29uc3QpOgorICAgICAgICAq IE1vZHVsZXMvY2FjaGUvRE9NQ2FjaGVTdG9yYWdlLmg6CisgICAgICAgICogTW9kdWxlcy9jYWNo ZS9ET01DYWNoZVN0b3JhZ2UuaWRsOgorCiAyMDE5LTEwLTExICBBbGV4IENocmlzdGVuc2VuICA8 YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgT25seSB1c2UgQ0ZOZXR3b3JrIFNQ SSBmb3IgbWV0cmljcyB3aGVyZSBuZWVkZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvY2FjaGUvRE9NQ2FjaGUuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9jYWNoZS9E T01DYWNoZS5jcHAKaW5kZXggYjYzMTZkNzQ2MmZmNGEyOTZlOGUxNmM4ZjkxZjU2OTk1YjYwMGVk MC4uYjlmOTM1YjgwNjcwMGQyOWI0ODIxZGY5YjYwMmE0ZGI4YWIzMTk2ZCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9jYWNoZS9ET01DYWNoZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9jYWNoZS9ET01DYWNoZS5jcHAKQEAgLTYxMyw1ICs2MTMsMTAgQEAgYm9v bCBET01DYWNoZTo6Y2FuU3VzcGVuZEZvckRvY3VtZW50U3VzcGVuc2lvbigpIGNvbnN0CiAgICAg cmV0dXJuIHRydWU7CiB9CiAKK2Jvb2wgRE9NQ2FjaGU6Omhhc1BlbmRpbmdBY3Rpdml0eSgpIGNv bnN0Cit7CisgICAgcmV0dXJuIG1fdGFza1F1ZXVlLT5oYXNQZW5kaW5nVGFza3MoKSB8fCBBY3Rp dmVET01PYmplY3Q6Omhhc1BlbmRpbmdBY3Rpdml0eSgpOworfQorCiAKIH0gLy8gbmFtZXNwYWNl IFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvY2FjaGUvRE9NQ2Fj aGUuaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvY2FjaGUvRE9NQ2FjaGUuaAppbmRleCBjZjIw NjFkMjhmOWU4MmQxN2MyNTZkOGQ3MmI1ZjIzNjE1MjliN2ZmLi40ZGMwM2NhNTcyOTBjMGU1Zjg5 YThkYmM0NjRiOWVmYzQyOWE0MmZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L2NhY2hlL0RPTUNhY2hlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9jYWNoZS9ET01D YWNoZS5oCkBAIC02Myw2ICs2Myw5IEBAIHB1YmxpYzoKIAogICAgIENhY2hlU3RvcmFnZUNvbm5l Y3Rpb24mIGNvbm5lY3Rpb24oKSB7IHJldHVybiBtX2Nvbm5lY3Rpb24uZ2V0KCk7IH0KIAorICAg IC8vIEFjdGl2ZURPTU9iamVjdAorICAgIGJvb2wgaGFzUGVuZGluZ0FjdGl2aXR5KCkgY29uc3Qg ZmluYWw7CisKIHByaXZhdGU6CiAgICAgRE9NQ2FjaGUoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCYs IFN0cmluZyYmIG5hbWUsIHVpbnQ2NF90IGlkZW50aWZpZXIsIFJlZjxDYWNoZVN0b3JhZ2VDb25u ZWN0aW9uPiYmKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9jYWNoZS9E T01DYWNoZS5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2NhY2hlL0RPTUNhY2hlLmlkbApp bmRleCA4MzQwZTk1MzJlOTc4NDMyYjc5MmIyYTBhZDQzNGQxYTZkMDhlZjVmLi42ODI2YjQ2YzI1 YjE0MGQwZjJmZjhjMTJjNDI4NTNjZTk2NTExNmUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL2NhY2hlL0RPTUNhY2hlLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L2NhY2hlL0RPTUNhY2hlLmlkbApAQCAtMjYsNiArMjYsNyBAQAogdHlwZWRlZiAoRmV0Y2hSZXF1 ZXN0IG9yIFVTVlN0cmluZykgUmVxdWVzdEluZm87CiAKIFsKKyAgICBBY3RpdmVET01PYmplY3Qs CiAgICAgU2VjdXJlQ29udGV4dCwKICAgICBFeHBvc2VkPShXaW5kb3csV29ya2VyKSwKICAgICBF bmFibGVkQXRSdW50aW1lPUNhY2hlQVBJLApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9k dWxlcy9jYWNoZS9ET01DYWNoZVN0b3JhZ2UuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9j YWNoZS9ET01DYWNoZVN0b3JhZ2UuY3BwCmluZGV4IGNjMjg5YTZmZTNmMGNjYzVlNDUxZTg1MDYw MzhlZmYzNDE0YjZlZTUuLjU2ZjgxM2Y1ODg0YWU2YWZiM2E5ZWUxOTJmZjgxOGJmYmNlMTIxYzMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvY2FjaGUvRE9NQ2FjaGVTdG9yYWdl LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2NhY2hlL0RPTUNhY2hlU3RvcmFnZS5j cHAKQEAgLTI5Myw0ICsyOTMsOSBAQCBib29sIERPTUNhY2hlU3RvcmFnZTo6Y2FuU3VzcGVuZEZv ckRvY3VtZW50U3VzcGVuc2lvbigpIGNvbnN0CiAgICAgcmV0dXJuIHRydWU7CiB9CiAKK2Jvb2wg RE9NQ2FjaGVTdG9yYWdlOjpoYXNQZW5kaW5nQWN0aXZpdHkoKSBjb25zdAoreworICAgIHJldHVy biBtX3Rhc2tRdWV1ZS0+aGFzUGVuZGluZ1Rhc2tzKCkgfHwgQWN0aXZlRE9NT2JqZWN0OjpoYXNQ ZW5kaW5nQWN0aXZpdHkoKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9jYWNoZS9ET01DYWNoZVN0b3JhZ2UuaCBiL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvY2FjaGUvRE9NQ2FjaGVTdG9yYWdlLmgKaW5kZXggOWI2ZDliMWQy ZTVmNTFjYTIwNGY4ZWM2YjY2N2M0MmJiYzJmNTRlMy4uNjZlODhiMzY4N2MyYzllMmEyNzhiODU5 OWZmYWQ5ZmI3ZGZiNjhlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9jYWNo ZS9ET01DYWNoZVN0b3JhZ2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2NhY2hlL0RP TUNhY2hlU3RvcmFnZS5oCkBAIC00Nyw2ICs0Nyw5IEBAIHB1YmxpYzoKICAgICB2b2lkIHJlbW92 ZShjb25zdCBTdHJpbmcmLCBET01Qcm9taXNlRGVmZXJyZWQ8SURMQm9vbGVhbj4mJik7CiAgICAg dm9pZCBrZXlzKEtleXNQcm9taXNlJiYpOwogCisgICAgLy8gQWN0aXZlRE9NT2JqZWN0CisgICAg Ym9vbCBoYXNQZW5kaW5nQWN0aXZpdHkoKSBjb25zdCBmaW5hbDsKKwogcHJpdmF0ZToKICAgICBE T01DYWNoZVN0b3JhZ2UoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCYsIFJlZjxDYWNoZVN0b3JhZ2VD b25uZWN0aW9uPiYmKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9jYWNo ZS9ET01DYWNoZVN0b3JhZ2UuaWRsIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9jYWNoZS9ET01D YWNoZVN0b3JhZ2UuaWRsCmluZGV4IDAzMTk2YzU2Y2E4YWRhYzM0NGZiZmE0Y2RkYTBlMTEyOTI1 NjYyNGUuLjU1YmRjMjY2NjRkYmJkODkyY2E3Y2VmYmUyNTJkNTY3NzlkMzllNWEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvY2FjaGUvRE9NQ2FjaGVTdG9yYWdlLmlkbAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2NhY2hlL0RPTUNhY2hlU3RvcmFnZS5pZGwKQEAgLTI2 LDYgKzI2LDcgQEAKIHR5cGVkZWYgKEZldGNoUmVxdWVzdCBvciBVU1ZTdHJpbmcpIFJlcXVlc3RJ bmZvOwogCiBbCisgICAgQWN0aXZlRE9NT2JqZWN0LAogICAgIFNlY3VyZUNvbnRleHQsCiAgICAg RXhwb3NlZD0oV2luZG93LFdvcmtlciksCiAgICAgRW5hYmxlZEF0UnVudGltZT1DYWNoZUFQSSwK