<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>202836</bug_id>
          
          <creation_ts>2019-10-10 17:51:39 -0700</creation_ts>
          <short_desc>Enable WebGL&apos;s ASTC extension all the time</short_desc>
          <delta_ts>2020-02-18 16:48:08 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebGL</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>185272</dependson>
    
    <dependson>197900</dependson>
          <blocked>198948</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Kenneth Russell">kbr</reporter>
          <assigned_to name="Kenneth Russell">kbr</assigned_to>
          <cc>cdumez</cc>
    
    <cc>dino</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>graouts</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>jdarpinian</cc>
    
    <cc>justin_fan</cc>
    
    <cc>kondapallykalyan</cc>
    
    <cc>shrekshao</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1578933</commentid>
    <comment_count>0</comment_count>
    <who name="Kenneth Russell">kbr</who>
    <bug_when>2019-10-10 17:51:39 -0700</bug_when>
    <thetext>In Bug 185272 ASTC compressed texture support was added to the WebGL implementation. Currently it&apos;s behind a run-time flag. It should be removed from behind this flag and just enabled whenever the underlying OpenGL (ES) extensions are available, so it auto-enables whenever sufficient support is present.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1588476</commentid>
    <comment_count>1</comment_count>
    <who name="Kenneth Russell">kbr</who>
    <bug_when>2019-11-07 16:24:08 -0800</bug_when>
    <thetext>Blocking on the ETC1/ETC2 bug, which alphabetizes the compressed texture extensions in some of the code.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1588875</commentid>
    <comment_count>2</comment_count>
      <attachid>383175</attachid>
    <who name="Kenneth Russell">kbr</who>
    <bug_when>2019-11-08 16:11:16 -0800</bug_when>
    <thetext>Created attachment 383175
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1588877</commentid>
    <comment_count>3</comment_count>
    <who name="Kenneth Russell">kbr</who>
    <bug_when>2019-11-08 16:16:01 -0800</bug_when>
    <thetext>Built on macOS. Still building for the iOS Simulator, with WebKit modified to always use an OpenGL ES 3.0 context, to verify the WebGL conformance test passes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1588989</commentid>
    <comment_count>4</comment_count>
    <who name="Kenneth Russell">kbr</who>
    <bug_when>2019-11-09 01:19:58 -0800</bug_when>
    <thetext>I built this patch for the iOS Simulator, plus a couple of changes to GraphicsContext3DCocoa.mm to force the use of ES 3.0 contexts:


diff --git a/Source/WebCore/platform/graphics/cocoa/GraphicsContext3DCocoa.mm b/Source/WebCore/platform/graphics/cocoa/GraphicsContext3DCocoa.mm
index d1af803f38d..6a7c5eaa598 100644
--- a/Source/WebCore/platform/graphics/cocoa/GraphicsContext3DCocoa.mm
+++ b/Source/WebCore/platform/graphics/cocoa/GraphicsContext3DCocoa.mm
@@ -192,6 +192,8 @@ GraphicsContext3D::GraphicsContext3D(GraphicsContext3DAttributes attrs, HostWind
     m_powerPreferenceUsedForCreation = GraphicsContext3DPowerPreference::Default;
 #endif
 
+    m_attrs.isWebGL2 = true;
+
 #if !USE(ANGLE)
 #if USE(OPENGL_ES)
     if (m_attrs.isWebGL2)
@@ -215,6 +217,7 @@ GraphicsContext3D::GraphicsContext3D(GraphicsContext3DAttributes attrs, HostWind
 
     if (m_attrs.isWebGL2)
         ::glEnable(GraphicsContext3D::PRIMITIVE_RESTART_FIXED_INDEX);
+    m_isForWebGL2 = m_attrs.isWebGL2;
 #elif USE(OPENGL)
 
     bool useMultisampling = m_attrs.antialias;





Unfortunately https://www.khronos.org/registry/webgl/sdk/tests/conformance/extensions/webgl-compressed-texture-astc.html still reported no support for ASTC textures on the iPhone SE for WebKit Development.

Appreciate others&apos; help getting this patch tested and over the finish line. Thanks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1593529</commentid>
    <comment_count>5</comment_count>
    <who name="">shrekshao</who>
    <bug_when>2019-11-25 16:05:12 -0800</bug_when>
    <thetext>I know this patch is for NonAngle case.
The debugging shows it&apos;s Extensions3DOpenGLCommon::m_availableExtensions that doesn&apos;t include the ASTC extension string. Given that it is initialized by calling glGetStringi, I doubt if the iPhone Simulator on Mac could ever populate such extension if the underlying gpu hardware doesn&apos;t support the ASTC extension? If this could be verified I think we could only test this patch on real iPhone. Could Dean or Justin help to verify this? Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1595248</commentid>
    <comment_count>6</comment_count>
    <who name="Dean Jackson">dino</who>
    <bug_when>2019-12-03 16:11:25 -0800</bug_when>
    <thetext>(In reply to shrekshao from comment #5)
&gt; I know this patch is for NonAngle case.
&gt; The debugging shows it&apos;s Extensions3DOpenGLCommon::m_availableExtensions
&gt; that doesn&apos;t include the ASTC extension string. Given that it is initialized
&gt; by calling glGetStringi, I doubt if the iPhone Simulator on Mac could ever
&gt; populate such extension if the underlying gpu hardware doesn&apos;t support the
&gt; ASTC extension? If this could be verified I think we could only test this
&gt; patch on real iPhone. Could Dean or Justin help to verify this? Thanks!

I&apos;ll test, but from what I recall, ASTC is only supported on device (and as Ken pointed out, &gt; iPhone SE)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1595249</commentid>
    <comment_count>7</comment_count>
    <who name="Dean Jackson">dino</who>
    <bug_when>2019-12-03 16:13:02 -0800</bug_when>
    <thetext>Oh. I also think ASTC was only supported on devices when using a GLES 3 context, not a GLES 2 context :(

That&apos;s why Justin put it behind a flag for now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1595250</commentid>
    <comment_count>8</comment_count>
      <attachid>383175</attachid>
    <who name="Dean Jackson">dino</who>
    <bug_when>2019-12-03 16:13:59 -0800</bug_when>
    <thetext>Comment on attachment 383175
Patch

r=me

I&apos;ll test manually before landing this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1595266</commentid>
    <comment_count>9</comment_count>
    <who name="Kenneth Russell">kbr</who>
    <bug_when>2019-12-03 16:59:42 -0800</bug_when>
    <thetext>Thanks Dean for helping with this. Please see the diff in https://bugs.webkit.org/show_bug.cgi?id=202836#c4 which was needed to force WebGL to use an ES3 context by default. Still the simulator didn&apos;t appear to support ASTC compressed textures - maybe not surprising since the emulation path would be much more complex than ETC? ETC is supported by the simulator.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1595511</commentid>
    <comment_count>10</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-12-04 10:02:49 -0800</bug_when>
    <thetext>&lt;rdar://problem/57627592&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1595512</commentid>
    <comment_count>11</comment_count>
    <who name="Dean Jackson">dino</who>
    <bug_when>2019-12-04 10:03:03 -0800</bug_when>
    <thetext>I confirmed this works on devices (that themselves support ASTC).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1595514</commentid>
    <comment_count>12</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-12-04 10:03:09 -0800</bug_when>
    <thetext>&lt;rdar://problem/57627600&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1595516</commentid>
    <comment_count>13</comment_count>
    <who name="Dean Jackson">dino</who>
    <bug_when>2019-12-04 10:05:30 -0800</bug_when>
    <thetext>Committed r253108: &lt;https://trac.webkit.org/changeset/253108&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1595539</commentid>
    <comment_count>14</comment_count>
    <who name="Kenneth Russell">kbr</who>
    <bug_when>2019-12-04 11:07:39 -0800</bug_when>
    <thetext>Thank you Dean for testing and landing this!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1620439</commentid>
    <comment_count>15</comment_count>
    <who name="Kenneth Russell">kbr</who>
    <bug_when>2020-02-18 16:48:08 -0800</bug_when>
    <thetext>*** Bug 194751 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>383175</attachid>
            <date>2019-11-08 16:11:16 -0800</date>
            <delta_ts>2019-12-03 16:13:59 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-202836-20191108161116.patch</filename>
            <type>text/plain</type>
            <size>6515</size>
            <attacher name="Kenneth Russell">kbr</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyMjYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzY5N2FjY2EwMGJlNTI0
NjcyMDYyZGNiYTkzYzk2NDZlN2QwMzQxYy4uYjQ0ZWMzN2M3NzdkMGYwNDIyMDdiZjU0NjIwMmZm
ZTgwYzU0ZTAwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTExLTA4ICBLZW5u
ZXRoIFJ1c3NlbGwgIDxrYnJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEVuYWJsZSBXZWJHTCdz
IEFTVEMgZXh0ZW5zaW9uIGFsbCB0aGUgdGltZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAyODM2CisKKyAgICAgICAgUmVtb3ZlIHRoZSBydW4tdGlt
ZSBmbGFnIC0gbm8gbG9uZ2VyIG5lY2Vzc2FyeS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP
RFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0bWwvY2FudmFzL1dlYkdMQ29tcHJlc3NlZFRleHR1
cmVBU1RDLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYkdMQ29tcHJlc3NlZFRleHR1cmVBU1RD
OjpzdXBwb3J0ZWQpOgorICAgICAgICAqIGh0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4
dEJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2ViR0xSZW5kZXJpbmdDb250ZXh0QmFzZTo6
ZXh0ZW5zaW9uSXNFbmFibGVkKToKKyAgICAgICAgKiBwYWdlL1J1bnRpbWVFbmFibGVkRmVhdHVy
ZXMuaDoKKyAgICAgICAgKFdlYkNvcmU6OlJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OnNldFdlYkdM
Q29tcHJlc3NlZFRleHR1cmVBU1RDU3VwcG9ydEVuYWJsZWQpOiBEZWxldGVkLgorICAgICAgICAo
V2ViQ29yZTo6UnVudGltZUVuYWJsZWRGZWF0dXJlczo6d2ViR0xDb21wcmVzc2VkVGV4dHVyZUFT
VENTdXBwb3J0RW5hYmxlZCBjb25zdCk6IERlbGV0ZWQuCisKIDIwMTktMTEtMDggIEFudHRpIEtv
aXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFN0eWxlUmVzb2x2ZXIgc3RhdGUg
c2hvdWxkIHN0b3JlIHVzZXIgYWdlbnQgYXBwZWFyYW5jZSBzdHlsZSBhcyBSZW5kZXJTdHlsZQpk
aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L0NoYW5n
ZUxvZwppbmRleCBkMWI3MTQyZTRhMGFlYmMyNDliZThhNTNhNjc2MzMwMTM1NjE5YzM4Li43MmUw
N2Q3ZmU1Y2Y5NGJkY2IzOGVhN2I4M2Q3ZGMxYmU5NDE1OGQyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv
V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx
LDE0IEBACisyMDE5LTExLTA4ICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAY2hyb21pdW0ub3JnPgor
CisgICAgICAgIEVuYWJsZSBXZWJHTCdzIEFTVEMgZXh0ZW5zaW9uIGFsbCB0aGUgdGltZQorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAyODM2CisKKyAg
ICAgICAgUmVtb3ZlIHRoZSBydW4tdGltZSBmbGFnIC0gbm8gbG9uZ2VyIG5lY2Vzc2FyeS4KKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNoYXJlZC9X
ZWJQcmVmZXJlbmNlcy55YW1sOgorCiAyMDE5LTExLTA4ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9s
bGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbbWFjT1NdIFtpT1NdIEFkZCBsb2dnaW5nIGFuZCB0
ZWxlbWV0cnkgdG8gbWFjaCBsb29rdXAgcnVsZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl
L2h0bWwvY2FudmFzL1dlYkdMQ29tcHJlc3NlZFRleHR1cmVBU1RDLmNwcCBiL1NvdXJjZS9XZWJD
b3JlL2h0bWwvY2FudmFzL1dlYkdMQ29tcHJlc3NlZFRleHR1cmVBU1RDLmNwcAppbmRleCAzMGRj
NDQ5ZTc0MTA1ZGM1MWRhMDk1YmM3NGQ2ODVkOTI5Y2FjNTViLi4xMzJmM2U2MGI3YmE2MzMxYTM5
ZGQ4OGI3NjFiMDJjNTA3YmFlMmM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2Nh
bnZhcy9XZWJHTENvbXByZXNzZWRUZXh0dXJlQVNUQy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv
aHRtbC9jYW52YXMvV2ViR0xDb21wcmVzc2VkVGV4dHVyZUFTVEMuY3BwCkBAIC05NCw5ICs5NCw4
IEBAIFZlY3RvcjxTdHJpbmc+IFdlYkdMQ29tcHJlc3NlZFRleHR1cmVBU1RDOjpnZXRTdXBwb3J0
ZWRQcm9maWxlcygpCiAKIGJvb2wgV2ViR0xDb21wcmVzc2VkVGV4dHVyZUFTVEM6OnN1cHBvcnRl
ZChjb25zdCBXZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNlJiBjb250ZXh0KQogewotICAgIHJldHVy
biBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpzaGFyZWRGZWF0dXJlcygpLndlYkdMQ29tcHJlc3Nl
ZFRleHR1cmVBU1RDU3VwcG9ydEVuYWJsZWQoKQotICAgICAgICAmJiAoY29udGV4dC5ncmFwaGlj
c0NvbnRleHQzRCgpLT5nZXRFeHRlbnNpb25zKCkuc3VwcG9ydHMoIkdMX0tIUl90ZXh0dXJlX2Nv
bXByZXNzaW9uX2FzdGNfaGRyIl9zKQotICAgICAgICB8fCBjb250ZXh0LmdyYXBoaWNzQ29udGV4
dDNEKCktPmdldEV4dGVuc2lvbnMoKS5zdXBwb3J0cygiR0xfS0hSX3RleHR1cmVfY29tcHJlc3Np
b25fYXN0Y19sZHIiX3MpKTsKKyAgICByZXR1cm4gY29udGV4dC5ncmFwaGljc0NvbnRleHQzRCgp
LT5nZXRFeHRlbnNpb25zKCkuc3VwcG9ydHMoIkdMX0tIUl90ZXh0dXJlX2NvbXByZXNzaW9uX2Fz
dGNfaGRyIl9zKQorICAgICAgICB8fCBjb250ZXh0LmdyYXBoaWNzQ29udGV4dDNEKCktPmdldEV4
dGVuc2lvbnMoKS5zdXBwb3J0cygiR0xfS0hSX3RleHR1cmVfY29tcHJlc3Npb25fYXN0Y19sZHIi
X3MpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi
Q29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNlLmNwcCBiL1NvdXJjZS9X
ZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2UuY3BwCmluZGV4IDc3
YTYxMjhkMzFlZThiZTE0MjdlNDZmYjNhMmYyMGY2ZTlmMjg5ZWEuLmU1YmM0Yzk3OTFhZDIyYTEx
OWU2MWYzZmVkNjM2ODZiMjE5OTE4NmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwv
Y2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl
L2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2UuY3BwCkBAIC0zMDkxLDEwICsz
MDkxLDEwIEBAIGJvb2wgV2ViR0xSZW5kZXJpbmdDb250ZXh0QmFzZTo6ZXh0ZW5zaW9uSXNFbmFi
bGVkKGNvbnN0IFN0cmluZyYgbmFtZSkKICAgICBDSEVDS19FWFRFTlNJT04obV93ZWJnbExvc2VD
b250ZXh0LCAiV0VCR0xfbG9zZV9jb250ZXh0Iik7CiAgICAgQ0hFQ0tfRVhURU5TSU9OKG1fd2Vi
Z2xEZWJ1Z1JlbmRlcmVySW5mbywgIldFQkdMX2RlYnVnX3JlbmRlcmVyX2luZm8iKTsKICAgICBD
SEVDS19FWFRFTlNJT04obV93ZWJnbERlYnVnU2hhZGVycywgIldFQkdMX2RlYnVnX3NoYWRlcnMi
KTsKLSAgICBDSEVDS19FWFRFTlNJT04obV93ZWJnbENvbXByZXNzZWRUZXh0dXJlQVNUQywgIldF
QktJVF9XRUJHTF9jb21wcmVzc2VkX3RleHR1cmVfYXN0YyIpOworICAgIENIRUNLX0VYVEVOU0lP
TihtX3dlYmdsQ29tcHJlc3NlZFRleHR1cmVBU1RDLCAiV0VCR0xfY29tcHJlc3NlZF90ZXh0dXJl
X2FzdGMiKTsKICAgICBDSEVDS19FWFRFTlNJT04obV93ZWJnbENvbXByZXNzZWRUZXh0dXJlQVRD
LCAiV0VCS0lUX1dFQkdMX2NvbXByZXNzZWRfdGV4dHVyZV9hdGMiKTsKLSAgICBDSEVDS19FWFRF
TlNJT04obV93ZWJnbENvbXByZXNzZWRUZXh0dXJlRVRDLCAiV0VCS0lUX1dFQkdMX2NvbXByZXNz
ZWRfdGV4dHVyZV9ldGMiKTsKLSAgICBDSEVDS19FWFRFTlNJT04obV93ZWJnbENvbXByZXNzZWRU
ZXh0dXJlRVRDMSwgIldFQktJVF9XRUJHTF9jb21wcmVzc2VkX3RleHR1cmVfZXRjMSIpOworICAg
IENIRUNLX0VYVEVOU0lPTihtX3dlYmdsQ29tcHJlc3NlZFRleHR1cmVFVEMsICJXRUJHTF9jb21w
cmVzc2VkX3RleHR1cmVfZXRjIik7CisgICAgQ0hFQ0tfRVhURU5TSU9OKG1fd2ViZ2xDb21wcmVz
c2VkVGV4dHVyZUVUQzEsICJXRUJHTF9jb21wcmVzc2VkX3RleHR1cmVfZXRjMSIpOwogICAgIENI
RUNLX0VYVEVOU0lPTihtX3dlYmdsQ29tcHJlc3NlZFRleHR1cmVQVlJUQywgIldFQktJVF9XRUJH
TF9jb21wcmVzc2VkX3RleHR1cmVfcHZydGMiKTsKICAgICBDSEVDS19FWFRFTlNJT04obV93ZWJn
bENvbXByZXNzZWRUZXh0dXJlUzNUQywgIldFQkdMX2NvbXByZXNzZWRfdGV4dHVyZV9zM3RjIik7
CiAgICAgQ0hFQ0tfRVhURU5TSU9OKG1fd2ViZ2xEZXB0aFRleHR1cmUsICJXRUJHTF9kZXB0aF90
ZXh0dXJlIik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1J1bnRpbWVFbmFibGVk
RmVhdHVyZXMuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5o
CmluZGV4IDliZTNiYzVkOTY3YjhlOTMzNDU5ZjdkMDhhMmE4Zjc4M2Y1NmRhNmYuLjg1N2JiMTM1
Yzc3NjVhNzM2OWM0NjgyNDU1ODM1ZTEyZjExNThhODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD
b3JlL3BhZ2UvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bh
Z2UvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5oCkBAIC0xNTgsOSArMTU4LDYgQEAgcHVibGljOgog
ICAgIHZvaWQgc2V0Q3Jvc3NPcmlnaW5SZXNvdXJjZVBvbGljeUVuYWJsZWQoYm9vbCBpc0VuYWJs
ZWQpIHsgbV9jcm9zc09yaWdpblJlc291cmNlUG9saWN5RW5hYmxlZCA9IGlzRW5hYmxlZDsgfQog
ICAgIGJvb2wgY3Jvc3NPcmlnaW5SZXNvdXJjZVBvbGljeUVuYWJsZWQoKSBjb25zdCB7IHJldHVy
biBtX2Nyb3NzT3JpZ2luUmVzb3VyY2VQb2xpY3lFbmFibGVkOyB9CiAKLSAgICB2b2lkIHNldFdl
YkdMQ29tcHJlc3NlZFRleHR1cmVBU1RDU3VwcG9ydEVuYWJsZWQoYm9vbCBpc0VuYWJsZWQpIHsg
bV9pc1dlYkdMQ29tcHJlc3NlZFRleHR1cmVBU1RDU3VwcG9ydEVuYWJsZWQgPSBpc0VuYWJsZWQ7
IH0KLSAgICBib29sIHdlYkdMQ29tcHJlc3NlZFRleHR1cmVBU1RDU3VwcG9ydEVuYWJsZWQoKSBj
b25zdCB7IHJldHVybiBtX2lzV2ViR0xDb21wcmVzc2VkVGV4dHVyZUFTVENTdXBwb3J0RW5hYmxl
ZDsgfQotCiAgICAgdm9pZCBzZXRTZXJ2ZXJUaW1pbmdFbmFibGVkKGJvb2wgaXNFbmFibGVkKSB7
IG1faXNTZXJ2ZXJUaW1pbmdFbmFibGVkID0gaXNFbmFibGVkOyB9CiAgICAgYm9vbCBzZXJ2ZXJU
aW1pbmdFbmFibGVkKCkgY29uc3QgeyByZXR1cm4gbV9pc1NlcnZlclRpbWluZ0VuYWJsZWQ7IH0K
IApAQCAtNDI3LDcgKzQyNCw2IEBAIHByaXZhdGU6CiAgICAgYm9vbCBtX2l0cERlYnVnTW9kZSB7
IGZhbHNlIH07CiAgICAgYm9vbCBtX2lzUmVzdHJpY3RlZEhUVFBSZXNwb25zZUFjY2VzcyB7IHRy
dWUgfTsKICAgICBib29sIG1fY3Jvc3NPcmlnaW5SZXNvdXJjZVBvbGljeUVuYWJsZWQgeyB0cnVl
IH07Ci0gICAgYm9vbCBtX2lzV2ViR0xDb21wcmVzc2VkVGV4dHVyZUFTVENTdXBwb3J0RW5hYmxl
ZCB7IGZhbHNlIH07CiAgICAgYm9vbCBtX2lzU2VydmVyVGltaW5nRW5hYmxlZCB7IGZhbHNlIH07
CiAgICAgYm9vbCBtX2V4cGVyaW1lbnRhbFBsdWdJblNhbmRib3hQcm9maWxlc0VuYWJsZWQgeyBm
YWxzZSB9OwogICAgIGJvb2wgbV9kaXNhYmxlZEFkYXB0YXRpb25zTWV0YVRhZ0VuYWJsZWQgeyBm
YWxzZSB9OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMu
eWFtbCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlhbWwKaW5kZXggMzQ0
OGNkYzRkNzE2M2ZlNzI4MzMyYzFkOGE2MWRjOTJhYzU5MTc0NS4uYmZlMzliNzE3MWVmNzk4MmQ1
NmIzNzRiY2E4ODY1Nzk4YjU0ZWU3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9TaGFyZWQv
V2ViUHJlZmVyZW5jZXMueWFtbAorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJl
bmNlcy55YW1sCkBAIC0xNTM2LDE0ICsxNTM2LDYgQEAgTGVnYWN5T3ZlcmZsb3dTY3JvbGxpbmdU
b3VjaEVuYWJsZWQ6CiAgIGNvbmRpdGlvbjogRU5BQkxFKE9WRVJGTE9XX1NDUk9MTElOR19UT1VD
SCkKICAgY2F0ZWdvcnk6IGludGVybmFsCiAKLVdlYkdMQ29tcHJlc3NlZFRleHR1cmVBU1RDU3Vw
cG9ydEVuYWJsZWQ6Ci0gIHR5cGU6IGJvb2wKLSAgZGVmYXVsdFZhbHVlOiBmYWxzZQotICBodW1h
blJlYWRhYmxlTmFtZTogIkFTVEMgVGV4dHVyZSBTdXBwb3J0IgotICBodW1hblJlYWRhYmxlRGVz
Y3JpcHRpb246ICJTdXBwb3J0IGZvciBBU1RDIGNvbXByZXNzZWQgdGV4dHVyZSBmb3JtYXRzIGlu
IFdlYkdMIgotICBjYXRlZ29yeTogaW50ZXJuYWwKLSAgd2ViY29yZUJpbmRpbmc6IFJ1bnRpbWVF
bmFibGVkRmVhdHVyZXMKLQogRnVsbFNjcmVlbkVuYWJsZWQ6CiAgIHR5cGU6IGJvb2wKICAgZGVm
YXVsdFZhbHVlOiBmYWxzZQo=
</data>
<flag name="review"
          id="398931"
          type_id="1"
          status="+"
          setter="dino"
    />
          </attachment>
      

    </bug>

</bugzilla>