202785 2019-10-10 02:42:10 -0700 image/apng not recognized in source tag 2019-10-16 02:02:19 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 202783 1 clopez clopez dino webkit-bug-importer oldest_to_newest 1578571 0 clopez 2019-10-10 02:42:10 -0700 The test imported/w3c/web-platform-tests/apng/supported-in-source-type.html fails on all platform. WPT test: https://w3c-test.org/apng/supported-in-source-type.html The failure is caused because the mime-type image/apng is not recognized for the <source> attribute, even when apng files are supported. 1578573 1 380618 clopez 2019-10-10 02:49:56 -0700 Created attachment 380618 Patch Patch fixing imported/w3c/web-platform-tests/apng/supported-in-source-type.html which needs to be imported first on bug 202783 1579814 2 380618 dino 2019-10-14 14:19:08 -0700 Comment on attachment 380618 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380618&action=review > Source/WebCore/platform/MIMETypeRegistry.cpp:78 > + "image/apng"_s, This is a duplicate of the one below. Why both? And why is one guarded? 1579824 3 380618 dino 2019-10-14 14:22:07 -0700 Comment on attachment 380618 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380618&action=review > Source/WebCore/platform/MIMETypeRegistry.cpp:141 > +#if ENABLE(APNG) > + "image/apng"_s, > +#endif Just leave this one and it's an r+. 1579842 4 380618 dino 2019-10-14 15:06:12 -0700 Comment on attachment 380618 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380618&action=review >> Source/WebCore/platform/MIMETypeRegistry.cpp:78 >> + "image/apng"_s, > > This is a duplicate of the one below. Why both? And why is one guarded? Unless I'm mistaken, this is inside USE(CG) and the one below is in PLATFORM(IOS_FAMILY). But the USE(CG) isn't closed, so it becomes a duplicate. I now think this is the one we should keep, but add the APNG guard. 1579846 5 380618 dino 2019-10-14 15:18:27 -0700 Comment on attachment 380618 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380618&action=review >> Source/WebCore/platform/MIMETypeRegistry.cpp:141 >> +#endif > > Just leave this one and it's an r+. Oh gosh. Ignore me. This is outside USE(CG) - I just didn't read the patch properly. 1579860 6 380618 clopez 2019-10-14 15:38:24 -0700 Comment on attachment 380618 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380618&action=review >>> Source/WebCore/platform/MIMETypeRegistry.cpp:141 >>> +#endif >> >> Just leave this one and it's an r+. > > Oh gosh. Ignore me. This is outside USE(CG) - I just didn't read the patch properly. Right. There are two main code-paths: USE(CG) that affects Mac/iOS and everything else. ENABLE(APNG) Only makes sense for everything else, because AFAIK on Mac/iOS the support for it depends on CoreGraphics (which I believe it supports it). It happens more or less like with the suport for JPEG2000. For GTK/WPE we have a build-time guard USE(OPENJPEG), but for Mac/iOS that guard isn't used. BTW, if you can review also bug 202783 that would be very nice, that way I can land this after first landing the test that this is supposed to fix. Thanks! 1580338 7 381033 clopez 2019-10-15 15:42:28 -0700 Created attachment 381033 Patch Patch for landing: Test EWS first 1580491 8 clopez 2019-10-16 02:01:03 -0700 Committed r251182: <https://trac.webkit.org/changeset/251182> 1580493 9 webkit-bug-importer 2019-10-16 02:02:19 -0700 <rdar://problem/56324500> 380618 2019-10-10 02:49:56 -0700 2019-10-15 15:42:25 -0700 Patch bug-202785-20191010114951.patch text/plain 1861 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwOTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDc0ZmVmYjcxM2JmNmJj ZjRjNzQxNTdkY2MyYmQ1MTg3NjljMDkzOS4uZTAzM2VmZDAxNDk5MTg1MWYxZGY5YjA1ZjM4Y2I5 M2E0NjViMGMxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTEwLTEwICBDYXJs b3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIGlt YWdlL2Fwbmcgbm90IHJlY29nbml6ZWQgaW4gc291cmNlIHRhZworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAyNzg1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGltYWdlL2FwbmcgYXMgc3VwcG9ydGVk IG1pbWUgdHlwZSBmb3IgaW1hZ2VzIG9uIE1hYy9pT1MgYW5kCisgICAgICAgIG9uIGFsbCB0aGUg b3RoZXIgcGxhdGZvcm1zIHRoYXQgZW5hYmxlIGFwbmcgc3VwcG9ydC4KKworICAgICAgICBUaGlz IGZpeGVzIHRoZSB0ZXN0IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvYXBuZy9zdXBw b3J0ZWQtaW4tc291cmNlLXR5cGUuaHRtbAorICAgICAgICAoc2VlIGJ1ZyAyMDI3ODMpCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9NSU1FVHlwZVJlZ2lzdHJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 Ok1JTUVUeXBlUmVnaXN0cnk6OnN1cHBvcnRlZEltYWdlTUlNRVR5cGVzKToKKwogMjAxOS0xMC0x MCAgeW91ZW5uIGZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGFzc2Vy dHMgdG8gTWVkaWFTdHJlYW1Qcml2YXRlIG9ic2VydmVyIHJvdXRpbmVzCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9NSU1FVHlwZVJlZ2lzdHJ5LmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL01JTUVUeXBlUmVnaXN0cnkuY3BwCmluZGV4IDBhMWM5MzZiZTllYjFkZWIz ODU3YmZiMDBmMjBlNjdlODE3ODJhOTIuLjIxOTA3ODQ1ZjU3MTZkMzhiOWI1MWZhZGQyY2RjNzlk ZWJiMmIwOTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL01JTUVUeXBlUmVn aXN0cnkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL01JTUVUeXBlUmVnaXN0cnku Y3BwCkBAIC03NSw2ICs3NSw3IEBAIGNvbnN0IEhhc2hTZXQ8U3RyaW5nLCBBU0NJSUNhc2VJbnNl bnNpdGl2ZUhhc2g+JiBNSU1FVHlwZVJlZ2lzdHJ5OjpzdXBwb3J0ZWRJbWFnCiAgICAgICAgICJp bWFnZS9qcGVnIl9zLAogICAgICAgICAiaW1hZ2Uvdm5kLm1pY3Jvc29mdC5pY29uIl9zLAogICAg ICAgICAiaW1hZ2UvanAyIl9zLAorICAgICAgICAiaW1hZ2UvYXBuZyJfcywKICAgICAgICAgImlt YWdlL3BuZyJfcywKICAgICAgICAgImltYWdlL2JtcCJfcywKIApAQCAtMTM1LDYgKzEzNiw5IEBA IGNvbnN0IEhhc2hTZXQ8U3RyaW5nLCBBU0NJSUNhc2VJbnNlbnNpdGl2ZUhhc2g+JiBNSU1FVHlw ZVJlZ2lzdHJ5OjpzdXBwb3J0ZWRJbWFnCiAgICAgICAgICJpbWFnZS92bmQubWljcm9zb2Z0Lmlj b24iX3MsIC8vIGljbwogICAgICAgICAiaW1hZ2UveC1pY29uIl9zLCAvLyBpY28KICAgICAgICAg ImltYWdlL3gteGJpdG1hcCJfcywgLy8geGJtCisjaWYgRU5BQkxFKEFQTkcpCisgICAgICAgICJp bWFnZS9hcG5nIl9zLAorI2VuZGlmCiAjaWYgVVNFKE9QRU5KUEVHKQogICAgICAgICAiaW1hZ2Uv anAyIl9zLAogICAgICAgICAiaW1hZ2UvanBlZzIwMDAiX3MsCg== 381033 2019-10-15 15:42:28 -0700 2019-10-15 15:42:28 -0700 Patch bug-202785-20191016004223.patch text/plain 3413 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxMTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjExNjZiNzE5OTc4YzQ1 NjQ1OWNhNjA5ZjI2YzM3YzE2YWE0ZDVhNS4uN2Y5ZjVjYWM2NThjN2JiYjM4M2Y5ZDA3MDRmYWU2 NjA3ZTc5OWNiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTEwLTE1ICBDYXJs b3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIGlt YWdlL2Fwbmcgbm90IHJlY29nbml6ZWQgaW4gc291cmNlIHRhZworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAyNzg1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgRGVhbiBKYWNrc29uLgorCisgICAgICAgIEFkZCBpbWFnZS9hcG5nIGFzIHN1cHBvcnRlZCBt aW1lIHR5cGUgZm9yIGltYWdlcyBvbiBNYWMvaU9TIGFuZAorICAgICAgICBvbiBhbGwgdGhlIG90 aGVyIHBsYXRmb3JtcyB0aGF0IGVuYWJsZSBhcG5nIHN1cHBvcnQuCisKKyAgICAgICAgVGhpcyBm aXhlcyB0aGUgdGVzdCBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Fwbmcvc3VwcG9y dGVkLWluLXNvdXJjZS10eXBlLmh0bWwKKworICAgICAgICAqIHBsYXRmb3JtL01JTUVUeXBlUmVn aXN0cnkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TUlNRVR5cGVSZWdpc3RyeTo6c3VwcG9ydGVk SW1hZ2VNSU1FVHlwZXMpOgorCiAyMDE5LTEwLTE1ICBQZW5nIExpdSAgPHBlbmcubGl1NkBhcHBs ZS5jb20+CiAKICAgICAgICAgW1BpY3R1cmUtaW4tUGljdHVyZSBXZWIgQVBJXSBJbXBsZW1lbnQg SFRNTFZpZGVvRWxlbWVudC5yZXF1ZXN0UGljdHVyZUluUGljdHVyZSgpIC8gRG9jdW1lbnQuZXhp dFBpY3R1cmVJblBpY3R1cmUoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v TUlNRVR5cGVSZWdpc3RyeS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9NSU1FVHlwZVJl Z2lzdHJ5LmNwcAppbmRleCAwYTFjOTM2YmU5ZWIxZGViMzg1N2JmYjAwZjIwZTY3ZTgxNzgyYTky Li4yMTkwNzg0NWY1NzE2ZDM4YjliNTFmYWRkMmNkYzc5ZGViYjJiMDkyIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9NSU1FVHlwZVJlZ2lzdHJ5LmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9NSU1FVHlwZVJlZ2lzdHJ5LmNwcApAQCAtNzUsNiArNzUsNyBAQCBj b25zdCBIYXNoU2V0PFN0cmluZywgQVNDSUlDYXNlSW5zZW5zaXRpdmVIYXNoPiYgTUlNRVR5cGVS ZWdpc3RyeTo6c3VwcG9ydGVkSW1hZwogICAgICAgICAiaW1hZ2UvanBlZyJfcywKICAgICAgICAg ImltYWdlL3ZuZC5taWNyb3NvZnQuaWNvbiJfcywKICAgICAgICAgImltYWdlL2pwMiJfcywKKyAg ICAgICAgImltYWdlL2FwbmciX3MsCiAgICAgICAgICJpbWFnZS9wbmciX3MsCiAgICAgICAgICJp bWFnZS9ibXAiX3MsCiAKQEAgLTEzNSw2ICsxMzYsOSBAQCBjb25zdCBIYXNoU2V0PFN0cmluZywg QVNDSUlDYXNlSW5zZW5zaXRpdmVIYXNoPiYgTUlNRVR5cGVSZWdpc3RyeTo6c3VwcG9ydGVkSW1h ZwogICAgICAgICAiaW1hZ2Uvdm5kLm1pY3Jvc29mdC5pY29uIl9zLCAvLyBpY28KICAgICAgICAg ImltYWdlL3gtaWNvbiJfcywgLy8gaWNvCiAgICAgICAgICJpbWFnZS94LXhiaXRtYXAiX3MsIC8v IHhibQorI2lmIEVOQUJMRShBUE5HKQorICAgICAgICAiaW1hZ2UvYXBuZyJfcywKKyNlbmRpZgog I2lmIFVTRShPUEVOSlBFRykKICAgICAgICAgImltYWdlL2pwMiJfcywKICAgICAgICAgImltYWdl L2pwZWcyMDAwIl9zLApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDYwYzYxNjBmYmI5OGIzNTcyM2VlNzgyNmVkMmU3YjY4ZDA0 NjJhNjcuLmJiMTBjOTIzNmNiY2IyMjU0NWNjYWU0M2E0YTIxNDBlNmI2MWM5MTAgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxMyBAQAorMjAxOS0xMC0xNSAgQ2FybG9zIEFsYmVydG8gTG9wZXogUGVyZXogIDxj bG9wZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBpbWFnZS9hcG5nIG5vdCByZWNvZ25pemVkIGlu IHNvdXJjZSB0YWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIwMjc4NQorCisgICAgICAgIFJldmlld2VkIGJ5IERlYW4gSmFja3Nvbi4KKworICAgICAg ICAqIFRlc3RFeHBlY3RhdGlvbnM6IFJlbW92ZSB0ZXN0IGltcG9ydGVkL3czYy93ZWItcGxhdGZv cm0tdGVzdHMvYXBuZy9zdXBwb3J0ZWQtaW4tc291cmNlLXR5cGUuaHRtbAorICAgICAgICBmcm9t IHRoZSBsaXN0IG9mIGV4cGVjdGVkIGZhaWx1cmVzLgorCiAyMDE5LTEwLTE1ICBDYXJsb3MgQWxi ZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIEltcG9ydCBh cG5nIHRlc3RjYXNlcyBmcm9tIFdQVC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL1Rlc3RFeHBl Y3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDNlODY2NzMwMDA3 N2JkNWU2NmMzZmZjNzAyNjJhODliODBlZjBlZTIuLmNjMmJiYjIyZjExMmEyOTZiZWI5YmExMzMz NTIyMzYxZDIyYjUzNjUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMK KysrIGIvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMzg4Miw1ICszODgyLDMgQEAg d2Via2l0Lm9yZy9iLzIwMDIwNyBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9j c3MtaW1hZ2VzL2Nzcy1pbWFnZS1mYWwKIHdlYmtpdC5vcmcvYi8yMDAyMDggaW1wb3J0ZWQvdzNj L3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWltYWdlcy9ncmFkaWVudHMtd2l0aC10cmFuc3Bh cmVudC5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMjAwMjA5IGltcG9y dGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1pbWFnZXMvbXVsdGlwbGUtcG9zaXRp b24tY29sb3Itc3RvcC1yYWRpYWwuaHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQogd2Via2l0Lm9y Zy9iLzIwMjgxMyBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtaW1hZ2Vz L211bHRpcGxlLXBvc2l0aW9uLWNvbG9yLXN0b3AtY29uaWMuaHRtbCBbIEltYWdlT25seUZhaWx1 cmUgXQotCi13ZWJraXQub3JnL2IvMjAyNzg1IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVz dHMvYXBuZy9zdXBwb3J0ZWQtaW4tc291cmNlLXR5cGUuaHRtbCBbIEZhaWx1cmUgXQo=