202722 2019-10-09 00:31:48 -0700 [Win] error LNK2019: unresolved external symbol "public: __cdecl JSC::Strong<enum JSC::Unknown>::Strong<enum JSC::Unknown>(class JSC::VM &,class JSC::JSValue)" 2019-10-09 02:43:17 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1578099 0 fujii 2019-10-09 00:31:48 -0700 [Win] error LNK2019: unresolved external symbol "public: __cdecl JSC::Strong<enum JSC::Unknown>::Strong<enum JSC::Unknown>(class JSC::VM &,class JSC::JSValue)" I'm observing the following linkage error by building release builds of WinCairo port with clang-cl. r250776 WebCore.lib(UnifiedSource-3a52ce78-61.cpp.obj) : error LNK2019: unresolved external symbol "public: __cdecl JSC::Strong<enum JSC::Unknown>::Strong<enum JSC::Unknown>(class JSC::VM &,class JSC::JSValue)" (??0?$Strong@W4Unknown@JSC@@@JSC@@QEAA@AEAVVM@1@VJSValue@1@@Z) referenced in function "public: static class WTF::Optional<class JSC::Strong<enum JSC::Unknown> > __cdecl WebCore::VariadicConverter<struct WebCore::IDLAny>::convert(class JSC::CallFrame &,class JSC::JSValue)" (?convert@?$VariadicConverter@UIDLAny@WebCore@@@WebCore@@SA?AV?$Optional@V?$Strong@W4Unknown@JSC@@@JSC@@@WTF@@AEAVCallFrame@JSC@@VJSValue@6@@Z) bin64\WebKit.dll : fatal error LNK1120: 1 unresolved externals 1578100 1 fujii 2019-10-09 00:32:20 -0700 This is a similar issue with Bug 193481. Bug 193481 – Add 'inline' specifier for declarations for its definitions are defined in separate headers (…Inlines.h) 1578101 2 fujii 2019-10-09 00:33:05 -0700 Here is the content of Release/WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-61.cpp #include "JSOESTextureFloatLinear.cpp" #include "JSOESTextureHalfFloat.cpp" #include "JSOESTextureHalfFloatLinear.cpp" #include "JSOESVertexArrayObject.cpp" #include "JSOfflineAudioCompletionEvent.cpp" #include "JSOfflineAudioContext.cpp" #include "JSOffscreenCanvas.cpp" #include "JSOffscreenCanvasRenderingContext2D.cpp" 1578103 3 fujii 2019-10-09 00:33:59 -0700 WebCore::VariadicConverter<struct WebCore::IDLAny>::convert is referred from JSOffscreenCanvasOwner::finalize ?finalize@JSOffscreenCanvasOwner@WebCore@@UEAAXV?$Handle@W4Unknown@JSC@@@JSC@@PEAX@Z (public: virtual void __cdecl WebCore::JSOffscreenCanvasOwner::finalize(class JSC::Handle<enum JSC::Unknown>,void *)): 0000000000000000: 56 push rsi 0000000000000001: 48 83 EC 30 sub rsp,30h 0000000000000005: 48 8B 05 00 00 00 mov rax,qword ptr [__security_cookie] 00 000000000000000C: 48 31 E0 xor rax,rsp 000000000000000F: 48 89 44 24 28 mov qword ptr [rsp+28h],rax 0000000000000014: 48 8B 02 mov rax,qword ptr [rdx] 0000000000000017: 48 8B 70 18 mov rsi,qword ptr [rax+18h] 000000000000001B: 41 80 78 40 00 cmp byte ptr [r8+40h],0 0000000000000020: 74 27 je 0000000000000049 0000000000000022: 48 83 7E 08 00 cmp qword ptr [rsi+8],0 0000000000000027: 74 3D je 0000000000000066 0000000000000029: 48 83 C6 08 add rsi,8 000000000000002D: 48 8B 4C 24 28 mov rcx,qword ptr [rsp+28h] 0000000000000032: 48 31 E1 xor rcx,rsp 0000000000000035: E8 00 00 00 00 call __security_check_cookie 000000000000003A: 48 89 F1 mov rcx,rsi 000000000000003D: 48 83 C4 30 add rsp,30h 0000000000000041: 5E pop rsi 0000000000000042: 48 FF 25 00 00 00 jmp qword ptr [__imp_?weakClearSlowCase@JSC@@YAXAEAPEAVWeakImpl@1@@Z] 00 0000000000000049: 48 83 C6 D0 add rsi,0FFFFFFFFFFFFFFD0h 000000000000004D: 48 89 74 24 20 mov qword ptr [rsp+20h],rsi 0000000000000052: 49 83 C0 28 add r8,28h 0000000000000056: 48 8D 54 24 20 lea rdx,[rsp+20h] 000000000000005B: 4C 89 C1 mov rcx,r8 000000000000005E: 49 89 C0 mov r8,rax 0000000000000061: E8 00 00 00 00 call ??$weakRemove@V?$HashMap@PEAXV?$Weak@VJSObject@JSC@@@JSC@@U?$PtrHash@PEAX@WTF@@U?$HashTraits@PEAX@4@U?$HashTraits@V?$Weak@VJSObject@JSC@@@JSC@@@4@@WTF@@PEAXPEAVJSOffscreenCanvas@WebCore@@@JSC@@YAXAEAV?$HashMap@PEAXV?$Weak@VJSObject@JSC@@@JSC@@U?$PtrHash@PEAX@WTF@@U?$HashTraits@PEAX@4@U?$HashTraits@V?$Weak@VJSObject@JSC@@@JSC@@@4@@WTF@@AEBQEAXPEAVJSOffscreenCanvas@WebCore@@@Z 0000000000000066: 48 8B 4C 24 28 mov rcx,qword ptr [rsp+28h] 000000000000006B: 48 31 E1 xor rcx,rsp 000000000000006E: E8 00 00 00 00 call __security_check_cookie 0000000000000073: 90 nop 0000000000000074: 48 83 C4 30 add rsp,30h 0000000000000078: 5E pop rsi 0000000000000079: C3 ret 1578108 4 fujii 2019-10-09 00:47:02 -0700 JSOffscreenCanvas.cpp has #include <JavaScriptCore/JSCInlines.h>, but JSCInlines.h doesn't include StrongInlines.h. 1578113 5 380506 fujii 2019-10-09 00:54:47 -0700 Created attachment 380506 Patch for landing 1578114 6 380507 fujii 2019-10-09 01:01:29 -0700 Created attachment 380507 Patch for landing 1578166 7 380507 fujii 2019-10-09 02:42:44 -0700 Comment on attachment 380507 Patch for landing Clearing flags on attachment: 380507 Committed r250907: <https://trac.webkit.org/changeset/250907> 1578167 8 fujii 2019-10-09 02:42:48 -0700 All reviewed patches have been landed. Closing bug. 1578168 9 webkit-bug-importer 2019-10-09 02:43:17 -0700 <rdar://problem/56110031> 380506 2019-10-09 00:54:47 -0700 2019-10-09 00:59:47 -0700 Patch for landing bug-202722-20191009165446.patch text/plain 4077 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwODc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 NTgzMzMwZTgyNWM4OTViOWU2NDgxNjc0ZmY4OTkzNzY3NjI5N2ZlLi43ZGI0NTM4OTc4MzEyZGUz OTcwMzY5ZTdkMTcyNDEzYWFhNDFiODg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxOS0xMC0wOSAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBz b255LmNvbT4KKworICAgICAgICBbV2luXSBlcnJvciBMTksyMDE5OiB1bnJlc29sdmVkIGV4dGVy bmFsIHN5bWJvbCAicHVibGljOiBfX2NkZWNsIEpTQzo6U3Ryb25nPGVudW0gSlNDOjpVbmtub3du Pjo6U3Ryb25nPGVudW0gSlNDOjpVbmtub3duPihjbGFzcyBKU0M6OlZNICYsY2xhc3MgSlNDOjpK U1ZhbHVlKSIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIwMjcyMgorCisgICAgICAgIFVucmV2aWV3ZWQgZmxha3kgYnVpbGQgZml4IGZvciBXaW5kb3dz IHBvcnRzLgorCisgICAgICAgIEpTQzo6U3Ryb25nIGlzIHVzZWQgd2l0aG91dCBpbmNsdWRpbmcg IlN0cm9uZ0lubGluZXMuaCIuCisKKyAgICAgICAgKiBydW50aW1lL0pTQ0lubGluZXMuaDogQWRk ZWQgI2luY2x1ZGUgIlN0cm9uZ0lubGluZXMuaCIuCisKIDIwMTktMTAtMDggIFl1c3VrZSBTdXp1 a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlNDXSBHZXR0ZXJTZXR0ZXIgc2hv dWxkIGJlIEpTQ2VsbCwgbm90IEpTT2JqZWN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc1NTQ4NGYyY2Y3MGY3ZDE2 ZTdmM2Q0NGQwZGQxMGJmMzBhZjRlNTguLmYwNGViYWM5OGQwMGVkMmI3MWU0M2UzYWRiOWJiYTVh MjJhZGY4ZWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xNjQ0LDYgKzE2NDQsMjMgQEAKIAogICAgICAgICAqIFVJ UHJvY2Vzcy9BUEkvQ29jb2EvX1dLVGh1bWJuYWlsVmlldy5tbToKIAorMjAxOS0xMC0wMyAgRnVq aWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBzb255LmNvbT4KKworICAgICAgICBbV2luXVtX ZWJLaXQyXSBDYW4ndCBwcmV2ZW50IGlucHV0IGV2ZW50cyBieSBjYW5jZWxpbmcga2V5ZG93biBl dmVudHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw MDU1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElm IGEga2V5ZG93biBldmVudCBpcyBoYW5kbGVkLCB0aGUga2V5cHJlc3MgZXZlbnQgc2hvdWxkbid0 IGJlCisgICAgICAgIGRpc3BhdGNoZWQuCisKKyAgICAgICAgVGVzdGVkIGJ5IGZhc3QvZXZlbnRz L2lucHV0VGV4dC1uZXZlci1maXJlZC1vbi1rZXlkb3duLWNhbmNlbC5odG1sCisgICAgICAgIGFu ZCBmYXN0L2V2ZW50cy9rZXlkb3duLWtleXByZXNzLXByZXZlbnREZWZhdWx0Lmh0bWwuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vi UGFnZVByb3h5OjpkaWRSZWNlaXZlRXZlbnQpOiBSZW1vdmUgcXVldWVkCisgICAgICAgIFdlYkV2 ZW50OjpDaGFyIGFuZCBXTV9DSEFSIGV2ZW50cyBpZiBXZWJFdmVudDo6UmF3S2V5RG93biBpcyBo YW5kbGVkLgorCiAyMDE5LTEwLTAxICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdl YmtpdC5vcmc+CiAKICAgICAgICAgUHJvZ3Jlc3MgdG93YXJkcyBhIGZ1bmN0aW9uaW5nIENNYWtl IGJ1aWxkIG9uIE1hYwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv SlNDSW5saW5lcy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNDSW5saW5lcy5o CmluZGV4IDcwMzMwY2E0OGY4NDM2NzZkZjgzODBjYTBmMTliODRlNTRkYWM5MDguLmVlMGMyZGZh ODA3YWM1YzAzODcwNzU4ZGYwMmVjODVjMTFhZGM3ZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL0pTQ0lubGluZXMuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9KU0NJbmxpbmVzLmgKQEAgLTUwLDYgKzUwLDcgQEAKICNpbmNsdWRlICJKU1N0 cmluZy5oIgogI2luY2x1ZGUgIk9wZXJhdGlvbnMuaCIKICNpbmNsdWRlICJTbG90VmlzaXRvcklu bGluZXMuaCIKKyNpbmNsdWRlICJTdHJvbmdJbmxpbmVzLmgiCiAjaW5jbHVkZSAiU3RydWN0dXJl SW5saW5lcy5oIgogI2luY2x1ZGUgIlRocm93U2NvcGUuaCIKICNpbmNsdWRlICJXZWFrR0NNYXBJ bmxpbmVzLmgiCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJv eHkuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAppbmRleCA4 NzgyMGQzM2FjZDIzZTgxZDhjNzMzZTEwMWZjZTg5YmQ1MjFhOTM3Li45YjQyYzlmODBlYzFlMTcx OTk3MmJhNjMxNTkxNWUwOTZjODk3NjQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9XZWJQYWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBh Z2VQcm94eS5jcHAKQEAgLTY0NzksNiArNjQ3OSwyMiBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6ZGlk UmVjZWl2ZUV2ZW50KHVpbnQzMl90IG9wYXF1ZVR5cGUsIGJvb2wgaGFuZGxlZCkKIAogICAgICAg ICBNRVNTQUdFX0NIRUNLKG1fcHJvY2VzcywgdHlwZSA9PSBldmVudC50eXBlKCkpOwogCisjaWYg UExBVEZPUk0oV0lOKQorICAgICAgICAvLyBmb2xsb3dpbmcga2V5cHJlc3MgZXZlbnRzIHNob3Vs ZCBiZSBjYW5jZWxlZCBpZiBhIGtleWRvd24gZXZlbnQgaXMgaGFuZGxlZAorICAgICAgICBpZiAo dHlwZSA9PSBXZWJFdmVudDo6UmF3S2V5RG93biAmJiBoYW5kbGVkKSB7CisgICAgICAgICAgICBp ZiAobV9rZXlFdmVudFF1ZXVlLmlzRW1wdHkoKSkgeworICAgICAgICAgICAgICAgIE1TRyBtc2c7 CisgICAgICAgICAgICAgICAgLy8gSW4gV2ViS2l0VGVzdFJ1bm5lciwgZGlkUmVjZWl2ZUV2ZW50 IGlzIGNhbGxlZCBpbW1lZGlhdGVseSBiZWNhdXNlIGl0IHByb2Nlc3NlcyBJUEMgbWVzc2FnZXMg c3luY2hyb25vdXNseS4KKyAgICAgICAgICAgICAgICAvLyBXTV9DSEFSIGV2ZW50cyBhcmUgbm90 IHF1ZXVlZCBpbiBtX2tleUV2ZW50UXVldWUgeWV0LiBSZW1vdmUgV01fQ0hBUiBtZXNzYWdlIGJ5 IHVzaW5nIFBlZWtNZXNzYWdlLgorICAgICAgICAgICAgICAgIC8vIFdNX1NZU0NIQVIgZXZlbnRz IHNob3VsZCBub3QgYmUgcmVtb3ZlZCwgYmVjYXVzZSBhY2Nlc3Mga2V5cyBhcmUgaW1wbGVtZW50 ZWQgaW4gV2ViQ29yZSBpbiBXTV9TWVNDSEFSIGhhbmRsZXIuCisgICAgICAgICAgICAgICAgaWYg KGV2ZW50Lm5hdGl2ZUV2ZW50KCktPm1lc3NhZ2UgPT0gV01fS0VZRE9XTikKKyAgICAgICAgICAg ICAgICAgICAgUGVla01lc3NhZ2UoJm1zZywgZXZlbnQubmF0aXZlRXZlbnQoKS0+aHduZCwgV01f Q0hBUiwgV01fQ0hBUiwgUE1fUkVNT1ZFKTsKKyAgICAgICAgICAgIH0gZWxzZSB7CisgICAgICAg ICAgICAgICAgd2hpbGUgKCFtX2tleUV2ZW50UXVldWUuaXNFbXB0eSgpICYmIG1fa2V5RXZlbnRR dWV1ZS5maXJzdCgpLnR5cGUoKSA9PSBXZWJFdmVudDo6Q2hhcikKKyAgICAgICAgICAgICAgICAg ICAgbV9rZXlFdmVudFF1ZXVlLnJlbW92ZUZpcnN0KCk7CisgICAgICAgICAgICB9CisgICAgICAg IH0KKyNlbmRpZgogICAgICAgICBib29sIGNhblByb2Nlc3NNb3JlS2V5RXZlbnRzID0gIW1fa2V5 RXZlbnRRdWV1ZS5pc0VtcHR5KCk7CiAgICAgICAgIGlmIChjYW5Qcm9jZXNzTW9yZUtleUV2ZW50 cykgewogICAgICAgICAgICAgTE9HKEtleUhhbmRsaW5nLCAiIFVJIHByb2Nlc3M6IHNlbnQga2V5 RXZlbnQgZnJvbSBkaWRSZWNlaXZlRXZlbnQiKTsK 380507 2019-10-09 01:01:29 -0700 2019-10-09 01:01:29 -0700 Patch for landing bug-202722-20191009170127.patch text/plain 1392 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwODc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 NTgzMzMwZTgyNWM4OTViOWU2NDgxNjc0ZmY4OTkzNzY3NjI5N2ZlLi43ZGI0NTM4OTc4MzEyZGUz OTcwMzY5ZTdkMTcyNDEzYWFhNDFiODg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxOS0xMC0wOSAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBz b255LmNvbT4KKworICAgICAgICBbV2luXSBlcnJvciBMTksyMDE5OiB1bnJlc29sdmVkIGV4dGVy bmFsIHN5bWJvbCAicHVibGljOiBfX2NkZWNsIEpTQzo6U3Ryb25nPGVudW0gSlNDOjpVbmtub3du Pjo6U3Ryb25nPGVudW0gSlNDOjpVbmtub3duPihjbGFzcyBKU0M6OlZNICYsY2xhc3MgSlNDOjpK U1ZhbHVlKSIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIwMjcyMgorCisgICAgICAgIFVucmV2aWV3ZWQgZmxha3kgYnVpbGQgZml4IGZvciBXaW5kb3dz IHBvcnRzLgorCisgICAgICAgIEpTQzo6U3Ryb25nIGlzIHVzZWQgd2l0aG91dCBpbmNsdWRpbmcg IlN0cm9uZ0lubGluZXMuaCIuCisKKyAgICAgICAgKiBydW50aW1lL0pTQ0lubGluZXMuaDogQWRk ZWQgI2luY2x1ZGUgIlN0cm9uZ0lubGluZXMuaCIuCisKIDIwMTktMTAtMDggIFl1c3VrZSBTdXp1 a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlNDXSBHZXR0ZXJTZXR0ZXIgc2hv dWxkIGJlIEpTQ2VsbCwgbm90IEpTT2JqZWN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9KU0NJbmxpbmVzLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9KU0NJbmxpbmVzLmgKaW5kZXggNzAzMzBjYTQ4Zjg0MzY3NmRmODM4MGNhMGYxOWI4NGU1NGRh YzkwOC4uZWUwYzJkZmE4MDdhYzVjMDM4NzA3NThkZjAyZWM4NWMxMWFkYzdkYyAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNDSW5saW5lcy5oCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQ0lubGluZXMuaApAQCAtNTAsNiArNTAsNyBAQAog I2luY2x1ZGUgIkpTU3RyaW5nLmgiCiAjaW5jbHVkZSAiT3BlcmF0aW9ucy5oIgogI2luY2x1ZGUg IlNsb3RWaXNpdG9ySW5saW5lcy5oIgorI2luY2x1ZGUgIlN0cm9uZ0lubGluZXMuaCIKICNpbmNs dWRlICJTdHJ1Y3R1cmVJbmxpbmVzLmgiCiAjaW5jbHVkZSAiVGhyb3dTY29wZS5oIgogI2luY2x1 ZGUgIldlYWtHQ01hcElubGluZXMuaCIK