202594 2019-10-04 12:32:17 -0700 REGRESSION(r250540): GitLab CI status is broken 2019-10-14 23:10:19 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build PC Linux RESOLVED DUPLICATE 202827 InRadar P2 Normal --- 201994 1 mcatanzaro webkit-unassigned bugs-noreply cgarcia clopez mcatanzaro saam webkit-bug-importer ysuzuki oldest_to_newest 1576955 0 mcatanzaro 2019-10-04 12:32:17 -0700 Since 2.27.1, GitLab CI status pages (e.g. https://gitlab.gnome.org/GNOME/gnome-boxes/-/jobs/455823) are broken. The terminal window does not appear at all. 1577069 1 mcatanzaro 2019-10-04 16:36:25 -0700 This broke in r250540: "Inline caching is wrong for custom accessors and custom values" 1577272 2 webkit-bug-importer 2019-10-06 17:40:41 -0700 <rdar://problem/56022868> 1578155 3 cgarcia 2019-10-09 02:12:46 -0700 I can't reproduce it in mac. With GTK port I get an error in the js console: [Error] TypeError: o is not a function. (In 'o(!1)', 'o' is an instance of Object) (anonymous function) (main.f8ac0dda.chunk.js:130:201836) c (runtime.15f5b13a.bundle.js:1:523) (anonymous function) (main.f8ac0dda.chunk.js:130:110589) c (runtime.15f5b13a.bundle.js:1:523) (anonymous function) (main.f8ac0dda.chunk.js:136:126956) c (runtime.15f5b13a.bundle.js:1:523) (anonymous function) (main.f8ac0dda.chunk.js:130:201645) c (runtime.15f5b13a.bundle.js:1:523) (anonymous function) (main.f8ac0dda.chunk.js:93:7337) c (runtime.15f5b13a.bundle.js:1:523) (anonymous function) (main.f8ac0dda.chunk.js:136:126850) c (runtime.15f5b13a.bundle.js:1:523) (anonymous function) (main.f8ac0dda.chunk.js:136:126778) c (runtime.15f5b13a.bundle.js:1:523) (anonymous function) (main.f8ac0dda.chunk.js:156:115284) c (runtime.15f5b13a.bundle.js:1:523) (anonymous function) (main.f8ac0dda.chunk.js:58:15103) (anonymous function) (main.f8ac0dda.chunk.js:58:19612) c (runtime.15f5b13a.bundle.js:1:523) (anonymous function) (pages.projects.merge_requests.show.bc041ae3.chunk.js:1:167621) c (runtime.15f5b13a.bundle.js:1:523) t (runtime.15f5b13a.bundle.js:1:389) r (runtime.15f5b13a.bundle.js:1:252) Global Code (pages.projects.merge_requests.show.bc041ae3.chunk.js:1) 1578158 4 cgarcia 2019-10-09 02:14:22 -0700 (In reply to Carlos Garcia Campos from comment #3) > I can't reproduce it in mac. With GTK port I get an error in the js console: > > [Error] TypeError: o is not a function. (In 'o(!1)', 'o' is an instance of > Object) > (anonymous function) (main.f8ac0dda.chunk.js:130:201836) > c (runtime.15f5b13a.bundle.js:1:523) > (anonymous function) (main.f8ac0dda.chunk.js:130:110589) > c (runtime.15f5b13a.bundle.js:1:523) > (anonymous function) (main.f8ac0dda.chunk.js:136:126956) > c (runtime.15f5b13a.bundle.js:1:523) > (anonymous function) (main.f8ac0dda.chunk.js:130:201645) > c (runtime.15f5b13a.bundle.js:1:523) > (anonymous function) (main.f8ac0dda.chunk.js:93:7337) > c (runtime.15f5b13a.bundle.js:1:523) > (anonymous function) (main.f8ac0dda.chunk.js:136:126850) > c (runtime.15f5b13a.bundle.js:1:523) > (anonymous function) (main.f8ac0dda.chunk.js:136:126778) > c (runtime.15f5b13a.bundle.js:1:523) > (anonymous function) (main.f8ac0dda.chunk.js:156:115284) > c (runtime.15f5b13a.bundle.js:1:523) > (anonymous function) (main.f8ac0dda.chunk.js:58:15103) > (anonymous function) (main.f8ac0dda.chunk.js:58:19612) > c (runtime.15f5b13a.bundle.js:1:523) > (anonymous function) > (pages.projects.merge_requests.show.bc041ae3.chunk.js:1:167621) > c (runtime.15f5b13a.bundle.js:1:523) > t (runtime.15f5b13a.bundle.js:1:389) > r (runtime.15f5b13a.bundle.js:1:252) > Global Code (pages.projects.merge_requests.show.bc041ae3.chunk.js:1) This is not CI status page is just a normal merge request page, the comments are never loaded. 1579578 5 cgarcia 2019-10-14 03:14:19 -0700 I've noticed that reloading the page sometimes fixes the issue, so it seems to be a race condition. Is there anything else I can do to help to fix this (with my limited jsc knowledge)? 1579618 6 mcatanzaro 2019-10-14 06:46:53 -0700 Rollout...? 1579635 7 saam 2019-10-14 08:32:31 -0700 I have a fix in: https://bugs.webkit.org/show_bug.cgi?id=202827 That I will land today. Please confirm it fixes your bug 1579700 8 mcatanzaro 2019-10-14 11:00:37 -0700 Thanks Saam! (In reply to Carlos Garcia Campos from comment #5) > I've noticed that reloading the page sometimes fixes the issue, so it seems > to be a race condition. Is there anything else I can do to help to fix this > (with my limited jsc knowledge)? If you could test Saam's fix, please, then I won't need to build WebKit on my travel laptop? :) 1579726 9 saam 2019-10-14 11:48:52 -0700 (In reply to Carlos Garcia Campos from comment #5) > I've noticed that reloading the page sometimes fixes the issue, so it seems > to be a race condition. Is there anything else I can do to help to fix this > (with my limited jsc knowledge)? I don't think it's a typical race. You're probably just seeing effects of concurrent JIT. If you turn of concurrent JIT, it should reproduce every time in my experience with other web pages that broke. 1579728 10 saam 2019-10-14 11:49:22 -0700 (In reply to Saam Barati from comment #9) > (In reply to Carlos Garcia Campos from comment #5) > > I've noticed that reloading the page sometimes fixes the issue, so it seems > > to be a race condition. Is there anything else I can do to help to fix this > > (with my limited jsc knowledge)? > > I don't think it's a typical race. You're probably just seeing effects of > concurrent JIT. If you turn of concurrent JIT, it should reproduce every > time in my experience with other web pages that broke. And if my patch doesn't fix the issue, it'd be super good to know :-) 1580002 11 cgarcia 2019-10-14 23:10:07 -0700 (In reply to Saam Barati from comment #10) > (In reply to Saam Barati from comment #9) > > (In reply to Carlos Garcia Campos from comment #5) > > > I've noticed that reloading the page sometimes fixes the issue, so it seems > > > to be a race condition. Is there anything else I can do to help to fix this > > > (with my limited jsc knowledge)? > > > > I don't think it's a typical race. You're probably just seeing effects of > > concurrent JIT. If you turn of concurrent JIT, it should reproduce every > > time in my experience with other web pages that broke. > > And if my patch doesn't fix the issue, it'd be super good to know :-) It fixed it, thanks! 1580003 12 cgarcia 2019-10-14 23:10:19 -0700 *** This bug has been marked as a duplicate of bug 202827 ***