202564 2019-10-03 22:46:21 -0700 [WebAuthn] Rename -[WKUIDelegatePrivate webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:] to -[WKUIDelegatePrivate _webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:] 2019-10-15 13:45:32 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 181943 1 jiewen_tan jiewen_tan alex.gaynor bfulgham commit-queue jiewen_tan webkit-bug-importer oldest_to_newest 1576732 0 jiewen_tan 2019-10-03 22:46:21 -0700 Rename -[WKUIDelegatePrivate webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:] to -[WKUIDelegatePrivate _webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]. 1576733 1 webkit-bug-importer 2019-10-03 22:46:55 -0700 <rdar://problem/55974027> 1579022 2 380732 jiewen_tan 2019-10-11 01:15:24 -0700 Created attachment 380732 Patch 1579189 3 jiewen_tan 2019-10-11 12:09:48 -0700 Not sure how the API test failure is related to this patch. 1579203 4 jiewen_tan 2019-10-11 13:11:09 -0700 (In reply to Jiewen Tan from comment #3) > Not sure how the API test failure is related to this patch. The test is super flaky in my local test. 1580120 5 380732 bfulgham 2019-10-15 09:14:50 -0700 Comment on attachment 380732 Patch r=me 1580161 6 jiewen_tan 2019-10-15 10:37:55 -0700 (In reply to Brent Fulgham from comment #5) > Comment on attachment 380732 [details] > Patch > > r=me Thanks Brent for r+ this patch. Will coordinate with the internal patch to land this properly. 1580231 7 380732 commit-queue 2019-10-15 13:45:30 -0700 Comment on attachment 380732 Patch Clearing flags on attachment: 380732 Committed r251154: <https://trac.webkit.org/changeset/251154> 1580232 8 commit-queue 2019-10-15 13:45:32 -0700 All reviewed patches have been landed. Closing bug. 380732 2019-10-11 01:15:24 -0700 2019-10-15 13:45:30 -0700 Patch bug-202564-20191011011523.patch text/plain 6623 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwOTg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ1MTcyNzA4YWNhM2JiYmJk NDljODMzZTdiN2Q2MTFkMGM5MTAzYWMuLjY2OWMwZGU0OGI4YWYzNzk1NGEyODQwN2Y5ZGM3Njgz ZDZkMjJiMjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMTAtMTEgIEppZXdlbiBU YW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViQXV0aG5dIFJlbmFtZSAt W1dLVUlEZWxlZ2F0ZVByaXZhdGUgd2ViVmlldzpydW5XZWJBdXRoZW50aWNhdGlvblBhbmVsOmlu aXRpYXRlZEJ5RnJhbWU6Y29tcGxldGlvbkhhbmRsZXI6XSB0byAtW1dLVUlEZWxlZ2F0ZVByaXZh dGUgX3dlYlZpZXc6cnVuV2ViQXV0aGVudGljYXRpb25QYW5lbDppbml0aWF0ZWRCeUZyYW1lOmNv bXBsZXRpb25IYW5kbGVyOl0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIwMjU2NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTU5NzQwMjc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVuYW1lIHRoZSBT UEkgdG8gYSBwcm9wZXIgU1BJIHN0eWxlLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2Nv YS9XS1VJRGVsZWdhdGVQcml2YXRlLmg6CisgICAgICAgICogVUlQcm9jZXNzL0NvY29hL1VJRGVs ZWdhdGUubW06CisgICAgICAgIChXZWJLaXQ6OlVJRGVsZWdhdGU6OnNldERlbGVnYXRlKToKKyAg ICAgICAgKFdlYktpdDo6VUlEZWxlZ2F0ZTo6VUlDbGllbnQ6OnJ1bldlYkF1dGhlbnRpY2F0aW9u UGFuZWwpOgorCiAyMDE5LTEwLTEwICBCYXN1a2UgU3V6dWtpICA8QmFzdWtlLlN1enVraUBzb255 LmNvbT4KIAogICAgICAgICBbV2luQ2Fpcm9dIE1vdmUgcmVtb3RlIGNvbW11bmljYXRpb24gaGFu ZGxpbmcgZnJvbSBSZW1vdGVJbnNwZWN0b3JTZXJ2ZXIgdG8gUmVtb3RlSW5zcGVjdG9yLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLVUlEZWxlZ2F0ZVBy aXZhdGUuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1VJRGVsZWdhdGVQ cml2YXRlLmgKaW5kZXggOWQyYTU5M2IwNDI0ODBkYmYzYTkzMjgyNmZlMmRiNWRjYTk0YWNhNy4u Nzk3NGQwYWE0ZGZhYzc3OTZkYWRkNjE2Y2ZiOTUzNDJlOGJhYTkxMSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLVUlEZWxlZ2F0ZVByaXZhdGUuaAorKysg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tVSURlbGVnYXRlUHJpdmF0ZS5o CkBAIC0xMzcsNyArMTM3LDcgQEAgc3RydWN0IFVJRWRnZUluc2V0czsKIAogLSAodm9pZClfd2Vi VmlldzooV0tXZWJWaWV3ICopd2ViVmlldyB0YWtlRm9jdXM6KF9XS0ZvY3VzRGlyZWN0aW9uKWRp cmVjdGlvbiBXS19BUElfQVZBSUxBQkxFKG1hY29zKDEwLjEzLjQpLCBpb3MoMTIuMikpOwogCi0t ICh2b2lkKXdlYlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcgcnVuV2ViQXV0aGVudGljYXRpb25Q YW5lbDooX1dLV2ViQXV0aGVudGljYXRpb25QYW5lbCAqKXBhbmVsIGluaXRpYXRlZEJ5RnJhbWU6 KFdLRnJhbWVJbmZvICopZnJhbWUgY29tcGxldGlvbkhhbmRsZXI6KHZvaWQgKF4pKF9XS1dlYkF1 dGhlbnRpY2F0aW9uUGFuZWxSZXN1bHQpKWNvbXBsZXRpb25IYW5kbGVyIFdLX0FQSV9BVkFJTEFC TEUobWFjb3MoV0tfTUFDX1RCQSksIGlvcyhXS19JT1NfVEJBKSk7CistICh2b2lkKV93ZWJWaWV3 OihXS1dlYlZpZXcgKil3ZWJWaWV3IHJ1bldlYkF1dGhlbnRpY2F0aW9uUGFuZWw6KF9XS1dlYkF1 dGhlbnRpY2F0aW9uUGFuZWwgKilwYW5lbCBpbml0aWF0ZWRCeUZyYW1lOihXS0ZyYW1lSW5mbyAq KWZyYW1lIGNvbXBsZXRpb25IYW5kbGVyOih2b2lkICheKShfV0tXZWJBdXRoZW50aWNhdGlvblBh bmVsUmVzdWx0KSljb21wbGV0aW9uSGFuZGxlciBXS19BUElfQVZBSUxBQkxFKG1hY29zKFdLX01B Q19UQkEpLCBpb3MoV0tfSU9TX1RCQSkpOwogCiAjaWYgVEFSR0VUX09TX0lQSE9ORQogLSAoQk9P TClfd2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldyBzaG91bGRJbmNsdWRlQXBwTGlua0FjdGlv bnNGb3JFbGVtZW50OihfV0tBY3RpdmF0ZWRFbGVtZW50SW5mbyAqKWVsZW1lbnQgV0tfQVBJX0FW QUlMQUJMRShpb3MoOS4wKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9D b2NvYS9VSURlbGVnYXRlLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvVUlEZWxl Z2F0ZS5tbQppbmRleCAzZWM0MmNlZjJlNjRhN2Q2YTMzM2M2N2I4Zjc2ZGE2YjMzNjk2NTI5Li41 MGRhYWUzNjIxZGE1NzEwYzlmMjVlM2JkMGZmYWMyYjQzOTQ3ZDE1IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9VSURlbGVnYXRlLm1tCisrKyBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0NvY29hL1VJRGVsZWdhdGUubW0KQEAgLTE3NCw3ICsxNzQsNyBAQCB2b2lk IFVJRGVsZWdhdGU6OnNldERlbGVnYXRlKGlkIDxXS1VJRGVsZWdhdGU+IGRlbGVnYXRlKQogICAg IG1fZGVsZWdhdGVNZXRob2RzLndlYlZpZXdIYXNWaWRlb0luUGljdHVyZUluUGljdHVyZURpZENo YW5nZSA9IFtkZWxlZ2F0ZSByZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKF93ZWJWaWV3Omhh c1ZpZGVvSW5QaWN0dXJlSW5QaWN0dXJlRGlkQ2hhbmdlOildOwogICAgIG1fZGVsZWdhdGVNZXRo b2RzLndlYlZpZXdEaWRTaG93U2FmZUJyb3dzaW5nV2FybmluZyA9IFtkZWxlZ2F0ZSByZXNwb25k c1RvU2VsZWN0b3I6QHNlbGVjdG9yKF93ZWJWaWV3RGlkU2hvd1NhZmVCcm93c2luZ1dhcm5pbmc6 KV07CiAjaWYgRU5BQkxFKFdFQl9BVVRITikKLSAgICBtX2RlbGVnYXRlTWV0aG9kcy53ZWJWaWV3 UnVuV2ViQXV0aGVudGljYXRpb25QYW5lbEluaXRpYXRlZEJ5RnJhbWVDb21wbGV0aW9uSGFuZGxl ciA9IFtkZWxlZ2F0ZSByZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKHdlYlZpZXc6cnVuV2Vi QXV0aGVudGljYXRpb25QYW5lbDppbml0aWF0ZWRCeUZyYW1lOmNvbXBsZXRpb25IYW5kbGVyOild OworICAgIG1fZGVsZWdhdGVNZXRob2RzLndlYlZpZXdSdW5XZWJBdXRoZW50aWNhdGlvblBhbmVs SW5pdGlhdGVkQnlGcmFtZUNvbXBsZXRpb25IYW5kbGVyID0gW2RlbGVnYXRlIHJlc3BvbmRzVG9T ZWxlY3RvcjpAc2VsZWN0b3IoX3dlYlZpZXc6cnVuV2ViQXV0aGVudGljYXRpb25QYW5lbDppbml0 aWF0ZWRCeUZyYW1lOmNvbXBsZXRpb25IYW5kbGVyOildOwogI2VuZGlmCiB9CiAKQEAgLTEyOTQs OCArMTI5NCw4IEBAIHZvaWQgVUlEZWxlZ2F0ZTo6VUlDbGllbnQ6OnJ1bldlYkF1dGhlbnRpY2F0 aW9uUGFuZWwoV2ViUGFnZVByb3h5JiwgQVBJOjpXZWJBdXRoCiAgICAgICAgIHJldHVybjsKICAg ICB9CiAKLSAgICBhdXRvIGNoZWNrZXIgPSBDb21wbGV0aW9uSGFuZGxlckNhbGxDaGVja2VyOjpj cmVhdGUoZGVsZWdhdGUuZ2V0KCksIEBzZWxlY3Rvcih3ZWJWaWV3OnJ1bldlYkF1dGhlbnRpY2F0 aW9uUGFuZWw6aW5pdGlhdGVkQnlGcmFtZTpjb21wbGV0aW9uSGFuZGxlcjopKTsKLSAgICBbKGlk IDxXS1VJRGVsZWdhdGVQcml2YXRlPilkZWxlZ2F0ZSB3ZWJWaWV3Om1fdWlEZWxlZ2F0ZS5tX3dl YlZpZXcgcnVuV2ViQXV0aGVudGljYXRpb25QYW5lbDp3cmFwcGVyKHBhbmVsKSBpbml0aWF0ZWRC eUZyYW1lOm5pbCBjb21wbGV0aW9uSGFuZGxlcjptYWtlQmxvY2tQdHIoW2NvbXBsZXRpb25IYW5k bGVyID0gV1RGTW92ZShjb21wbGV0aW9uSGFuZGxlciksIGNoZWNrZXIgPSBXVEZNb3ZlKGNoZWNr ZXIpXSAoX1dLV2ViQXV0aGVudGljYXRpb25QYW5lbFJlc3VsdCByZXN1bHQpIG11dGFibGUgewor ICAgIGF1dG8gY2hlY2tlciA9IENvbXBsZXRpb25IYW5kbGVyQ2FsbENoZWNrZXI6OmNyZWF0ZShk ZWxlZ2F0ZS5nZXQoKSwgQHNlbGVjdG9yKF93ZWJWaWV3OnJ1bldlYkF1dGhlbnRpY2F0aW9uUGFu ZWw6aW5pdGlhdGVkQnlGcmFtZTpjb21wbGV0aW9uSGFuZGxlcjopKTsKKyAgICBbKGlkIDxXS1VJ RGVsZWdhdGVQcml2YXRlPilkZWxlZ2F0ZSBfd2ViVmlldzptX3VpRGVsZWdhdGUubV93ZWJWaWV3 IHJ1bldlYkF1dGhlbnRpY2F0aW9uUGFuZWw6d3JhcHBlcihwYW5lbCkgaW5pdGlhdGVkQnlGcmFt ZTpuaWwgY29tcGxldGlvbkhhbmRsZXI6bWFrZUJsb2NrUHRyKFtjb21wbGV0aW9uSGFuZGxlciA9 IFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpLCBjaGVja2VyID0gV1RGTW92ZShjaGVja2VyKV0g KF9XS1dlYkF1dGhlbnRpY2F0aW9uUGFuZWxSZXN1bHQgcmVzdWx0KSBtdXRhYmxlIHsKICAgICAg ICAgaWYgKGNoZWNrZXItPmNvbXBsZXRpb25IYW5kbGVySGFzQmVlbkNhbGxlZCgpKQogICAgICAg ICAgICAgcmV0dXJuOwogICAgICAgICBjaGVja2VyLT5kaWRDYWxsQ29tcGxldGlvbkhhbmRsZXIo KTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBk NjUzNWUxZGJmMzNiNDgwOGJjMmI0OTAyOGIyNjY0OTljYTYyODRkLi5iM2RhMDVlZGVhYWRlODYz ZjQ0N2I4OGIzZDNlZWE1YzQ1ZWU3OTk0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysr IGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMTAtMTEgIEppZXdlbiBU YW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViQXV0aG5dIFJlbmFtZSAt W1dLVUlEZWxlZ2F0ZVByaXZhdGUgd2ViVmlldzpydW5XZWJBdXRoZW50aWNhdGlvblBhbmVsOmlu aXRpYXRlZEJ5RnJhbWU6Y29tcGxldGlvbkhhbmRsZXI6XSB0byAtW1dLVUlEZWxlZ2F0ZVByaXZh dGUgX3dlYlZpZXc6cnVuV2ViQXV0aGVudGljYXRpb25QYW5lbDppbml0aWF0ZWRCeUZyYW1lOmNv bXBsZXRpb25IYW5kbGVyOl0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIwMjU2NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTU5NzQwMjc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0 QVBJL1Rlc3RzL1dlYktpdENvY29hL19XS1dlYkF1dGhlbnRpY2F0aW9uUGFuZWwubW06CisgICAg ICAgICgtW1Rlc3RXZWJBdXRoZW50aWNhdGlvblBhbmVsVUlEZWxlZ2F0ZSBfd2ViVmlldzpydW5X ZWJBdXRoZW50aWNhdGlvblBhbmVsOmluaXRpYXRlZEJ5RnJhbWU6Y29tcGxldGlvbkhhbmRsZXI6 XSk6CisgICAgICAgICgtW1Rlc3RXZWJBdXRoZW50aWNhdGlvblBhbmVsVUlEZWxlZ2F0ZSB3ZWJW aWV3OnJ1bldlYkF1dGhlbnRpY2F0aW9uUGFuZWw6aW5pdGlhdGVkQnlGcmFtZTpjb21wbGV0aW9u SGFuZGxlcjpdKTogRGVsZXRlZC4KKwogMjAxOS0xMC0xMCAgSm9uYXRoYW4gQmVkYXJkICA8amJl ZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgcmVzdWx0cy53ZWJraXQub3JnOiBTZXJ2ZSBjb3Jy ZWN0IGV4aXQgY29kZXMgd2hlbiBhYm9ydGluZwpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9fV0tXZWJBdXRoZW50aWNhdGlvblBhbmVsLm1tIGIvVG9v bHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9fV0tXZWJBdXRoZW50aWNhdGlvblBh bmVsLm1tCmluZGV4IGNlNDExYmVlMzBkMTgwMjI5YjI5Nzk1MDVmMzIzYThlODFhYWQwMjcuLjUw YjVhNmU5MTBmZWE5NTU5ZmI2MzMzY2M4OGZhOWNiMDAxMGFlNmIgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvX1dLV2ViQXV0aGVudGljYXRpb25QYW5l bC5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL19XS1dlYkF1 dGhlbnRpY2F0aW9uUGFuZWwubW0KQEAgLTYwLDcgKzYwLDcgQEAgQGltcGxlbWVudGF0aW9uIFRl c3RXZWJBdXRoZW50aWNhdGlvblBhbmVsVUlEZWxlZ2F0ZSB7CiAgICAgUmV0YWluUHRyPFRlc3RX ZWJBdXRoZW50aWNhdGlvblBhbmVsRGVsZWdhdGU+IF9kZWxlZ2F0ZTsKIH0KIAotLSAodm9pZCl3 ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3IHJ1bldlYkF1dGhlbnRpY2F0aW9uUGFuZWw6KF9X S1dlYkF1dGhlbnRpY2F0aW9uUGFuZWwgKilwYW5lbCBpbml0aWF0ZWRCeUZyYW1lOihXS0ZyYW1l SW5mbyAqKWZyYW1lIGNvbXBsZXRpb25IYW5kbGVyOih2b2lkICheKShfV0tXZWJBdXRoZW50aWNh dGlvblBhbmVsUmVzdWx0KSljb21wbGV0aW9uSGFuZGxlcgorLSAodm9pZClfd2ViVmlldzooV0tX ZWJWaWV3ICopd2ViVmlldyBydW5XZWJBdXRoZW50aWNhdGlvblBhbmVsOihfV0tXZWJBdXRoZW50 aWNhdGlvblBhbmVsICopcGFuZWwgaW5pdGlhdGVkQnlGcmFtZTooV0tGcmFtZUluZm8gKilmcmFt ZSBjb21wbGV0aW9uSGFuZGxlcjoodm9pZCAoXikoX1dLV2ViQXV0aGVudGljYXRpb25QYW5lbFJl c3VsdCkpY29tcGxldGlvbkhhbmRsZXIKIHsKICAgICB3ZWJBdXRoZW50aWNhdGlvblBhbmVsUmFu ID0gdHJ1ZTsKIAo=