<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>202419</bug_id>
          
          <creation_ts>2019-10-01 12:04:42 -0700</creation_ts>
          <short_desc>REGRESSION (r250375): [old EWS] JSC EWS is always marking Patches as success</short_desc>
          <delta_ts>2019-10-10 09:41:22 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Caio Lima">ticaiolima</reporter>
          <assigned_to name="Jonathan Bedard">jbedard</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>ap</cc>
    
    <cc>commit-queue</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>glenn</cc>
    
    <cc>jbedard</cc>
    
    <cc>keith_miller</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1575631</commentid>
    <comment_count>0</comment_count>
    <who name="Caio Lima">ticaiolima</who>
    <bug_when>2019-10-01 12:04:42 -0700</bug_when>
    <thetext>The patch #379917 in https://bugs.webkit.org/show_bug.cgi?id=202140 contains a build error, however jsc, jsc-i386 and jsc-mips are being marked as success.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1576488</commentid>
    <comment_count>1</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2019-10-03 10:53:13 -0700</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 199753 ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1576545</commentid>
    <comment_count>2</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2019-10-03 12:20:41 -0700</bug_when>
    <thetext>This is actually not a duplicate of bug 199753. Bug 199753 is about the bubble color being wrong (when the test fails). This bug is about the build/test passing when they should have failed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1576547</commentid>
    <comment_count>3</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2019-10-03 12:22:27 -0700</bug_when>
    <thetext>(In reply to Caio Lima from comment #0)
&gt; The patch #379917 in https://bugs.webkit.org/show_bug.cgi?id=202140 contains a build error, however jsc, jsc-i386 and jsc-mips are being marked as success.
Just to add more info https://webkit-queues.webkit.org/patch/379917/jsc-armv7-ews says &quot;Built patch&quot;, while it should have failed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1576634</commentid>
    <comment_count>4</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2019-10-03 15:51:25 -0700</bug_when>
    <thetext>Does EWS actually build the EWS tool? Not sure if there is a bug here.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1576636</commentid>
    <comment_count>5</comment_count>
    <who name="Caio Lima">ticaiolima</who>
    <bug_when>2019-10-03 16:26:09 -0700</bug_when>
    <thetext>(In reply to Alexey Proskuryakov from comment #4)
&gt; Does EWS actually build the EWS tool? Not sure if there is a bug here.

What do you mean by EWS tool?

AFICT, If I uploaded a patch that doesn&apos;t build into any JSC port 1 week ago, those bubble would be red and report &quot;Patch does not build&quot;. However they are being marked as &quot;Passed&quot; and looking into the log, I can see that they successfully build and run tests. It is also the case when we have test failures. I noticed that this is happening since last week. I&apos;m not sure if this is the expected output from EWS bots.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1576642</commentid>
    <comment_count>6</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2019-10-03 16:43:39 -0700</bug_when>
    <thetext>*the jsc tool

Well, it is kind of a mystery indeed. I&apos;m not sure about other EWSes, but the &quot;jsc&quot; one that runs tests seems like it should have failed indeed.

The command that wrongly succeeds is:

webkit-patch --status-host=webkit-queues.webkit.org --bot-id=ews127 build --no-clean --no-update --build-style=release --group=jsc --port=mac</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1576963</commentid>
    <comment_count>7</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2019-10-04 12:55:01 -0700</bug_when>
    <thetext>I can reproduce locally. &quot;webkit-patch build&quot; exits with status 0, so it&apos;s a problem in or below webkit-patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1577891</commentid>
    <comment_count>8</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2019-10-08 12:53:09 -0700</bug_when>
    <thetext>Well, run_and_throw_if_fail in executive.py has this line:

            exit_code = self._run_command_with_teed_output(args, child_stdout, **kwargs)

And the _run_command_with_teed_output function never returns a value. Looks like a regression from r250375.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1577912</commentid>
    <comment_count>9</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2019-10-08 13:28:19 -0700</bug_when>
    <thetext>(In reply to Alexey Proskuryakov from comment #8)
&gt; Well, run_and_throw_if_fail in executive.py has this line:
&gt; 
&gt;             exit_code = self._run_command_with_teed_output(args,
&gt; child_stdout, **kwargs)
&gt; 
&gt; And the _run_command_with_teed_output function never returns a value. Looks
&gt; like a regression from r250375.

Totally is a regression, I have the fix.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1577935</commentid>
    <comment_count>10</comment_count>
      <attachid>380463</attachid>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2019-10-08 14:08:55 -0700</bug_when>
    <thetext>Created attachment 380463
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1577989</commentid>
    <comment_count>11</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2019-10-08 15:53:13 -0700</bug_when>
    <thetext>rs=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1578003</commentid>
    <comment_count>12</comment_count>
      <attachid>380476</attachid>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2019-10-08 16:20:53 -0700</bug_when>
    <thetext>Created attachment 380476
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1578011</commentid>
    <comment_count>13</comment_count>
      <attachid>380476</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-10-08 16:38:21 -0700</bug_when>
    <thetext>Comment on attachment 380476
Patch for landing

Clearing flags on attachment: 380476

Committed r250877: &lt;https://trac.webkit.org/changeset/250877&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1578012</commentid>
    <comment_count>14</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-10-08 16:38:23 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1578013</commentid>
    <comment_count>15</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-10-08 16:39:16 -0700</bug_when>
    <thetext>&lt;rdar://problem/56098044&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1578014</commentid>
    <comment_count>16</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2019-10-08 16:40:42 -0700</bug_when>
    <thetext>Alexey has another complaint about the weirdness of the log, looking into that as well.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1578699</commentid>
    <comment_count>17</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2019-10-10 09:41:22 -0700</bug_when>
    <thetext>(In reply to Jonathan Bedard from comment #16)
&gt; Alexey has another complaint about the weirdness of the log, looking into
&gt; that as well.

After the fix in r250877, the log looks fine, the end is:

The following build commands failed:
	CompileC /Volumes/Shared/OpenSource/WebKitBuild/JavaScriptCore.build/Release/jsc.build/Objects-normal/x86_64/jsc.o /Volumes/Shared/OpenSource/Source/JavaScriptCore/jsc.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)
/Volumes/Shared/OpenSource/WebKitBuild/JavaScriptCore.build/Release/JavaScriptCore.build/Objects-normal
    export OBJROOT=/Volumes/Shared/OpenSource/WebKitBuild
    export ONLY_ACTIVE_ARCH=YES
    export OS=MACOS
    export OSAC=/usr/bin/osacompile
    export OTHER_CFLAGS=&quot; --system-header-prefix=unicode/&quot;
    export OTHER_CPLUSPLUSFLAGS=&quot; -isystem /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/System.framework/PrivateHeaders --system-header-prefix=unicode/&quot;
    export OTHER_LDFLAGS=&quot; -Wl,-unexported_symbol,__ZTISt9bad_alloc -Wl,-unexported_symbol,__ZTISt9exception -Wl,-unexported_symbol,__ZTSSt9bad_alloc -Wl,-unexported_symbol,__ZTSSt9exception -Wl,-unexported_symbol,__ZdlPvS_ -Wl,-unexported_symbol,__ZnwmPv -Wl,-unexported_symbol,__ZNKSt3__18functionIFvvEEclEv -Wl,-unexported_symbol,__ZNSt3__18functionIFvvEEC1EOS2_ -Wl,-unexported_symbol,__ZNSt3__18functionIFvvEEC2EOS2_ -Wl,-unexported_symbol,__ZNKSt3__18functionIFvRN3JSC17BytecodeGeneratorEPNS1_10RegisterIDEEEclES3_S5_ -Wl,-unexported_symbol,__ZNSt3__18functionIFvRN3JSC17BytecodeGeneratorEPNS1_10RegisterIDEEED1Ev -Wl,-unexported_symbol,__ZNSt3__18functionIFvRN3JSC17BytecodeGeneratorEPNS1_10RegisterIDEEED2Ev -Wl,-unexported_symbol,__ZNSt3__18functionIFvvEED1Ev -Wl,-unexported_symbol,__ZNSt3__18functionIFvvEED2Ev -Wl,-unexported_symbol,__ZTVNSt3__117bad_function_callE -force_load &quot;/Volumes/Shared/OpenSource/WebKitBuild/Release/DerivedSources/JavaScriptCore/libWTF.a&quot; -framework CoreServices&quot;
    export OTHER_LDFLAGS_BASE=&quot;-Wl,-unexported_symbol,__ZTISt9bad_alloc -Wl,-unexported_symbol,__ZTISt9exception -Wl,-unexported_symbol,__ZTSSt9bad_alloc -Wl,-unexported_symbol,__ZTSSt9exception -Wl,-unexported_symbol,__ZdlPvS_ -Wl,-unexported_symbol,__ZnwmPv -Wl,-unexported_symbol,__ZNKSt3__18functionIFvvEEclEv -Wl,-unexported_symbol,__ZNSt3__18functionIFvvEEC1EOS2_ -Wl,-unexported_symbol,__ZNSt3__18functionIFvvEEC2EOS2_ -Wl,-unexported_symbol,__ZNKSt3__18functionIFvRN3JSC17BytecodeGeneratorEPNS1_10RegisterIDEEEclES3_S5_ -Wl,-unexported_symbol,__ZNSt3__18functionIFvRN3JSC17BytecodeGeneratorEPNS1_10RegisterIDEEED1Ev -Wl,-unexported_symbol,__ZNSt3__18functionIFvRN3JSC17BytecodeGeneratorEPNS1_10RegisterIDEEED2Ev -Wl,-unexported_symbol,__ZNSt3__18functionIFvvEED1Ev -Wl,-unexported_symbol,__ZNSt3__18functionIFvvEED2Ev -Wl,-unexported_symbol,__ZTVNSt3__117bad_function_callE -force_load &quot;/Volumes/Shared/OpenSource/WebKitBuild/Release/DerivedSources/JavaScriptCore/libWTF.a&quot;&quot;
    export OTHER_LDFLAGS_HIDE_SYMBOLS=&quot;-Wl,-unexported_symbol,__ZTISt9bad_alloc -Wl,-unexported_symbol,__ZTISt9exception -Wl,-unexported_symbol,__ZTSSt9bad_alloc -Wl,-unexported_symbol,__ZTSSt9exception -Wl,-unexported_symbol,__ZdlPvS_ -Wl,-unexported_symbol,__ZnwmPv -Wl,-unexported_symbol,__ZNKSt3__18functionIFvvEEclEv -Wl,-unexported_symbol,__ZNSt3__18functionIFvvEEC1EOS2_ -Wl,-unexported_symbol,__ZNSt3__18functionIFvvEEC2EOS2_ -Wl,-unexported_symbol,__ZNKSt3__18functionIFvRN3JSC17BytecodeGeneratorEPNS1_10RegisterIDEEEclES3_S5_ -Wl,-unexported_symbol,__ZNSt3__18functionIFvRN3JSC17BytecodeGeneratorEPNS1_10RegisterIDEEED1Ev -Wl,-unexported_symbol,__ZNSt3__18functionIFvRN3JSC17BytecodeGeneratorEPNS1_10RegisterIDEEED2Ev -Wl,-unexported_symbol,__ZNSt3__18functionIFvvEED1Ev -Wl,-unexported_symbol,__ZNSt3__18functionIFvvEED2Ev -Wl,-unexported_symbol,__ZTVNSt3__117bad_function_callE&quot;
    export PACKAGE_TYPE=com.apple.package-type.wrapper.framework

Failed to run &quot;[&apos;Tools/Scripts/build-jsc&apos;, &apos;--release&apos;]&quot; exit_code: 65

Pretty sure the logging weirdness Alexey observed was because we weren&apos;t early exiting on non-zero exit codes.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>380463</attachid>
            <date>2019-10-08 14:08:55 -0700</date>
            <delta_ts>2019-10-08 16:20:51 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-202419-20191008140854.patch</filename>
            <type>text/plain</type>
            <size>2811</size>
            <attacher name="Jonathan Bedard">jbedard</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDI1MDg1OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE2IEBACisyMDE5LTEwLTA4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv
bT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjUwMzc1KTogW29sZCBFV1NdIEpTQyBFV1MgaXMg
YWx3YXlzIG1hcmtpbmcgUGF0Y2hlcyBhcyBzdWNjZXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53
ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDI0MTkKKworICAgICAgICBSZXZpZXdlZCBieSBO
T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3Rl
bS9leGVjdXRpdmUucHk6CisgICAgICAgIChFeGVjdXRpdmUuX3J1bl9jb21tYW5kX3dpdGhfdGVl
ZF9vdXRwdXQpOiBSZXR1cm4gZXhpdCBjb2RlLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv
Y29tbW9uL3N5c3RlbS9leGVjdXRpdmVfdW5pdHRlc3QucHk6CisgICAgICAgIChFeGVjdXRpdmVU
ZXN0LnRlc3RfcnVuX2NvbW1hbmRfd2l0aF9iYWRfY29tbWFuZCk6IFRlc3QgdGhhdCBleGNlcHRp
b25zIGFyZSByYWlzZWQKKyAgICAgICAgRm9yIG5vbi16ZXJvIGV4aXQgY29kZXMuCisKIDIwMTkt
MTAtMDggIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFNlcnZp
Y2UgV29ya2VyIEZldGNoIGV2ZW50cyBzaG91bGQgdGltZSBvdXQuCkluZGV4OiBUb29scy9TY3Jp
cHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlLnB5Cj09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRv
b2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9leGVjdXRpdmUucHkJKHJldmlzaW9u
IDI1MDg1NikKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9leGVjdXRp
dmUucHkJKHdvcmtpbmcgY29weSkKQEAgLTEyOCw2ICsxMjgsNyBAQCBjbGFzcyBFeGVjdXRpdmUo
QWJzdHJhY3RFeGVjdXRpdmUpOgogICAgICAgICAgICAgd2hpbGUgY2hpbGRfcHJvY2Vzcy5wb2xs
KCkgaXMgTm9uZToKICAgICAgICAgICAgICAgICBvdXRwdXRfbGluZSA9IGNoaWxkX3Byb2Nlc3Mu
c3Rkb3V0LnJlYWRsaW5lKCkKICAgICAgICAgICAgICAgICB0ZWVkX291dHB1dC53cml0ZSh1bmlj
b2RlX2NvbXBhdGliaWxpdHkuZGVjb2RlX2ZvcihvdXRwdXRfbGluZSwgc3RyKSkKKyAgICAgICAg
ICAgIHJldHVybiBjaGlsZF9wcm9jZXNzLnBvbGwoKQogCiAgICAgIyBGSVhNRTogUmVtb3ZlIHRo
aXMgZGVwcmVjYXRlZCBtZXRob2QgYW5kIG1vdmUgY2FsbGVycyB0byBydW5fY29tbWFuZC4KICAg
ICAjIEZJWE1FOiBUaGlzIG1ldGhvZCBpcyBhIGhhY2sgdG8gYWxsb3cgcnVubmluZyBjb21tYW5k
IHdoaWNoIGJvdGgKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9l
eGVjdXRpdmVfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRw
eS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZV91bml0dGVzdC5weQkocmV2aXNpb24gMjUwODU2KQor
KysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZV91bml0dGVz
dC5weQkod29ya2luZyBjb3B5KQpAQCAtMTA1LDkgKzEwNSwxMCBAQCBjbGFzcyBFeGVjdXRpdmVU
ZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgc2VsZi5hc3NlcnRfaW50ZXJwcmV0ZXJf
Zm9yX2NvbnRlbnQoJ3J1YnknLCAnIyEvdXNyL2Jpbi9ydWJ5JykKIAogICAgIGRlZiB0ZXN0X3J1
bl9jb21tYW5kX3dpdGhfYmFkX2NvbW1hbmQoc2VsZik6Ci0gICAgICAgIGRlZiBydW5fYmFkX2Nv
bW1hbmQoKToKLSAgICAgICAgICAgIEV4ZWN1dGl2ZSgpLnJ1bl9jb21tYW5kKFsiZm9vX2Jhcl9j
b21tYW5kX2JsYWgiXSwgaWdub3JlX2Vycm9ycz1UcnVlLCByZXR1cm5fZXhpdF9jb2RlPVRydWUp
Ci0gICAgICAgIHNlbGYuYXNzZXJ0UmFpc2VzKE9TRXJyb3IsIHJ1bl9iYWRfY29tbWFuZCkKKyAg
ICAgICAgc2VsZi5hc3NlcnRSYWlzZXMoT1NFcnJvciwgbGFtYmRhOiBFeGVjdXRpdmUoKS5ydW5f
Y29tbWFuZChbImZvb19iYXJfY29tbWFuZF9ibGFoIl0sIGlnbm9yZV9lcnJvcnM9VHJ1ZSwgcmV0
dXJuX2V4aXRfY29kZT1UcnVlKSkKKyAgICAgICAgc2VsZi5hc3NlcnRSYWlzZXMoT1NFcnJvciwg
bGFtYmRhOiBFeGVjdXRpdmUoKS5ydW5fYW5kX3Rocm93X2lmX2ZhaWwoWyJmb29fYmFyX2NvbW1h
bmRfYmxhaCJdLCBxdWlldD1UcnVlKSkKKyAgICAgICAgc2VsZi5hc3NlcnRSYWlzZXMoU2NyaXB0
RXJyb3IsIGxhbWJkYTogRXhlY3V0aXZlKCkucnVuX2NvbW1hbmQoWydweXRob24nLCAnLWMnLCAn
aW1wb3J0IHN5czsgc3lzLmV4aXQoMSknXSkpCisgICAgICAgIHNlbGYuYXNzZXJ0UmFpc2VzKFNj
cmlwdEVycm9yLCBsYW1iZGE6IEV4ZWN1dGl2ZSgpLnJ1bl9hbmRfdGhyb3dfaWZfZmFpbChbJ3B5
dGhvbicsICctYycsICdpbXBvcnQgc3lzOyBzeXMuZXhpdCgxKSddLCBxdWlldD1UcnVlKSkKIAog
ICAgIGRlZiB0ZXN0X3J1bl9jb21tYW5kX2FyZ3NfdHlwZShzZWxmKToKICAgICAgICAgZXhlY3V0
aXZlID0gRXhlY3V0aXZlKCkK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>380476</attachid>
            <date>2019-10-08 16:20:53 -0700</date>
            <delta_ts>2019-10-08 16:38:21 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-202419-20191008162052.patch</filename>
            <type>text/plain</type>
            <size>2814</size>
            <attacher name="Jonathan Bedard">jbedard</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDI1MDg1OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE2IEBACisyMDE5LTEwLTA4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv
bT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjUwMzc1KTogW29sZCBFV1NdIEpTQyBFV1MgaXMg
YWx3YXlzIG1hcmtpbmcgUGF0Y2hlcyBhcyBzdWNjZXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53
ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDI0MTkKKworICAgICAgICBSdWJiZXItc3RhbXBl
ZCBieSBBYWthc2ggSmFpbi4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5
c3RlbS9leGVjdXRpdmUucHk6CisgICAgICAgIChFeGVjdXRpdmUuX3J1bl9jb21tYW5kX3dpdGhf
dGVlZF9vdXRwdXQpOiBSZXR1cm4gZXhpdCBjb2RlLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0
cHkvY29tbW9uL3N5c3RlbS9leGVjdXRpdmVfdW5pdHRlc3QucHk6CisgICAgICAgIChFeGVjdXRp
dmVUZXN0LnRlc3RfcnVuX2NvbW1hbmRfd2l0aF9iYWRfY29tbWFuZCk6IFRlc3QgdGhhdCBleGNl
cHRpb25zIGFyZSByYWlzZWQKKyAgICAgICAgRm9yIG5vbi16ZXJvIGV4aXQgY29kZXMuCisKIDIw
MTktMTAtMDggIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFNl
cnZpY2UgV29ya2VyIEZldGNoIGV2ZW50cyBzaG91bGQgdGltZSBvdXQuCkluZGV4OiBUb29scy9T
Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlLnB5Cj09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t
IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9leGVjdXRpdmUucHkJKHJldmlz
aW9uIDI1MDg1NikKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9leGVj
dXRpdmUucHkJKHdvcmtpbmcgY29weSkKQEAgLTEyOCw2ICsxMjgsNyBAQCBjbGFzcyBFeGVjdXRp
dmUoQWJzdHJhY3RFeGVjdXRpdmUpOgogICAgICAgICAgICAgd2hpbGUgY2hpbGRfcHJvY2Vzcy5w
b2xsKCkgaXMgTm9uZToKICAgICAgICAgICAgICAgICBvdXRwdXRfbGluZSA9IGNoaWxkX3Byb2Nl
c3Muc3Rkb3V0LnJlYWRsaW5lKCkKICAgICAgICAgICAgICAgICB0ZWVkX291dHB1dC53cml0ZSh1
bmljb2RlX2NvbXBhdGliaWxpdHkuZGVjb2RlX2ZvcihvdXRwdXRfbGluZSwgc3RyKSkKKyAgICAg
ICAgICAgIHJldHVybiBjaGlsZF9wcm9jZXNzLnBvbGwoKQogCiAgICAgIyBGSVhNRTogUmVtb3Zl
IHRoaXMgZGVwcmVjYXRlZCBtZXRob2QgYW5kIG1vdmUgY2FsbGVycyB0byBydW5fY29tbWFuZC4K
ICAgICAjIEZJWE1FOiBUaGlzIG1ldGhvZCBpcyBhIGhhY2sgdG8gYWxsb3cgcnVubmluZyBjb21t
YW5kIHdoaWNoIGJvdGgKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3Rl
bS9leGVjdXRpdmVfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJr
aXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZV91bml0dGVzdC5weQkocmV2aXNpb24gMjUwODU2
KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZV91bml0
dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtMTA1LDkgKzEwNSwxMCBAQCBjbGFzcyBFeGVjdXRp
dmVUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgc2VsZi5hc3NlcnRfaW50ZXJwcmV0
ZXJfZm9yX2NvbnRlbnQoJ3J1YnknLCAnIyEvdXNyL2Jpbi9ydWJ5JykKIAogICAgIGRlZiB0ZXN0
X3J1bl9jb21tYW5kX3dpdGhfYmFkX2NvbW1hbmQoc2VsZik6Ci0gICAgICAgIGRlZiBydW5fYmFk
X2NvbW1hbmQoKToKLSAgICAgICAgICAgIEV4ZWN1dGl2ZSgpLnJ1bl9jb21tYW5kKFsiZm9vX2Jh
cl9jb21tYW5kX2JsYWgiXSwgaWdub3JlX2Vycm9ycz1UcnVlLCByZXR1cm5fZXhpdF9jb2RlPVRy
dWUpCi0gICAgICAgIHNlbGYuYXNzZXJ0UmFpc2VzKE9TRXJyb3IsIHJ1bl9iYWRfY29tbWFuZCkK
KyAgICAgICAgc2VsZi5hc3NlcnRSYWlzZXMoT1NFcnJvciwgbGFtYmRhOiBFeGVjdXRpdmUoKS5y
dW5fY29tbWFuZChbImZvb19iYXJfY29tbWFuZF9ibGFoIl0sIGlnbm9yZV9lcnJvcnM9VHJ1ZSwg
cmV0dXJuX2V4aXRfY29kZT1UcnVlKSkKKyAgICAgICAgc2VsZi5hc3NlcnRSYWlzZXMoT1NFcnJv
ciwgbGFtYmRhOiBFeGVjdXRpdmUoKS5ydW5fYW5kX3Rocm93X2lmX2ZhaWwoWyJmb29fYmFyX2Nv
bW1hbmRfYmxhaCJdLCBxdWlldD1UcnVlKSkKKyAgICAgICAgc2VsZi5hc3NlcnRSYWlzZXMoU2Ny
aXB0RXJyb3IsIGxhbWJkYTogRXhlY3V0aXZlKCkucnVuX2NvbW1hbmQoWydweXRob24nLCAnLWMn
LCAnaW1wb3J0IHN5czsgc3lzLmV4aXQoMSknXSkpCisgICAgICAgIHNlbGYuYXNzZXJ0UmFpc2Vz
KFNjcmlwdEVycm9yLCBsYW1iZGE6IEV4ZWN1dGl2ZSgpLnJ1bl9hbmRfdGhyb3dfaWZfZmFpbChb
J3B5dGhvbicsICctYycsICdpbXBvcnQgc3lzOyBzeXMuZXhpdCgxKSddLCBxdWlldD1UcnVlKSkK
IAogICAgIGRlZiB0ZXN0X3J1bl9jb21tYW5kX2FyZ3NfdHlwZShzZWxmKToKICAgICAgICAgZXhl
Y3V0aXZlID0gRXhlY3V0aXZlKCkK
</data>

          </attachment>
      

    </bug>

</bugzilla>