202358 2019-09-29 22:49:03 -0700 [Nicosia] Complete ScrollingTreeNicosia::createScrollingTreeNode() 2019-09-30 02:07:20 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 198475 1 zan zan cgarcia cmarcelo ews-watchlist fred.wang jamesr luiz tonikitoo webkit-bug-importer oldest_to_newest 1575197 0 zan 2019-09-29 22:49:03 -0700 [Nicosia] Complete ScrollingTreeNicosia::createScrollingTreeNode() 1575199 1 379823 zan 2019-09-29 22:50:27 -0700 Created attachment 379823 Patch 1575205 2 379823 cgarcia 2019-09-30 01:04:51 -0700 Comment on attachment 379823 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379823&action=review > Source/WebCore/page/scrolling/nicosia/ScrollingTreeNicosia.cpp:74 > - RELEASE_ASSERT_NOT_REACHED(); > + ASSERT_NOT_REACHED(); > + return ScrollingTreeFixedNode::create(*this, nodeID); why? 1575218 3 379829 zan 2019-09-30 02:03:24 -0700 Created attachment 379829 Patch for landing 1575219 4 379829 zan 2019-09-30 02:06:40 -0700 Comment on attachment 379829 Patch for landing Clearing flags on attachment: 379829 Committed r250514: <https://trac.webkit.org/changeset/250514> 1575220 5 zan 2019-09-30 02:06:44 -0700 All reviewed patches have been landed. Closing bug. 1575221 6 webkit-bug-importer 2019-09-30 02:07:20 -0700 <rdar://problem/55832537> 379823 2019-09-29 22:50:27 -0700 2019-09-30 02:03:21 -0700 Patch bug-202358-20190930075025.patch text/plain 2639 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwNDk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTIyNzY0NDU0ODE4NDA2 MTg2YzcxYmEwZTI4YWU2NTYyYWI1Y2QyNy4uODEzZTJiNGM3ZWRmZjA4MjJmOWM4ZDBlYjg1MWM3 MjgwMjZmOWRiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTA5LTI5ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbTmljb3NpYV0gQ29t cGxldGUgU2Nyb2xsaW5nVHJlZU5pY29zaWE6OmNyZWF0ZVNjcm9sbGluZ1RyZWVOb2RlKCkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjM1OAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGFnZS9zY3Jv bGxpbmcvbmljb3NpYS9TY3JvbGxpbmdUcmVlTmljb3NpYS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpTY3JvbGxpbmdUcmVlTmljb3NpYTo6Y3JlYXRlU2Nyb2xsaW5nVHJlZU5vZGUpOgorICAgICAg ICBSZXR1cm4gYXBwcm9wcmlhdGUgb2JqZWN0cyBmb3IgdGhlIHJlbWFpbmluZyBub2RlIHR5cGVz LgorCiAyMDE5LTA5LTI5ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAog ICAgICAgICBTY3JvbGxpbmdUcmVlU2Nyb2xsaW5nTm9kZTogdXNlIExheWVyUmVwcmVzZW50YXRp b24gZm9yIHNjcm9sbCBjb250YWluZXIsIHNjcm9sbGVkIGNvbnRlbnRzIGxheWVycwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvbmljb3NpYS9TY3JvbGxpbmdUcmVl Tmljb3NpYS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9uaWNvc2lhL1Njcm9s bGluZ1RyZWVOaWNvc2lhLmNwcAppbmRleCBjZWE3MTQ2ZjExODA5NjA1YzUzNmJhNzc4NTgzZjA0 ZmJjMzlhODBkLi42OTQyNTIwYzAyMmUyZDlmYjk2MjUxNzczNDZjZGU5OTNjNzc5OWRjIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9uaWNvc2lhL1Njcm9sbGluZ1Ry ZWVOaWNvc2lhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9uaWNvc2lh L1Njcm9sbGluZ1RyZWVOaWNvc2lhLmNwcApAQCAtMzMsNiArMzMsOSBAQAogI2luY2x1ZGUgIlNj cm9sbGluZ1RyZWVGaXhlZE5vZGUuaCIKICNpbmNsdWRlICJTY3JvbGxpbmdUcmVlRnJhbWVIb3N0 aW5nTm9kZS5oIgogI2luY2x1ZGUgIlNjcm9sbGluZ1RyZWVGcmFtZVNjcm9sbGluZ05vZGVOaWNv c2lhLmgiCisjaW5jbHVkZSAiU2Nyb2xsaW5nVHJlZU92ZXJmbG93U2Nyb2xsUHJveHlOb2RlLmgi CisjaW5jbHVkZSAiU2Nyb2xsaW5nVHJlZU92ZXJmbG93U2Nyb2xsaW5nTm9kZU5pY29zaWEuaCIK KyNpbmNsdWRlICJTY3JvbGxpbmdUcmVlUG9zaXRpb25lZE5vZGUuaCIKICNpbmNsdWRlICJTY3Jv bGxpbmdUcmVlU3RpY2t5Tm9kZS5oIgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC01NiwxNyAr NTksMTkgQEAgUmVmPFNjcm9sbGluZ1RyZWVOb2RlPiBTY3JvbGxpbmdUcmVlTmljb3NpYTo6Y3Jl YXRlU2Nyb2xsaW5nVHJlZU5vZGUoU2Nyb2xsaW5nTm8KICAgICBjYXNlIFNjcm9sbGluZ05vZGVU eXBlOjpGcmFtZUhvc3Rpbmc6CiAgICAgICAgIHJldHVybiBTY3JvbGxpbmdUcmVlRnJhbWVIb3N0 aW5nTm9kZTo6Y3JlYXRlKCp0aGlzLCBub2RlSUQpOwogICAgIGNhc2UgU2Nyb2xsaW5nTm9kZVR5 cGU6Ok92ZXJmbG93OgotICAgICAgICAvLyBTaG91bGQgbm90IGJlIHJlYWNoZWQgLS0gY2F1Z2h0 IGJ5IEFTU0VSVF9OT1RfUkVBQ0hFRCgpIGJlbG93LgotICAgICAgICBicmVhazsKKyAgICAgICAg cmV0dXJuIFNjcm9sbGluZ1RyZWVPdmVyZmxvd1Njcm9sbGluZ05vZGVOaWNvc2lhOjpjcmVhdGUo KnRoaXMsIG5vZGVJRCk7CisgICAgY2FzZSBTY3JvbGxpbmdOb2RlVHlwZTo6T3ZlcmZsb3dQcm94 eToKKyAgICAgICAgcmV0dXJuIFNjcm9sbGluZ1RyZWVPdmVyZmxvd1Njcm9sbFByb3h5Tm9kZTo6 Y3JlYXRlKCp0aGlzLCBub2RlSUQpOwogICAgIGNhc2UgU2Nyb2xsaW5nTm9kZVR5cGU6OkZpeGVk OgogICAgICAgICByZXR1cm4gU2Nyb2xsaW5nVHJlZUZpeGVkTm9kZTo6Y3JlYXRlKCp0aGlzLCBu b2RlSUQpOwogICAgIGNhc2UgU2Nyb2xsaW5nTm9kZVR5cGU6OlN0aWNreToKICAgICAgICAgcmV0 dXJuIFNjcm9sbGluZ1RyZWVTdGlja3lOb2RlOjpjcmVhdGUoKnRoaXMsIG5vZGVJRCk7CiAgICAg Y2FzZSBTY3JvbGxpbmdOb2RlVHlwZTo6UG9zaXRpb25lZDoKLSAgICAgICAgUkVMRUFTRV9BU1NF UlRfTk9UX1JFQUNIRUQoKTsKKyAgICAgICAgcmV0dXJuIFNjcm9sbGluZ1RyZWVQb3NpdGlvbmVk Tm9kZTo6Y3JlYXRlKCp0aGlzLCBub2RlSUQpOwogICAgIH0KIAotICAgIFJFTEVBU0VfQVNTRVJU X05PVF9SRUFDSEVEKCk7CisgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgcmV0dXJuIFNj cm9sbGluZ1RyZWVGaXhlZE5vZGU6OmNyZWF0ZSgqdGhpcywgbm9kZUlEKTsKIH0KIAogfSAvLyBu YW1lc3BhY2UgV2ViQ29yZQo= 379829 2019-09-30 02:03:24 -0700 2019-09-30 02:03:24 -0700 Patch for landing bug-202358-20190930110323.patch text/plain 2530 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwNDk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTIyNzY0NDU0ODE4NDA2 MTg2YzcxYmEwZTI4YWU2NTYyYWI1Y2QyNy4uMTljYmQxN2Q3ODdiMjc2YmVhMmRiNGQ2N2U5M2Uy MDk0MWQ0YmMyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTA5LTMwICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbTmljb3NpYV0gQ29t cGxldGUgU2Nyb2xsaW5nVHJlZU5pY29zaWE6OmNyZWF0ZVNjcm9sbGluZ1RyZWVOb2RlKCkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjM1OAorCisg ICAgICAgIFJldmlld2VkIGJ5IENhcmxvcyBHYXJjaWEgQ2FtcG9zLgorCisgICAgICAgICogcGFn ZS9zY3JvbGxpbmcvbmljb3NpYS9TY3JvbGxpbmdUcmVlTmljb3NpYS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpTY3JvbGxpbmdUcmVlTmljb3NpYTo6Y3JlYXRlU2Nyb2xsaW5nVHJlZU5vZGUpOgor ICAgICAgICBSZXR1cm4gYXBwcm9wcmlhdGUgb2JqZWN0cyBmb3IgdGhlIHJlbWFpbmluZyBub2Rl IHR5cGVzLgorCiAyMDE5LTA5LTI5ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNv bT4KIAogICAgICAgICBTY3JvbGxpbmdUcmVlU2Nyb2xsaW5nTm9kZTogdXNlIExheWVyUmVwcmVz ZW50YXRpb24gZm9yIHNjcm9sbCBjb250YWluZXIsIHNjcm9sbGVkIGNvbnRlbnRzIGxheWVycwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvbmljb3NpYS9TY3JvbGxp bmdUcmVlTmljb3NpYS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9uaWNvc2lh L1Njcm9sbGluZ1RyZWVOaWNvc2lhLmNwcAppbmRleCBjZWE3MTQ2ZjExODA5NjA1YzUzNmJhNzc4 NTgzZjA0ZmJjMzlhODBkLi4wYWMyOTk5ZWU2MWE2NGI4NjNkYjNiNTZhMzlkYTA0YmRmYjMwZjc0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9uaWNvc2lhL1Njcm9s bGluZ1RyZWVOaWNvc2lhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9u aWNvc2lhL1Njcm9sbGluZ1RyZWVOaWNvc2lhLmNwcApAQCAtMzMsNiArMzMsOSBAQAogI2luY2x1 ZGUgIlNjcm9sbGluZ1RyZWVGaXhlZE5vZGUuaCIKICNpbmNsdWRlICJTY3JvbGxpbmdUcmVlRnJh bWVIb3N0aW5nTm9kZS5oIgogI2luY2x1ZGUgIlNjcm9sbGluZ1RyZWVGcmFtZVNjcm9sbGluZ05v ZGVOaWNvc2lhLmgiCisjaW5jbHVkZSAiU2Nyb2xsaW5nVHJlZU92ZXJmbG93U2Nyb2xsUHJveHlO b2RlLmgiCisjaW5jbHVkZSAiU2Nyb2xsaW5nVHJlZU92ZXJmbG93U2Nyb2xsaW5nTm9kZU5pY29z aWEuaCIKKyNpbmNsdWRlICJTY3JvbGxpbmdUcmVlUG9zaXRpb25lZE5vZGUuaCIKICNpbmNsdWRl ICJTY3JvbGxpbmdUcmVlU3RpY2t5Tm9kZS5oIgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC01 NiwxNCArNTksMTUgQEAgUmVmPFNjcm9sbGluZ1RyZWVOb2RlPiBTY3JvbGxpbmdUcmVlTmljb3Np YTo6Y3JlYXRlU2Nyb2xsaW5nVHJlZU5vZGUoU2Nyb2xsaW5nTm8KICAgICBjYXNlIFNjcm9sbGlu Z05vZGVUeXBlOjpGcmFtZUhvc3Rpbmc6CiAgICAgICAgIHJldHVybiBTY3JvbGxpbmdUcmVlRnJh bWVIb3N0aW5nTm9kZTo6Y3JlYXRlKCp0aGlzLCBub2RlSUQpOwogICAgIGNhc2UgU2Nyb2xsaW5n Tm9kZVR5cGU6Ok92ZXJmbG93OgotICAgICAgICAvLyBTaG91bGQgbm90IGJlIHJlYWNoZWQgLS0g Y2F1Z2h0IGJ5IEFTU0VSVF9OT1RfUkVBQ0hFRCgpIGJlbG93LgotICAgICAgICBicmVhazsKKyAg ICAgICAgcmV0dXJuIFNjcm9sbGluZ1RyZWVPdmVyZmxvd1Njcm9sbGluZ05vZGVOaWNvc2lhOjpj cmVhdGUoKnRoaXMsIG5vZGVJRCk7CisgICAgY2FzZSBTY3JvbGxpbmdOb2RlVHlwZTo6T3ZlcmZs b3dQcm94eToKKyAgICAgICAgcmV0dXJuIFNjcm9sbGluZ1RyZWVPdmVyZmxvd1Njcm9sbFByb3h5 Tm9kZTo6Y3JlYXRlKCp0aGlzLCBub2RlSUQpOwogICAgIGNhc2UgU2Nyb2xsaW5nTm9kZVR5cGU6 OkZpeGVkOgogICAgICAgICByZXR1cm4gU2Nyb2xsaW5nVHJlZUZpeGVkTm9kZTo6Y3JlYXRlKCp0 aGlzLCBub2RlSUQpOwogICAgIGNhc2UgU2Nyb2xsaW5nTm9kZVR5cGU6OlN0aWNreToKICAgICAg ICAgcmV0dXJuIFNjcm9sbGluZ1RyZWVTdGlja3lOb2RlOjpjcmVhdGUoKnRoaXMsIG5vZGVJRCk7 CiAgICAgY2FzZSBTY3JvbGxpbmdOb2RlVHlwZTo6UG9zaXRpb25lZDoKLSAgICAgICAgUkVMRUFT RV9BU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICAgICAgcmV0dXJuIFNjcm9sbGluZ1RyZWVQb3Np dGlvbmVkTm9kZTo6Y3JlYXRlKCp0aGlzLCBub2RlSUQpOwogICAgIH0KIAogICAgIFJFTEVBU0Vf QVNTRVJUX05PVF9SRUFDSEVEKCk7Cg==