<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>202314</bug_id>
          
          <creation_ts>2019-09-27 09:05:26 -0700</creation_ts>
          <short_desc>Allow pages served over HTTPS with `Cache-Control: no-store` header to enter the back/forward cache</short_desc>
          <delta_ts>2019-11-08 15:07:15 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=204025</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>202293</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>achristensen</cc>
    
    <cc>beidson</cc>
    
    <cc>commit-queue</cc>
    
    <cc>ggaren</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1574831</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-09-27 09:05:26 -0700</bug_when>
    <thetext>Allow pages served over HTTPS with `Cache-Control: no-store` header to enter the back/forward cache.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1574832</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-09-27 09:06:08 -0700</bug_when>
    <thetext>&lt;rdar://problem/55783482&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1574836</commentid>
    <comment_count>2</comment_count>
      <attachid>379731</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-09-27 09:15:43 -0700</bug_when>
    <thetext>Created attachment 379731
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1574881</commentid>
    <comment_count>3</comment_count>
      <attachid>379731</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2019-09-27 10:47:25 -0700</bug_when>
    <thetext>Comment on attachment 379731
Patch

This feels like r177948</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1574896</commentid>
    <comment_count>4</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-09-27 11:23:51 -0700</bug_when>
    <thetext>(In reply to Alex Christensen from comment #3)
&gt; Comment on attachment 379731 [details]
&gt; Patch
&gt; 
&gt; This feels like r177948

Yes, I did no-cache a while back, and now I am doing no-store :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1574919</commentid>
    <comment_count>5</comment_count>
      <attachid>379731</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-09-27 12:09:11 -0700</bug_when>
    <thetext>Comment on attachment 379731
Patch

Clearing flags on attachment: 379731

Committed r250437: &lt;https://trac.webkit.org/changeset/250437&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1574920</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-09-27 12:09:12 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>379731</attachid>
            <date>2019-09-27 09:15:43 -0700</date>
            <delta_ts>2019-09-27 12:09:11 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-202314-20190927091543.patch</filename>
            <type>text/plain</type>
            <size>5497</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwNDAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGMxYzhjOTM1NDk5NjQy
YTdlOTk4ZDg2MmRiNWU3Njg1NWM2MTkyOC4uMGFlODVlMzEyMjc1ZTVjNGYyNzY2M2ExYmJiMzdk
YWE0NGE4NDg5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTA5LTI3ICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQWxsb3cgcGFnZXMgc2VydmVk
IG92ZXIgSFRUUFMgd2l0aCBgQ2FjaGUtQ29udHJvbDogbm8tc3RvcmVgIGhlYWRlciB0byBlbnRl
ciB0aGUgYmFjay9mb3J3YXJkIGNhY2hlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD0yMDIzMTQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU1NzgzNDgy
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFsbG93
IHBhZ2VzIHNlcnZlZCBvdmVyIEhUVFBTIHdpdGggYENhY2hlLUNvbnRyb2w6IG5vLXN0b3JlYCBo
ZWFkZXIgdG8gZW50ZXIgdGhlIGJhY2svZm9yd2FyZCBjYWNoZS4KKyAgICAgICAgVGhpcyB3YXMg
cHJldmVudGluZyBhbGwgcGFnZXMgb24gRmFjZWJvb2suY29tIHRvIGVudGVyIHRoZSBiYWNrL2Zv
cndhcmQgY2FjaGUuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCB1cGRhdGVkIGV4aXN0aW5nIHRl
c3QuCisKKyAgICAgICAgKiBoaXN0b3J5L1BhZ2VDYWNoZS5jcHA6CisgICAgICAgIChXZWJDb3Jl
OjpjYW5DYWNoZUZyYW1lKToKKwogMjAxOS0wOS0yNyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBw
bGUuY29tPgogCiAgICAgICAgIFBhZ2VzIHdpdGggV2ViIFdvcmtlcnMgY2Fubm90IGVudGVyIHRo
ZSBiYWNrIC8gZm9yd2FyZCBjYWNoZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaGlzdG9y
eS9QYWdlQ2FjaGUuY3BwIGIvU291cmNlL1dlYkNvcmUvaGlzdG9yeS9QYWdlQ2FjaGUuY3BwCmlu
ZGV4IDZiOTAxZmI1MWIzZWQzZDlhNTZjZDIxOTQ1ZDA4YjFlYzVjOTJiZjIuLjg1MTVkNmMzYWFh
Y2YwYWZjNWVkNzQ4MzRjY2M5MTg5MzI2NWM2YjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl
L2hpc3RvcnkvUGFnZUNhY2hlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9oaXN0b3J5L1BhZ2VD
YWNoZS5jcHAKQEAgLTEyNywxMSArMTI3LDYgQEAgc3RhdGljIGJvb2wgY2FuQ2FjaGVGcmFtZShG
cmFtZSYgZnJhbWUsIERpYWdub3N0aWNMb2dnaW5nQ2xpZW50JiBkaWFnbm9zdGljTG9nZ2kKICAg
ICAgICAgbG9nUGFnZUNhY2hlRmFpbHVyZURpYWdub3N0aWNNZXNzYWdlKGRpYWdub3N0aWNMb2dn
aW5nQ2xpZW50LCBEaWFnbm9zdGljTG9nZ2luZ0tleXM6Omhhc1BsdWdpbnNLZXkoKSk7CiAgICAg
ICAgIGlzQ2FjaGVhYmxlID0gZmFsc2U7CiAgICAgfQotICAgIGlmIChmcmFtZS5pc01haW5GcmFt
ZSgpICYmIGZyYW1lLmRvY3VtZW50KCkgJiYgZnJhbWUuZG9jdW1lbnQoKS0+dXJsKCkucHJvdG9j
b2xJcygiaHR0cHMiKSAmJiBkb2N1bWVudExvYWRlci0+cmVzcG9uc2UoKS5jYWNoZUNvbnRyb2xD
b250YWluc05vU3RvcmUoKSkgewotICAgICAgICBQQ0xPRygiICAgLUZyYW1lIGlzIEhUVFBTLCBh
bmQgY2FjaGUgY29udHJvbCBwcm9oaWJpdHMgc3RvcmluZyIpOwotICAgICAgICBsb2dQYWdlQ2Fj
aGVGYWlsdXJlRGlhZ25vc3RpY01lc3NhZ2UoZGlhZ25vc3RpY0xvZ2dpbmdDbGllbnQsIERpYWdu
b3N0aWNMb2dnaW5nS2V5czo6aHR0cHNOb1N0b3JlS2V5KCkpOwotICAgICAgICBpc0NhY2hlYWJs
ZSA9IGZhbHNlOwotICAgIH0KICAgICBpZiAoZnJhbWUuaXNNYWluRnJhbWUoKSAmJiAhZnJhbWVM
b2FkZXIuaGlzdG9yeSgpLmN1cnJlbnRJdGVtKCkpIHsKICAgICAgICAgUENMT0coIiAgIC1NYWlu
IGZyYW1lIGhhcyBubyBjdXJyZW50IGhpc3RvcnkgaXRlbSIpOwogICAgICAgICBsb2dQYWdlQ2Fj
aGVGYWlsdXJlRGlhZ25vc3RpY01lc3NhZ2UoZGlhZ25vc3RpY0xvZ2dpbmdDbGllbnQsIERpYWdu
b3N0aWNMb2dnaW5nS2V5czo6bm9DdXJyZW50SGlzdG9yeUl0ZW1LZXkoKSk7CmRpZmYgLS1naXQg
YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZTli
NTZiMjU3NTQ1NjFiYzBkZmExOWVmZTRjZGEzODY4OWFiNDRhNy4uMzc2YjZkNTQ0NzA3MzliZmEy
Yzk0MWQ1OWUwZGIzMWYyMjVjZGIzZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n
CisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA5LTI3
ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQWxsb3cgcGFnZXMg
c2VydmVkIG92ZXIgSFRUUFMgd2l0aCBgQ2FjaGUtQ29udHJvbDogbm8tc3RvcmVgIGhlYWRlciB0
byBlbnRlciB0aGUgYmFjay9mb3J3YXJkIGNhY2hlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDIzMTQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU1
NzgzNDgyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IFVwZGF0ZSBleGlzdGluZyB0ZXN0IHRvIHJlZmxlY3QgYmVoYXZpb3IgY2hhbmdlLgorCisgICAg
ICAgICogaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL2h0dHBzLWluLXBhZ2UtY2FjaGUtZXhwZWN0ZWQu
dHh0OgorICAgICAgICAqIGh0dHAvdGVzdHMvbmF2aWdhdGlvbi9yZXNvdXJjZXMvaHR0cHMtaW4t
cGFnZS1jYWNoZS0xLnBocDoKKwogMjAxOS0wOS0yNyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBw
bGUuY29tPgogCiAgICAgICAgIFBhZ2VzIHdpdGggV2ViIFdvcmtlcnMgY2Fubm90IGVudGVyIHRo
ZSBiYWNrIC8gZm9yd2FyZCBjYWNoZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0
cy9uYXZpZ2F0aW9uL2h0dHBzLWluLXBhZ2UtY2FjaGUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz
dHMvaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL2h0dHBzLWluLXBhZ2UtY2FjaGUtZXhwZWN0ZWQudHh0
CmluZGV4IGM4OTNhYmI0ZWI1M2QzOTJkNjZkMjE2ZDViN2ZlZDM4NDkzMWIzOTMuLjE2NTM0NTlj
YjhhNDZjODAwOTkyMDFhYjc1MWYzMDFjNTljNDhhZmEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz
L2h0dHAvdGVzdHMvbmF2aWdhdGlvbi9odHRwcy1pbi1wYWdlLWNhY2hlLWV4cGVjdGVkLnR4dAor
KysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL25hdmlnYXRpb24vaHR0cHMtaW4tcGFnZS1jYWNo
ZS1leHBlY3RlZC50eHQKQEAgLTEsNSArMSw1IEBACi1BTEVSVDogVGhpcyBwYWdlIGlzIGh0dHBz
IGFuZCBoYXMgdGhlIG5vLXN0b3JlIGNhY2hlLWNvbnRyb2wgZGlyZWN0aXZlLiBJdCBzaG91bGQg
Tk9UIGdvIGluIHRvIHRoZSBwYWdlIGNhY2hlLgotQUxFUlQ6IFRoZSBwYWdlIHdhcyByZWxvYWRl
ZCBvbiBiYWNrLCBub3QgZnJvbSB0aGUgcGFnZSBjYWNoZS4gR29vZCBqb2IuIFJ1bm5pbmcgcGFy
dCAyIG9mIHRoZSB0ZXN0LgorQUxFUlQ6IFRoaXMgcGFnZSBpcyBodHRwcyBhbmQgaGFzIHRoZSBu
by1zdG9yZSBjYWNoZS1jb250cm9sIGRpcmVjdGl2ZS4gSXQgc2hvdWxkIGdvIGluIHRvIHRoZSBw
YWdlIGNhY2hlLgorQUxFUlQ6IFRoZSBwYWdlIHdhcyByZXN0b3JlZCBmcm9tIHRoZSBwYWdlIGNh
Y2hlLiBHb29kIGpvYi4gUnVubmluZyBwYXJ0IDIgb2YgdGhlIHRlc3QuCiBBTEVSVDogVGhpcyBw
YWdlIGlzIGh0dHBzIGFuZCBoYXMgdGhlIG5vLWNhY2hlIGNhY2hlLWNvbnRyb2wgZGlyZWN0aXZl
LiBJdCBzaG91bGQgZ28gaW4gdG8gdGhlIHBhZ2UgY2FjaGUuCiBBTEVSVDogVGhlIHBhZ2Ugd2Fz
IHJlc3RvcmVkIGZyb20gdGhlIHBhZ2UgY2FjaGUuIEdvb2Qgam9iIS4gUnVubmluZyBwYXJ0IDMg
b2YgdGhlIHRlc3QuCiBBTEVSVDogVGhpcyBwYWdlIGlzIGh0dHBzIGFuZCBzaG91bGQgZ28gaW4g
dG8gdGhlIHBhZ2UgY2FjaGUuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL25h
dmlnYXRpb24vcmVzb3VyY2VzL2h0dHBzLWluLXBhZ2UtY2FjaGUtMS5waHAgYi9MYXlvdXRUZXN0
cy9odHRwL3Rlc3RzL25hdmlnYXRpb24vcmVzb3VyY2VzL2h0dHBzLWluLXBhZ2UtY2FjaGUtMS5w
aHAKaW5kZXggYzY1ZGU5NTFmMWE4M2YwYjRmNzMzODQ5MzIzNDVhY2E0NDA1MjU3Mi4uNThlMDA5
NmE3YzIwYjhiZmJiZmZmZTIzN2UxNmRhYmJhYWYzNTJkMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz
dHMvaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3Jlc291cmNlcy9odHRwcy1pbi1wYWdlLWNhY2hlLTEu
cGhwCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbmF2aWdhdGlvbi9yZXNvdXJjZXMvaHR0
cHMtaW4tcGFnZS1jYWNoZS0xLnBocApAQCAtMTEsMTkgKzExLDE5IEBAIGZ1bmN0aW9uIG5leHRU
ZXN0KCkgewogCiB3aW5kb3cub25wYWdlc2hvdyA9IGZ1bmN0aW9uKGV2dCkgewogCWlmIChldnQu
cGVyc2lzdGVkKSB7Ci0JCWFsZXJ0KCJUaGUgcGFnZSB3YXMgcmVzdG9yZWQgZnJvbSB0aGUgcGFn
ZSBjYWNoZS4gSXQgc2hvdWxkIE5PVCBoYXZlIGJlZW4uIFJ1bm5pbmcgcGFydCAyIG9mIHRoZSB0
ZXN0LiIpOworCQlhbGVydCgiVGhlIHBhZ2Ugd2FzIHJlc3RvcmVkIGZyb20gdGhlIHBhZ2UgY2Fj
aGUuIEdvb2Qgam9iLiBSdW5uaW5nIHBhcnQgMiBvZiB0aGUgdGVzdC4iKTsKIAkJbmV4dFRlc3Qo
KTsKIAl9CiB9CiAKIHdpbmRvdy5vbmxvYWQgPSBmdW5jdGlvbigpIHsKIAlpZiAod2luZG93LnNl
c3Npb25TdG9yYWdlLmh0dHBzX2luX3BhZ2VfY2FjaGVfc3RhcnRlZCkgewotCQlhbGVydCgiVGhl
IHBhZ2Ugd2FzIHJlbG9hZGVkIG9uIGJhY2ssIG5vdCBmcm9tIHRoZSBwYWdlIGNhY2hlLiBHb29k
IGpvYi4gUnVubmluZyBwYXJ0IDIgb2YgdGhlIHRlc3QuIik7CisJCWFsZXJ0KCJUaGUgcGFnZSB3
YXMgcmVsb2FkZWQgb24gYmFjaywgbm90IGZyb20gdGhlIHBhZ2UgY2FjaGUuIEl0IHNob3VsZCBO
T1QgaGF2ZSByZWxvYWRlZC4gUnVubmluZyBwYXJ0IDIgb2YgdGhlIHRlc3QuIik7CiAJCW5leHRU
ZXN0KCk7CiAJCXJldHVybjsKIAl9CiAKLQlhbGVydCgiVGhpcyBwYWdlIGlzIGh0dHBzIGFuZCBo
YXMgdGhlIG5vLXN0b3JlIGNhY2hlLWNvbnRyb2wgZGlyZWN0aXZlLiBJdCBzaG91bGQgTk9UIGdv
IGluIHRvIHRoZSBwYWdlIGNhY2hlLiIpOworCWFsZXJ0KCJUaGlzIHBhZ2UgaXMgaHR0cHMgYW5k
IGhhcyB0aGUgbm8tc3RvcmUgY2FjaGUtY29udHJvbCBkaXJlY3RpdmUuIEl0IHNob3VsZCBnbyBp
biB0byB0aGUgcGFnZSBjYWNoZS4iKTsKIAl3aW5kb3cuc2Vzc2lvblN0b3JhZ2UuaHR0cHNfaW5f
cGFnZV9jYWNoZV9zdGFydGVkID0gdHJ1ZTsKIAlzZXRUaW1lb3V0KCd3aW5kb3cubG9jYXRpb24g
PSAiZ28tYmFjay5odG1sIicsIDApOwogCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>