202270 2019-09-26 08:40:33 -0700 IDBRequest should not prevent a page from entering the back/forward cache 2019-09-27 08:56:09 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 202291 202293 1 cdumez cdumez achristensen alecflett beidson commit-queue ews-watchlist ggaren jsbell webkit-bug-importer youennf oldest_to_newest 1574459 0 cdumez 2019-09-26 08:40:33 -0700 IDBRequest should not prevent a page from entering the back/forward cache. This sometimes prevents weather.com from entering the back/forward cache. 1574460 1 webkit-bug-importer 2019-09-26 08:40:51 -0700 <rdar://problem/55744717> 1574465 2 379644 cdumez 2019-09-26 08:47:31 -0700 Created attachment 379644 Patch 1574807 3 379644 youennf 2019-09-27 07:48:52 -0700 Comment on attachment 379644 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379644&action=review > Source/WebCore/Modules/indexeddb/IDBRequest.cpp:265 > + return true; This change also affects IDBOpenDBRequest. I think your reasoning for IDBRequest also applies to IDBOpenDBRequest (events are enqueued). It might be good to double check this though. 1574812 4 379644 cdumez 2019-09-27 08:20:26 -0700 Comment on attachment 379644 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379644&action=review >> Source/WebCore/Modules/indexeddb/IDBRequest.cpp:265 >> + return true; > > This change also affects IDBOpenDBRequest. > I think your reasoning for IDBRequest also applies to IDBOpenDBRequest (events are enqueued). > It might be good to double check this though. Yes, I have checked that IDBOpenDBRequest properly queues its upgradeneeded / blocked events as well. 1574823 5 379644 cdumez 2019-09-27 08:56:07 -0700 Comment on attachment 379644 Patch Clearing flags on attachment: 379644 Committed r250425: <https://trac.webkit.org/changeset/250425> 1574824 6 cdumez 2019-09-27 08:56:09 -0700 All reviewed patches have been landed. Closing bug. 379644 2019-09-26 08:47:31 -0700 2019-09-27 08:56:07 -0700 Patch bug-202270-20190926084730.patch text/plain 4651 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwMzQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmE5MWExYjA0OGE5NzM5 MGI5NDhkZDdmODE3ZGFkOTc4NDBhYTIzMi4uMDJhMGQxYmRhYTVkYTY0MmM0M2MzMGUwZDk3OTk1 ZDNjOTc4ZWY4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE5LTA5LTI2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgSURCUmVxdWVzdCBzaG91bGQg bm90IHByZXZlbnQgYSBwYWdlIGZyb20gZW50ZXJpbmcgdGhlIGJhY2svZm9yd2FyZCBjYWNoZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAyMjcwCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NTc0NDcxNz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgSURCUmVxdWVzdDo6Y2FuU3VzcGVuZEZv ckRvY3VtZW50U3VzcGVuc2lvbigpIHRvIHJldHVybiB0cnVlIGluc3RlYWQgb2YKKyAgICAgICAg ZmFsc2UuIElEQlJlcXVlc3QgY2FuIG9ubHkgZmlyZSAyIGV2ZW50cyAoZXJyb3IgLyBzdWNjZXNz KSBhbmQgZm9yIGJvdGggaXRzCisgICAgICAgIG1lcmVseSBlbnF1ZXVlcyB0aGUgRXZlbnQgdG8g dGhlIERvY3VtZW50RXZlbnRRdWV1ZS4gVGhlIERvY3VtZW50RXZlbnRRdWV1ZQorICAgICAgICB1 c2VzIGEgU3VzcGVuZGFibGVUaW1lciAod2hpY2ggd2lsbCBiZSBzdXNwZW5kZWQgd2hpbGUgdGhl IGRvY3VtZW50IGlzIGluIHRoZQorICAgICAgICBwYWdlIGNhY2hlKSBzbyB0aGVyZSBpcyBubyBy aXNrIG9mIGZpcmluZyB0aGUgZXZlbnRzIChhbmQgdGh1cyBydW5uaW5nIHNjcmlwdCkKKyAgICAg ICAgd2hpbGUgaW4gdGhlIHBhZ2UgY2FjaGUuCisKKyAgICAgICAgVGVzdDogc3RvcmFnZS9pbmRl eGVkZGIvSURCUmVxdWVzdC1wYWdlLWNhY2hlLmh0bWwKKworICAgICAgICAqIE1vZHVsZXMvaW5k ZXhlZGRiL0lEQlJlcXVlc3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SURCUmVxdWVzdDo6Y2Fu U3VzcGVuZEZvckRvY3VtZW50U3VzcGVuc2lvbiBjb25zdCk6CisKIDIwMTktMDktMjUgIENocmlz IER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgdmVyeSBiYXNpYyBQYWdl Q2FjaGUgc3VwcG9ydCBmb3IgUlRDUGVlckNvbm5lY3Rpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQlJlcXVlc3QuY3BwIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9pbmRleGVkZGIvSURCUmVxdWVzdC5jcHAKaW5kZXggYTgyOGNlMDk5YjE2ZDZmN2E1 MzkxZDNhZjNkNTdlNzQ0NTFjODY4Ny4uYTI0NjFmYzNmNzFhMjRhZTljODI4ZDg4Yjc4NzAyYzQ3 ZjYwZGQ2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURC UmVxdWVzdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCUmVx dWVzdC5jcHAKQEAgLTI2Miw3ICsyNjIsNyBAQCBjb25zdCBjaGFyKiBJREJSZXF1ZXN0OjphY3Rp dmVET01PYmplY3ROYW1lKCkgY29uc3QKIGJvb2wgSURCUmVxdWVzdDo6Y2FuU3VzcGVuZEZvckRv Y3VtZW50U3VzcGVuc2lvbigpIGNvbnN0CiB7CiAgICAgQVNTRVJUKCZvcmlnaW5UaHJlYWQoKSA9 PSAmVGhyZWFkOjpjdXJyZW50KCkpOwotICAgIHJldHVybiBmYWxzZTsKKyAgICByZXR1cm4gdHJ1 ZTsKIH0KIAogYm9vbCBJREJSZXF1ZXN0OjpoYXNQZW5kaW5nQWN0aXZpdHkoKSBjb25zdApkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmlu ZGV4IGFkY2M0ZjM5MzMwZjhhMzQ1YWQ4ZjJlODE4YThlZGUzZjZhYWU0YjEuLjRlNDdkNTMxMTM0 MWViOWEzYjE3NjVlYzE3M2I4ZWFjZTdjNDkwZTMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0No YW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAx OS0wOS0yNiAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCisgICAgICAgIElEQlJl cXVlc3Qgc2hvdWxkIG5vdCBwcmV2ZW50IGEgcGFnZSBmcm9tIGVudGVyaW5nIHRoZSBiYWNrL2Zv cndhcmQgY2FjaGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIwMjI3MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTU3NDQ3MTc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGxheW91dCB0ZXN0IGNv dmVyYWdlLgorCisgICAgICAgICogc3RvcmFnZS9pbmRleGVkZGIvSURCUmVxdWVzdC1wYWdlLWNh Y2hlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogc3RvcmFnZS9pbmRleGVkZGIvSURC UmVxdWVzdC1wYWdlLWNhY2hlLmh0bWw6IEFkZGVkLgorCiAyMDE5LTA5LTI1ICBDaHJpcyBEdW1l eiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIHZlcnkgYmFzaWMgUGFnZUNhY2hl IHN1cHBvcnQgZm9yIFJUQ1BlZXJDb25uZWN0aW9uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9z dG9yYWdlL2luZGV4ZWRkYi9JREJSZXF1ZXN0LXBhZ2UtY2FjaGUtZXhwZWN0ZWQudHh0IGIvTGF5 b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvSURCUmVxdWVzdC1wYWdlLWNhY2hlLWV4cGVjdGVk LnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwLi4zYWI5YjUyMDBmMWQ4ODNlYTk4YzZmMDljM2IzOTk2M2FmNjg2MDMw Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvSURCUmVx dWVzdC1wYWdlLWNhY2hlLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDEzIEBACitUZXN0cyB0aGF0 IGFuIElEQlJlcXVlc3QgZG9lcyBub3QgcHJldmVudCBwYWdlIGNhY2hpbmcuCisKK09uIHN1Y2Nl c3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5 ICJURVNUIENPTVBMRVRFIi4KKworCitwYWdlc2hvdyAtIG5vdCBmcm9tIHBhZ2UgY2FjaGUKK3Bh Z2VoaWRlIC0gZW50ZXJpbmcgcGFnZSBjYWNoZQorcGFnZXNob3cgLSBmcm9tIHBhZ2UgY2FjaGUK K1BBU1MgUGFnZSBlbnRlcmVkIHBhZ2UgY2FjaGUKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlz IHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdG9yYWdl L2luZGV4ZWRkYi9JREJSZXF1ZXN0LXBhZ2UtY2FjaGUuaHRtbCBiL0xheW91dFRlc3RzL3N0b3Jh Z2UvaW5kZXhlZGRiL0lEQlJlcXVlc3QtcGFnZS1jYWNoZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjZkZTgw NjNkZjhkNWNlYTNlYmE1NzVhMGRhOGY4NDhhMjIxNDRhMmYKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9JREJSZXF1ZXN0LXBhZ2UtY2FjaGUuaHRtbApA QCAtMCwwICsxLDM0IEBACis8IS0tIHdlYmtpdC10ZXN0LXJ1bm5lciBbIGVuYWJsZVBhZ2VDYWNo ZT10cnVlIF0gLS0+Cis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGJvZHk+Cis8c2NyaXB0IHNy Yz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KK2Rlc2Ny aXB0aW9uKCJUZXN0cyB0aGF0IGFuIElEQlJlcXVlc3QgZG9lcyBub3QgcHJldmVudCBwYWdlIGNh Y2hpbmcuIik7Citqc1Rlc3RJc0FzeW5jID0gdHJ1ZTsKKword2luZG93LmFkZEV2ZW50TGlzdGVu ZXIoInBhZ2VzaG93IiwgZnVuY3Rpb24oZXZlbnQpIHsKKyAgIGRlYnVnKCJwYWdlc2hvdyAtICIg KyAoZXZlbnQucGVyc2lzdGVkID8gIiIgOiAibm90ICIpICsgImZyb20gcGFnZSBjYWNoZSIpOwor ICAgaWYgKGV2ZW50LnBlcnNpc3RlZCkgeworICAgICAgIHRlc3RQYXNzZWQoIlBhZ2UgZW50ZXJl ZCBwYWdlIGNhY2hlIik7CisgICAgICAgZmluaXNoSlNUZXN0KCk7CisgICB9CisgfSk7CisgCisg d2luZG93LmFkZEV2ZW50TGlzdGVuZXIoInBhZ2VoaWRlIiwgZnVuY3Rpb24oZXZlbnQpIHsKKyAg ICAgZGVidWcoInBhZ2VoaWRlIC0gIiArIChldmVudC5wZXJzaXN0ZWQgPyAiIiA6ICJub3QgIikg KyAiZW50ZXJpbmcgcGFnZSBjYWNoZSIpOworICAgICBpZiAoIWV2ZW50LnBlcnNpc3RlZCkgewor ICAgICAgICAgdGVzdEZhaWxlZCgiUGFnZSBmYWlsZWQgdG8gZW50ZXIgcGFnZSBjYWNoZSIpOwor ICAgICAgICAgZmluaXNoSlNUZXN0KCk7CisgICAgIH0KKyB9KTsKKyAKKyBvbmxvYWQgPSAoKSA9 PiB7CisgICAgIHNldFRpbWVvdXQoKCkgPT4geworICAgICAgICAgcmVxdWVzdCA9IGluZGV4ZWRE Qi5vcGVuKCJNeVRlc3REYXRhYmFzZSIpOworCisgICAgICAgICB3aW5kb3cubG9jYXRpb24gPSAi Li4vLi4vZmFzdC9oaXN0b3J5L3Jlc291cmNlcy9wYWdlLWNhY2hlLWhlbHBlci5odG1sIjsKKyAg ICB9LCAwKTsKKyB9OworPC9zY3JpcHQ+Cis8L2h0bWw+Cg==