202122 2019-09-23 16:17:04 -0700 Lazy JSGlobalObject property materialization should not use putDirectWithoutTransition. 2019-09-26 11:35:37 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam antoniogroza ews-watchlist keith_miller msaboff prti saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1573466 0 mark.lam 2019-09-23 16:17:04 -0700 <rdar://problem/55535249> 1573467 1 379403 mark.lam 2019-09-23 16:23:07 -0700 Created attachment 379403 proposed patch. 1573468 2 379403 ysuzuki 2019-09-23 16:24:50 -0700 Comment on attachment 379403 proposed patch. r=me 1573471 3 mark.lam 2019-09-23 16:29:40 -0700 Thanks for the review. I'm going to replace "initialization" with "materialization" in my test name and ChangeLog comments because I think it's a more accurate description. 1573472 4 mark.lam 2019-09-23 16:34:04 -0700 Landed in r250264: <http://trac.webkit.org/r250264>. 1573474 5 webkit-bug-importer 2019-09-23 16:34:48 -0700 <rdar://problem/55642472> 1573495 6 mark.lam 2019-09-23 17:40:15 -0700 <rdar://problem/55535249> 1574541 7 tzagallo 2019-09-26 11:09:08 -0700 *** Bug 202150 has been marked as a duplicate of this bug. *** 379403 2019-09-23 16:23:07 -0700 2019-09-23 16:24:50 -0700 proposed patch. bug-202122.patch text/plain 3591 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTAyNjMpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE5LTA5LTIzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBMYXp5IEpTR2xvYmFsT2JqZWN0IHByb3BlcnR5IGluaXRpYWxpemF0aW9u IHNob3VsZCBub3QgdXNlIHB1dERpcmVjdFdpdGhvdXRUcmFuc2l0aW9uLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAyMTIyCisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS81NTUzNTI0OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHN0cmVzcy9sYXp5LWdsb2JhbC1vYmplY3QtcHJvcGVydHktaW5pdGlh bGl6YXRpb24tc2hvdWxkLW5vdC1wdXREaXJlY3RXaXRob3V0VHJhbnNpdGlvbi5qczogQWRkZWQu CisKIDIwMTktMDktMjMgIENhaW8gTGltYSAgPHRpY2Fpb2xpbWFAZ21haWwuY29tPgogCiAgICAg ICAgIFNraXAgc3RyZXNzL3JlZ2V4cC11bmljb2RlLXN1cnJvZ2F0ZS1wYWlyLWluY3JlbWVudC1z aG91bGQtaW52b2x2ZS1sZW5ndGgtY2hlY2suanMgaW50byBBUk12NyBhbmQgTUlQUwpJbmRleDog SlNUZXN0cy9zdHJlc3MvbGF6eS1nbG9iYWwtb2JqZWN0LXByb3BlcnR5LWluaXRpYWxpemF0aW9u LXNob3VsZC1ub3QtcHV0RGlyZWN0V2l0aG91dFRyYW5zaXRpb24uanMKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g SlNUZXN0cy9zdHJlc3MvbGF6eS1nbG9iYWwtb2JqZWN0LXByb3BlcnR5LWluaXRpYWxpemF0aW9u LXNob3VsZC1ub3QtcHV0RGlyZWN0V2l0aG91dFRyYW5zaXRpb24uanMJKG5vbmV4aXN0ZW50KQor KysgSlNUZXN0cy9zdHJlc3MvbGF6eS1nbG9iYWwtb2JqZWN0LXByb3BlcnR5LWluaXRpYWxpemF0 aW9uLXNob3VsZC1ub3QtcHV0RGlyZWN0V2l0aG91dFRyYW5zaXRpb24uanMJKHdvcmtpbmcgY29w eSkKQEAgLTAsMCArMSwxMyBAQAorLy9AIHJ1bkRlZmF1bHQoIi0tdXNlQ29uY3VycmVudEpJVD0w IikKKworY29uc3QgeCA9IHt9OworZm9yIChsZXQgaSA9IDA7IGkgPCAxMDA7IGkrKykgeworICAg IGNvbnN0IG8gPSBjcmVhdGVHbG9iYWxPYmplY3QoKTsKKyAgICB4Ll9fcHJvdG9fXyA9IG87Cisg ICAgZm9yIChsZXQgaiA9IDA7IGogPCAxMDAwMDsgaisrKSB7CisgICAgICAgIG8ueSA9IDA7Cisg ICAgfQorICAgIHdpdGggKHgpIHsKKyAgICAgICAgbmV3IFVpbnQ4QXJyYXkoKTsKKyAgICB9Cit9 CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1MDI2MikKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBA QAorMjAxOS0wOS0yMyAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CisKKyAgICAgICAg TGF6eSBKU0dsb2JhbE9iamVjdCBwcm9wZXJ0eSBpbml0aWFsaXphdGlvbiBzaG91bGQgbm90IHVz ZSBwdXREaXJlY3RXaXRob3V0VHJhbnNpdGlvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjEyMgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTU1 MzUyNDk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBydW50aW1lL0pTR2xvYmFsT2JqZWN0LmNwcDoKKyAgICAgICAgKEpTQzo6SlNHbG9iYWxPYmpl Y3Q6OmluaXQpOgorCiAyMDE5LTA5LTIzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4K IAogICAgICAgICBSZWR1Y2UgdGhlIGFtb3VudCBvZiBtZW1vcnkgbmVlZGVkIHRvIHN0b3JlIE9w dGlvbnMuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbE9iamVj dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9i YWxPYmplY3QuY3BwCShyZXZpc2lvbiAyNTAyNjIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9KU0dsb2JhbE9iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU5OCw3ICs1OTgs NyBAQCB2b2lkIEpTR2xvYmFsT2JqZWN0Ojppbml0KFZNJiB2bSkKICAgICAgICAgICAgIGluaXQu c2V0UHJvdG90eXBlKEpTICMjIHR5cGUgIyMgQXJyYXlQcm90b3R5cGU6OmNyZWF0ZShpbml0LnZt LCBpbml0Lmdsb2JhbCwgSlMgIyMgdHlwZSAjIyBBcnJheVByb3RvdHlwZTo6Y3JlYXRlU3RydWN0 dXJlKGluaXQudm0sIGluaXQuZ2xvYmFsLCBpbml0Lmdsb2JhbC0+bV90eXBlZEFycmF5UHJvdG8u Z2V0KGluaXQuZ2xvYmFsKSkpKTsgXAogICAgICAgICAgICAgaW5pdC5zZXRTdHJ1Y3R1cmUoSlMg IyMgdHlwZSAjIyBBcnJheTo6Y3JlYXRlU3RydWN0dXJlKGluaXQudm0sIGluaXQuZ2xvYmFsLCBp bml0LnByb3RvdHlwZSkpOyBcCiAgICAgICAgICAgICBpbml0LnNldENvbnN0cnVjdG9yKEpTICMj IHR5cGUgIyMgQXJyYXlDb25zdHJ1Y3Rvcjo6Y3JlYXRlKGluaXQudm0sIGluaXQuZ2xvYmFsLCBK UyAjIyB0eXBlICMjIEFycmF5Q29uc3RydWN0b3I6OmNyZWF0ZVN0cnVjdHVyZShpbml0LnZtLCBp bml0Lmdsb2JhbCwgaW5pdC5nbG9iYWwtPm1fdHlwZWRBcnJheVN1cGVyQ29uc3RydWN0b3IuZ2V0 KGluaXQuZ2xvYmFsKSksIGluaXQucHJvdG90eXBlLCAjdHlwZSAiQXJyYXkiX3MsIHR5cGVkQXJy YXlDb25zdHJ1Y3RvckFsbG9jYXRlICMjIHR5cGUgIyMgQXJyYXlDb2RlR2VuZXJhdG9yKGluaXQu dm0pKSk7IFwKLSAgICAgICAgICAgIGluaXQuZ2xvYmFsLT5wdXREaXJlY3RXaXRob3V0VHJhbnNp dGlvbihpbml0LnZtLCBpbml0LnZtLnByb3BlcnR5TmFtZXMtPmJ1aWx0aW5OYW1lcygpLnR5cGUg IyMgQXJyYXlQcml2YXRlTmFtZSgpLCBpbml0LmNvbnN0cnVjdG9yLCBzdGF0aWNfY2FzdDx1bnNp Z25lZD4oUHJvcGVydHlBdHRyaWJ1dGU6OkRvbnRFbnVtKSk7IFwKKyAgICAgICAgICAgIGluaXQu Z2xvYmFsLT5wdXREaXJlY3QoaW5pdC52bSwgaW5pdC52bS5wcm9wZXJ0eU5hbWVzLT5idWlsdGlu TmFtZXMoKS50eXBlICMjIEFycmF5UHJpdmF0ZU5hbWUoKSwgaW5pdC5jb25zdHJ1Y3Rvciwgc3Rh dGljX2Nhc3Q8dW5zaWduZWQ+KFByb3BlcnR5QXR0cmlidXRlOjpEb250RW51bSkpOyBcCiAgICAg ICAgIH0pOwogICAgIEZPUl9FQUNIX1RZUEVEX0FSUkFZX1RZUEVfRVhDTFVESU5HX0RBVEFfVklF VyhJTklUX1RZUEVEX0FSUkFZX0xBVEVSKQogI3VuZGVmIElOSVRfVFlQRURfQVJSQVlfTEFURVIK