201973 2019-09-18 22:26:00 -0700 Remove some support for < iOS 13 2019-09-20 12:31:31 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=201851 InRadar P2 Normal --- 1 krollin krollin achristensen benjamin cdumez cmarcelo commit-queue dbates ews-watchlist webkit-bug-importer oldest_to_newest 1572262 0 krollin 2019-09-18 22:26:00 -0700 Remove some support for iOS versions less than 13.0. Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have values >= 130000. This means that expressions like "__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and "__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True. This removal is part of a series of patches effecting the removal of dead code for old versions of iOS. This particular pass involves changes in which Chris Dumez was involved. These changes are isolated from other similar changes in order to facilitate the reviewing process. 1572263 1 webkit-bug-importer 2019-09-18 22:26:13 -0700 <rdar://problem/55506966> 1572600 2 379193 krollin 2019-09-19 19:28:58 -0700 Created attachment 379193 Patch 1572815 3 379193 commit-queue 2019-09-20 12:31:30 -0700 Comment on attachment 379193 Patch Clearing flags on attachment: 379193 Committed r250138: <https://trac.webkit.org/changeset/250138> 1572816 4 commit-queue 2019-09-20 12:31:31 -0700 All reviewed patches have been landed. Closing bug. 379193 2019-09-19 19:28:58 -0700 2019-09-20 12:31:30 -0700 Patch bug-201973-20190919192857.patch text/plain 7071 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwMTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDYxODI2NTU3Yzc5YWNlMTI5ZjYwMmEx YmM3YmY5ZDgxMmZiZGU0MWEuLjg0ZTY0YWZlZmNkZDdmZmFjMjc2MWE1ZTUxYWIwZmI0MDg1NTRi OWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMTktMDktMTggIEtlaXRoIFJvbGxpbiAgPGtyb2xs aW5AYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBzb21lIHN1cHBvcnQgZm9yIDwgaU9TIDEz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDE5NzMK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU1NTA2OTY2PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBzb21lIHN1cHBvcnQgZm9yIGlPUyB2 ZXJzaW9ucyBsZXNzIHRoYW4gMTMuMC4KKworICAgICAgICBVcGRhdGUgY29uZGl0aW9uYWxzIHRo YXQgcmVmZXJlbmNlIF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVECisgICAgICAgIGFu ZCBfX0lQSE9ORV9PU19WRVJTSU9OX01BWF9BTExPV0VELCBhc3N1bWluZyB0aGF0IHRoZXkgYm90 aCBoYXZlCisgICAgICAgIHZhbHVlcyA+PSAxMzAwMDAuIFRoaXMgbWVhbnMgdGhhdCBleHByZXNz aW9ucyBsaWtlCisgICAgICAgICJfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA8IDEw MTMwMCIgYXJlIGFsd2F5cyBGYWxzZSBhbmQKKyAgICAgICAgIl9fSVBIT05FX09TX1ZFUlNJT05f TUlOX1JFUVVJUkVEID49IDEwMTMwMCIgYXJlIGFsd2F5cyBUcnVlLgorCisgICAgICAgIFRoaXMg cmVtb3ZhbCBpcyBwYXJ0IG9mIGEgc2VyaWVzIG9mIHBhdGNoZXMgZWZmZWN0aW5nIHRoZSByZW1v dmFsIG9mCisgICAgICAgIGRlYWQgY29kZSBmb3Igb2xkIHZlcnNpb25zIG9mIGlPUy4gVGhpcyBw YXJ0aWN1bGFyIHBhc3MgaW52b2x2ZXMKKyAgICAgICAgY2hhbmdlcyBpbiB3aGljaCBDaHJpcyBE dW1leiB3YXMgaW52b2x2ZWQuIFRoZXNlIGNoYW5nZXMgYXJlIGlzb2xhdGVkCisgICAgICAgIGZy b20gb3RoZXIgc2ltaWxhciBjaGFuZ2VzIGluIG9yZGVyIHRvIGZhY2lsaXRhdGUgdGhlIHJldmll d2luZworICAgICAgICBwcm9jZXNzLgorCisgICAgICAgICogd3RmL0ZlYXR1cmVEZWZpbmVzLmg6 CisKIDIwMTktMDktMTggIEtlaXRoIFJvbGxpbiAgPGtyb2xsaW5AYXBwbGUuY29tPgogCiAgICAg ICAgIFJlbW92ZSBzb21lIHN1cHBvcnQgZm9yIDwgaU9TIDEzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGFmNWZiOTBm ZDM0NGFiYjMwNzBlMjZhMGYwYTMzMDNjY2ZmMzZlZDMuLmY5MDEzNzZjYmZiZTJmMjE5MWE1MTA4 ZGU4NDAxZDZiN2JjYWI3NTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjggQEAKKzIwMTktMDktMTgg IEtlaXRoIFJvbGxpbiAgPGtyb2xsaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBzb21l IHN1cHBvcnQgZm9yIDwgaU9TIDEzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDE5NzMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU1NTA2OTY2Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBz b21lIHN1cHBvcnQgZm9yIGlPUyB2ZXJzaW9ucyBsZXNzIHRoYW4gMTMuMC4KKworICAgICAgICBV cGRhdGUgY29uZGl0aW9uYWxzIHRoYXQgcmVmZXJlbmNlIF9fSVBIT05FX09TX1ZFUlNJT05fTUlO X1JFUVVJUkVECisgICAgICAgIGFuZCBfX0lQSE9ORV9PU19WRVJTSU9OX01BWF9BTExPV0VELCBh c3N1bWluZyB0aGF0IHRoZXkgYm90aCBoYXZlCisgICAgICAgIHZhbHVlcyA+PSAxMzAwMDAuIFRo aXMgbWVhbnMgdGhhdCBleHByZXNzaW9ucyBsaWtlCisgICAgICAgICJfX0lQSE9ORV9PU19WRVJT SU9OX01JTl9SRVFVSVJFRCA8IDEwMTMwMCIgYXJlIGFsd2F5cyBGYWxzZSBhbmQKKyAgICAgICAg Il9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTMwMCIgYXJlIGFsd2F5cyBU cnVlLgorCisgICAgICAgIFRoaXMgcmVtb3ZhbCBpcyBwYXJ0IG9mIGEgc2VyaWVzIG9mIHBhdGNo ZXMgZWZmZWN0aW5nIHRoZSByZW1vdmFsIG9mCisgICAgICAgIGRlYWQgY29kZSBmb3Igb2xkIHZl cnNpb25zIG9mIGlPUy4gVGhpcyBwYXJ0aWN1bGFyIHBhc3MgaW52b2x2ZXMKKyAgICAgICAgY2hh bmdlcyBpbiB3aGljaCBDaHJpcyBEdW1leiB3YXMgaW52b2x2ZWQuIFRoZXNlIGNoYW5nZXMgYXJl IGlzb2xhdGVkCisgICAgICAgIGZyb20gb3RoZXIgc2ltaWxhciBjaGFuZ2VzIGluIG9yZGVyIHRv IGZhY2lsaXRhdGUgdGhlIHJldmlld2luZworICAgICAgICBwcm9jZXNzLgorCisgICAgICAgICog TmV0d29ya1Byb2Nlc3MvRG93bmxvYWRzL2NvY29hL0Rvd25sb2FkQ29jb2EubW06CisgICAgICAg IChXZWJLaXQ6OkRvd25sb2FkOjpyZXN1bWUpOgorCiAyMDE5LTA5LTE4ICBLZWl0aCBSb2xsaW4g IDxrcm9sbGluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgc29tZSBzdXBwb3J0IGZvciA8 IGlPUyAxMwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvRmVhdHVyZURlZmluZXMuaCBiL1Nv dXJjZS9XVEYvd3RmL0ZlYXR1cmVEZWZpbmVzLmgKaW5kZXggN2E3ZjQ2M2IyODFkOWIxODQwZDU0 MDRiZGM5ZTNhNjczMDA5N2E0Yi4uMDZmZDA4MmYzNTNhNjMzNGMwMTFmZjQ5YjE4YzQ5YTM5OWU2 ODU1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvRmVhdHVyZURlZmluZXMuaAorKysgYi9T b3VyY2UvV1RGL3d0Zi9GZWF0dXJlRGVmaW5lcy5oCkBAIC0xODYsMTYgKzE4NiwxMiBAQCB0aGUg cHVibGljIGlPUyBTREsuIFNlZSA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTc5MTY3Pi4gKi8KICNl bmRpZgogCiAjaWYgIWRlZmluZWQoSEFWRV9WSVNJQklMSVRZX1BST1BBR0FUSU9OX1ZJRVcpCi0j aWYgX19JUEhPTkVfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTMwMDAwCiAjZGVmaW5lIEhB VkVfVklTSUJJTElUWV9QUk9QQUdBVElPTl9WSUVXIDEKICNlbmRpZgotI2VuZGlmCiAKICNpZiAh ZGVmaW5lZChIQVZFX1VJU0NFTkUpCi0jaWYgKF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJ UkVEID49IDEzMDAwMCkgfHwgUExBVEZPUk0oQVBQTEVUVikgfHwgUExBVEZPUk0oV0FUQ0hPUykK ICNkZWZpbmUgSEFWRV9VSVNDRU5FIDEKICNlbmRpZgotI2VuZGlmCiAKICNpZiAhZGVmaW5lZChI QVZFX0FWU1RSRUFNU0VTU0lPTikKICNkZWZpbmUgSEFWRV9BVlNUUkVBTVNFU1NJT04gMApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9Eb3dubG9hZHMvY29jb2EvRG93 bmxvYWRDb2NvYS5tbSBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvRG93bmxvYWRzL2Nv Y29hL0Rvd25sb2FkQ29jb2EubW0KaW5kZXggNDk1NjEzM2Y0YTBhMmRkY2NjMjUwYzk4NjM5NDZh OWIzZGQ4MzczNC4uYWZmMTZkYmVmNWFkMzgyM2IyOWRjYjMyMDc3Yjk0MjAyOTEwODMwYiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9Eb3dubG9hZHMvY29jb2EvRG93 bmxvYWRDb2NvYS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL0Rvd25sb2Fk cy9jb2NvYS9Eb3dubG9hZENvY29hLm1tCkBAIC00OCw4ICs0OCw4IEBAIHZvaWQgRG93bmxvYWQ6 OnJlc3VtZShjb25zdCBJUEM6OkRhdGFSZWZlcmVuY2UmIHJlc3VtZURhdGEsIGNvbnN0IFN0cmlu ZyYgcGF0aCwKICAgICBhdXRvJiBjb2NvYVNlc3Npb24gPSBzdGF0aWNfY2FzdDxOZXR3b3JrU2Vz c2lvbkNvY29hJj4oKm5ldHdvcmtTZXNzaW9uKTsKICAgICBhdXRvIG5zRGF0YSA9IGFkb3B0TlMo W1tOU0RhdGEgYWxsb2NdIGluaXRXaXRoQnl0ZXM6cmVzdW1lRGF0YS5kYXRhKCkgbGVuZ3RoOnJl c3VtZURhdGEuc2l6ZSgpXSk7CiAKLSAgICAvLyBGSVhNRTogVGhpcyBpcyBhIHRlbXBvcmFyeSB3 b3JrYXJvdW5kIGZvciA8cmRhcjovL3Byb2JsZW0vMzQ3NDUxNzE+LgotI2lmIChQTEFURk9STShJ T1NfRkFNSUxZKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMjAwMDAp IHx8IChQTEFURk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0g MTAxNDAwKQorICAgIC8vIEZJWE1FOiBUaGlzIGlzIGEgdGVtcG9yYXJ5IHdvcmthcm91bmQgZm9y IDxyZGFyOi8vcHJvYmxlbS8zNDc0NTE3MT4uIEZpeGVkIGluIGlPUyAxMyBhbmQgbWFjT1MgMTAu MTUsIGJ1dCB3ZSBzdGlsbCBuZWVkIHRvIHN1cHBvcnQgbWFjT1MgMTAuMTQgZm9yIG5vdy4KKyNp ZiBQTEFURk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAx NDAwICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPCAxMDE1MDAKICAgICBzdGF0 aWMgTlNTZXQ8Q2xhc3M+ICpwbGlzdENsYXNzZXMgPSBuaWw7CiAgICAgc3RhdGljIGRpc3BhdGNo X29uY2VfdCBvbmNlVG9rZW47CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xz L0NoYW5nZUxvZwppbmRleCAwNDdlMjQwYWEwYzk0Yjg1ZTBjZjcxZDcyY2Y5YjllOTk4NDU1ZmQz Li5lYTM3NWZiYzg3ZDlmNDBiZjY2YWUzMzRiMTZmOTVhNjczNWEzZmQ5IDEwMDY0NAotLS0gYS9U b29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIw MTktMDktMTggIEtlaXRoIFJvbGxpbiAgPGtyb2xsaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJl bW92ZSBzb21lIHN1cHBvcnQgZm9yIDwgaU9TIDEzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDE5NzMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU1 NTA2OTY2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFJlbW92ZSBzb21lIHN1cHBvcnQgZm9yIGlPUyB2ZXJzaW9ucyBsZXNzIHRoYW4gMTMuMC4KKwor ICAgICAgICBVcGRhdGUgY29uZGl0aW9uYWxzIHRoYXQgcmVmZXJlbmNlIF9fSVBIT05FX09TX1ZF UlNJT05fTUlOX1JFUVVJUkVECisgICAgICAgIGFuZCBfX0lQSE9ORV9PU19WRVJTSU9OX01BWF9B TExPV0VELCBhc3N1bWluZyB0aGF0IHRoZXkgYm90aCBoYXZlCisgICAgICAgIHZhbHVlcyA+PSAx MzAwMDAuIFRoaXMgbWVhbnMgdGhhdCBleHByZXNzaW9ucyBsaWtlCisgICAgICAgICJfX0lQSE9O RV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA8IDEwMTMwMCIgYXJlIGFsd2F5cyBGYWxzZSBhbmQK KyAgICAgICAgIl9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTMwMCIgYXJl IGFsd2F5cyBUcnVlLgorCisgICAgICAgIFRoaXMgcmVtb3ZhbCBpcyBwYXJ0IG9mIGEgc2VyaWVz IG9mIHBhdGNoZXMgZWZmZWN0aW5nIHRoZSByZW1vdmFsIG9mCisgICAgICAgIGRlYWQgY29kZSBm b3Igb2xkIHZlcnNpb25zIG9mIGlPUy4gVGhpcyBwYXJ0aWN1bGFyIHBhc3MgaW52b2x2ZXMKKyAg ICAgICAgY2hhbmdlcyBpbiB3aGljaCBDaHJpcyBEdW1leiB3YXMgaW52b2x2ZWQuIFRoZXNlIGNo YW5nZXMgYXJlIGlzb2xhdGVkCisgICAgICAgIGZyb20gb3RoZXIgc2ltaWxhciBjaGFuZ2VzIGlu IG9yZGVyIHRvIGZhY2lsaXRhdGUgdGhlIHJldmlld2luZworICAgICAgICBwcm9jZXNzLgorCisg ICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Qcm9jZXNzU3dhcE9uTmF2 aWdhdGlvbi5tbToKKwogMjAxOS0wOS0xOCAgS2VpdGggUm9sbGluICA8a3JvbGxpbkBhcHBsZS5j b20+CiAKICAgICAgICAgUmVtb3ZlIHNvbWUgc3VwcG9ydCBmb3IgPCBpT1MgMTMKZGlmZiAtLWdp dCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvUHJvY2Vzc1N3YXBPbk5h dmlnYXRpb24ubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1Byb2Nl c3NTd2FwT25OYXZpZ2F0aW9uLm1tCmluZGV4IDEwMGU5YmNmYmNjMTNkZjliNDNmMzdlYTJlYTE5 ZWQ0MjlmOWVlOWEuLjQ1YmIwYTAyMTNmZjgxNDcxYjlkMDcxYWI4NTM2YWEyYWJkYmE5OWEgMTAw NjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvUHJvY2Vzc1N3 YXBPbk5hdmlnYXRpb24ubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRD b2NvYS9Qcm9jZXNzU3dhcE9uTmF2aWdhdGlvbi5tbQpAQCAtNjksNyArNjksNyBAQCBzdGF0aWMg Ym9vbCBkaWRDcmVhdGVXZWJWaWV3Owogc3RhdGljIGludCBudW1iZXJPZkRlY2lkZVBvbGljeUNh bGxzOwogc3RhdGljIGJvb2wgZGlkUmVwb25kVG9Qb2xpY3lEZWNpc2lvbkNhbGw7CiAKLSNpZiBQ TEFURk9STShJT1MpICYmIF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDExMDAw MAorI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpCiBzdGF0aWMgYm9vbCByZXF1ZXN0ZWRRdWlja0xv b2tQYXNzd29yZDsKIHN0YXRpYyBib29sIGRpZFN0YXJ0UXVpY2tMb29rTG9hZDsKIHN0YXRpYyBi b29sIGRpZEZpbmlzaFF1aWNrTG9va0xvYWQ7CkBAIC0xNzksNyArMTc5LDcgQEAgLSAodm9pZClf d2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldyBkaWRQZXJmb3JtQ2xpZW50UmVkaXJlY3RGcm9t VVJMOihOU1VSTCAqKXMKICAgICBkaWRQZXJmb3JtQ2xpZW50UmVkaXJlY3QgPSB0cnVlOwogfQog Ci0jaWYgUExBVEZPUk0oSU9TKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+ PSAxMTAwMDAKKyNpZiBQTEFURk9STShJT1NfRkFNSUxZKQogCiAtICh2b2lkKV93ZWJWaWV3RGlk UmVxdWVzdFBhc3N3b3JkRm9yUXVpY2tMb29rRG9jdW1lbnQ6KFdLV2ViVmlldyAqKXdlYlZpZXcK IHsK