201893 2019-09-17 19:46:39 -0700 REGRESSION (r247566): Leak of UICTFontDescriptor in WebCore::FontDatabase::InstalledFont::InstalledFont() 2019-09-18 04:30:24 -0700 1 1 1 Unclassified WebKit Text WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=199769 InRadar P2 Normal --- 1 ddkilzer ddkilzer bfulgham commit-queue joepeck mmaxfield webkit-bug-importer youennf oldest_to_newest 1571778 0 ddkilzer 2019-09-17 19:46:39 -0700 Leak of UICTFontDescriptor in WebCore::FontDatabase::InstalledFont::InstalledFont(): struct InstalledFont { InstalledFont() = default; InstalledFont(CTFontDescriptorRef fontDescriptor, AllowUserInstalledFonts allowUserInstalledFonts) : fontDescriptor(fontDescriptor) , capabilities(capabilitiesForFontDescriptor(fontDescriptor)) { #if HAVE(CTFONTCREATEFORCHARACTERSWITHLANGUAGEANDOPTION) UNUSED_PARAM(allowUserInstalledFonts); #else if (allowUserInstalledFonts != AllowUserInstalledFonts::No) return; auto attributes = adoptCF(CFDictionaryCreateMutable(kCFAllocatorDefault, 0, &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks)); addAttributesForInstalledFonts(attributes.get(), allowUserInstalledFonts); this->fontDescriptor = CTFontDescriptorCreateCopyWithAttributes(fontDescriptor, attributes.get()); // LEAK of CTFontDescriptorRef. Missing adoptCF(). #endif } RetainPtr<CTFontDescriptorRef> fontDescriptor; FontSelectionCapabilities capabilities; }; Regressed in: Bug 199769: Make sure to set kCTFontFallbackOptionAttribute to kCTFontFallbackOptionSystem for system fonts <https://bugs.webkit.org/show_bug.cgi?id=199769> <https://trac.webkit.org/changeset/247566/webkit> 1571779 1 ddkilzer 2019-09-17 19:46:52 -0700 <rdar://problem/55464115> 1571782 2 379014 ddkilzer 2019-09-17 19:52:13 -0700 Created attachment 379014 Patch v1 1571791 3 379014 bfulgham 2019-09-17 20:26:40 -0700 Comment on attachment 379014 Patch v1 r=me 1571878 4 379014 commit-queue 2019-09-18 04:30:23 -0700 Comment on attachment 379014 Patch v1 Clearing flags on attachment: 379014 Committed r250031: <https://trac.webkit.org/changeset/250031> 1571879 5 commit-queue 2019-09-18 04:30:24 -0700 All reviewed patches have been landed. Closing bug. 379014 2019-09-17 19:52:13 -0700 2019-09-18 04:30:23 -0700 Patch v1 bug-201893-20190917195213.patch text/plain 1767 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5OTUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2MxZDM4NzhiN2Q2ZGFi M2ZhOTgzMTk1NjE0ZTMzNDY4NWViNGViYy4uYTEzZDI3NjQ0NjgxNTE4OGViMTA3MTgyMzVkN2Nh YTMxM2Q1M2Y2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA5LTE3ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI0 NzU2Nik6IExlYWsgb2YgVUlDVEZvbnREZXNjcmlwdG9yIGluIFdlYkNvcmU6OkZvbnREYXRhYmFz ZTo6SW5zdGFsbGVkRm9udDo6SW5zdGFsbGVkRm9udCgpCisgICAgICAgIDxodHRwczovL3dlYmtp dC5vcmcvYi8yMDE4OTM+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NTQ2NDExNT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL2NvY29hL0ZvbnRDYWNoZUNvcmVUZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZv bnREYXRhYmFzZTo6SW5zdGFsbGVkRm9udDo6SW5zdGFsbGVkRm9udCk6IFVzZQorICAgICAgICBh ZG9wdENGKCkgdG8gZml4IHRoZSBsZWFrLgorCiAyMDE5LTA5LTE3ICBKaWV3ZW4gVGFuICA8amll d2VuX3RhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW1dlYkF1dGhuXSBVc2UgV2ViUHJlZmVyZW5j ZXMgaW5zdGVhZCBvZiBSdW50aW1lRW5hYmxlZEZlYXR1cmVzIGluIFVJUHJvY2VzcwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvRm9udENhY2hlQ29y ZVRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvRm9udENh Y2hlQ29yZVRleHQuY3BwCmluZGV4IGZmN2ZjNjYzNjhiZDJjNjYwYzQ4YzEwNjc0NWY5YmE4OWIz ZGRmNTEuLjU1YmI2YmFkZGIwNDZmYTlhMmMwMTI2ZjY2OTgzMTcwMjJkM2Y4YzkgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0ZvbnRDYWNoZUNvcmVU ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9Gb250 Q2FjaGVDb3JlVGV4dC5jcHAKQEAgLTg5NSw3ICs4OTUsNyBAQCBwdWJsaWM6CiAgICAgICAgICAg ICAgICAgcmV0dXJuOwogICAgICAgICAgICAgYXV0byBhdHRyaWJ1dGVzID0gYWRvcHRDRihDRkRp Y3Rpb25hcnlDcmVhdGVNdXRhYmxlKGtDRkFsbG9jYXRvckRlZmF1bHQsIDAsICZrQ0ZUeXBlRGlj dGlvbmFyeUtleUNhbGxCYWNrcywgJmtDRlR5cGVEaWN0aW9uYXJ5VmFsdWVDYWxsQmFja3MpKTsK ICAgICAgICAgICAgIGFkZEF0dHJpYnV0ZXNGb3JJbnN0YWxsZWRGb250cyhhdHRyaWJ1dGVzLmdl dCgpLCBhbGxvd1VzZXJJbnN0YWxsZWRGb250cyk7Ci0gICAgICAgICAgICB0aGlzLT5mb250RGVz Y3JpcHRvciA9IENURm9udERlc2NyaXB0b3JDcmVhdGVDb3B5V2l0aEF0dHJpYnV0ZXMoZm9udERl c2NyaXB0b3IsIGF0dHJpYnV0ZXMuZ2V0KCkpOworICAgICAgICAgICAgdGhpcy0+Zm9udERlc2Ny aXB0b3IgPSBhZG9wdENGKENURm9udERlc2NyaXB0b3JDcmVhdGVDb3B5V2l0aEF0dHJpYnV0ZXMo Zm9udERlc2NyaXB0b3IsIGF0dHJpYnV0ZXMuZ2V0KCkpKTsKICNlbmRpZgogICAgICAgICB9CiAK