201873 2019-09-17 09:45:25 -0700 run-webkit-tests: Driver.do_post_tests_work() is never called when `stop_when_done` is true in Driver.run_test() 2019-09-17 10:50:35 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=193772 InRadar P2 Normal --- 1 ddkilzer ddkilzer commit-queue ews-watchlist glenn jbedard joepeck rniwa simon.fraser webkit-bug-importer oldest_to_newest 1571568 0 ddkilzer 2019-09-17 09:45:25 -0700 Driver.do_post_tests_work() is never called when `stop_when_done` is true in Driver.run_test() in run-webkit-tests. This breaks traditional leaks checking (added in Bug 193772) and document leak checking at the end of each testing shard. (This regressed sometime after the fix for Bug 193772 was landed. I think it was related to fixing test timeouts on bots.) 1571569 1 webkit-bug-importer 2019-09-17 09:45:54 -0700 <rdar://problem/55442387> 1571571 2 378971 ddkilzer 2019-09-17 09:47:50 -0700 Created attachment 378971 Patch v1 1571592 3 378971 commit-queue 2019-09-17 10:50:33 -0700 Comment on attachment 378971 Patch v1 Clearing flags on attachment: 378971 Committed r249965: <https://trac.webkit.org/changeset/249965> 1571593 4 commit-queue 2019-09-17 10:50:35 -0700 All reviewed patches have been landed. Closing bug. 378971 2019-09-17 09:47:50 -0700 2019-09-17 10:50:33 -0700 Patch v1 bug-201873-20190917094930.patch text/plain 1623 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5OTUwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDMzZWJiODViZjY3MTQ4YjY5YTFiNDZiZjI3Y2QwNWEx NWIzYzAyYi4uMGY4NjUzZGFjMjRlZGQyNjg3YjJjMWVjZGJjNmYyNmNhODdhNTQwOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE5LTA5LTE3ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgcnVuLXdlYmtpdC10ZXN0czogRHJpdmVyLmRvX3Bvc3RfdGVzdHNfd29yaygpIGlzIG5l dmVyIGNhbGxlZCB3aGVuIGBzdG9wX3doZW5fZG9uZWAgaXMgdHJ1ZSBpbiBEcml2ZXIucnVuX3Rl c3QoKQorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMjAxODczPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9w b3J0L2RyaXZlci5weToKKyAgICAgICAgKERyaXZlci5ydW5fdGVzdCk6IENhbGwgc2VsZi5kb19w b3N0X3Rlc3RzX3dvcmsoKSB3aGVuIGEgdGVzdAorICAgICAgICBzaGFyZCBoYXMgY29tcGxldGVk LCBidXQgZGlkbid0IGNyYXNoIG9yIHRpbWUgb3V0LgorCiAyMDE5LTA5LTE3ICBEZWFuIEphY2tz b24gIDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgdGhlICJTaG93IExpbmsgUHJl dmlld3MiIGFuZCAiSGlkZSBMaW5rIFByZXZpZXdzIiBhY3Rpb24gbWVudXMgaW4gdGhlIHByZXZp ZXcgcGxhdHRlcgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2RyaXZl ci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9kcml2ZXIucHkKaW5kZXggMWIxZDJk YzNkZWZjMjJkYjA3Mjc2NmM2OTg1OTZiMDc5N2U1NmM2Yi4uMmE1OTgzOGJlZTAwN2ZkOGQwYWI2 OGM5Yjk5YjRmZTM1OWNlYjEwZCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9w b3J0L2RyaXZlci5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZHJpdmVyLnB5 CkBAIC0yMjEsNiArMjIxLDggQEAgY2xhc3MgRHJpdmVyKG9iamVjdCk6CiAgICAgICAgIHBpZCA9 IHNlbGYuX3NlcnZlcl9wcm9jZXNzLnBpZCgpCiAKICAgICAgICAgaWYgc3RvcF93aGVuX2RvbmUg b3IgY3Jhc2hlZCBvciB0aW1lZF9vdXQ6CisgICAgICAgICAgICBpZiBzdG9wX3doZW5fZG9uZSBh bmQgbm90IChjcmFzaGVkIG9yIHRpbWVkX291dCk6CisgICAgICAgICAgICAgICAgc2VsZi5kb19w b3N0X3Rlc3RzX3dvcmsoKQogICAgICAgICAgICAgIyBXZSBjYWxsIHN0b3AoKSBldmVuIGlmIHdl IGNyYXNoZWQgb3IgdGltZWQgb3V0IGluIG9yZGVyIHRvIGdldCBhbnkgcmVtYWluaW5nIHN0ZG91 dC9zdGRlcnIgb3V0cHV0LgogICAgICAgICAgICAgIyBJbiB0aGUgdGltZW91dCBjYXNlLCB3ZSBr aWxsIHRoZSBodW5nIHByb2Nlc3MgYXMgd2VsbC4KICAgICAgICAgICAgIG91dCwgZXJyID0gc2Vs Zi5fc2VydmVyX3Byb2Nlc3Muc3RvcChzZWxmLl9wb3J0LmRyaXZlcl9zdG9wX3RpbWVvdXQoKSBp ZiBzdG9wX3doZW5fZG9uZSBlbHNlIDAuMCkK