201845 2019-09-16 15:05:50 -0700 [WebAuthn] Name instance variables consistently in WKMockNFTag 2019-09-16 18:26:07 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=201813 https://bugs.webkit.org/show_bug.cgi?id=201839 InRadar P2 Normal --- 1 ddkilzer ddkilzer bfulgham commit-queue jiewen_tan krollin webkit-bug-importer oldest_to_newest 1571286 0 ddkilzer 2019-09-16 15:05:50 -0700 Name instance variables consistently in WKMockNFTag. Bug 201813 and Bug 201839 fixed leaks by releasing instance variables in -dealloc, but the result is that only some synthesized instance variables have leading underscores in their names. This bug tracks making all of the instance variables use the same naming convention. 1571287 1 webkit-bug-importer 2019-09-16 15:06:07 -0700 <rdar://problem/55416240> 1571288 2 378899 ddkilzer 2019-09-16 15:08:00 -0700 Created attachment 378899 Patch v1 1571295 3 378899 jiewen_tan 2019-09-16 15:44:12 -0700 Comment on attachment 378899 Patch v1 LGTM. r=me. 1571371 4 378899 commit-queue 2019-09-16 18:26:05 -0700 Comment on attachment 378899 Patch v1 Clearing flags on attachment: 378899 Committed r249934: <https://trac.webkit.org/changeset/249934> 1571372 5 commit-queue 2019-09-16 18:26:07 -0700 All reviewed patches have been landed. Closing bug. 378899 2019-09-16 15:08:00 -0700 2019-09-16 18:26:05 -0700 Patch v1 bug-201845-20190916150935.patch text/plain 1727 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5OTE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDlkYmY1ZDFmYzliYjVjNjIw MGZjNTNlNjg5MjdkYTZjOTI5ZjcwMDguLmZhOTNiM2M0YmUwNzBjZmZmYzk3OWIzYzg0NjE1NTE5 YmUyYzBmZGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDktMTYgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViQXV0aG5dIE5hbWUgaW5z dGFuY2UgdmFyaWFibGVzIGNvbnNpc3RlbnRseSBpbiBXS01vY2tORlRhZworICAgICAgICA8aHR0 cHM6Ly93ZWJraXQub3JnL2IvMjAxODQ1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9uL01vY2svTW9j a05mY1NlcnZpY2UubW06CisgICAgICAgIE1ha2UgYWxsIEBzeW50aGVzaXplIGluc3RhbmNlIHZh cmlhYmxlcyB1c2UgYSBsZWFkaW5nIHVuZGVyc2NvcmUKKyAgICAgICAgZm9yIHRoZWlyIG5hbWUu CisKIDIwMTktMDktMTYgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAg ICAgICBGaXggYnVpbGQgZmFpbHVyZSBpbiBNb2NrTmZjU2VydmljZS5tbQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vTW9jay9Nb2NrTmZjU2Vy dmljZS5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9uL01vY2sv TW9ja05mY1NlcnZpY2UubW0KaW5kZXggMzI1OTQxODJkNGYyMjhlMTdiYzhjY2VkOGI4YjFkNDFl NDYzNDRiZC4uY2EzZGUyMTAyMmIzYTM5MTI3ODBiYTA3MWIxZmRkNjQ2ZGM5YmE0YSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vTW9jay9Nb2Nr TmZjU2VydmljZS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJBdXRoZW50aWNh dGlvbi9Nb2NrL01vY2tOZmNTZXJ2aWNlLm1tCkBAIC01MCwxNiArNTAsMTYgQEAgQGltcGxlbWVu dGF0aW9uIFdLTW9ja05GVGFnIHsKICAgICBORlRhZ1R5cGUgX3R5cGU7CiB9CiAKLUBzeW50aGVz aXplIHRlY2hub2xvZ3k7CitAc3ludGhlc2l6ZSB0ZWNobm9sb2d5PV90ZWNobm9sb2d5OwogQHN5 bnRoZXNpemUgdGFnSUQ9X3RhZ0lEOwogQHN5bnRoZXNpemUgQXBwRGF0YT1fQXBwRGF0YTsKIEBz eW50aGVzaXplIFVJRD1fVUlEOwotQHN5bnRoZXNpemUgbmRlZkF2YWlsYWJpbGl0eTsKLUBzeW50 aGVzaXplIG5kZWZNZXNzYWdlU2l6ZTsKLUBzeW50aGVzaXplIG5kZWZDb250YWluZXJTaXplOwot QHN5bnRoZXNpemUgdGFnQTsKLUBzeW50aGVzaXplIHRhZ0I7Ci1Ac3ludGhlc2l6ZSB0YWdGOwor QHN5bnRoZXNpemUgbmRlZkF2YWlsYWJpbGl0eT1fbmRlZkF2YWlsYWJpbGl0eTsKK0BzeW50aGVz aXplIG5kZWZNZXNzYWdlU2l6ZT1fbmRlZk1lc3NhZ2VTaXplOworQHN5bnRoZXNpemUgbmRlZkNv bnRhaW5lclNpemU9X25kZWZDb250YWluZXJTaXplOworQHN5bnRoZXNpemUgdGFnQT1fdGFnQTsK K0BzeW50aGVzaXplIHRhZ0I9X3RhZ0I7CitAc3ludGhlc2l6ZSB0YWdGPV90YWdGOwogCiAtIChO RlRhZ1R5cGUpdHlwZQogewo=