201813 2019-09-15 22:14:13 -0700 [WebAuthn] REGRESSION (r249059): Leak of WKMockNFTag objects and WKMockNFTag instance variables 2019-09-16 15:05:50 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=188624 https://bugs.webkit.org/show_bug.cgi?id=201839 https://bugs.webkit.org/show_bug.cgi?id=201845 InRadar P2 Normal --- 1 ddkilzer ddkilzer alex.gaynor bfulgham cdumez commit-queue darin jiewen_tan webkit-bug-importer oldest_to_newest 1571009 0 ddkilzer 2019-09-15 22:14:13 -0700 Leak of WKMockNFTag instances (missing -release) and WKMockNFTag instance variables (missing -dealloc). Regressed with: Bug 188624: [WebAuthn] Support NFC authenticators for iOS <https://bugs.webkit.org/show_bug.cgi?id=188624> <https://trac.webkit.org/changeset/249059/webkit> 1571010 1 webkit-bug-importer 2019-09-15 22:14:24 -0700 <rdar://problem/55387597> 1571011 2 378839 ddkilzer 2019-09-15 22:19:06 -0700 Created attachment 378839 Patch v1 1571188 3 378839 commit-queue 2019-09-16 11:29:56 -0700 Comment on attachment 378839 Patch v1 Clearing flags on attachment: 378839 Committed r249907: <https://trac.webkit.org/changeset/249907> 1571189 4 commit-queue 2019-09-16 11:29:57 -0700 All reviewed patches have been landed. Closing bug. 378839 2019-09-15 22:19:06 -0700 2019-09-16 11:29:56 -0700 Patch v1 bug-201813-20190915222037.patch text/plain 2839 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5ODUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU5NzdmMTdhN2M2NzhhNWI1 NTE2YmM3ODVmMDI4MWYxNzg5ZTQ5MzkuLjhlMjJkMGJhNzU2MjgzM2Y4ZjQzMmIwYTA4M2ZkOTMx YmMxNTE0ODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDktMTUgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViQXV0aG5dIFJFR1JFU1NJ T04gKHIyNDkwNTkpOiBMZWFrIG9mIFdLTW9ja05GVGFnIG9iamVjdHMgYW5kIFdLTW9ja05GVGFn IGluc3RhbmNlIHZhcmlhYmxlcworICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMjAxODEz PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQ cm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9uL01vY2svTW9ja05mY1NlcnZpY2UubW06CisgICAgICAg ICgtW1dLTW9ja05GVGFnIGRlYWxsb2NdKTogQWRkIG1ldGhvZCBhbmQgcmVsZWFzZSBpbnN0YW5j ZQorICAgICAgICB2YXJpYWJsZXMgdG8gZml4IGxlYWtzLgorICAgICAgICAoV2ViS2l0OjpNb2Nr TmZjU2VydmljZTo6ZGV0ZWN0VGFncyBjb25zdCk6IFVzZSBhZG9wdE5TKCkgdG8gZml4CisgICAg ICAgIGxlYWtzIG9mIFdLTW9ja05GVGFnIG9iamVjdHMuCisKIDIwMTktMDktMTUgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMjQzMTEz KTogTGVhayBvZiBtdWx0aXBsZSBpbnN0YW5jZSB2YXJpYWJsZSBibG9ja3Mgd2hlbiBkZWFsbG9j YXRpbmcgX1dLQXR0cmlidXRlZFN0cmluZ05hdmlnYXRpb25EZWxlZ2F0ZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vTW9jay9Nb2NrTmZjU2Vy dmljZS5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9uL01vY2sv TW9ja05mY1NlcnZpY2UubW0KaW5kZXggNGZmMjk2NjkyNTVhMTMxNzMyMWQ4Y2NmYmUxZjYwNDcz ZWUzMzc0YS4uODlkNjNlMDgyYWI3MzlhMDg5MGYyNTcwMjhjZDUzMDIyM2JhOGFjZCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vTW9jay9Nb2Nr TmZjU2VydmljZS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJBdXRoZW50aWNh dGlvbi9Nb2NrL01vY2tOZmNTZXJ2aWNlLm1tCkBAIC0zMiw2ICszMiw3IEBACiAjaW1wb3J0ICJO ZmNDb25uZWN0aW9uLmgiCiAjaW1wb3J0IDxXZWJDb3JlL0ZpZG9Db25zdGFudHMuaD4KICNpbXBv cnQgPHd0Zi9CbG9ja1B0ci5oPgorI2ltcG9ydCA8d3RmL1JldGFpblB0ci5oPgogI2ltcG9ydCA8 d3RmL1J1bkxvb3AuaD4KICNpbXBvcnQgPHd0Zi9WZWN0b3IuaD4KIApAQCAtNzIsNiArNzMsMTgg QEAgLSAoaW5zdGFuY2V0eXBlKWluaXRXaXRoTkZUYWc6KGlkPE5GVGFnPil0YWcKICAgICByZXR1 cm4gc2VsZjsKIH0KIAorLSAodm9pZClkZWFsbG9jCit7CisgICAgW190YWdJRCByZWxlYXNlXTsK KyAgICBfdGFnSUQgPSBuaWw7CisgICAgW19BcHBEYXRhIHJlbGVhc2VdOworICAgIF9BcHBEYXRh ID0gbmlsOworICAgIFtfVUlEIHJlbGVhc2VdOworICAgIF9VSUQgPSBuaWw7CisKKyAgICBbc3Vw ZXIgZGVhbGxvY107Cit9CisKIC0gKE5TU3RyaW5nKilkZXNjcmlwdGlvbgogewogICAgIHJldHVy biBuaWw7CkBAIC0xODcsMTIgKzIwMCwxMiBAQCB2b2lkIE1vY2tOZmNTZXJ2aWNlOjpkZXRlY3RU YWdzKCkgY29uc3QKICAgICBhdXRvIGNhbGxiYWNrID0gbWFrZUJsb2NrUHRyKFtjb25maWd1cmF0 aW9uID0gbV9jb25maWd1cmF0aW9uXSB7CiAgICAgICAgIGF1dG8gdGFncyA9IGFkb3B0TlMoW1tO U011dGFibGVBcnJheSBhbGxvY10gaW5pdF0pOwogICAgICAgICBpZiAoY29uZmlndXJhdGlvbi5u ZmMtPmVycm9yID09IE1vY2tOZmM6OkVycm9yOjpXcm9uZ1RhZ1R5cGUgfHwgY29uZmlndXJhdGlv bi5uZmMtPm11bHRpcGxlVGFncykKLSAgICAgICAgICAgIFt0YWdzIGFkZE9iamVjdDpbW1dLTW9j a05GVGFnIGFsbG9jXSBpbml0V2l0aFR5cGU6TkZUYWdUeXBlVW5rbm93bl1dOworICAgICAgICAg ICAgW3RhZ3MgYWRkT2JqZWN0OmFkb3B0TlMoW1tXS01vY2tORlRhZyBhbGxvY10gaW5pdFdpdGhU eXBlOk5GVGFnVHlwZVVua25vd25dKS5nZXQoKV07CiAgICAgICAgIGVsc2UKLSAgICAgICAgICAg IFt0YWdzIGFkZE9iamVjdDpbW1dLTW9ja05GVGFnIGFsbG9jXSBpbml0V2l0aFR5cGU6TkZUYWdU eXBlR2VuZXJpYzRBXV07CisgICAgICAgICAgICBbdGFncyBhZGRPYmplY3Q6YWRvcHROUyhbW1dL TW9ja05GVGFnIGFsbG9jXSBpbml0V2l0aFR5cGU6TkZUYWdUeXBlR2VuZXJpYzRBXSkuZ2V0KCld OwogCiAgICAgICAgIGlmIChjb25maWd1cmF0aW9uLm5mYy0+bXVsdGlwbGVUYWdzKQotICAgICAg ICAgICAgW3RhZ3MgYWRkT2JqZWN0OltbV0tNb2NrTkZUYWcgYWxsb2NdIGluaXRXaXRoVHlwZTpO RlRhZ1R5cGVHZW5lcmljNEFdXTsKKyAgICAgICAgICAgIFt0YWdzIGFkZE9iamVjdDphZG9wdE5T KFtbV0tNb2NrTkZUYWcgYWxsb2NdIGluaXRXaXRoVHlwZTpORlRhZ1R5cGVHZW5lcmljNEFdKS5n ZXQoKV07CiAKICAgICAgICAgW2dsb2JhbE5GUmVhZGVyU2Vzc2lvbkRlbGVnYXRlIHJlYWRlclNl c3Npb246bmlsIGRpZERldGVjdFRhZ3M6dGFncy5nZXQoKV07CiAgICAgfSk7Cg==