201785 2019-09-13 17:26:02 -0700 Remove commit.h copying build steps 2020-03-11 14:44:27 -0700 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 201156 198948 1 jdarpinian jdarpinian achristensen annulen commit-queue dino ews-watchlist graouts gyuyoung.kim kbr kondapallykalyan rakuco ryuan.choi sergio webkit-bug-importer oldest_to_newest 1570773 0 jdarpinian 2019-09-13 17:26:02 -0700 Remove commit.h copying build steps 1570775 1 378767 jdarpinian 2019-09-13 17:27:35 -0700 Created attachment 378767 Remove commit.h copying build steps 1570776 2 ews-watchlist 2019-09-13 17:28:08 -0700 Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE 1570777 3 jdarpinian 2019-09-13 17:36:46 -0700 Following up after my ANGLE update change. On an unrelated note, I don't have permission to update the wiki page. After my recent changes to ANGLE most of the steps are obsolete (3, 4, 5, 6) or can be performed automatically by the update-angle.sh script (1, 2). Can you update it? http://trac.webkit.org/wiki/UpdatingANGLE 1571047 4 378767 commit-queue 2019-09-16 01:46:52 -0700 Comment on attachment 378767 Remove commit.h copying build steps Clearing flags on attachment: 378767 Committed r249892: <https://trac.webkit.org/changeset/249892> 1571048 5 commit-queue 2019-09-16 01:46:54 -0700 All reviewed patches have been landed. Closing bug. 1571049 6 webkit-bug-importer 2019-09-16 01:47:29 -0700 <rdar://problem/55391834> 1571050 7 webkit-bug-importer 2019-09-16 01:47:30 -0700 <rdar://problem/55391835> 378767 2019-09-13 17:27:35 -0700 2019-09-16 01:46:52 -0700 Remove commit.h copying build steps bug-201785-20190913172734.patch text/plain 7101 jdarpinian U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5ODYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggMjdiODJmY2MwZjJmYmY0ZDQyNmQwNDQ4MTMxMmIxMGUyNjRiYjA1OS4uMzQzMmNhMDdiNGJm NjZhN2Y2MThmZGU1ODQzMDY1ZWQ0MjNmMmRjYyAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA5LTEzICBKYW1lcyBEYXJwaW5pYW4gIDxqZGFycGlu aWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgY29tbWl0LmggY29weWluZyBidWls ZCBzdGVwcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjAxNzg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBBTkdMRS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qOiBSZW1vdmUgbGVmdG92ZXIgYnVpbGQg c3RlcAorICAgICAgICAqIENNYWtlTGlzdHMudHh0OiBSZW1vdmUgY29tbWl0LmggY29weWluZwor ICAgICAgICAqIHNyYy9jb21tb24vdmVyc2lvbi5oOiBSZXN0b3JlIHRvIHVwc3RyZWFtIHZlcnNp b24KKyAgICAgICAgKiBzcmMvaWQvY29tbWl0Lmg6IEFkZGVkLgorICAgICAgICAqIHVwZGF0ZS1h bmdsZS5zaDogQ29weSBjb21taXQuaCB0byBpZC9jb21taXQuaCBhdCBpbXBvcnQgdGltZQorCiAy MDE5LTA5LTEyICBKYW1lcyBEYXJwaW5pYW4gIDxqZGFycGluaWFuQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBVcGRhdGUgQU5HTEUKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xF L0FOR0xFLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2ogYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdM RS9BTkdMRS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCmluZGV4IDVlZjVmYTkzNjhhOWZmNDI5 ZDM4ZGYzZGIxOGJjM2RjNzg1ODczNjMuLjMwZWEzN2Y5MGMxZWE1NDQxZWJjNGM3ZGU2MzI5ZTkz MDBlNDU2MjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0FOR0xFLnhjb2Rl cHJvai9wcm9qZWN0LnBieHByb2oKKysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvQU5HTEUu eGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagpAQCAtMjg4OSw3ICsyODg5LDYgQEAKIAkJCWJ1aWxk Q29uZmlndXJhdGlvbkxpc3QgPSBGQjM5RDBENjEyMDBGMTFFMDAwODhFNjkgLyogQnVpbGQgY29u ZmlndXJhdGlvbiBsaXN0IGZvciBQQlhOYXRpdmVUYXJnZXQgIkFOR0xFIiAqLzsKIAkJCWJ1aWxk UGhhc2VzID0gKAogCQkJCUZCMzlENzdCMTIwMTExMEMwMDA4OEU2OSAvKiBIZWFkZXJzICovLAot CQkJCUEzRTgyN0FCMjMwQ0FGNzcwMEU3NjY4MiAvKiBTaGVsbFNjcmlwdCAqLywKIAkJCQlGQjM5 RDBDRTEyMDBGMEUzMDAwODhFNjkgLyogU291cmNlcyAqLywKIAkJCQlGQjM5RDBDRjEyMDBGMEUz MDAwODhFNjkgLyogRnJhbWV3b3JrcyAqLywKIAkJCQkzMTJCREIwQjE1RkVDQUIwMDA5N0VCQzcg LyogQ29weUZpbGVzICovLApAQCAtMjk1MiwyMyArMjk1MSw2IEBACiAJCQlzaGVsbFBhdGggPSAv YmluL3NoOwogCQkJc2hlbGxTY3JpcHQgPSAiaWYgWyBcIiR7WENPREVfVkVSU0lPTl9NQUpPUn1c IiAtZ2UgXCIxMTAwXCIgLWEgXCIke1VTRV9ORVdfQlVJTERfU1lTVEVNfVwiID0gXCJZRVNcIiBd OyB0aGVuXG4gICAgZXhpdCAwXG5maVxuXG5leGVjIFwiJFNSQ1JPT1QvYWRqdXN0LWFuZ2xlLWlu Y2x1ZGUtcGF0aHMuc2hcIlxuIjsKIAkJfTsKLQkJQTNFODI3QUIyMzBDQUY3NzAwRTc2NjgyIC8q IFNoZWxsU2NyaXB0ICovID0gewotCQkJaXNhID0gUEJYU2hlbGxTY3JpcHRCdWlsZFBoYXNlOwot CQkJYnVpbGRBY3Rpb25NYXNrID0gMjE0NzQ4MzY0NzsKLQkJCWZpbGVzID0gKAotCQkJKTsKLQkJ CWlucHV0RmlsZUxpc3RQYXRocyA9ICgKLQkJCSk7Ci0JCQlpbnB1dFBhdGhzID0gKAotCQkJKTsK LQkJCW91dHB1dEZpbGVMaXN0UGF0aHMgPSAoCi0JCQkpOwotCQkJb3V0cHV0UGF0aHMgPSAoCi0J CQkpOwotCQkJcnVuT25seUZvckRlcGxveW1lbnRQb3N0cHJvY2Vzc2luZyA9IDA7Ci0JCQlzaGVs bFBhdGggPSAvYmluL3NoOwotCQkJc2hlbGxTY3JpcHQgPSAibWtkaXIgLXAgXCIkREVSSVZFRF9G SUxFX0RJUi9pbmNsdWRlL2lkXCJcbiI7Ci0JCX07CiAvKiBFbmQgUEJYU2hlbGxTY3JpcHRCdWls ZFBoYXNlIHNlY3Rpb24gKi8KIAogLyogQmVnaW4gUEJYU291cmNlc0J1aWxkUGhhc2Ugc2VjdGlv biAqLwpAQCAtMzMxOCw3ICszMzAwLDYgQEAKIAkJCQkJc3JjLAogCQkJCQl0aGlyZF9wYXJ0eS9i YXNlLAogCQkJCQlzcmMvY29tbW9uL3RoaXJkX3BhcnR5L2Jhc2UsCi0JCQkJCSIkKERFUklWRURf RklMRV9ESVIpL2luY2x1ZGUiLAogCQkJCSk7CiAJCQkJT1RIRVJfQ1BMVVNQTFVTRkxBR1MgPSAi JChBU0FOX09USEVSX0NQTFVTUExVU0ZMQUdTKSI7CiAJCQl9OwpAQCAtMzM1NCw3ICszMzM1LDYg QEAKIAkJCQkJc3JjLAogCQkJCQl0aGlyZF9wYXJ0eS9iYXNlLAogCQkJCQlzcmMvY29tbW9uL3Ro aXJkX3BhcnR5L2Jhc2UsCi0JCQkJCSIkKERFUklWRURfRklMRV9ESVIpL2luY2x1ZGUiLAogCQkJ CSk7CiAJCQkJT1RIRVJfQ1BMVVNQTFVTRkxBR1MgPSAiJChBU0FOX09USEVSX0NQTFVTUExVU0ZM QUdTKSI7CiAJCQl9OwpAQCAtMzM3NSw3ICszMzU1LDYgQEAKIAkJCQkJc3JjLAogCQkJCQl0aGly ZF9wYXJ0eS9iYXNlLAogCQkJCQlzcmMvY29tbW9uL3RoaXJkX3BhcnR5L2Jhc2UsCi0JCQkJCSIk KERFUklWRURfRklMRV9ESVIpL2luY2x1ZGUiLAogCQkJCSk7CiAJCQkJT1RIRVJfQ1BMVVNQTFVT RkxBR1MgPSAiJChBU0FOX09USEVSX0NQTFVTUExVU0ZMQUdTKSI7CiAJCQl9OwpkaWZmIC0tZ2l0 IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvVGhpcmRQ YXJ0eS9BTkdMRS9DTWFrZUxpc3RzLnR4dAppbmRleCAyNjdhNWJjODk3Mzk4NDUzMWY5YmM0YjBl MzA4NWE1M2Y4YWY5MDU1Li5hYjY5MDJhOTVkMTMwMTg0ODY0Mjg3N2ZkYTBiMTk5MWI5MmVjZTQ4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DTWFrZUxpc3RzLnR4dAorKysg Yi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DTWFrZUxpc3RzLnR4dApAQCAtNTgsNyArNTgsNiBA QCBzZXQoQU5HTEVfU09VUkNFUwogICAgICR7YW5nbGVfdHJhbnNsYXRvcl9nbHNsX3NvdXJjZXN9 CiAgICAgJHthbmdsZV90cmFuc2xhdG9yX3NvdXJjZXN9CiAgICAgJHtsaWJhbmdsZV9jYXB0dXJl X3NvdXJjZXN9Ci0gICAgJHtDTUFLRV9DVVJSRU5UX0JJTkFSWV9ESVJ9L2luY2x1ZGUvaWQvY29t bWl0LmgKICkKIAogaWYgKFVOSVgpCkBAIC04NSw4ICs4NCw2IEBAIGFkZF9zdWJkaXJlY3Rvcnko aW5jbHVkZSkKIGFkZF9saWJyYXJ5KEFOR0xFRnJhbWV3b3JrIElOVEVSRkFDRSkKIGFkZF9kZXBl bmRlbmNpZXMoQU5HTEVGcmFtZXdvcmsgR0xTTEFOR0hlYWRlcnMgQU5HTEVIZWFkZXJzKQogCi1j b25maWd1cmVfZmlsZShzcmMvY29tbWl0LmggJHtDTUFLRV9DVVJSRU5UX0JJTkFSWV9ESVJ9L2lu Y2x1ZGUvaWQvY29tbWl0LmggQ09QWU9OTFkpCi0KIGlmIChVU0VfQU5HTEVfRUdMKQogICAgIGFk ZF9saWJyYXJ5KEFOR0xFIFNUQVRJQwogICAgICAgICAke0FOR0xFX1NPVVJDRVN9CkBAIC0xMDMs NyArMTAwLDYgQEAgaWYgKFVTRV9BTkdMRV9FR0wpCiAKICAgICBhZGRfbGlicmFyeShHTEVTdjIg U0hBUkVECiAgICAgICAgICR7bGliZ2xlc3YyX3NvdXJjZXN9Ci0gICAgICAgICR7Q01BS0VfQ1VS UkVOVF9CSU5BUllfRElSfS9pbmNsdWRlL2lkL2NvbW1pdC5oCiAgICAgKQogICAgIHRhcmdldF9p bmNsdWRlX2RpcmVjdG9yaWVzKEdMRVN2MiBQUklWQVRFICR7QU5HTEVfUFJJVkFURV9JTkNMVURF X0RJUkVDVE9SSUVTfSkKICAgICB0YXJnZXRfY29tcGlsZV9kZWZpbml0aW9ucyhHTEVTdjIgUFJJ VkFURSBMSUJHTEVTVjJfSU1QTEVNRU5UQVRJT04pCkBAIC0xMTEsNyArMTA3LDYgQEAgaWYgKFVT RV9BTkdMRV9FR0wpCiAKICAgICBhZGRfbGlicmFyeShFR0wgU0hBUkVECiAgICAgICAgICR7bGli ZWdsX3NvdXJjZXN9Ci0gICAgICAgICR7Q01BS0VfQ1VSUkVOVF9CSU5BUllfRElSfS9pbmNsdWRl L2lkL2NvbW1pdC5oCiAgICAgKQogICAgIHRhcmdldF9pbmNsdWRlX2RpcmVjdG9yaWVzKEVHTCBQ UklWQVRFICR7QU5HTEVfUFJJVkFURV9JTkNMVURFX0RJUkVDVE9SSUVTfSkKICAgICB0YXJnZXRf Y29tcGlsZV9kZWZpbml0aW9ucyhFR0wgUFJJVkFURQpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJk UGFydHkvQU5HTEUvc3JjL2NvbW1vbi92ZXJzaW9uLmggYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdM RS9zcmMvY29tbW9uL3ZlcnNpb24uaAppbmRleCAxYWEzMWZkNDZiMDI3YTUxNGI2NzIzYTAxNzM5 MDg2ZDE3MTY4NDM1Li41NmQ2YmUwOWM5MTQ4NDMxNmY4OWQ5MGUzMTU4NTZjYTFlYWVmZTZjIDEw MDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tbW9uL3ZlcnNpb24uaAor KysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tbW9uL3ZlcnNpb24uaApAQCAtNyw3 ICs3LDcgQEAKICNpZm5kZWYgQ09NTU9OX1ZFUlNJT05fSF8KICNkZWZpbmUgQ09NTU9OX1ZFUlNJ T05fSF8KIAotI2luY2x1ZGUgImNvbW1pdC5oIgorI2luY2x1ZGUgImlkL2NvbW1pdC5oIgogCiAj ZGVmaW5lIEFOR0xFX01BSk9SX1ZFUlNJT04gMgogI2RlZmluZSBBTkdMRV9NSU5PUl9WRVJTSU9O IDEKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9pZC9jb21taXQuaCBi L1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9pZC9jb21taXQuaApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5mMjFm ZjQzODdkYzgxYzU0YzVmYTEzZTM3MDIyNzEwYzE3YTk3YWMzCi0tLSAvZGV2L251bGwKKysrIGIv U291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2lkL2NvbW1pdC5oCkBAIC0wLDAgKzEsMTQgQEAK Ky8vCisvLyBDb3B5cmlnaHQgMjAxNCBUaGUgQU5HTEUgUHJvamVjdCBBdXRob3JzLiBBbGwgcmln aHRzIHJlc2VydmVkLgorLy8gVXNlIG9mIHRoaXMgc291cmNlIGNvZGUgaXMgZ292ZXJuZWQgYnkg YSBCU0Qtc3R5bGUgbGljZW5zZSB0aGF0IGNhbiBiZQorLy8gZm91bmQgaW4gdGhlIExJQ0VOU0Ug ZmlsZS4KKy8vCisvLyBjb21taXQuaDoKKy8vICAgVGhpcyBpcyBhIGRlZmF1bHQgY29tbWl0IGhh c2ggaGVhZGVyLCB3aGVuIGdpdCBpcyBub3QgYXZhaWxhYmxlLgorLy8KKworI2RlZmluZSBBTkdM RV9DT01NSVRfSEFTSCAidW5rbm93biBoYXNoIgorI2RlZmluZSBBTkdMRV9DT01NSVRfSEFTSF9T SVpFIDEyCisjZGVmaW5lIEFOR0xFX0NPTU1JVF9EQVRFICJ1bmtub3duIGRhdGUiCisKKyNkZWZp bmUgQU5HTEVfRElTQUJMRV9QUk9HUkFNX0JJTkFSWV9MT0FECmRpZmYgLS1naXQgYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9BTkdMRS91cGRhdGUtYW5nbGUuc2ggYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdM RS91cGRhdGUtYW5nbGUuc2gKaW5kZXggYjdmYmQwN2YzMDA2Y2MwMWNlNTZkNWM2ZDQ0MDQ2Yzcy YTBiNTNjYi4uM2QzZWFhYTU0N2EyNmI4M2NkZGFlNzg0YWM2ZWVhNGI4YjllZmNlYSAxMDA3NTUK LS0tIGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvdXBkYXRlLWFuZ2xlLnNoCisrKyBiL1NvdXJj ZS9UaGlyZFBhcnR5L0FOR0xFL3VwZGF0ZS1hbmdsZS5zaApAQCAtMTQsNiArMTQsOCBAQCBpZiBb WyAhICRSRVBMWSA9fiBeW1l5XSQgXV07IHRoZW4KICAgICBleGl0CiBmaQogCitQUkVWSU9VU19D T01NSVRfSEFTSD1gZ3JlcCAtbSAxIC1vIC1FICJbYS16MC05XXs0MH0iIEFOR0xFLnBsaXN0YAor CiAjIEZpcnN0LCBwcmVzZXJ2ZSBXZWJLaXQncyBhZGRpdGlvbmFsIGZpbGVzCiBURU1QRElSPWBt a3RlbXAgLWRgCiBmdW5jdGlvbiBjbGVhbnVwIHsKQEAgLTQzLDE1ICs0NSwyNSBAQCBtdiBpbmNs dWRlL0NNYWtlTGlzdHMudHh0ICIkVEVNUERJUi9pbmNsdWRlIgogIyBSZW1vdmUgYWxsIGZpbGVz IGluY2x1ZGluZyBoaWRkZW4gb25lcywgYnV0IG5vdCAuIG9yIC4uCiBybSAtcmYgLi4/KiAuWyEu XSogKgogZWNobyAiRG93bmxvYWRpbmcgbGF0ZXN0IEFOR0xFIHZpYSBnaXQgY2xvbmUuIgotZ2l0 IGNsb25lIGh0dHBzOi8vY2hyb21pdW0uZ29vZ2xlc291cmNlLmNvbS9hbmdsZS9hbmdsZSAuIC0t ZGVwdGggMQorZ2l0IGNsb25lIGh0dHBzOi8vY2hyb21pdW0uZ29vZ2xlc291cmNlLmNvbS9hbmds ZS9hbmdsZSAuCiBlY2hvICJTdWNjZXNzZnVsbHkgZG93bmxvYWRlZCBsYXRlc3QgQU5HTEUuIgog ZWNobyAtbiAiQ29tbWl0IGhhc2g6ICIKIENPTU1JVF9IQVNIPWBnaXQgcmV2LXBhcnNlIEhFQURg CiBlY2hvICIkQ09NTUlUX0hBU0giCitlY2hvICIiCitlY2hvICJTdW1tYXJ5IG9mIGFkZGVkIGFu ZCByZW1vdmVkIGZpbGVzIHNpbmNlIGxhc3QgdXBkYXRlOiIKK2VjaG8gIl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XyIKK2VjaG8gIiIKK2dpdCBkaWZmIC0tc3VtbWFyeSAiJFBSRVZJT1VTX0NPTU1JVF9IQVNIIgor ZWNobyAiX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fIgorZWNobyAiIgogCiB0cmFwIC0gRVhJVAogY2xlYW51cAog CitlY2hvICJDb3B5aW5nIHNyYy9jb21taXQuaCB0byBzcmMvaWQvY29tbWl0LmgiCitta2RpciAt cCBzcmMvaWQKK2NwIHNyYy9jb21taXQuaCBzcmMvaWQvCiBlY2hvICJVcGRhdGluZyBBTkdMRS5w bGlzdCBjb21taXQgaGFzaGVzLiIKIHNlZCAtaS5iYWsgLWUgInMvXChbXmEtejAtOV1cKVthLXow LTldXHs0MFx9XChbXmEtejAtOV1cKS9cMSRDT01NSVRfSEFTSFwyL2ciIEFOR0xFLnBsaXN0CiBl Y2hvICJVcGRhdGluZyBBTkdMRS5wbGlzdCBkYXRlLiIK