201771 2019-09-13 14:06:44 -0700 [WPE][GTK] BubblewrapLauncher leaks D-Bus proxy sockets 2022-02-11 00:32:48 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 206533 1 mcatanzaro webkit-unassigned bugs-noreply cgarcia mcatanzaro pgriffis oldest_to_newest 1570698 0 mcatanzaro 2019-09-13 14:06:44 -0700 I have a bunch of D-Bus proxy sockets leaked on the filesystem, created by the XDGDBusProxyLauncher class in BubblewrapLauncher.cpp. We shouldn't leak temporary files to disk; they should be removed when the web process quits. It's kinda hard to do if the xdg-dbus-proxy process itself isn't responsible for removing its socket. Why does WebKit have to create the socket file itself? 1839596 1 cgarcia 2022-02-10 04:28:55 -0800 xdg-dbus-proxy removes the socket when the sync fd is closed by the application. In most of the cases the xdg-dbus-proxy process is killed before the sync fd is closed and the socket file is leaked. We should explicitly close the sync fd. 1839601 2 451518 cgarcia 2022-02-10 04:32:36 -0800 Created attachment 451518 Patch This patch applyes on top of patch attached to bug #236437 1839616 3 451522 cgarcia 2022-02-10 05:56:17 -0800 Created attachment 451522 Patch 1840246 4 cgarcia 2022-02-11 00:32:48 -0800 Committed r289608 (247121@trunk): <https://commits.webkit.org/247121@trunk> 451518 2022-02-10 04:32:36 -0800 2022-02-10 05:56:17 -0800 Patch wk-sockets-leak.diff text/plain 3087 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYzlmOTY5ZjMyZjhjLi41ZWQ2ZmM1ZDc1YWUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMjAgQEAKKzIwMjItMDItMTAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtXUEVdW0dUS10gQnViYmxld3JhcExhdW5jaGVyIGxlYWtzIEQt QnVzIHByb3h5IHNvY2tldHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIwMTc3MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIHhkZy1kYnVzLXByb3h5IHJlbW92ZXMgdGhlIHNvY2tldCB3aGVuIHRoZSBzeW5j IGZkIGlzIGNsb3NlZCBieSB0aGUgYXBwbGljYXRpb24uIEluIG1vc3Qgb2YgdGhlIGNhc2VzIHRo ZQorICAgICAgICB4ZGctZGJ1cy1wcm94eSBwcm9jZXNzIGlzIGtpbGxlZCBiZWZvcmUgdGhlIHN5 bmMgZmQgaXMgY2xvc2VkIGFuZCB0aGUgc29ja2V0IGZpbGUgaXMgbGVha2VkLiBXZSBzaG91bGQK KyAgICAgICAgZXhwbGljaXRseSBjbG9zZSB0aGUgc3luYyBmZC4KKworICAgICAgICAqIFVJUHJv Y2Vzcy9MYXVuY2hlci9nbGliL1hER0RCdXNQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OlhE R0RCdXNQcm94eTo6WERHREJ1c1Byb3h5KTogU2F2ZSB0aGUgc3luYyBmZC4KKyAgICAgICAgKFdl YktpdDo6WERHREJ1c1Byb3h5Ojp+WERHREJ1c1Byb3h5KTogQ2xvc2UgdGhlIHN5bmMgZmQgaXMg bmVlZGVkLgorICAgICAgICAoV2ViS2l0OjpYREdEQnVzUHJveHk6OmxhdW5jaCBjb25zdCk6IFJl dHVybiB0aGUgc3luYyBmZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9YREdE QnVzUHJveHkuaDoKKwogMjAyMi0wMi0xMCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lh QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bV1BFXSBSZWZhY3RvciB0aGUgWERHREJ1c1By b3h5IGxhdW5jaGVyIHRvIHNpbXBsaWZ5IGl0IGFuZCBmaXggc29tZSBpc3N1ZXMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvWERHREJ1c1Byb3h5LmNw cCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvWERHREJ1c1Byb3h5LmNw cAppbmRleCA4ODQxZTdmNzFjZmEuLjA0NGExNWJmYzA0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9YREdEQnVzUHJveHkuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvWERHREJ1c1Byb3h5LmNwcApAQCAtNzQs NyArNzQsMTMgQEAgWERHREJ1c1Byb3h5OjpYREdEQnVzUHJveHkoVHlwZSB0eXBlLCBib29sIGFs bG93UG9ydGFscykKICAgICAgICAgbV9wYXRoID0gQ1N0cmluZyhwYXRoLCBwYXRoRW5kIC0gcGF0 aCk7CiAgICAgfQogCi0gICAgbGF1bmNoKGFsbG93UG9ydGFscyk7CisgICAgbV9zeW5jRkQgPSBs YXVuY2goYWxsb3dQb3J0YWxzKTsKK30KKworWERHREJ1c1Byb3h5Ojp+WERHREJ1c1Byb3h5KCkK K3sKKyAgICBpZiAobV9zeW5jRkQgIT0gLTEpCisgICAgICAgIGNsb3NlKG1fc3luY0ZEKTsKIH0K IAogQ1N0cmluZyBYREdEQnVzUHJveHk6Om1ha2VQcm94eSgpIGNvbnN0CkBAIC0xMDYsNyArMTEy LDcgQEAgQ1N0cmluZyBYREdEQnVzUHJveHk6Om1ha2VQcm94eSgpIGNvbnN0CiAgICAgcmV0dXJu IHByb3h5U29ja2V0VGVtcGxhdGUuZ2V0KCk7CiB9CiAKLXZvaWQgWERHREJ1c1Byb3h5OjpsYXVu Y2goYm9vbCBhbGxvd1BvcnRhbHMpIGNvbnN0CitpbnQgWERHREJ1c1Byb3h5OjpsYXVuY2goYm9v bCBhbGxvd1BvcnRhbHMpIGNvbnN0CiB7CiAgICAgaW50IHN5bmNGZHNbMl07CiAgICAgaWYgKHBp cGUoc3luY0ZkcykgPT0gLTEpCkBAIC0yMDMsNiArMjA5LDggQEAgdm9pZCBYREdEQnVzUHJveHk6 OmxhdW5jaChib29sIGFsbG93UG9ydGFscykgY29uc3QKICAgICBjaGFyIG91dDsKICAgICBpZiAo cmVhZChzeW5jRmRzWzBdLCAmb3V0LCAxKSAhPSAxKQogICAgICAgICBnX2Vycm9yKCJGYWlsZWQg dG8gZnVsbHkgbGF1bmNoIGRidXMtcHJveHk6ICVzIiwgZ19zdHJlcnJvcihlcnJubykpOworCisg ICAgcmV0dXJuIHN5bmNGZHNbMF07CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9YREdEQnVzUHJveHku aCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvWERHREJ1c1Byb3h5LmgK aW5kZXggY2Q0YTg1YTYzYTFmLi4xZDg5MzQ2ZDc5ZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvWERHREJ1c1Byb3h5LmgKKysrIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9YREdEQnVzUHJveHkuaApAQCAtMzcsMTggKzM3 LDIwIEBAIGNsYXNzIFhER0RCdXNQcm94eSB7CiBwdWJsaWM6CiAgICAgZW51bSBjbGFzcyBUeXBl IHsgU2Vzc2lvbkJ1cywgQWNjZXNzaWJpbGl0eUJ1cyB9OwogICAgIFhER0RCdXNQcm94eShUeXBl LCBib29sID0gZmFsc2UpOworICAgIH5YREdEQnVzUHJveHkoKTsKIAogICAgIGNvbnN0IENTdHJp bmcmIHByb3h5UGF0aCgpIGNvbnN0IHsgcmV0dXJuIG1fcHJveHlQYXRoOyB9CiAgICAgY29uc3Qg Q1N0cmluZyYgcGF0aCgpIGNvbnN0IHsgcmV0dXJuIG1fcGF0aDsgfQogCiBwcml2YXRlOgogICAg IENTdHJpbmcgbWFrZVByb3h5KCkgY29uc3Q7Ci0gICAgdm9pZCBsYXVuY2goYm9vbCkgY29uc3Q7 CisgICAgaW50IGxhdW5jaChib29sKSBjb25zdDsKIAogICAgIFR5cGUgbV90eXBlOwogICAgIENT dHJpbmcgbV9kYnVzQWRkcmVzczsKICAgICBDU3RyaW5nIG1fcHJveHlQYXRoOwogICAgIENTdHJp bmcgbV9wYXRoOworICAgIGludCBtX3N5bmNGRCB7IC0xIH07CiB9OwogCiB9IC8vIG5hbWVzcGFj ZSBXZWJLaXQK 451522 2022-02-10 05:56:17 -0800 2022-02-10 07:05:19 -0800 Patch wk-sockets-leak.diff text/plain 3087 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYzlmOTY5ZjMyZjhjLi41ZWQ2ZmM1ZDc1YWUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMjAgQEAKKzIwMjItMDItMTAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtXUEVdW0dUS10gQnViYmxld3JhcExhdW5jaGVyIGxlYWtzIEQt QnVzIHByb3h5IHNvY2tldHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIwMTc3MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIHhkZy1kYnVzLXByb3h5IHJlbW92ZXMgdGhlIHNvY2tldCB3aGVuIHRoZSBzeW5j IGZkIGlzIGNsb3NlZCBieSB0aGUgYXBwbGljYXRpb24uIEluIG1vc3Qgb2YgdGhlIGNhc2VzIHRo ZQorICAgICAgICB4ZGctZGJ1cy1wcm94eSBwcm9jZXNzIGlzIGtpbGxlZCBiZWZvcmUgdGhlIHN5 bmMgZmQgaXMgY2xvc2VkIGFuZCB0aGUgc29ja2V0IGZpbGUgaXMgbGVha2VkLiBXZSBzaG91bGQK KyAgICAgICAgZXhwbGljaXRseSBjbG9zZSB0aGUgc3luYyBmZC4KKworICAgICAgICAqIFVJUHJv Y2Vzcy9MYXVuY2hlci9nbGliL1hER0RCdXNQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OlhE R0RCdXNQcm94eTo6WERHREJ1c1Byb3h5KTogU2F2ZSB0aGUgc3luYyBmZC4KKyAgICAgICAgKFdl YktpdDo6WERHREJ1c1Byb3h5Ojp+WERHREJ1c1Byb3h5KTogQ2xvc2UgdGhlIHN5bmMgZmQgaXMg bmVlZGVkLgorICAgICAgICAoV2ViS2l0OjpYREdEQnVzUHJveHk6OmxhdW5jaCBjb25zdCk6IFJl dHVybiB0aGUgc3luYyBmZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9YREdE QnVzUHJveHkuaDoKKwogMjAyMi0wMi0xMCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lh QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bV1BFXSBSZWZhY3RvciB0aGUgWERHREJ1c1By b3h5IGxhdW5jaGVyIHRvIHNpbXBsaWZ5IGl0IGFuZCBmaXggc29tZSBpc3N1ZXMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvWERHREJ1c1Byb3h5LmNw cCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvWERHREJ1c1Byb3h5LmNw cAppbmRleCA4ODQxZTdmNzFjZmEuLjA0NGExNWJmYzA0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9YREdEQnVzUHJveHkuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvWERHREJ1c1Byb3h5LmNwcApAQCAtNzQs NyArNzQsMTMgQEAgWERHREJ1c1Byb3h5OjpYREdEQnVzUHJveHkoVHlwZSB0eXBlLCBib29sIGFs bG93UG9ydGFscykKICAgICAgICAgbV9wYXRoID0gQ1N0cmluZyhwYXRoLCBwYXRoRW5kIC0gcGF0 aCk7CiAgICAgfQogCi0gICAgbGF1bmNoKGFsbG93UG9ydGFscyk7CisgICAgbV9zeW5jRkQgPSBs YXVuY2goYWxsb3dQb3J0YWxzKTsKK30KKworWERHREJ1c1Byb3h5Ojp+WERHREJ1c1Byb3h5KCkK K3sKKyAgICBpZiAobV9zeW5jRkQgIT0gLTEpCisgICAgICAgIGNsb3NlKG1fc3luY0ZEKTsKIH0K IAogQ1N0cmluZyBYREdEQnVzUHJveHk6Om1ha2VQcm94eSgpIGNvbnN0CkBAIC0xMDYsNyArMTEy LDcgQEAgQ1N0cmluZyBYREdEQnVzUHJveHk6Om1ha2VQcm94eSgpIGNvbnN0CiAgICAgcmV0dXJu IHByb3h5U29ja2V0VGVtcGxhdGUuZ2V0KCk7CiB9CiAKLXZvaWQgWERHREJ1c1Byb3h5OjpsYXVu Y2goYm9vbCBhbGxvd1BvcnRhbHMpIGNvbnN0CitpbnQgWERHREJ1c1Byb3h5OjpsYXVuY2goYm9v bCBhbGxvd1BvcnRhbHMpIGNvbnN0CiB7CiAgICAgaW50IHN5bmNGZHNbMl07CiAgICAgaWYgKHBp cGUoc3luY0ZkcykgPT0gLTEpCkBAIC0yMDMsNiArMjA5LDggQEAgdm9pZCBYREdEQnVzUHJveHk6 OmxhdW5jaChib29sIGFsbG93UG9ydGFscykgY29uc3QKICAgICBjaGFyIG91dDsKICAgICBpZiAo cmVhZChzeW5jRmRzWzBdLCAmb3V0LCAxKSAhPSAxKQogICAgICAgICBnX2Vycm9yKCJGYWlsZWQg dG8gZnVsbHkgbGF1bmNoIGRidXMtcHJveHk6ICVzIiwgZ19zdHJlcnJvcihlcnJubykpOworCisg ICAgcmV0dXJuIHN5bmNGZHNbMF07CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9YREdEQnVzUHJveHku aCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvWERHREJ1c1Byb3h5LmgK aW5kZXggY2Q0YTg1YTYzYTFmLi4xZDg5MzQ2ZDc5ZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvWERHREJ1c1Byb3h5LmgKKysrIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9YREdEQnVzUHJveHkuaApAQCAtMzcsMTggKzM3 LDIwIEBAIGNsYXNzIFhER0RCdXNQcm94eSB7CiBwdWJsaWM6CiAgICAgZW51bSBjbGFzcyBUeXBl IHsgU2Vzc2lvbkJ1cywgQWNjZXNzaWJpbGl0eUJ1cyB9OwogICAgIFhER0RCdXNQcm94eShUeXBl LCBib29sID0gZmFsc2UpOworICAgIH5YREdEQnVzUHJveHkoKTsKIAogICAgIGNvbnN0IENTdHJp bmcmIHByb3h5UGF0aCgpIGNvbnN0IHsgcmV0dXJuIG1fcHJveHlQYXRoOyB9CiAgICAgY29uc3Qg Q1N0cmluZyYgcGF0aCgpIGNvbnN0IHsgcmV0dXJuIG1fcGF0aDsgfQogCiBwcml2YXRlOgogICAg IENTdHJpbmcgbWFrZVByb3h5KCkgY29uc3Q7Ci0gICAgdm9pZCBsYXVuY2goYm9vbCkgY29uc3Q7 CisgICAgaW50IGxhdW5jaChib29sKSBjb25zdDsKIAogICAgIFR5cGUgbV90eXBlOwogICAgIENT dHJpbmcgbV9kYnVzQWRkcmVzczsKICAgICBDU3RyaW5nIG1fcHJveHlQYXRoOwogICAgIENTdHJp bmcgbV9wYXRoOworICAgIGludCBtX3N5bmNGRCB7IC0xIH07CiB9OwogCiB9IC8vIG5hbWVzcGFj ZSBXZWJLaXQK