201714 2019-09-11 22:12:52 -0700 REGRESSION? (r249786): inspector/canvas/context-attributes.html is failing on macOS WK1 2019-09-12 08:09:40 -0700 1 1 1 Unclassified WebKit Web Inspector Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=201650 InRadar P2 Normal --- 1 ryanhaddad hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1570147 0 ryanhaddad 2019-09-11 22:12:52 -0700 inspector/canvas/context-attributes.html is failing on macOS WK1 after r249786 with the following diff: --- /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/inspector/canvas/context-attributes-expected.txt +++ /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/inspector/canvas/context-attributes-actual.txt @@ -32,7 +32,7 @@ "antialias": true, "premultipliedAlpha": true, "preserveDrawingBuffer": false, - "powerPreference": "default", + "powerPreference": "low-power", "failIfMajorPerformanceCaveat": false } @@ -46,7 +46,7 @@ "antialias": true, "premultipliedAlpha": true, "preserveDrawingBuffer": false, - "powerPreference": "default", + "powerPreference": "low-power", "failIfMajorPerformanceCaveat": false } PASS: Canvas context should have attribute "alpha" with value "false". https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fcanvas%2Fcontext-attributes.html 1570148 1 webkit-bug-importer 2019-09-11 22:13:05 -0700 <rdar://problem/55290473> 1570149 2 ryanhaddad 2019-09-11 22:14:09 -0700 Devin, should the test be rebaselined for WK1, or is this unexpected? 1570155 3 joepeck 2019-09-11 22:27:13 -0700 (In reply to Ryan Haddad from comment #2) > Devin, should the test be rebaselined for WK1, or is this unexpected? WK1 (or perhaps specifically Mac WK1) will apparently need its own results since WebKitLegacy forces low-power: WebPreferences.mm: @YES, WebKitForceWebGLUsesLowPowerPreferenceKey, WK2 does not force low-power and uses the default WebCore::Setting values. 1570161 4 hi 2019-09-11 22:30:45 -0700 (In reply to Ryan Haddad from comment #2) > Devin, should the test be rebaselined for WK1, or is this unexpected? No, this is unexpected, but not wrong. Apparently WK1 forces any WebGL/WebGL2 <canvas> to be "low-power", regardless of whatever value is asked for. I'll change the test to just filter out the `powerPreference` so long as it's one of the known possible values. 1570222 5 378638 hi 2019-09-12 03:30:45 -0700 Created attachment 378638 Patch 1570249 6 378638 joepeck 2019-09-12 07:25:27 -0700 Comment on attachment 378638 Patch I liked seeing default. We could check in WK1 results. But this is fine 1570255 7 378638 commit-queue 2019-09-12 08:09:38 -0700 Comment on attachment 378638 Patch Clearing flags on attachment: 378638 Committed r249809: <https://trac.webkit.org/changeset/249809> 1570256 8 commit-queue 2019-09-12 08:09:40 -0700 All reviewed patches have been landed. Closing bug. 378638 2019-09-12 03:30:45 -0700 2019-09-12 08:09:38 -0700 Patch 201714.diff text/plain 2947 hi ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhODY5MzQyZjUxYy4uZWM1YjIwNmZiY2EgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAor MjAxOS0wOS0xMSAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CisKKyAgICAgICAg UkVHUkVTU0lPTj8gKHIyNDk3ODYpOiBpbnNwZWN0b3IvY2FudmFzL2NvbnRleHQtYXR0cmlidXRl cy5odG1sIGlzIGZhaWxpbmcgb24gbWFjT1MgV0sxCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDE3MTQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU1 MjkwNDczPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogaW5zcGVjdG9yL2NhbnZhcy9jb250ZXh0LWF0dHJpYnV0ZXMuaHRtbDoKKyAgICAgICAgKiBp bnNwZWN0b3IvY2FudmFzL2NvbnRleHQtYXR0cmlidXRlcy1leHBlY3RlZC50eHQ6CisKIDIwMTkt MDktMTEgIFNhYW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgW1dITFNM XSBFbnN1cmUgc3RydWN0cy9hcnJheXMgd2l0aCBwb2ludGVycyBhcyBmaWVsZHMgYXJlIGRpc2Fs bG93ZWQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9jYW52YXMvY29udGV4dC1h dHRyaWJ1dGVzLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9jYW52YXMvY29u dGV4dC1hdHRyaWJ1dGVzLWV4cGVjdGVkLnR4dAppbmRleCAwMmFmNjBhNjJjOC4uM2ZmOWU0MDBi NWUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9jYW52YXMvY29udGV4dC1hdHRy aWJ1dGVzLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY2FudmFzL2Nv bnRleHQtYXR0cmlidXRlcy1leHBlY3RlZC50eHQKQEAgLTMyLDcgKzMyLDcgQEAgUEFTUzogQ2Fu dmFzIGNvbnRleHQgc2hvdWxkIGJlICJXZWJHTCIuCiAgICJhbnRpYWxpYXMiOiB0cnVlLAogICAi cHJlbXVsdGlwbGllZEFscGhhIjogdHJ1ZSwKICAgInByZXNlcnZlRHJhd2luZ0J1ZmZlciI6IGZh bHNlLAotICAicG93ZXJQcmVmZXJlbmNlIjogImRlZmF1bHQiLAorICAicG93ZXJQcmVmZXJlbmNl IjogIjxmaWx0ZXJlZD4iLAogICAiZmFpbElmTWFqb3JQZXJmb3JtYW5jZUNhdmVhdCI6IGZhbHNl CiB9CiAKQEAgLTQ2LDcgKzQ2LDcgQEAgUEFTUzogQ2FudmFzIGNvbnRleHQgc2hvdWxkIGJlICJX ZWJHTCIuCiAgICJhbnRpYWxpYXMiOiB0cnVlLAogICAicHJlbXVsdGlwbGllZEFscGhhIjogdHJ1 ZSwKICAgInByZXNlcnZlRHJhd2luZ0J1ZmZlciI6IGZhbHNlLAotICAicG93ZXJQcmVmZXJlbmNl IjogImRlZmF1bHQiLAorICAicG93ZXJQcmVmZXJlbmNlIjogIjxmaWx0ZXJlZD4iLAogICAiZmFp bElmTWFqb3JQZXJmb3JtYW5jZUNhdmVhdCI6IGZhbHNlCiB9CiBQQVNTOiBDYW52YXMgY29udGV4 dCBzaG91bGQgaGF2ZSBhdHRyaWJ1dGUgImFscGhhIiB3aXRoIHZhbHVlICJmYWxzZSIuCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY2FudmFzL2NvbnRleHQtYXR0cmlidXRlcy5o dG1sIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NhbnZhcy9jb250ZXh0LWF0dHJpYnV0ZXMuaHRt bAppbmRleCBmYWRhN2JiODg3Mi4uZDRlMTExZmQ5ZDggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L2luc3BlY3Rvci9jYW52YXMvY29udGV4dC1hdHRyaWJ1dGVzLmh0bWwKKysrIGIvTGF5b3V0VGVz dHMvaW5zcGVjdG9yL2NhbnZhcy9jb250ZXh0LWF0dHJpYnV0ZXMuaHRtbApAQCAtMjcsNyArMjcs MTMgQEAgZnVuY3Rpb24gdGVzdCgpIHsKIAogICAgICAgICAgICAgICAgICAgICBsZXQgY29udGV4 dERpc3BsYXlOYW1lID0gV0kuQ2FudmFzLmRpc3BsYXlOYW1lRm9yQ29udGV4dFR5cGUoY29udGV4 dFR5cGUpOwogICAgICAgICAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmV4cGVjdEVxdWFsKGNh bnZhcy5jb250ZXh0VHlwZSwgY29udGV4dFR5cGUsIGBDYW52YXMgY29udGV4dCBzaG91bGQgYmUg IiR7Y29udGV4dERpc3BsYXlOYW1lfSIuYCk7Ci0gICAgICAgICAgICAgICAgICAgIEluc3BlY3Rv clRlc3QubG9nKEpTT04uc3RyaW5naWZ5KGNhbnZhcy5jb250ZXh0QXR0cmlidXRlcywgbnVsbCwg MikpOworICAgICAgICAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0Lmpzb24oY2FudmFzLmNvbnRl eHRBdHRyaWJ1dGVzLCAoa2V5LCB2YWx1ZSkgPT4geworICAgICAgICAgICAgICAgICAgICAgICAg aWYgKGtleSA9PT0gInBvd2VyUHJlZmVyZW5jZSIpIHsKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICBJbnNwZWN0b3JUZXN0LmFzc2VydCh2YWx1ZSA9PT0gImRlZmF1bHQiIHx8IHZhbHVlID09 PSAibG93LXBvd2VyIiB8fCB2YWx1ZSA9PT0gImhpZ2gtcGVyZm9ybWFuY2UiLCBgVW5leHBlY3Rl ZCAicG93ZXJQcmVmZXJlbmNlIiB2YWx1ZTogJHt2YWx1ZX1gKTsKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICByZXR1cm4gIjxmaWx0ZXJlZD4iOworICAgICAgICAgICAgICAgICAgICAgICAg fQorICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHZhbHVlOworICAgICAgICAgICAgICAg ICAgICB9KTsKIAogICAgICAgICAgICAgICAgICAgICBmb3IgKGxldCBuYW1lIGluIGNvbnRleHRB dHRyaWJ1dGVzKQogICAgICAgICAgICAgICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5leHBlY3RF cXVhbChjYW52YXMuY29udGV4dEF0dHJpYnV0ZXNbbmFtZV0sIGNvbnRleHRBdHRyaWJ1dGVzW25h bWVdLCBgQ2FudmFzIGNvbnRleHQgc2hvdWxkIGhhdmUgYXR0cmlidXRlICIke25hbWV9IiB3aXRo IHZhbHVlICIke2NvbnRleHRBdHRyaWJ1dGVzW25hbWVdfSIuYCk7Cg==