201559 2019-09-06 14:04:17 -0700 Web Inspector: CSS Formatter: links to CSS resources don't map to the right line after pretty printing if the line is after a multiline comment 2019-09-06 15:35:22 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1568681 0 hi 2019-09-06 14:04:17 -0700 Newlines in multiline comments weren't added as line endings, so they weren't considered when a source code location updated after pretty printing. 1568689 1 378234 hi 2019-09-06 14:09:14 -0700 Created attachment 378234 Patch 1568695 2 378234 joepeck 2019-09-06 14:20:44 -0700 Comment on attachment 378234 Patch r=me 1568696 3 joepeck 2019-09-06 14:21:00 -0700 We should consider some way of testing this. I may look into it for the HTML formatter. 1568737 4 378234 commit-queue 2019-09-06 15:34:10 -0700 Comment on attachment 378234 Patch Clearing flags on attachment: 378234 Committed r249596: <https://trac.webkit.org/changeset/249596> 1568738 5 commit-queue 2019-09-06 15:34:11 -0700 All reviewed patches have been landed. Closing bug. 1568739 6 webkit-bug-importer 2019-09-06 15:35:22 -0700 <rdar://problem/55130685> 378234 2019-09-06 14:09:14 -0700 2019-09-06 15:34:10 -0700 Patch 201559.diff text/plain 2391 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDJmY2NjMjYzYzAwLi5kYjE1ZWM4ZTRiOCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDktMDYgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IENT UyBGb3JtYXR0ZXI6IGxpbmtzIHRvIENTUyByZXNvdXJjZXMgZG9uJ3QgbWFwIHRvIHRoZSByaWdo dCBsaW5lIGFmdGVyIHByZXR0eSBwcmludGluZyBpZiB0aGUgbGluZSBpcyBhZnRlciBhIG11bHRp bGluZSBjb21tZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDE1NTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBOZXdsaW5lcyBpbiBtdWx0aWxpbmUgY29tbWVudHMgd2VyZW4ndCBhZGRlZCBhcyBsaW5l IGVuZGluZ3MsIHNvIHRoZXkgd2VyZW4ndCBjb25zaWRlcmVkCisgICAgICAgIHdoZW4gYSBzb3Vy Y2UgY29kZSBsb2NhdGlvbiB1cGRhdGVkIGFmdGVyIHByZXR0eSBwcmludGluZy4KKworICAgICAg ICAqIFVzZXJJbnRlcmZhY2UvV29ya2Vycy9Gb3JtYXR0ZXIvQ1NTRm9ybWF0dGVyLmpzOgorICAg ICAgICAoQ1NTRm9ybWF0dGVyLnByb3RvdHlwZS5fZm9ybWF0KToKKwogMjAxOS0wOS0wNiAgSm9z ZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IE5ldHdvcms6IEVycm9yIHJlc3BvbnNlIGhlYWRlcnMgc3VtbWFyeSBoYXMgd3JvbmcgY29s b3IgYm9yZGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9Xb3JrZXJzL0Zvcm1hdHRlci9DU1NGb3JtYXR0ZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9Xb3JrZXJzL0Zvcm1hdHRlci9DU1NGb3JtYXR0ZXIuanMKaW5kZXgg Y2U0MWQ2NTRkYjUuLjlhNmZkOWY3YmI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9Xb3JrZXJzL0Zvcm1hdHRlci9DU1NGb3JtYXR0ZXIuanMKKysrIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvV29ya2Vycy9Gb3JtYXR0ZXIvQ1NT Rm9ybWF0dGVyLmpzCkBAIC0yNzAsNyArMjcwLDE3IEBAIENTU0Zvcm1hdHRlciA9IGNsYXNzIENT U0Zvcm1hdHRlcgogICAgICAgICAgICAgICAgICAgICAgICAgdGhpcy5fYnVpbGRlci5hcHBlbmRO ZXdsaW5lKHRydWUpOwogICAgICAgICAgICAgICAgIH0KIAotICAgICAgICAgICAgICAgIHRoaXMu X2J1aWxkZXIuYXBwZW5kVG9rZW4oc3BlY2lhbFNlcXVlbmNlVGV4dCwgc3RhcnRJbmRleCk7Cisg ICAgICAgICAgICAgICAgc3BlY2lhbFNlcXVlbmNlVGV4dC5zcGxpdChgXG5gKS5mb3JFYWNoKChs aW5lLCBpLCBsaW5lcykgPT4geworICAgICAgICAgICAgICAgICAgICBpZiAobGluZSkgeworICAg ICAgICAgICAgICAgICAgICAgICAgdGhpcy5fYnVpbGRlci5hcHBlbmRUb2tlbihsaW5lLCBzdGFy dEluZGV4KTsKKyAgICAgICAgICAgICAgICAgICAgICAgIHN0YXJ0SW5kZXggKz0gbGluZS5sZW5n dGg7CisgICAgICAgICAgICAgICAgICAgIH0KKworICAgICAgICAgICAgICAgICAgICBpZiAoaSA8 IGxpbmVzLmxlbmd0aCAtIDEpIHsKKyAgICAgICAgICAgICAgICAgICAgICAgIHRoaXMuX2J1aWxk ZXIuYXBwZW5kTmV3bGluZSh0cnVlKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICsrc3RhcnRJ bmRleDsKKyAgICAgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgICAgIH0pOwogCiAgICAg ICAgICAgICAgICAgaSA9IGVuZEluZGV4OwogICAgICAgICAgICAgICAgIGMgPSB0aGlzLl9zb3Vy Y2VUZXh0W2ldOwpAQCAtMjk4LDcgKzMwOCw2IEBAIENTU0Zvcm1hdHRlciA9IGNsYXNzIENTU0Zv cm1hdHRlcgogCiAgICAgICAgICAgICBpZiAoL1xzLy50ZXN0KGMpKSB7CiAgICAgICAgICAgICAg ICAgaWYgKGMgPT09IGBcbmApIHsKLSAgICAgICAgICAgICAgICAgICAgdGhpcy5fYnVpbGRlci5h ZGRPcmlnaW5hbExpbmVFbmRpbmcoaSk7CiAgICAgICAgICAgICAgICAgICAgIGlmICghdGhpcy5f YnVpbGRlci5sYXN0VG9rZW5XYXNOZXdsaW5lKSB7CiAgICAgICAgICAgICAgICAgICAgICAgICB3 aGlsZSAodGhpcy5fYnVpbGRlci5sYXN0VG9rZW5XYXNXaGl0ZXNwYWNlKQogICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHRoaXMuX2J1aWxkZXIucmVtb3ZlTGFzdFdoaXRlc3BhY2UoKTsK